From: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "Hunter, Adrian" <adrian.hunter@intel.com>, "Raja Subramanian, Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>, "Wan Mohamad, Wan Ahmad Zainie" <wan.ahmad.zainie.wan.mohamad@intel.com>, "David E. Box" <david.e.box@linux.intel.com> Subject: RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Date: Mon, 16 Nov 2020 14:22:32 +0000 [thread overview] Message-ID: <DM6PR11MB2876BB714DF701E81866B13EB8E30@DM6PR11MB2876.namprd11.prod.outlook.com> (raw) In-Reply-To: <CAPDyKFrq0Wsc7bNS0QPMitNqpkzK87VAuTnjDqrqTrVDGCwxgg@mail.gmail.com> Hi Ulf, Thanks for your review comments. I replied inline >-----Original Message----- >From: Ulf Hansson <ulf.hansson@linaro.org> >Sent: Monday, November 16, 2020 7:41 PM >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm- >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; Raja >Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>; Wan >Mohamad, Wan Ahmad Zainie ><wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box ><david.e.box@linux.intel.com> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem >Bay SOC > >On Fri, 6 Nov 2020 at 05:10, <muhammad.husaini.zulkifli@intel.com> wrote: >> >> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations >> handling") introduces platform specific SDHCI clock operation. >> >> This patch declares the clock operation for Keem Bay. >> Add clk_ops for SD, EMMC and SDIO operations. > >The above commit message doesn't really tell why or what goes on here. >Can please try to clarify that. We missed out the clock operation handling patch (Commit 16ada730a759) and did not handle the clk_ops for Keem Bay SOC devices. These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86) are merged at around the same time. We catch the issue later when trying to boot into v5.10-rc1 with Keem Bay EVM. That is why I created this patch to handle the clk_ops for Keem Bay devices. > >> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem >> Bay") > >Is $subject patch fixing a bug/regression? This is to fix issue on previous commit. It is a bug fix. > >Kind regards >Uffe > >> >> Signed-off-by: Muhammad Husaini Zulkifli >> <muhammad.husaini.zulkifli@intel.com> >> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com> >> --- >> drivers/mmc/host/sdhci-of-arasan.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-of-arasan.c >> b/drivers/mmc/host/sdhci-of-arasan.c >> index 829ccef87426..012d52e1abee 100644 >> --- a/drivers/mmc/host/sdhci-of-arasan.c >> +++ b/drivers/mmc/host/sdhci-of-arasan.c >> @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data >> sdhci_arasan_versal_data = { static struct sdhci_arasan_of_data >intel_keembay_emmc_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_emmc_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static struct sdhci_arasan_of_data intel_keembay_sd_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_sd_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static struct sdhci_arasan_of_data intel_keembay_sdio_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_sdio_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static const struct of_device_id sdhci_arasan_of_match[] = { >> -- >> 2.17.1 >>
WARNING: multiple messages have this Message-ID (diff)
From: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: "Raja Subramanian, Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "Wan Mohamad, Wan Ahmad Zainie" <wan.ahmad.zainie.wan.mohamad@intel.com>, "David E. Box" <david.e.box@linux.intel.com>, "Hunter, Adrian" <adrian.hunter@intel.com>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Date: Mon, 16 Nov 2020 14:22:32 +0000 [thread overview] Message-ID: <DM6PR11MB2876BB714DF701E81866B13EB8E30@DM6PR11MB2876.namprd11.prod.outlook.com> (raw) In-Reply-To: <CAPDyKFrq0Wsc7bNS0QPMitNqpkzK87VAuTnjDqrqTrVDGCwxgg@mail.gmail.com> Hi Ulf, Thanks for your review comments. I replied inline >-----Original Message----- >From: Ulf Hansson <ulf.hansson@linaro.org> >Sent: Monday, November 16, 2020 7:41 PM >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm- >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; Raja >Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>; Wan >Mohamad, Wan Ahmad Zainie ><wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box ><david.e.box@linux.intel.com> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem >Bay SOC > >On Fri, 6 Nov 2020 at 05:10, <muhammad.husaini.zulkifli@intel.com> wrote: >> >> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com> >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations >> handling") introduces platform specific SDHCI clock operation. >> >> This patch declares the clock operation for Keem Bay. >> Add clk_ops for SD, EMMC and SDIO operations. > >The above commit message doesn't really tell why or what goes on here. >Can please try to clarify that. We missed out the clock operation handling patch (Commit 16ada730a759) and did not handle the clk_ops for Keem Bay SOC devices. These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86) are merged at around the same time. We catch the issue later when trying to boot into v5.10-rc1 with Keem Bay EVM. That is why I created this patch to handle the clk_ops for Keem Bay devices. > >> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem >> Bay") > >Is $subject patch fixing a bug/regression? This is to fix issue on previous commit. It is a bug fix. > >Kind regards >Uffe > >> >> Signed-off-by: Muhammad Husaini Zulkifli >> <muhammad.husaini.zulkifli@intel.com> >> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com> >> --- >> drivers/mmc/host/sdhci-of-arasan.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-of-arasan.c >> b/drivers/mmc/host/sdhci-of-arasan.c >> index 829ccef87426..012d52e1abee 100644 >> --- a/drivers/mmc/host/sdhci-of-arasan.c >> +++ b/drivers/mmc/host/sdhci-of-arasan.c >> @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data >> sdhci_arasan_versal_data = { static struct sdhci_arasan_of_data >intel_keembay_emmc_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_emmc_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static struct sdhci_arasan_of_data intel_keembay_sd_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_sd_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static struct sdhci_arasan_of_data intel_keembay_sdio_data = { >> .soc_ctl_map = &intel_keembay_soc_ctl_map, >> .pdata = &sdhci_keembay_sdio_pdata, >> + .clk_ops = &arasan_clk_ops, >> }; >> >> static const struct of_device_id sdhci_arasan_of_match[] = { >> -- >> 2.17.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-16 14:23 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-06 12:09 [PATCH v1 0/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC muhammad.husaini.zulkifli 2020-11-06 12:09 ` muhammad.husaini.zulkifli 2020-11-06 12:09 ` [PATCH v1 1/1] " muhammad.husaini.zulkifli 2020-11-06 12:09 ` muhammad.husaini.zulkifli 2020-11-16 11:41 ` Ulf Hansson 2020-11-16 11:41 ` Ulf Hansson 2020-11-16 14:22 ` Zulkifli, Muhammad Husaini [this message] 2020-11-16 14:22 ` Zulkifli, Muhammad Husaini 2020-11-17 11:27 ` Ulf Hansson 2020-11-17 11:27 ` Ulf Hansson 2020-11-17 13:46 ` Zulkifli, Muhammad Husaini 2020-11-17 13:46 ` Zulkifli, Muhammad Husaini 2020-11-17 17:14 ` Ulf Hansson 2020-11-17 17:14 ` Ulf Hansson 2020-11-18 1:04 ` Zulkifli, Muhammad Husaini 2020-11-18 1:04 ` Zulkifli, Muhammad Husaini 2020-11-12 14:15 ` [PATCH v1 0/1] " Zulkifli, Muhammad Husaini 2020-11-12 14:15 ` Zulkifli, Muhammad Husaini [not found] ` <DM6PR11MB28767CEEAD0FA1E20614B797B8E60@DM6PR11MB2876.namprd11.prod.outlook.com> 2020-11-13 0:15 ` Zulkifli, Muhammad Husaini 2020-11-13 0:15 ` Zulkifli, Muhammad Husaini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM6PR11MB2876BB714DF701E81866B13EB8E30@DM6PR11MB2876.namprd11.prod.outlook.com \ --to=muhammad.husaini.zulkifli@intel.com \ --cc=adrian.hunter@intel.com \ --cc=david.e.box@linux.intel.com \ --cc=lakshmi.bai.raja.subramanian@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=wan.ahmad.zainie.wan.mohamad@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.