From: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "Hunter, Adrian" <adrian.hunter@intel.com>, "Raja Subramanian, Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>, "Wan Mohamad, Wan Ahmad Zainie" <wan.ahmad.zainie.wan.mohamad@intel.com>, "David E. Box" <david.e.box@linux.intel.com> Subject: RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Date: Wed, 18 Nov 2020 01:04:52 +0000 [thread overview] Message-ID: <DM6PR11MB2876E25D0685E32FC18BB5FBB8E10@DM6PR11MB2876.namprd11.prod.outlook.com> (raw) In-Reply-To: <CAPDyKFp1nR_Qx5p+ou1cZns9MvLVWD5bTuFCkMpu_EbHxh1Opw@mail.gmail.com> Hi Ulf, >-----Original Message----- >From: Ulf Hansson <ulf.hansson@linaro.org> >Sent: Wednesday, November 18, 2020 1:14 AM >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm- >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; Raja >Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>; Wan >Mohamad, Wan Ahmad Zainie ><wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box ><david.e.box@linux.intel.com> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay >SOC > >On Tue, 17 Nov 2020 at 14:46, Zulkifli, Muhammad Husaini ><muhammad.husaini.zulkifli@intel.com> wrote: >> >> Hi Ulf, >> >> >-----Original Message----- >> >From: Ulf Hansson <ulf.hansson@linaro.org> >> >Sent: Tuesday, November 17, 2020 7:27 PM >> >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com> >> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm- >> >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- >> >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; >> >Raja Subramanian, Lakshmi Bai >> ><lakshmi.bai.raja.subramanian@intel.com>; Wan Mohamad, Wan Ahmad >> >Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box >> ><david.e.box@linux.intel.com> >> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops >> >for Keem Bay SOC >> > >> >On Mon, 16 Nov 2020 at 15:22, Zulkifli, Muhammad Husaini >> ><muhammad.husaini.zulkifli@intel.com> wrote: >> >> >> >> Hi Ulf, >> >> >> >> Thanks for your review comments. I replied inline >> >> >> >> >-----Original Message----- >> >> >From: Ulf Hansson <ulf.hansson@linaro.org> >> >> >Sent: Monday, November 16, 2020 7:41 PM >> >> >To: Zulkifli, Muhammad Husaini >> >> ><muhammad.husaini.zulkifli@intel.com> >> >> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm- >> >> >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- >> >> >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; >> >> >Raja Subramanian, Lakshmi Bai >> >> ><lakshmi.bai.raja.subramanian@intel.com>; Wan Mohamad, Wan >Ahmad >> >> >Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box >> >> ><david.e.box@linux.intel.com> >> >> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops >> >> >for Keem Bay SOC >> >> > >> >> >On Fri, 6 Nov 2020 at 05:10, <muhammad.husaini.zulkifli@intel.com> >wrote: >> >> >> >> >> >> From: Muhammad Husaini Zulkifli >> >> >> <muhammad.husaini.zulkifli@intel.com> >> >> >> >> >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock >> >> >> operations >> >> >> handling") introduces platform specific SDHCI clock operation. >> >> >> >> >> >> This patch declares the clock operation for Keem Bay. >> >> >> Add clk_ops for SD, EMMC and SDIO operations. >> >> > >> >> >The above commit message doesn't really tell why or what goes on here. >> >> >Can please try to clarify that. >> >> >> >> We missed out the clock operation handling patch (Commit >> >> 16ada730a759) and did not handle the clk_ops for Keem Bay SOC devices. >> >> These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86) >> >> are >> >merged at around the same time. >> >> We catch the issue later when trying to boot into v5.10-rc1 with >> >> Keem Bay >> >EVM. >> >> That is why I created this patch to handle the clk_ops for Keem Bay >devices. >> > >> >Alright, so the previous changes were simply not sufficient to >> >complete the support. >> > >> >> >> >> > >> >> >> >> >> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for >> >> >> Intel Keem >> >> >> Bay") >> >> > >> >> >Is $subject patch fixing a bug/regression? >> >> >> >> This is to fix issue on previous commit. It is a bug fix. >> > >> >Has it ever worked? >> >> Yes it is working. Tested with Keem Bay EVM. >> SD/EMMC/SDIO devices registered successfully with this fix. > >I am not asking if $subject patch makes it work, I understand that it does. > >> >> > >> >Did the commit you point to with the fixes tag, break some other >> >existing functionality? >> >> It should not break other existing functionality. >> This is specific for Keem Bay SOC only. > >So, you are saying that it has never worked for Keem Bay? But $subject patch >makes it work? It is working for Keem Bay before until the Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") came into the picture. Both Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") and Commit 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem") are merged about the same time. We did not have "Modify clock operations handling" patch when rebasing and testing during upstreaming process. I noticed of this issue when using latest mainline v5.10-rcx recently. > >Can you please re-spin and update the commit message to better reflect what >goes on, then I can apply. Noted. I will update the commit message and re-send again. Thanks > >Kind regards >Uffe
WARNING: multiple messages have this Message-ID (diff)
From: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: "Raja Subramanian, Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "Wan Mohamad, Wan Ahmad Zainie" <wan.ahmad.zainie.wan.mohamad@intel.com>, "David E. Box" <david.e.box@linux.intel.com>, "Hunter, Adrian" <adrian.hunter@intel.com>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC Date: Wed, 18 Nov 2020 01:04:52 +0000 [thread overview] Message-ID: <DM6PR11MB2876E25D0685E32FC18BB5FBB8E10@DM6PR11MB2876.namprd11.prod.outlook.com> (raw) In-Reply-To: <CAPDyKFp1nR_Qx5p+ou1cZns9MvLVWD5bTuFCkMpu_EbHxh1Opw@mail.gmail.com> Hi Ulf, >-----Original Message----- >From: Ulf Hansson <ulf.hansson@linaro.org> >Sent: Wednesday, November 18, 2020 1:14 AM >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm- >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; Raja >Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>; Wan >Mohamad, Wan Ahmad Zainie ><wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box ><david.e.box@linux.intel.com> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay >SOC > >On Tue, 17 Nov 2020 at 14:46, Zulkifli, Muhammad Husaini ><muhammad.husaini.zulkifli@intel.com> wrote: >> >> Hi Ulf, >> >> >-----Original Message----- >> >From: Ulf Hansson <ulf.hansson@linaro.org> >> >Sent: Tuesday, November 17, 2020 7:27 PM >> >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@intel.com> >> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm- >> >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- >> >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; >> >Raja Subramanian, Lakshmi Bai >> ><lakshmi.bai.raja.subramanian@intel.com>; Wan Mohamad, Wan Ahmad >> >Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box >> ><david.e.box@linux.intel.com> >> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops >> >for Keem Bay SOC >> > >> >On Mon, 16 Nov 2020 at 15:22, Zulkifli, Muhammad Husaini >> ><muhammad.husaini.zulkifli@intel.com> wrote: >> >> >> >> Hi Ulf, >> >> >> >> Thanks for your review comments. I replied inline >> >> >> >> >-----Original Message----- >> >> >From: Ulf Hansson <ulf.hansson@linaro.org> >> >> >Sent: Monday, November 16, 2020 7:41 PM >> >> >To: Zulkifli, Muhammad Husaini >> >> ><muhammad.husaini.zulkifli@intel.com> >> >> >Cc: linux-mmc@vger.kernel.org; Linux ARM <linux-arm- >> >> >kernel@lists.infradead.org>; Linux Kernel Mailing List <linux- >> >> >kernel@vger.kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; >> >> >Raja Subramanian, Lakshmi Bai >> >> ><lakshmi.bai.raja.subramanian@intel.com>; Wan Mohamad, Wan >Ahmad >> >> >Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>; David E. Box >> >> ><david.e.box@linux.intel.com> >> >> >Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-arasan: Specify .clk_ops >> >> >for Keem Bay SOC >> >> > >> >> >On Fri, 6 Nov 2020 at 05:10, <muhammad.husaini.zulkifli@intel.com> >wrote: >> >> >> >> >> >> From: Muhammad Husaini Zulkifli >> >> >> <muhammad.husaini.zulkifli@intel.com> >> >> >> >> >> >> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock >> >> >> operations >> >> >> handling") introduces platform specific SDHCI clock operation. >> >> >> >> >> >> This patch declares the clock operation for Keem Bay. >> >> >> Add clk_ops for SD, EMMC and SDIO operations. >> >> > >> >> >The above commit message doesn't really tell why or what goes on here. >> >> >Can please try to clarify that. >> >> >> >> We missed out the clock operation handling patch (Commit >> >> 16ada730a759) and did not handle the clk_ops for Keem Bay SOC devices. >> >> These 2 patches (Commit 16ada730a759) and (Commit 36c6aadaae86) >> >> are >> >merged at around the same time. >> >> We catch the issue later when trying to boot into v5.10-rc1 with >> >> Keem Bay >> >EVM. >> >> That is why I created this patch to handle the clk_ops for Keem Bay >devices. >> > >> >Alright, so the previous changes were simply not sufficient to >> >complete the support. >> > >> >> >> >> > >> >> >> >> >> >> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for >> >> >> Intel Keem >> >> >> Bay") >> >> > >> >> >Is $subject patch fixing a bug/regression? >> >> >> >> This is to fix issue on previous commit. It is a bug fix. >> > >> >Has it ever worked? >> >> Yes it is working. Tested with Keem Bay EVM. >> SD/EMMC/SDIO devices registered successfully with this fix. > >I am not asking if $subject patch makes it work, I understand that it does. > >> >> > >> >Did the commit you point to with the fixes tag, break some other >> >existing functionality? >> >> It should not break other existing functionality. >> This is specific for Keem Bay SOC only. > >So, you are saying that it has never worked for Keem Bay? But $subject patch >makes it work? It is working for Keem Bay before until the Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") came into the picture. Both Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations handling") and Commit 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem") are merged about the same time. We did not have "Modify clock operations handling" patch when rebasing and testing during upstreaming process. I noticed of this issue when using latest mainline v5.10-rcx recently. > >Can you please re-spin and update the commit message to better reflect what >goes on, then I can apply. Noted. I will update the commit message and re-send again. Thanks > >Kind regards >Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-18 1:05 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-06 12:09 [PATCH v1 0/1] mmc: sdhci-of-arasan: Specify .clk_ops for Keem Bay SOC muhammad.husaini.zulkifli 2020-11-06 12:09 ` muhammad.husaini.zulkifli 2020-11-06 12:09 ` [PATCH v1 1/1] " muhammad.husaini.zulkifli 2020-11-06 12:09 ` muhammad.husaini.zulkifli 2020-11-16 11:41 ` Ulf Hansson 2020-11-16 11:41 ` Ulf Hansson 2020-11-16 14:22 ` Zulkifli, Muhammad Husaini 2020-11-16 14:22 ` Zulkifli, Muhammad Husaini 2020-11-17 11:27 ` Ulf Hansson 2020-11-17 11:27 ` Ulf Hansson 2020-11-17 13:46 ` Zulkifli, Muhammad Husaini 2020-11-17 13:46 ` Zulkifli, Muhammad Husaini 2020-11-17 17:14 ` Ulf Hansson 2020-11-17 17:14 ` Ulf Hansson 2020-11-18 1:04 ` Zulkifli, Muhammad Husaini [this message] 2020-11-18 1:04 ` Zulkifli, Muhammad Husaini 2020-11-12 14:15 ` [PATCH v1 0/1] " Zulkifli, Muhammad Husaini 2020-11-12 14:15 ` Zulkifli, Muhammad Husaini [not found] ` <DM6PR11MB28767CEEAD0FA1E20614B797B8E60@DM6PR11MB2876.namprd11.prod.outlook.com> 2020-11-13 0:15 ` Zulkifli, Muhammad Husaini 2020-11-13 0:15 ` Zulkifli, Muhammad Husaini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM6PR11MB2876E25D0685E32FC18BB5FBB8E10@DM6PR11MB2876.namprd11.prod.outlook.com \ --to=muhammad.husaini.zulkifli@intel.com \ --cc=adrian.hunter@intel.com \ --cc=david.e.box@linux.intel.com \ --cc=lakshmi.bai.raja.subramanian@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=wan.ahmad.zainie.wan.mohamad@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.