All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: dove: add DT LCD controllers
@ 2014-11-19 11:32 ` Russell King
  0 siblings, 0 replies; 14+ messages in thread
From: Russell King @ 2014-11-19 11:32 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth
  Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell, Rob Herring,
	Kumar Gala, linux-arm-kernel

Add the DT fragment for the Marvell Dove LCD controllers.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
The documentation for this binding was submitted previously as part of
the code which parses this - v3.17-rc1~82^2~32^2~2.

 arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 3b891dd20993..a5441d5482a6 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -630,6 +630,20 @@
 				reg = <0xe8400 0x0c>;
 				ngpios = <8>;
 			};
+
+			lcd1: lcd-controller@810000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x810000 0x1000>;
+				interrupts = <46>;
+				status = "disabled";
+			};
+
+			lcd0: lcd-controller@820000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x820000 0x1000>;
+				interrupts = <47>;
+				status = "disabled";
+			};
 		};
 	};
 };
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH] ARM: dts: dove: add DT LCD controllers
@ 2014-11-19 11:32 ` Russell King
  0 siblings, 0 replies; 14+ messages in thread
From: Russell King @ 2014-11-19 11:32 UTC (permalink / raw)
  To: linux-arm-kernel

Add the DT fragment for the Marvell Dove LCD controllers.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
The documentation for this binding was submitted previously as part of
the code which parses this - v3.17-rc1~82^2~32^2~2.

 arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 3b891dd20993..a5441d5482a6 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -630,6 +630,20 @@
 				reg = <0xe8400 0x0c>;
 				ngpios = <8>;
 			};
+
+			lcd1: lcd-controller at 810000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x810000 0x1000>;
+				interrupts = <46>;
+				status = "disabled";
+			};
+
+			lcd0: lcd-controller at 820000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x820000 0x1000>;
+				interrupts = <47>;
+				status = "disabled";
+			};
 		};
 	};
 };
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: dts: dove: add DT LCD controllers
  2014-11-19 11:32 ` Russell King
@ 2014-11-19 16:40   ` Jean-Francois Moine
  -1 siblings, 0 replies; 14+ messages in thread
From: Jean-Francois Moine @ 2014-11-19 16:40 UTC (permalink / raw)
  To: Russell King
  Cc: Mark Rutland, Andrew Lunn, Jason Cooper, Pawel Moll, devicetree,
	Ian Campbell, Rob Herring, Kumar Gala, linux-arm-kernel,
	Sebastian Hesselbarth

On Wed, 19 Nov 2014 11:32:29 +0000
Russell King <rmk+kernel@arm.linux.org.uk> wrote:

> +			lcd1: lcd-controller@810000 {
> +				compatible = "marvell,dove-lcd";
> +				reg = <0x810000 0x1000>;
> +				interrupts = <46>;
> +				status = "disabled";
> +			};

The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH] ARM: dts: dove: add DT LCD controllers
@ 2014-11-19 16:40   ` Jean-Francois Moine
  0 siblings, 0 replies; 14+ messages in thread
From: Jean-Francois Moine @ 2014-11-19 16:40 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, 19 Nov 2014 11:32:29 +0000
Russell King <rmk+kernel@arm.linux.org.uk> wrote:

> +			lcd1: lcd-controller at 810000 {
> +				compatible = "marvell,dove-lcd";
> +				reg = <0x810000 0x1000>;
> +				interrupts = <46>;
> +				status = "disabled";
> +			};

The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?

-- 
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: dts: dove: add DT LCD controllers
  2014-11-19 16:40   ` Jean-Francois Moine
@ 2014-11-19 16:47     ` Russell King - ARM Linux
  -1 siblings, 0 replies; 14+ messages in thread
From: Russell King - ARM Linux @ 2014-11-19 16:47 UTC (permalink / raw)
  To: Jean-Francois Moine
  Cc: Mark Rutland, Andrew Lunn, Jason Cooper, Pawel Moll, devicetree,
	Ian Campbell, Rob Herring, Kumar Gala, linux-arm-kernel,
	Sebastian Hesselbarth

On Wed, Nov 19, 2014 at 05:40:50PM +0100, Jean-Francois Moine wrote:
> On Wed, 19 Nov 2014 11:32:29 +0000
> Russell King <rmk+kernel@arm.linux.org.uk> wrote:
> 
> > +			lcd1: lcd-controller@810000 {
> > +				compatible = "marvell,dove-lcd";
> > +				reg = <0x810000 0x1000>;
> > +				interrupts = <46>;
> > +				status = "disabled";
> > +			};
> 
> The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?

Actually, a more correct value would be 0x10000, if you read table 145.
Yes, the device may onlny have documented registers from 0x84 to 0x1c8,
but that isn't to say that we should say that the device resources
start at 0x810084 and have a size of 0x144, when the bus level decodes
a 64K chunk of memory.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH] ARM: dts: dove: add DT LCD controllers
@ 2014-11-19 16:47     ` Russell King - ARM Linux
  0 siblings, 0 replies; 14+ messages in thread
From: Russell King - ARM Linux @ 2014-11-19 16:47 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Nov 19, 2014 at 05:40:50PM +0100, Jean-Francois Moine wrote:
> On Wed, 19 Nov 2014 11:32:29 +0000
> Russell King <rmk+kernel@arm.linux.org.uk> wrote:
> 
> > +			lcd1: lcd-controller at 810000 {
> > +				compatible = "marvell,dove-lcd";
> > +				reg = <0x810000 0x1000>;
> > +				interrupts = <46>;
> > +				status = "disabled";
> > +			};
> 
> The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?

Actually, a more correct value would be 0x10000, if you read table 145.
Yes, the device may onlny have documented registers from 0x84 to 0x1c8,
but that isn't to say that we should say that the device resources
start at 0x810084 and have a size of 0x144, when the bus level decodes
a 64K chunk of memory.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: dts: dove: add DT LCD controllers
  2014-11-19 11:32 ` Russell King
@ 2014-11-22  4:12     ` Jason Cooper
  -1 siblings, 0 replies; 14+ messages in thread
From: Jason Cooper @ 2014-11-22  4:12 UTC (permalink / raw)
  To: Russell King
  Cc: Andrew Lunn, Sebastian Hesselbarth, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On Wed, Nov 19, 2014 at 11:32:29AM +0000, Russell King wrote:
> Add the DT fragment for the Marvell Dove LCD controllers.
> 
> Signed-off-by: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
> ---
> The documentation for this binding was submitted previously as part of
> the code which parses this - v3.17-rc1~82^2~32^2~2.
> 
>  arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

hmmm... this was already applied:

  087b04701111e ARM: dts: dove: add DT LCD controllers

>From here:

  https://lkml.kernel.org/r/E1XAKGS-0004WE-8h-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH] ARM: dts: dove: add DT LCD controllers
@ 2014-11-22  4:12     ` Jason Cooper
  0 siblings, 0 replies; 14+ messages in thread
From: Jason Cooper @ 2014-11-22  4:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Nov 19, 2014 at 11:32:29AM +0000, Russell King wrote:
> Add the DT fragment for the Marvell Dove LCD controllers.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> The documentation for this binding was submitted previously as part of
> the code which parses this - v3.17-rc1~82^2~32^2~2.
> 
>  arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

hmmm... this was already applied:

  087b04701111e ARM: dts: dove: add DT LCD controllers

>From here:

  https://lkml.kernel.org/r/E1XAKGS-0004WE-8h at rmk-PC.arm.linux.org.uk

thx,

Jason.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: dts: dove: add DT LCD controllers
  2014-07-24 14:45 ` Russell King
@ 2014-07-25  0:10     ` Jason Cooper
  -1 siblings, 0 replies; 14+ messages in thread
From: Jason Cooper @ 2014-07-25  0:10 UTC (permalink / raw)
  To: Russell King
  Cc: Sebastian Hesselbarth, Andrew Lunn, Gregory Clement, Rob Herring,
	Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On Thu, Jul 24, 2014 at 03:45:00PM +0100, Russell King wrote:
> Add the DT fragment for the Marvell Dove LCD controllers.
> 
> Signed-off-by: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
> ---
> Jason,
> 
> David Airlie has taken the Armada DRM changes into his tree, so the DT
> bits can now be queued for the next merge window.
> 
>  arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Applied to mvebu/dt with Sebastian's Ack.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH] ARM: dts: dove: add DT LCD controllers
@ 2014-07-25  0:10     ` Jason Cooper
  0 siblings, 0 replies; 14+ messages in thread
From: Jason Cooper @ 2014-07-25  0:10 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jul 24, 2014 at 03:45:00PM +0100, Russell King wrote:
> Add the DT fragment for the Marvell Dove LCD controllers.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Jason,
> 
> David Airlie has taken the Armada DRM changes into his tree, so the DT
> bits can now be queued for the next merge window.
> 
>  arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Applied to mvebu/dt with Sebastian's Ack.

thx,

Jason.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] ARM: dts: dove: add DT LCD controllers
  2014-07-24 14:45 ` Russell King
@ 2014-07-24 15:09     ` Sebastian Hesselbarth
  -1 siblings, 0 replies; 14+ messages in thread
From: Sebastian Hesselbarth @ 2014-07-24 15:09 UTC (permalink / raw)
  To: Russell King, Jason Cooper
  Cc: Andrew Lunn, Gregory Clement, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On 07/24/2014 04:45 PM, Russell King wrote:
> Add the DT fragment for the Marvell Dove LCD controllers.
>
> Signed-off-by: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Thanks!

> ---
> Jason,
>
> David Airlie has taken the Armada DRM changes into his tree, so the DT
> bits can now be queued for the next merge window.
>
>   arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
> index 3b891dd20993..a5441d5482a6 100644
> --- a/arch/arm/boot/dts/dove.dtsi
> +++ b/arch/arm/boot/dts/dove.dtsi
> @@ -630,6 +630,20 @@
>   				reg = <0xe8400 0x0c>;
>   				ngpios = <8>;
>   			};
> +
> +			lcd1: lcd-controller@810000 {
> +				compatible = "marvell,dove-lcd";
> +				reg = <0x810000 0x1000>;
> +				interrupts = <46>;
> +				status = "disabled";
> +			};
> +
> +			lcd0: lcd-controller@820000 {
> +				compatible = "marvell,dove-lcd";
> +				reg = <0x820000 0x1000>;
> +				interrupts = <47>;
> +				status = "disabled";
> +			};
>   		};
>   	};
>   };
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH] ARM: dts: dove: add DT LCD controllers
@ 2014-07-24 15:09     ` Sebastian Hesselbarth
  0 siblings, 0 replies; 14+ messages in thread
From: Sebastian Hesselbarth @ 2014-07-24 15:09 UTC (permalink / raw)
  To: linux-arm-kernel

On 07/24/2014 04:45 PM, Russell King wrote:
> Add the DT fragment for the Marvell Dove LCD controllers.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>

Thanks!

> ---
> Jason,
>
> David Airlie has taken the Armada DRM changes into his tree, so the DT
> bits can now be queued for the next merge window.
>
>   arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
> index 3b891dd20993..a5441d5482a6 100644
> --- a/arch/arm/boot/dts/dove.dtsi
> +++ b/arch/arm/boot/dts/dove.dtsi
> @@ -630,6 +630,20 @@
>   				reg = <0xe8400 0x0c>;
>   				ngpios = <8>;
>   			};
> +
> +			lcd1: lcd-controller at 810000 {
> +				compatible = "marvell,dove-lcd";
> +				reg = <0x810000 0x1000>;
> +				interrupts = <46>;
> +				status = "disabled";
> +			};
> +
> +			lcd0: lcd-controller at 820000 {
> +				compatible = "marvell,dove-lcd";
> +				reg = <0x820000 0x1000>;
> +				interrupts = <47>;
> +				status = "disabled";
> +			};
>   		};
>   	};
>   };
>

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH] ARM: dts: dove: add DT LCD controllers
@ 2014-07-24 14:45 ` Russell King
  0 siblings, 0 replies; 14+ messages in thread
From: Russell King @ 2014-07-24 14:45 UTC (permalink / raw)
  To: Jason Cooper
  Cc: Sebastian Hesselbarth, Andrew Lunn, Gregory Clement, Rob Herring,
	Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Add the DT fragment for the Marvell Dove LCD controllers.

Signed-off-by: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
---
Jason,

David Airlie has taken the Armada DRM changes into his tree, so the DT
bits can now be queued for the next merge window.

 arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 3b891dd20993..a5441d5482a6 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -630,6 +630,20 @@
 				reg = <0xe8400 0x0c>;
 				ngpios = <8>;
 			};
+
+			lcd1: lcd-controller@810000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x810000 0x1000>;
+				interrupts = <46>;
+				status = "disabled";
+			};
+
+			lcd0: lcd-controller@820000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x820000 0x1000>;
+				interrupts = <47>;
+				status = "disabled";
+			};
 		};
 	};
 };
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH] ARM: dts: dove: add DT LCD controllers
@ 2014-07-24 14:45 ` Russell King
  0 siblings, 0 replies; 14+ messages in thread
From: Russell King @ 2014-07-24 14:45 UTC (permalink / raw)
  To: linux-arm-kernel

Add the DT fragment for the Marvell Dove LCD controllers.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
Jason,

David Airlie has taken the Armada DRM changes into his tree, so the DT
bits can now be queued for the next merge window.

 arch/arm/boot/dts/dove.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 3b891dd20993..a5441d5482a6 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -630,6 +630,20 @@
 				reg = <0xe8400 0x0c>;
 				ngpios = <8>;
 			};
+
+			lcd1: lcd-controller at 810000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x810000 0x1000>;
+				interrupts = <46>;
+				status = "disabled";
+			};
+
+			lcd0: lcd-controller at 820000 {
+				compatible = "marvell,dove-lcd";
+				reg = <0x820000 0x1000>;
+				interrupts = <47>;
+				status = "disabled";
+			};
 		};
 	};
 };
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-11-22  4:12 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-19 11:32 [PATCH] ARM: dts: dove: add DT LCD controllers Russell King
2014-11-19 11:32 ` Russell King
2014-11-19 16:40 ` Jean-Francois Moine
2014-11-19 16:40   ` Jean-Francois Moine
2014-11-19 16:47   ` Russell King - ARM Linux
2014-11-19 16:47     ` Russell King - ARM Linux
     [not found] ` <E1Xr3Ur-0005Qx-Fx-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2014-11-22  4:12   ` Jason Cooper
2014-11-22  4:12     ` Jason Cooper
  -- strict thread matches above, loose matches on Subject: below --
2014-07-24 14:45 Russell King
2014-07-24 14:45 ` Russell King
     [not found] ` <E1XAKGS-0004WE-8h-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2014-07-24 15:09   ` Sebastian Hesselbarth
2014-07-24 15:09     ` Sebastian Hesselbarth
2014-07-25  0:10   ` Jason Cooper
2014-07-25  0:10     ` Jason Cooper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.