* [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
@ 2016-04-26 14:00 ` Maxime Ripard
0 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2016-04-26 14:00 UTC (permalink / raw)
To: linux-arm-kernel
The current linear voltage range for the LDO4 regulator found in the APX20X
PMICs assumes that the voltage is linear between 2.5 and 3.1V.
However, the PMIC can output up to 3.3V on that regulator by skipping the
2.6V and 2.9V steps.
Fix the ranges to read and set the proper voltages.
Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4")
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
Hi Mark,
This patch fixes a commit merged into 4.6-rc1, so it should probably go in
the next -rc release.
Thanks!
Maxime
drivers/regulator/axp20x-regulator.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index 40cd894e4df5..29ab0985b46e 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -157,7 +157,9 @@ static struct regulator_ops axp20x_ops_sw = {
static const struct regulator_linear_range axp20x_ldo4_ranges[] = {
REGULATOR_LINEAR_RANGE(1250000, 0x0, 0x0, 0),
REGULATOR_LINEAR_RANGE(1300000, 0x1, 0x8, 100000),
- REGULATOR_LINEAR_RANGE(2500000, 0x9, 0xf, 100000),
+ REGULATOR_LINEAR_RANGE(2500000, 0x9, 0x9, 0),
+ REGULATOR_LINEAR_RANGE(2700000, 0xa, 0xb, 100000),
+ REGULATOR_LINEAR_RANGE(3000000, 0xc, 0xf, 100000),
};
static const struct regulator_desc axp20x_regulators[] = {
--
2.8.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
2016-04-26 14:00 ` Maxime Ripard
@ 2016-04-26 14:18 ` Chen-Yu Tsai
-1 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2016-04-26 14:18 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Brown, Chen-Yu Tsai, Liam Girdwood, linux-kernel,
linux-arm-kernel, Hans De Goede
On Tue, Apr 26, 2016 at 10:00 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The current linear voltage range for the LDO4 regulator found in the APX20X
> PMICs assumes that the voltage is linear between 2.5 and 3.1V.
>
> However, the PMIC can output up to 3.3V on that regulator by skipping the
> 2.6V and 2.9V steps.
>
> Fix the ranges to read and set the proper voltages.
>
> Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4")
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Hans sent an identical patch (plus another fix) a month ago though.
> ---
> Hi Mark,
>
> This patch fixes a commit merged into 4.6-rc1, so it should probably go in
> the next -rc release.
>
> Thanks!
> Maxime
>
> drivers/regulator/axp20x-regulator.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index 40cd894e4df5..29ab0985b46e 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c
> @@ -157,7 +157,9 @@ static struct regulator_ops axp20x_ops_sw = {
> static const struct regulator_linear_range axp20x_ldo4_ranges[] = {
> REGULATOR_LINEAR_RANGE(1250000, 0x0, 0x0, 0),
> REGULATOR_LINEAR_RANGE(1300000, 0x1, 0x8, 100000),
> - REGULATOR_LINEAR_RANGE(2500000, 0x9, 0xf, 100000),
> + REGULATOR_LINEAR_RANGE(2500000, 0x9, 0x9, 0),
> + REGULATOR_LINEAR_RANGE(2700000, 0xa, 0xb, 100000),
> + REGULATOR_LINEAR_RANGE(3000000, 0xc, 0xf, 100000),
> };
>
> static const struct regulator_desc axp20x_regulators[] = {
> --
> 2.8.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
@ 2016-04-26 14:18 ` Chen-Yu Tsai
0 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2016-04-26 14:18 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 26, 2016 at 10:00 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The current linear voltage range for the LDO4 regulator found in the APX20X
> PMICs assumes that the voltage is linear between 2.5 and 3.1V.
>
> However, the PMIC can output up to 3.3V on that regulator by skipping the
> 2.6V and 2.9V steps.
>
> Fix the ranges to read and set the proper voltages.
>
> Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4")
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Hans sent an identical patch (plus another fix) a month ago though.
> ---
> Hi Mark,
>
> This patch fixes a commit merged into 4.6-rc1, so it should probably go in
> the next -rc release.
>
> Thanks!
> Maxime
>
> drivers/regulator/axp20x-regulator.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index 40cd894e4df5..29ab0985b46e 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c
> @@ -157,7 +157,9 @@ static struct regulator_ops axp20x_ops_sw = {
> static const struct regulator_linear_range axp20x_ldo4_ranges[] = {
> REGULATOR_LINEAR_RANGE(1250000, 0x0, 0x0, 0),
> REGULATOR_LINEAR_RANGE(1300000, 0x1, 0x8, 100000),
> - REGULATOR_LINEAR_RANGE(2500000, 0x9, 0xf, 100000),
> + REGULATOR_LINEAR_RANGE(2500000, 0x9, 0x9, 0),
> + REGULATOR_LINEAR_RANGE(2700000, 0xa, 0xb, 100000),
> + REGULATOR_LINEAR_RANGE(3000000, 0xc, 0xf, 100000),
> };
>
> static const struct regulator_desc axp20x_regulators[] = {
> --
> 2.8.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
2016-04-26 14:18 ` Chen-Yu Tsai
@ 2016-04-26 14:57 ` Mark Brown
-1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2016-04-26 14:57 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Maxime Ripard, Liam Girdwood, linux-kernel, linux-arm-kernel,
Hans De Goede
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
On Tue, Apr 26, 2016 at 10:18:04PM +0800, Chen-Yu Tsai wrote:
> Hans sent an identical patch (plus another fix) a month ago though.
I have no record of any such patch, I don't know where it might've been
sent.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
@ 2016-04-26 14:57 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2016-04-26 14:57 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 26, 2016 at 10:18:04PM +0800, Chen-Yu Tsai wrote:
> Hans sent an identical patch (plus another fix) a month ago though.
I have no record of any such patch, I don't know where it might've been
sent.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160426/1c5de1e7/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
2016-04-26 14:57 ` Mark Brown
@ 2016-04-27 9:46 ` Hans de Goede
-1 siblings, 0 replies; 12+ messages in thread
From: Hans de Goede @ 2016-04-27 9:46 UTC (permalink / raw)
To: Mark Brown, Chen-Yu Tsai
Cc: Maxime Ripard, Liam Girdwood, linux-kernel, linux-arm-kernel
Hi,
On 26-04-16 16:57, Mark Brown wrote:
> On Tue, Apr 26, 2016 at 10:18:04PM +0800, Chen-Yu Tsai wrote:
>
>> Hans sent an identical patch (plus another fix) a month ago though.
>
> I have no record of any such patch, I don't know where it might've been
> sent.
It is here:
https://groups.google.com/forum/#!topic/linux-sunxi/3sjt47-CtbU
And according to that archive it was send to broonie@linaro.org
(amongst others).
Regards,
Hans
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
@ 2016-04-27 9:46 ` Hans de Goede
0 siblings, 0 replies; 12+ messages in thread
From: Hans de Goede @ 2016-04-27 9:46 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 26-04-16 16:57, Mark Brown wrote:
> On Tue, Apr 26, 2016 at 10:18:04PM +0800, Chen-Yu Tsai wrote:
>
>> Hans sent an identical patch (plus another fix) a month ago though.
>
> I have no record of any such patch, I don't know where it might've been
> sent.
It is here:
https://groups.google.com/forum/#!topic/linux-sunxi/3sjt47-CtbU
And according to that archive it was send to broonie at linaro.org
(amongst others).
Regards,
Hans
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
2016-04-27 9:46 ` Hans de Goede
@ 2016-04-27 10:32 ` Mark Brown
-1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2016-04-27 10:32 UTC (permalink / raw)
To: Hans de Goede
Cc: Chen-Yu Tsai, Maxime Ripard, Liam Girdwood, linux-kernel,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
On Wed, Apr 27, 2016 at 11:46:29AM +0200, Hans de Goede wrote:
> On 26-04-16 16:57, Mark Brown wrote:
> >I have no record of any such patch, I don't know where it might've been
> >sent.
> It is here:
Please follow the normal submission workflow, don't pick random new
places to send things. It's fine to copy extra places but if you don't
send to the normal places your patches are likely to not be seen.
> https://groups.google.com/forum/#!topic/linux-sunxi/3sjt47-CtbU
That's linux-sunxi and linux-arm-kernel but not linux-kernel where
regulator patches are supposed to be sent. I did go look to see if I
could see anything on lkml but there was nothing visible from you.
> And according to that archive it was send to broonie@linaro.org
> (amongst others).
That's my work address, not broonie@kernel.org which is the address I
use consistently and which is what is advertised in MAINTAINERS. That
goes somewhere completely different which isn't set up to handle patches
and since essentialy everything that does manage to get sent there is
also sent to the right place things sent there tend to get deleted
unread when I'm doing inbox triage which I imagine is what happened
here. This is the one that's most critical.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
@ 2016-04-27 10:32 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2016-04-27 10:32 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 27, 2016 at 11:46:29AM +0200, Hans de Goede wrote:
> On 26-04-16 16:57, Mark Brown wrote:
> >I have no record of any such patch, I don't know where it might've been
> >sent.
> It is here:
Please follow the normal submission workflow, don't pick random new
places to send things. It's fine to copy extra places but if you don't
send to the normal places your patches are likely to not be seen.
> https://groups.google.com/forum/#!topic/linux-sunxi/3sjt47-CtbU
That's linux-sunxi and linux-arm-kernel but not linux-kernel where
regulator patches are supposed to be sent. I did go look to see if I
could see anything on lkml but there was nothing visible from you.
> And according to that archive it was send to broonie at linaro.org
> (amongst others).
That's my work address, not broonie at kernel.org which is the address I
use consistently and which is what is advertised in MAINTAINERS. That
goes somewhere completely different which isn't set up to handle patches
and since essentialy everything that does manage to get sent there is
also sent to the right place things sent there tend to get deleted
unread when I'm doing inbox triage which I imagine is what happened
here. This is the one that's most critical.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160427/8e8d939d/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Applied "regulator: axp20x: Fix LDO4 linear voltage range" to the regulator tree
2016-04-26 14:00 ` Maxime Ripard
@ 2016-04-26 18:25 ` Mark Brown
-1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2016-04-26 18:25 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Mark Brown, Mark Brown, Chen-Yu Tsai,
Liam Girdwood, linux-kernel, linux-arm-kernel
The patch
regulator: axp20x: Fix LDO4 linear voltage range
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 8d4d5c3a7c25e69075e60e5e70c1e05c205aef89 Mon Sep 17 00:00:00 2001
From: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Tue, 26 Apr 2016 16:00:51 +0200
Subject: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
The current linear voltage range for the LDO4 regulator found in the APX20X
PMICs assumes that the voltage is linear between 2.5 and 3.1V.
However, the PMIC can output up to 3.3V on that regulator by skipping the
2.6V and 2.9V steps.
Fix the ranges to read and set the proper voltages.
Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4")
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/axp20x-regulator.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index 40cd894e4df5..29ab0985b46e 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -157,7 +157,9 @@ static struct regulator_ops axp20x_ops_sw = {
static const struct regulator_linear_range axp20x_ldo4_ranges[] = {
REGULATOR_LINEAR_RANGE(1250000, 0x0, 0x0, 0),
REGULATOR_LINEAR_RANGE(1300000, 0x1, 0x8, 100000),
- REGULATOR_LINEAR_RANGE(2500000, 0x9, 0xf, 100000),
+ REGULATOR_LINEAR_RANGE(2500000, 0x9, 0x9, 0),
+ REGULATOR_LINEAR_RANGE(2700000, 0xa, 0xb, 100000),
+ REGULATOR_LINEAR_RANGE(3000000, 0xc, 0xf, 100000),
};
static const struct regulator_desc axp20x_regulators[] = {
--
2.8.0.rc3
^ permalink raw reply related [flat|nested] 12+ messages in thread* Applied "regulator: axp20x: Fix LDO4 linear voltage range" to the regulator tree
@ 2016-04-26 18:25 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2016-04-26 18:25 UTC (permalink / raw)
To: linux-arm-kernel
The patch
regulator: axp20x: Fix LDO4 linear voltage range
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 8d4d5c3a7c25e69075e60e5e70c1e05c205aef89 Mon Sep 17 00:00:00 2001
From: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Tue, 26 Apr 2016 16:00:51 +0200
Subject: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range
The current linear voltage range for the LDO4 regulator found in the APX20X
PMICs assumes that the voltage is linear between 2.5 and 3.1V.
However, the PMIC can output up to 3.3V on that regulator by skipping the
2.6V and 2.9V steps.
Fix the ranges to read and set the proper voltages.
Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4")
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/axp20x-regulator.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index 40cd894e4df5..29ab0985b46e 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -157,7 +157,9 @@ static struct regulator_ops axp20x_ops_sw = {
static const struct regulator_linear_range axp20x_ldo4_ranges[] = {
REGULATOR_LINEAR_RANGE(1250000, 0x0, 0x0, 0),
REGULATOR_LINEAR_RANGE(1300000, 0x1, 0x8, 100000),
- REGULATOR_LINEAR_RANGE(2500000, 0x9, 0xf, 100000),
+ REGULATOR_LINEAR_RANGE(2500000, 0x9, 0x9, 0),
+ REGULATOR_LINEAR_RANGE(2700000, 0xa, 0xb, 100000),
+ REGULATOR_LINEAR_RANGE(3000000, 0xc, 0xf, 100000),
};
static const struct regulator_desc axp20x_regulators[] = {
--
2.8.0.rc3
^ permalink raw reply related [flat|nested] 12+ messages in thread