* [RFC PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes
@ 2021-07-12 15:47 Russell King
2021-07-12 21:27 ` Marek Behún
2021-07-19 9:05 ` Ioana Ciornei
0 siblings, 2 replies; 3+ messages in thread
From: Russell King @ 2021-07-12 15:47 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit
Cc: David S. Miller, netdev, Ioana Ciornei, Jakub Kicinski
Phylink documentation says:
* Note that the PHY may be able to transform from one connection
* technology to another, so, eg, don't clear 1000BaseX just
* because the MAC is unable to BaseX mode. This is more about
* clearing unsupported speeds and duplex settings. The port modes
* should not be cleared; phylink_set_port_modes() will help with this.
So add the missing 10G modes.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
net-next is currently closed, but I'd like to collect acks for this
patch. Thanks.
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index ae6d382d8735..543c1f202420 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
case PHY_INTERFACE_MODE_10GBASER:
case PHY_INTERFACE_MODE_USXGMII:
phylink_set(mask, 10000baseT_Full);
+ phylink_set(mask, 10000baseCR_Full);
+ phylink_set(mask, 10000baseSR_Full);
+ phylink_set(mask, 10000baseLR_Full);
+ phylink_set(mask, 10000baseLRM_Full);
+ phylink_set(mask, 10000baseER_Full);
if (state->interface == PHY_INTERFACE_MODE_10GBASER)
break;
phylink_set(mask, 5000baseT_Full);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes
2021-07-12 15:47 [RFC PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes Russell King
@ 2021-07-12 21:27 ` Marek Behún
2021-07-19 9:05 ` Ioana Ciornei
1 sibling, 0 replies; 3+ messages in thread
From: Marek Behún @ 2021-07-12 21:27 UTC (permalink / raw)
To: Russell King
Cc: Andrew Lunn, Heiner Kallweit, David S. Miller, netdev,
Ioana Ciornei, Jakub Kicinski
Hi Russell,
On Mon, 12 Jul 2021 16:47:10 +0100
Russell King <rmk+kernel@armlinux.org.uk> wrote:
> Phylink documentation says:
> * Note that the PHY may be able to transform from one connection
> * technology to another, so, eg, don't clear 1000BaseX just
> * because the MAC is unable to BaseX mode. This is more about
> * clearing unsupported speeds and duplex settings. The port modes
> * should not be cleared; phylink_set_port_modes() will help with this.
At first I thought these are points as in Markdown. Maybe remove the
asterisks from the commit message, next time :)
>
> So add the missing 10G modes.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> net-next is currently closed, but I'd like to collect acks for this
> patch. Thanks.
>
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> index ae6d382d8735..543c1f202420 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> @@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
> case PHY_INTERFACE_MODE_10GBASER:
> case PHY_INTERFACE_MODE_USXGMII:
> phylink_set(mask, 10000baseT_Full);
> + phylink_set(mask, 10000baseCR_Full);
> + phylink_set(mask, 10000baseSR_Full);
> + phylink_set(mask, 10000baseLR_Full);
> + phylink_set(mask, 10000baseLRM_Full);
> + phylink_set(mask, 10000baseER_Full);
> if (state->interface == PHY_INTERFACE_MODE_10GBASER)
> break;
> phylink_set(mask, 5000baseT_Full);
Acked-by: Marek Behún <kabel@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes
2021-07-12 15:47 [RFC PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes Russell King
2021-07-12 21:27 ` Marek Behún
@ 2021-07-19 9:05 ` Ioana Ciornei
1 sibling, 0 replies; 3+ messages in thread
From: Ioana Ciornei @ 2021-07-19 9:05 UTC (permalink / raw)
To: Russell King
Cc: Andrew Lunn, Heiner Kallweit, David S. Miller, netdev, Jakub Kicinski
On Mon, Jul 12, 2021 at 04:47:10PM +0100, Russell King wrote:
> Phylink documentation says:
> * Note that the PHY may be able to transform from one connection
> * technology to another, so, eg, don't clear 1000BaseX just
> * because the MAC is unable to BaseX mode. This is more about
> * clearing unsupported speeds and duplex settings. The port modes
> * should not be cleared; phylink_set_port_modes() will help with this.
>
> So add the missing 10G modes.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Acked-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> net-next is currently closed, but I'd like to collect acks for this
> patch. Thanks.
>
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> index ae6d382d8735..543c1f202420 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> @@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
> case PHY_INTERFACE_MODE_10GBASER:
> case PHY_INTERFACE_MODE_USXGMII:
> phylink_set(mask, 10000baseT_Full);
> + phylink_set(mask, 10000baseCR_Full);
> + phylink_set(mask, 10000baseSR_Full);
> + phylink_set(mask, 10000baseLR_Full);
> + phylink_set(mask, 10000baseLRM_Full);
> + phylink_set(mask, 10000baseER_Full);
> if (state->interface == PHY_INTERFACE_MODE_10GBASER)
> break;
> phylink_set(mask, 5000baseT_Full);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-19 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12 15:47 [RFC PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes Russell King
2021-07-12 21:27 ` Marek Behún
2021-07-19 9:05 ` Ioana Ciornei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.