All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Landen Chao <Landen.Chao@mediatek.com>,
	DENG Qingfang <dqfext@gmail.com>,
	Sean Wang <sean.wang@mediatek.com>
Cc: Marek Beh__n <kabel@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: [PATCH net-next 4/9] net: dsa: mt7530: drop use of phylink_helper_basex_speed()
Date: Wed, 06 Apr 2022 11:48:52 +0100	[thread overview]
Message-ID: <E1nc3DY-004hq1-9H@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <Yk1iHCy4fqvxsvu0@shell.armlinux.org.uk>

Now that we have a better method to select SFP interface modes, we
no longer need to use phylink_helper_basex_speed() in a driver's
validation function.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/dsa/mt7530.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 60264836da49..868d1af646f7 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2947,11 +2947,6 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
 
 	linkmode_and(supported, supported, mask);
 	linkmode_and(state->advertising, state->advertising, mask);
-
-	/* We can only operate at 2500BaseX or 1000BaseX.  If requested
-	 * to advertise both, only report advertising at 2500BaseX.
-	 */
-	phylink_helper_basex_speed(state);
 }
 
 static int
-- 
2.30.2


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Landen Chao <Landen.Chao@mediatek.com>,
	DENG Qingfang <dqfext@gmail.com>,
	Sean Wang <sean.wang@mediatek.com>
Cc: Marek Beh__n <kabel@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: [PATCH net-next 4/9] net: dsa: mt7530: drop use of phylink_helper_basex_speed()
Date: Wed, 06 Apr 2022 11:48:52 +0100	[thread overview]
Message-ID: <E1nc3DY-004hq1-9H@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <Yk1iHCy4fqvxsvu0@shell.armlinux.org.uk>

Now that we have a better method to select SFP interface modes, we
no longer need to use phylink_helper_basex_speed() in a driver's
validation function.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/dsa/mt7530.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 60264836da49..868d1af646f7 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2947,11 +2947,6 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
 
 	linkmode_and(supported, supported, mask);
 	linkmode_and(state->advertising, state->advertising, mask);
-
-	/* We can only operate at 2500BaseX or 1000BaseX.  If requested
-	 * to advertise both, only report advertising at 2500BaseX.
-	 */
-	phylink_helper_basex_speed(state);
 }
 
 static int
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Landen Chao <Landen.Chao@mediatek.com>,
	DENG Qingfang <dqfext@gmail.com>,
	Sean Wang <sean.wang@mediatek.com>
Cc: Marek Beh__n <kabel@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: [PATCH net-next 4/9] net: dsa: mt7530: drop use of phylink_helper_basex_speed()
Date: Wed, 06 Apr 2022 11:48:52 +0100	[thread overview]
Message-ID: <E1nc3DY-004hq1-9H@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <Yk1iHCy4fqvxsvu0@shell.armlinux.org.uk>

Now that we have a better method to select SFP interface modes, we
no longer need to use phylink_helper_basex_speed() in a driver's
validation function.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/dsa/mt7530.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 60264836da49..868d1af646f7 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2947,11 +2947,6 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
 
 	linkmode_and(supported, supported, mask);
 	linkmode_and(state->advertising, state->advertising, mask);
-
-	/* We can only operate at 2500BaseX or 1000BaseX.  If requested
-	 * to advertise both, only report advertising at 2500BaseX.
-	 */
-	phylink_helper_basex_speed(state);
 }
 
 static int
-- 
2.30.2


  parent reply	other threads:[~2022-04-06 10:49 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06  9:49 [PATCH net-next 0/9] net: dsa: mt7530: updates for phylink changes Russell King (Oracle)
2022-04-06  9:49 ` Russell King (Oracle)
2022-04-06  9:49 ` Russell King (Oracle)
2022-04-06 10:48 ` [PATCH net-next 1/9] net: dsa: mt7530: 1G can also support 1000BASE-X link mode Russell King (Oracle)
2022-04-06 10:48   ` Russell King (Oracle)
2022-04-06 10:48   ` Russell King (Oracle)
2022-04-06 10:48 ` [PATCH net-next 2/9] net: dsa: mt7530: populate supported_interfaces and mac_capabilities Russell King (Oracle)
2022-04-06 10:48   ` Russell King (Oracle)
2022-04-06 10:48   ` Russell King (Oracle)
2022-04-06 10:48 ` [PATCH net-next 3/9] net: dsa: mt7530: remove interface checks Russell King (Oracle)
2022-04-06 10:48   ` Russell King (Oracle)
2022-04-06 10:48   ` Russell King (Oracle)
2022-04-06 10:48 ` Russell King (Oracle) [this message]
2022-04-06 10:48   ` [PATCH net-next 4/9] net: dsa: mt7530: drop use of phylink_helper_basex_speed() Russell King (Oracle)
2022-04-06 10:48   ` Russell King (Oracle)
2022-04-06 10:48 ` [PATCH net-next 5/9] net: dsa: mt7530: only indicate linkmodes that can be supported Russell King (Oracle)
2022-04-06 10:48   ` Russell King (Oracle)
2022-04-06 10:48   ` Russell King (Oracle)
2022-04-06 18:52   ` Jakub Kicinski
2022-04-06 18:52     ` Jakub Kicinski
2022-04-06 18:52     ` Jakub Kicinski
2022-04-06 20:34     ` Marek Behún
2022-04-06 20:34       ` Marek Behún
2022-04-06 20:34       ` Marek Behún
2022-04-07 14:47       ` Russell King (Oracle)
2022-04-07 14:47         ` Russell King (Oracle)
2022-04-07 14:47         ` Russell King (Oracle)
2022-04-06 10:49 ` [PATCH net-next 6/9] net: dsa: mt7530: switch to use phylink_get_linkmodes() Russell King (Oracle)
2022-04-06 10:49   ` Russell King (Oracle)
2022-04-06 10:49   ` Russell King (Oracle)
2022-04-06 10:49 ` [PATCH net-next 7/9] net: dsa: mt7530: partially convert to phylink_pcs Russell King (Oracle)
2022-04-06 10:49   ` Russell King (Oracle)
2022-04-06 10:49   ` Russell King (Oracle)
2022-04-06 10:49 ` [PATCH net-next 8/9] net: dsa: mt7530: move autoneg handling to PCS validation Russell King (Oracle)
2022-04-06 10:49   ` Russell King (Oracle)
2022-04-06 10:49   ` Russell King (Oracle)
2022-04-06 10:49 ` [PATCH net-next 9/9] net: dsa: mt7530: mark as non-legacy Russell King (Oracle)
2022-04-06 10:49   ` Russell King (Oracle)
2022-04-06 10:49   ` Russell King (Oracle)
2022-04-06 22:35 ` [PATCH net-next 0/9] net: dsa: mt7530: updates for phylink changes Marek Behún
2022-04-06 22:35   ` Marek Behún
2022-04-06 22:35   ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1nc3DY-004hq1-9H@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=Landen.Chao@mediatek.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dqfext@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=kabel@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=sean.wang@mediatek.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.