All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Delevoryas <pdel@fb.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"zev@bewilderbeest.net" <zev@bewilderbeest.net>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Iris Chen" <irischenlj@fb.com>,
	"OpenBMC List" <openbmc@lists.ozlabs.org>,
	"Cameron Esfahani via" <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>, "Joel Stanley" <joel@jms.id.au>,
	"Peter Delevoryas" <pdel@fb.com>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices
Date: Sun, 15 May 2022 22:55:28 +0000	[thread overview]
Message-ID: <F01557BD-FC48-47DD-8EED-9845EBB987F1@fb.com> (raw)
In-Reply-To: <7187a877-354e-5e79-7ad1-a6e368678002@kaod.org>



> On May 15, 2022, at 2:19 PM, Cédric Le Goater <clg@kaod.org> wrote:
> 
> [ ... ]
> 
>>> The problem is that it is breaking compatibility with previous QEMUs.
>> It is? We can still run things the old way too, I specifically
>> wrote this with the intention that it would support backwards
>> compatibility.
> 
> You are right. Let's start with your patchset. We can add the "uart"
> machine option when the need arises.
> 
> I have sent a small cleanup of aspeed_soc_get_irq() that should avoid
> the duplication of the serial init in the different SoC models. Please
> give it a try.
> 

Oh this is fantastic, thanks! I’ll gladly put the serial init code into
a function declared in aspeed_soc.h then.

> Thanks,
> 
> C.
> 


WARNING: multiple messages have this Message-ID (diff)
From: Peter Delevoryas <pdel@fb.com>
Cc: "Iris Chen" <irischenlj@fb.com>,
	"patrick@stwcx.xyz" <patrick@stwcx.xyz>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Cameron Esfahani via" <qemu-devel@nongnu.org>,
	"zev@bewilderbeest.net" <zev@bewilderbeest.net>,
	"OpenBMC List" <openbmc@lists.ozlabs.org>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Peter Delevoryas" <pdel@fb.com>
Subject: Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices
Date: Sun, 15 May 2022 22:55:28 +0000	[thread overview]
Message-ID: <F01557BD-FC48-47DD-8EED-9845EBB987F1@fb.com> (raw)
In-Reply-To: <7187a877-354e-5e79-7ad1-a6e368678002@kaod.org>



> On May 15, 2022, at 2:19 PM, Cédric Le Goater <clg@kaod.org> wrote:
> 
> [ ... ]
> 
>>> The problem is that it is breaking compatibility with previous QEMUs.
>> It is? We can still run things the old way too, I specifically
>> wrote this with the intention that it would support backwards
>> compatibility.
> 
> You are right. Let's start with your patchset. We can add the "uart"
> machine option when the need arises.
> 
> I have sent a small cleanup of aspeed_soc_get_irq() that should avoid
> the duplication of the serial init in the different SoC models. Please
> give it a try.
> 

Oh this is fantastic, thanks! I’ll gladly put the serial init code into
a function declared in aspeed_soc.h then.

> Thanks,
> 
> C.
> 


  reply	other threads:[~2022-05-15 22:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13  4:02 [PATCH 0/2] hw: aspeed: Init all UART's with serial devices Peter Delevoryas
2022-05-13  4:02 ` Peter Delevoryas
2022-05-13  4:02 ` [PATCH 1/2] hw: aspeed: Add missing UART's Peter Delevoryas
2022-05-13  4:02   ` Peter Delevoryas
2022-05-13  5:21   ` Cédric Le Goater
2022-05-13  5:21     ` Cédric Le Goater
2022-05-13  4:02 ` [PATCH 2/2] hw: aspeed: Init all UART's with serial devices Peter Delevoryas
2022-05-13  4:02   ` Peter Delevoryas
2022-05-13  5:31   ` Cédric Le Goater
2022-05-13  5:31     ` Cédric Le Goater
2022-05-13 21:08     ` Peter Delevoryas
2022-05-13 21:08       ` Peter Delevoryas
2022-05-14  7:30       ` Cédric Le Goater
2022-05-14  7:30         ` Cédric Le Goater
2022-05-14  7:39         ` Peter Delevoryas
2022-05-14  7:39           ` Peter Delevoryas
2022-05-15 21:19           ` Cédric Le Goater
2022-05-15 21:19             ` Cédric Le Goater
2022-05-15 22:55             ` Peter Delevoryas [this message]
2022-05-15 22:55               ` Peter Delevoryas
2022-05-16 14:56       ` Peter Maydell
2022-05-16 14:56         ` Peter Maydell
2022-05-13 21:39 ` [PATCH 0/2] " Zev Weiss
2022-05-13 21:39   ` Zev Weiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F01557BD-FC48-47DD-8EED-9845EBB987F1@fb.com \
    --to=pdel@fb.com \
    --cc=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=irischenlj@fb.com \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zev@bewilderbeest.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.