* [PATCH] net/avf: fix link autoneg value
@ 2018-03-09 17:56 Ferruh Yigit
2018-03-28 6:42 ` Zhang, Qi Z
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-03-09 17:56 UTC (permalink / raw)
To: Jingjing Wu, Wenzhuo Lu; +Cc: dev, Ferruh Yigit, stable
Intention of the logic is:
If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to
ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG
ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0;
Current logic is broken, fix it according above values.
Fixes: 48de41ca11f0 ("net/avf: enable link status update")
Cc: jingjing.wu@intel.com
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/avf/avf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 4df661705..4442c3cd8 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -608,7 +608,7 @@ avf_dev_link_update(struct rte_eth_dev *dev,
new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
new_link.link_status = vf->link_up ? ETH_LINK_UP :
ETH_LINK_DOWN;
- new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds &
+ new_link.link_autoneg = !(dev->data->dev_conf.link_speeds &
ETH_LINK_SPEED_FIXED);
if (rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link,
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net/avf: fix link autoneg value 2018-03-09 17:56 [PATCH] net/avf: fix link autoneg value Ferruh Yigit @ 2018-03-28 6:42 ` Zhang, Qi Z 2018-03-28 13:25 ` Ferruh Yigit 2018-03-29 5:51 ` Zhang, Helin 0 siblings, 2 replies; 4+ messages in thread From: Zhang, Qi Z @ 2018-03-28 6:42 UTC (permalink / raw) To: Yigit, Ferruh, Wu, Jingjing, Lu, Wenzhuo; +Cc: dev, Yigit, Ferruh, stable Hi Ferruh: > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Saturday, March 10, 2018 1:57 AM > To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com> > Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value > > Intention of the logic is: > If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to > ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG > > ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0; > > Current logic is broken, fix it according above values. > > Fixes: 48de41ca11f0 ("net/avf: enable link status update") > Cc: jingjing.wu@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: Qi Zhang <qi.z.zhang@intel.com> BTW, I saw the same issue on i40evf, will you also fix that? Thanks Qi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/avf: fix link autoneg value 2018-03-28 6:42 ` Zhang, Qi Z @ 2018-03-28 13:25 ` Ferruh Yigit 2018-03-29 5:51 ` Zhang, Helin 1 sibling, 0 replies; 4+ messages in thread From: Ferruh Yigit @ 2018-03-28 13:25 UTC (permalink / raw) To: Zhang, Qi Z, Wu, Jingjing, Lu, Wenzhuo; +Cc: dev, stable On 3/28/2018 7:42 AM, Zhang, Qi Z wrote: > Hi Ferruh: > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Saturday, March 10, 2018 1:57 AM >> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo >> <wenzhuo.lu@intel.com> >> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org >> Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value >> >> Intention of the logic is: >> If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to >> ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG >> >> ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0; >> >> Current logic is broken, fix it according above values. >> >> Fixes: 48de41ca11f0 ("net/avf: enable link status update") >> Cc: jingjing.wu@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Acked-by: Qi Zhang <qi.z.zhang@intel.com> > > BTW, I saw the same issue on i40evf, will you also fix that? It is in: https://dpdk.org/dev/patchwork/patch/36076/ > > Thanks > Qi > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/avf: fix link autoneg value 2018-03-28 6:42 ` Zhang, Qi Z 2018-03-28 13:25 ` Ferruh Yigit @ 2018-03-29 5:51 ` Zhang, Helin 1 sibling, 0 replies; 4+ messages in thread From: Zhang, Helin @ 2018-03-29 5:51 UTC (permalink / raw) To: Zhang, Qi Z, Yigit, Ferruh, Wu, Jingjing, Lu, Wenzhuo Cc: dev, Yigit, Ferruh, stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, March 28, 2018 2:43 PM > To: Yigit, Ferruh; Wu, Jingjing; Lu, Wenzhuo > Cc: dev@dpdk.org; Yigit, Ferruh; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/avf: fix link autoneg value > > Hi Ferruh: > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > > Sent: Saturday, March 10, 2018 1:57 AM > > To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo > > <wenzhuo.lu@intel.com> > > Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value > > > > Intention of the logic is: > > If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to > > ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG > > > > ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0; > > > > Current logic is broken, fix it according above values. > > > > Fixes: 48de41ca11f0 ("net/avf: enable link status update") > > Cc: jingjing.wu@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Acked-by: Qi Zhang <qi.z.zhang@intel.com> Applied to dpdk-next-net-intel, thanks! /Helin ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-29 5:51 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-03-09 17:56 [PATCH] net/avf: fix link autoneg value Ferruh Yigit 2018-03-28 6:42 ` Zhang, Qi Z 2018-03-28 13:25 ` Ferruh Yigit 2018-03-29 5:51 ` Zhang, Helin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.