All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Jonathan Cameron" <jic23@jic23.retrosnub.co.uk>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Michael Welling" <mwelling@ieee.org>,
	"Mika Penttilä" <mika.penttila@nextfour.com>,
	"Javier Martinez Canillas" <javier@osg.samsung.com>,
	"Igor Grinberg" <grinberg@compulab.co.il>,
	"Andrew F. Davis" <afd@ti.com>, "Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Alexander Stein" <alexander.stein@systec-electronic.com>,
	"Eric Engestrom" <eric@engestrom.ch>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Petr Cvek" <petr.cvek@tul.cz>,
	linux-input@vger.kernel.org,
	devicetree <devicetree@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"Discussions about the Letux Kernel"
	<letux-kernel@openphoenux.org>,
	linux-iio@vger.kernel.org, kernel@pyra-handheld.com,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	"Linux Kbuild mailing list" <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature
Date: Wed, 28 Dec 2016 15:52:48 +0100	[thread overview]
Message-ID: <FA2666F0-0C5B-458E-97B5-83243F26D0DE@goldelico.com> (raw)
In-Reply-To: <20161227215416.GB28140@dtor-ws>

Hi Dmitry,

> Am 27.12.2016 um 22:54 schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> 
> On Mon, Dec 12, 2016 at 10:21:25PM +0100, H. Nikolaus Schaller wrote:
>> Hi,
>> 
>> 
>>> Am 27.11.2016 um 16:47 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
>>> 
>>> Hi Jonathan,
>>> 
>>>> Am 27.11.2016 um 12:02 schrieb Jonathan Cameron <jic23@kernel.org>:
>>>> 
>>>> On 24/11/16 18:05, H. Nikolaus Schaller wrote:
>>>>> 
>>>>>> Am 24.11.2016 um 18:38 schrieb Jonathan Cameron <jic23@jic23.retrosnub.co.uk>:
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> On 22 November 2016 14:02:30 GMT+00:00, "H. Nikolaus Schaller" <hns@goldelico.com> wrote:
>> 
>>> 
>>>> - hence cc'd Yann and the Kbuild list
>>>> to see if they can offer some advices.
>> 
>> no response / advice so far.
> 
> Since you are saying that IIO stuff is optional, add it to Kconfig
> explicitly:
> 
> config "TOUCHSCREEN_TSC2007_IIO"
> 	bool "IIO interface for external ADC input and temperature"
> 	depends on TOUCHSCREEN_TSC2007
> 	depends on IIO=y || IIO=TOUCHSCREEN_TSC2007
> 	help
> 	  ...
> 
> and use this symbols in makefile:
> 
> and in Makefile:
> 
> obj-$(CONFIG_TOUCHSCREEN_TSC2007) += tsc2007.o
> tsc2007-y := tsc2007-core.o ...
> tsc2007-$(CONFIG_TOUCHSCREEN_TSC2007_IIO) += tsc2007_iio.o

Ah, ok. Well, we tried to make it without an explicit config option
but it does not hurt to have one.

Your proposal works fine for 3 out of the 4 possible combinations.

I think it is unlikely that the combination TOUCHSCREEN_TSC2007=y IIO=m
is needed at all (we configure as much as possible as =m in our kernel).

Patch v9 will come next (where I have also moved this iio driver
patch to be 8/8).

BR and thanks,
Nikolaus

WARNING: multiple messages have this Message-ID (diff)
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Jonathan Cameron" <jic23@jic23.retrosnub.co.uk>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Michael Welling" <mwelling@ieee.org>,
	"Mika Penttilä" <mika.penttila@nextfour.com>,
	"Javier Martinez Canillas" <javier@osg.samsung.com>,
	"Igor Grinberg" <grinberg@compulab.co.il>,
	"Andrew F. Davis" <afd@ti.com>, "Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Alexander Stein" <alexander.stein@systec-electronic.com>,
	"Eric Engestrom" <eric@engestrom.ch>,
	"Hans de Goede" <hdegoede@redhat.com>
Subject: Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature
Date: Wed, 28 Dec 2016 15:52:48 +0100	[thread overview]
Message-ID: <FA2666F0-0C5B-458E-97B5-83243F26D0DE@goldelico.com> (raw)
In-Reply-To: <20161227215416.GB28140@dtor-ws>

Hi Dmitry,

> Am 27.12.2016 um 22:54 schrieb Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> 
> On Mon, Dec 12, 2016 at 10:21:25PM +0100, H. Nikolaus Schaller wrote:
>> Hi,
>> 
>> 
>>> Am 27.11.2016 um 16:47 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
>>> 
>>> Hi Jonathan,
>>> 
>>>> Am 27.11.2016 um 12:02 schrieb Jonathan Cameron <jic23@kernel.org>:
>>>> 
>>>> On 24/11/16 18:05, H. Nikolaus Schaller wrote:
>>>>> 
>>>>>> Am 24.11.2016 um 18:38 schrieb Jonathan Cameron <jic23@jic23.retrosnub.co.uk>:
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> On 22 November 2016 14:02:30 GMT+00:00, "H. Nikolaus Schaller" <hns@goldelico.com> wrote:
>> 
>>> 
>>>> - hence cc'd Yann and the Kbuild list
>>>> to see if they can offer some advices.
>> 
>> no response / advice so far.
> 
> Since you are saying that IIO stuff is optional, add it to Kconfig
> explicitly:
> 
> config "TOUCHSCREEN_TSC2007_IIO"
> 	bool "IIO interface for external ADC input and temperature"
> 	depends on TOUCHSCREEN_TSC2007
> 	depends on IIO=y || IIO=TOUCHSCREEN_TSC2007
> 	help
> 	  ...
> 
> and use this symbols in makefile:
> 
> and in Makefile:
> 
> obj-$(CONFIG_TOUCHSCREEN_TSC2007) += tsc2007.o
> tsc2007-y := tsc2007-core.o ...
> tsc2007-$(CONFIG_TOUCHSCREEN_TSC2007_IIO) += tsc2007_iio.o

Ah, ok. Well, we tried to make it without an explicit config option
but it does not hurt to have one.

Your proposal works fine for 3 out of the 4 possible combinations.

I think it is unlikely that the combination TOUCHSCREEN_TSC2007=y IIO=m
is needed at all (we configure as much as possible as =m in our kernel).

Patch v9 will come next (where I have also moved this iio driver
patch to be 8/8).

BR and thanks,
Nikolaus

WARNING: multiple messages have this Message-ID (diff)
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Jonathan Cameron" <jic23@jic23.retrosnub.co.uk>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Michael Welling" <mwelling@ieee.org>,
	"Mika Penttilä" <mika.penttila@nextfour.com>,
	"Javier Martinez Canillas" <javier@osg.samsung.com>,
	"Igor Grinberg" <grinberg@compulab.co.il>,
	"Andrew F. Davis" <afd@ti.com>, "Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Alexander Stein" <alexander.stein@systec-electronic.com>,
	"Eric Engestrom" <eric@engestrom.ch>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Petr Cvek" <petr.cvek@tul.cz>,
	linux-input@vger.kernel.org,
	devicetree <devicetree@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"Discussions about the Letux Kernel"
	<letux-kernel@openphoenux.org>,
	linux-iio@vger.kernel.org, kernel@pyra-handheld.com,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	"Linux Kbuild mailing list" <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature
Date: Wed, 28 Dec 2016 15:52:48 +0100	[thread overview]
Message-ID: <FA2666F0-0C5B-458E-97B5-83243F26D0DE@goldelico.com> (raw)
In-Reply-To: <20161227215416.GB28140@dtor-ws>

Hi Dmitry,

> Am 27.12.2016 um 22:54 schrieb Dmitry Torokhov =
<dmitry.torokhov@gmail.com>:
>=20
> On Mon, Dec 12, 2016 at 10:21:25PM +0100, H. Nikolaus Schaller wrote:
>> Hi,
>>=20
>>=20
>>> Am 27.11.2016 um 16:47 schrieb H. Nikolaus Schaller =
<hns@goldelico.com>:
>>>=20
>>> Hi Jonathan,
>>>=20
>>>> Am 27.11.2016 um 12:02 schrieb Jonathan Cameron <jic23@kernel.org>:
>>>>=20
>>>> On 24/11/16 18:05, H. Nikolaus Schaller wrote:
>>>>>=20
>>>>>> Am 24.11.2016 um 18:38 schrieb Jonathan Cameron =
<jic23@jic23.retrosnub.co.uk>:
>>>>>>=20
>>>>>>=20
>>>>>>=20
>>>>>> On 22 November 2016 14:02:30 GMT+00:00, "H. Nikolaus Schaller" =
<hns@goldelico.com> wrote:
>>=20
>>>=20
>>>> - hence cc'd Yann and the Kbuild list
>>>> to see if they can offer some advices.
>>=20
>> no response / advice so far.
>=20
> Since you are saying that IIO stuff is optional, add it to Kconfig
> explicitly:
>=20
> config "TOUCHSCREEN_TSC2007_IIO"
> 	bool "IIO interface for external ADC input and temperature"
> 	depends on TOUCHSCREEN_TSC2007
> 	depends on IIO=3Dy || IIO=3DTOUCHSCREEN_TSC2007
> 	help
> 	  ...
>=20
> and use this symbols in makefile:
>=20
> and in Makefile:
>=20
> obj-$(CONFIG_TOUCHSCREEN_TSC2007) +=3D tsc2007.o
> tsc2007-y :=3D tsc2007-core.o ...
> tsc2007-$(CONFIG_TOUCHSCREEN_TSC2007_IIO) +=3D tsc2007_iio.o

Ah, ok. Well, we tried to make it without an explicit config option
but it does not hurt to have one.

Your proposal works fine for 3 out of the 4 possible combinations.

I think it is unlikely that the combination TOUCHSCREEN_TSC2007=3Dy =
IIO=3Dm
is needed at all (we configure as much as possible as =3Dm in our =
kernel).

Patch v9 will come next (where I have also moved this iio driver
patch to be 8/8).

BR and thanks,
Nikolaus=

  reply	other threads:[~2016-12-28 14:53 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 14:02 [PATCH v8 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2016-11-22 14:02 ` H. Nikolaus Schaller
2016-11-22 14:02 ` [PATCH v8 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation H. Nikolaus Schaller
2016-11-22 14:02   ` H. Nikolaus Schaller
2016-11-22 14:02 ` [PATCH v8 2/8] drivers:input:tsc2007: check for presence and power down tsc2007 during probe H. Nikolaus Schaller
2016-11-22 14:02   ` H. Nikolaus Schaller
2016-11-22 14:02 ` [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature H. Nikolaus Schaller
2016-11-22 14:02   ` H. Nikolaus Schaller
2016-11-24 17:38   ` Jonathan Cameron
2016-11-24 17:38     ` Jonathan Cameron
2016-11-24 17:38     ` Jonathan Cameron
2016-11-24 18:05     ` H. Nikolaus Schaller
2016-11-24 18:05       ` H. Nikolaus Schaller
2016-11-24 18:05       ` H. Nikolaus Schaller
2016-11-27 11:02       ` Jonathan Cameron
2016-11-27 11:02         ` Jonathan Cameron
2016-11-27 15:47         ` H. Nikolaus Schaller
2016-11-27 15:47           ` H. Nikolaus Schaller
2016-11-27 15:47           ` H. Nikolaus Schaller
2016-12-12 21:21           ` H. Nikolaus Schaller
2016-12-12 21:21             ` H. Nikolaus Schaller
2016-12-12 21:21             ` H. Nikolaus Schaller
2016-12-27 19:08             ` H. Nikolaus Schaller
2016-12-27 19:08               ` H. Nikolaus Schaller
2016-12-27 19:08               ` H. Nikolaus Schaller
2016-12-27 21:54             ` Dmitry Torokhov
2016-12-27 21:54               ` Dmitry Torokhov
2016-12-28 14:52               ` H. Nikolaus Schaller [this message]
2016-12-28 14:52                 ` H. Nikolaus Schaller
2016-12-28 14:52                 ` H. Nikolaus Schaller
2016-12-30 20:17                 ` Jonathan Cameron
2016-12-30 20:17                   ` Jonathan Cameron
2016-11-22 14:02 ` [PATCH v8 4/8] DT:omap3+tsc2007: use new common touchscreen bindings H. Nikolaus Schaller
2016-11-22 14:02   ` H. Nikolaus Schaller
2016-11-22 14:02 ` [PATCH v8 5/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping H. Nikolaus Schaller
2016-11-22 14:02   ` H. Nikolaus Schaller
2016-11-22 14:02 ` [PATCH v8 6/8] dt-bindings: input: move ads7846 bindings to touchscreen subdirectory H. Nikolaus Schaller
2016-11-22 14:02   ` H. Nikolaus Schaller
2016-11-22 14:02 ` [PATCH v8 7/8] drivers:input:ads7846(+tsc2046): fix spi module table H. Nikolaus Schaller
2016-11-22 14:02   ` H. Nikolaus Schaller
2016-11-22 14:02 ` [PATCH v8 8/8] DT:omap3+ads7846: use new common touchscreen bindings H. Nikolaus Schaller
2016-11-22 14:02   ` H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FA2666F0-0C5B-458E-97B5-83243F26D0DE@goldelico.com \
    --to=hns@goldelico.com \
    --cc=afd@ti.com \
    --cc=alexander.stein@systec-electronic.com \
    --cc=arnd@arndb.de \
    --cc=bcousson@baylibre.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=eric@engestrom.ch \
    --cc=grinberg@compulab.co.il \
    --cc=hdegoede@redhat.com \
    --cc=javier@osg.samsung.com \
    --cc=jic23@jic23.retrosnub.co.uk \
    --cc=jic23@kernel.org \
    --cc=kernel@pyra-handheld.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mika.penttila@nextfour.com \
    --cc=mwelling@ieee.org \
    --cc=petr.cvek@tul.cz \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.