* [PATCH] iwd: Fix station in scan callback [not found] <20220118102842.1199829-1-Emmanuel.VAUTRIN@cpexterne.org> @ 2022-01-18 10:33 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 2022-01-18 10:38 ` Michael Nazzareno Trimarchi 2022-01-18 10:39 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 0 siblings, 2 replies; 6+ messages in thread From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2022-01-18 10:33 UTC (permalink / raw) To: connman The station shall be searched in stations table instead of networks. Fixes: 8371114aaef9 ("iwd: Hookup manual scan trigger") --- plugins/iwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/iwd.c b/plugins/iwd.c index b0e17a4d6396..bb97262eff38 100644 --- a/plugins/iwd.c +++ b/plugins/iwd.c @@ -555,7 +555,7 @@ static void cm_device_scan_cb(DBusMessage *message, void *user_data) const char *path = user_data; struct iwd_station *iwds; - iwds = g_hash_table_lookup(networks, path); + iwds = g_hash_table_lookup(stations, path); if (!iwds) return; -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iwd: Fix station in scan callback 2022-01-18 10:33 ` [PATCH] iwd: Fix station in scan callback VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2022-01-18 10:38 ` Michael Nazzareno Trimarchi 2022-01-18 10:47 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 2022-01-18 10:39 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 1 sibling, 1 reply; 6+ messages in thread From: Michael Nazzareno Trimarchi @ 2022-01-18 10:38 UTC (permalink / raw) To: VAUTRIN Emmanuel (Canal Plus Prestataire); +Cc: connman Hi On Tue, Jan 18, 2022 at 11:33 AM VAUTRIN Emmanuel (Canal Plus Prestataire) <Emmanuel.VAUTRIN@cpexterne.org> wrote: > > The station shall be searched in stations table instead of networks. > Fixes: 8371114aaef9 ("iwd: Hookup manual scan trigger") > --- > plugins/iwd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/plugins/iwd.c b/plugins/iwd.c > index b0e17a4d6396..bb97262eff38 100644 > --- a/plugins/iwd.c > +++ b/plugins/iwd.c > @@ -555,7 +555,7 @@ static void cm_device_scan_cb(DBusMessage *message, void *user_data) > const char *path = user_data; > struct iwd_station *iwds; > > - iwds = g_hash_table_lookup(networks, path); > + iwds = g_hash_table_lookup(stations, path); > if (!iwds) > return; > Can you describe how to verify the problem? Michael > -- > 2.25.1 > > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] iwd: Fix station in scan callback 2022-01-18 10:38 ` Michael Nazzareno Trimarchi @ 2022-01-18 10:47 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 0 siblings, 0 replies; 6+ messages in thread From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2022-01-18 10:47 UTC (permalink / raw) To: Michael Nazzareno Trimarchi; +Cc: connman [-- Attachment #1: Type: text/plain, Size: 269 bytes --] Hi Michael. > Can you describe how to verify the problem? Only dev logs are impacted. They never were called. As it seems that either via gmail or my pro emails, the tabs are automatically replaced by spaces, I attach the patch. Best Regards, Emmanuel [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-iwd-Fix-station-in-scan-callback.patch --] [-- Type: text/x-patch; name="0001-iwd-Fix-station-in-scan-callback.patch", Size: 820 bytes --] From 2cb497e1ef5b96e7458eed6283a96ae1cfd9e90b Mon Sep 17 00:00:00 2001 From: Emmanuel VAUTRIN <Emmanuel.VAUTRIN@cpexterne.org> Date: Tue, 18 Jan 2022 09:30:57 +0100 Subject: [PATCH] iwd: Fix station in scan callback The station shall be searched in stations table instead of networks. Fixes: 8371114aaef9 ("iwd: Hookup manual scan trigger") --- plugins/iwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/iwd.c b/plugins/iwd.c index b0e17a4d6396..bb97262eff38 100644 --- a/plugins/iwd.c +++ b/plugins/iwd.c @@ -555,7 +555,7 @@ static void cm_device_scan_cb(DBusMessage *message, void *user_data) const char *path = user_data; struct iwd_station *iwds; - iwds = g_hash_table_lookup(networks, path); + iwds = g_hash_table_lookup(stations, path); if (!iwds) return; -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] iwd: Fix station in scan callback 2022-01-18 10:33 ` [PATCH] iwd: Fix station in scan callback VAUTRIN Emmanuel (Canal Plus Prestataire) 2022-01-18 10:38 ` Michael Nazzareno Trimarchi @ 2022-01-18 10:39 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 2022-01-21 7:48 ` Daniel Wagner 1 sibling, 1 reply; 6+ messages in thread From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2022-01-18 10:39 UTC (permalink / raw) To: connman The station shall be searched in stations table instead of networks. Fixes: 8371114aaef9 ("iwd: Hookup manual scan trigger") --- plugins/iwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/iwd.c b/plugins/iwd.c index b0e17a4d6396..bb97262eff38 100644 --- a/plugins/iwd.c +++ b/plugins/iwd.c @@ -555,7 +555,7 @@ static void cm_device_scan_cb(DBusMessage *message, void *user_data) const char *path = user_data; struct iwd_station *iwds; - iwds = g_hash_table_lookup(networks, path); + iwds = g_hash_table_lookup(stations, path); if (!iwds) return; -- 2.25.1 Hi Daniel, I wish you a happy new year! It seems that I am still accountering the tabs -> spaces issue. I try to send the patch back in the message. Best Regards, Emmanuel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iwd: Fix station in scan callback 2022-01-18 10:39 ` VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2022-01-21 7:48 ` Daniel Wagner 2022-01-21 9:47 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 0 siblings, 1 reply; 6+ messages in thread From: Daniel Wagner @ 2022-01-21 7:48 UTC (permalink / raw) To: VAUTRIN Emmanuel (Canal Plus Prestataire); +Cc: connman On Tue, Jan 18, 2022 at 10:39:34AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote: > The station shall be searched in stations table instead of networks. > Fixes: 8371114aaef9 ("iwd: Hookup manual scan trigger") Patch applied. Thanks! > --- > plugins/iwd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/plugins/iwd.c b/plugins/iwd.c > index b0e17a4d6396..bb97262eff38 100644 > --- a/plugins/iwd.c > +++ b/plugins/iwd.c > @@ -555,7 +555,7 @@ static void cm_device_scan_cb(DBusMessage *message, void *user_data) > const char *path = user_data; > struct iwd_station *iwds; > > - iwds = g_hash_table_lookup(networks, path); > + iwds = g_hash_table_lookup(stations, path); > if (!iwds) > return; > > -- > 2.25.1 > Hi Daniel, > > I wish you a happy new year! Thank you, same to you! > It seems that I am still accountering the tabs -> spaces issue. > I try to send the patch back in the message. Ah, back to your MS setup, I see. Attaching the patches works. We don't have that many patches so I can handle it. Daniel ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] iwd: Fix station in scan callback 2022-01-21 7:48 ` Daniel Wagner @ 2022-01-21 9:47 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 0 siblings, 0 replies; 6+ messages in thread From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2022-01-21 9:47 UTC (permalink / raw) To: connman > Patch applied. Thanks! Great, thank you Daniel! ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-21 9:47 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20220118102842.1199829-1-Emmanuel.VAUTRIN@cpexterne.org> 2022-01-18 10:33 ` [PATCH] iwd: Fix station in scan callback VAUTRIN Emmanuel (Canal Plus Prestataire) 2022-01-18 10:38 ` Michael Nazzareno Trimarchi 2022-01-18 10:47 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 2022-01-18 10:39 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 2022-01-21 7:48 ` Daniel Wagner 2022-01-21 9:47 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.