All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Peled <bpeled@marvell.com>
To: Rob Herring <robh@kernel.org>
Cc: "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>,
	"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"mw@semihalf.com" <mw@semihalf.com>,
	"jaz@semihalf.com" <jaz@semihalf.com>,
	Kostya Porotchkin <kostap@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Stefan Chulski <stefanc@marvell.com>,
	Ofer Heifetz <oferh@marvell.com>
Subject: RE: [EXT] Re: [”PATCH” 3/5] dt-bindings: pci: add system controller and MAC reset bit to Armada 7K/8K controller bindings
Date: Mon, 26 Apr 2021 15:58:33 +0000	[thread overview]
Message-ID: <MW2PR18MB2217D165D4E0435888525310C2429@MW2PR18MB2217.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210413151013.GA1683364@robh.at.kernel.org>

Hi Rob,
Sorry I missed it.

> > diff --git a/Documentation/devicetree/bindings/pci/pci-armada8k.txt
> > b/Documentation/devicetree/bindings/pci/pci-armada8k.txt
> > index 7a813d0..2696e79 100644
> > --- a/Documentation/devicetree/bindings/pci/pci-armada8k.txt
> > +++ b/Documentation/devicetree/bindings/pci/pci-armada8k.txt
> > @@ -24,6 +24,10 @@ Optional properties:
> >  - phy-names: names of the PHYs corresponding to the number of lanes.
> >  	Must be "cp0-pcie0-x4-lane0-phy", "cp0-pcie0-x4-lane1-phy" for
> >  	2 PHYs.
> > +- marvell,system-controller: address of system controller needed
> > +	in order to reset MAC used by link-down handle
> > +- marvell,mac-reset-bit-mask: MAC reset bit of system controller
> > +	needed in order to reset MAC used by link-down handle
> 
> Seems like this should use the reset controller binding instead.
> 
> If not, this can be a single property with a phandle plus arg.
> 
> Rob

I will fix it v3.
Thanks

WARNING: multiple messages have this Message-ID (diff)
From: Ben Peled <bpeled@marvell.com>
To: Rob Herring <robh@kernel.org>
Cc: "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>,
	"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"mw@semihalf.com" <mw@semihalf.com>,
	"jaz@semihalf.com" <jaz@semihalf.com>,
	Kostya Porotchkin <kostap@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Stefan Chulski <stefanc@marvell.com>,
	Ofer Heifetz <oferh@marvell.com>
Subject: RE: [EXT] Re: [”PATCH” 3/5] dt-bindings: pci: add system controller and MAC reset bit to Armada 7K/8K controller bindings
Date: Mon, 26 Apr 2021 15:58:33 +0000	[thread overview]
Message-ID: <MW2PR18MB2217D165D4E0435888525310C2429@MW2PR18MB2217.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210413151013.GA1683364@robh.at.kernel.org>

Hi Rob,
Sorry I missed it.

> > diff --git a/Documentation/devicetree/bindings/pci/pci-armada8k.txt
> > b/Documentation/devicetree/bindings/pci/pci-armada8k.txt
> > index 7a813d0..2696e79 100644
> > --- a/Documentation/devicetree/bindings/pci/pci-armada8k.txt
> > +++ b/Documentation/devicetree/bindings/pci/pci-armada8k.txt
> > @@ -24,6 +24,10 @@ Optional properties:
> >  - phy-names: names of the PHYs corresponding to the number of lanes.
> >  	Must be "cp0-pcie0-x4-lane0-phy", "cp0-pcie0-x4-lane1-phy" for
> >  	2 PHYs.
> > +- marvell,system-controller: address of system controller needed
> > +	in order to reset MAC used by link-down handle
> > +- marvell,mac-reset-bit-mask: MAC reset bit of system controller
> > +	needed in order to reset MAC used by link-down handle
> 
> Seems like this should use the reset controller binding instead.
> 
> If not, this can be a single property with a phandle plus arg.
> 
> Rob

I will fix it v3.
Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-26 15:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 15:30 [”PATCH” 0/5] Asynchronous linkdown recovery bpeled
2021-04-12 15:30 ` bpeled
2021-04-12 15:30 ` [”PATCH” 1/5] PCI: armada8k: Disable LTSSM on link down interrupts bpeled
2021-04-12 15:30   ` bpeled
2021-04-12 15:30 ` [”PATCH” 2/5] PCI: armada8k: Add link-down handle bpeled
2021-04-12 15:30   ` bpeled
2021-04-14 12:42   ` Jonathan Cameron
2021-04-14 12:42     ` Jonathan Cameron
2021-04-27  7:07     ` [EXT] " Ben Peled
2021-04-27  7:07       ` Ben Peled
2021-04-12 15:30 ` [”PATCH” 3/5] dt-bindings: pci: add system controller and MAC reset bit to Armada 7K/8K controller bindings bpeled
2021-04-12 15:30   ` bpeled
2021-04-13 15:10   ` Rob Herring
2021-04-13 15:10     ` Rob Herring
2021-04-26 15:58     ` Ben Peled [this message]
2021-04-26 15:58       ` [EXT] " Ben Peled
2021-04-12 15:30 ` [”PATCH” 4/5] arm64: dts: marvell: add pcie mac reset to pcie bpeled
2021-04-12 15:30   ` bpeled
2021-04-12 15:30 ` [”PATCH” 5/5] PCI: armada8k: add device reset to link-down handle bpeled
2021-04-12 15:30   ` bpeled
2021-04-13 10:14 ` [”PATCH” 0/5] Asynchronous linkdown recovery Ben Peled
2021-04-13 10:14   ` Ben Peled

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW2PR18MB2217D165D4E0435888525310C2429@MW2PR18MB2217.namprd18.prod.outlook.com \
    --to=bpeled@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=jaz@semihalf.com \
    --cc=kostap@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=oferh@marvell.com \
    --cc=robh@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=stefanc@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.