* [PATCH v5 0/2] Add octal DTR support for Macronix flash @ 2021-05-17 6:14 ` Zhengxun Li 0 siblings, 0 replies; 22+ messages in thread From: Zhengxun Li @ 2021-05-17 6:14 UTC (permalink / raw) To: linux-mtd, linux-spi Cc: tudor.ambarus, p.yadav, miquel.raynal, broonie, jaimeliao, Zhengxun Li This series adds support for Octal DTR for Macronix flashes. The first set of patches is add Macronix octal dtr mode support and Macronix octaflash series support. The second add the Octal DTR mode support for host driver. Changes in v5: - Based on Pratyush patch[0], modify the length of the value written to the Octal DTR register (1 is changed to 2) and add check ID in SPI mode. [0]https://patchwork.ozlabs.org/project/linux-mtd/patch/20210506191829.8271-3-p.yadav@ti.com/ Changes in v4: - merge patch 2(support octaflash Id) to patch 1(support octal dtr) - add switching back to default mode(1-1-1) support if octal dtr is disabled - delete the duplicate code settings initialized by the Profile 1.0 table. (such as cmd_ext_type, rdsr_dummy, rdsr_addr_nbytes, etc.) - add a description about stacked die Changes in v3: - Add support for Macronix octaflash series. Changes in v2: - Define with a generic name to describe the maximum dummy cycles. - Compare the ID directly in the loop, no longer copy and execute memcmp(). - Add spi_mem_dtr_supports_op() to support dtr operation. Zhengxun Li (2): mtd: spi-nor: macronix: add support for Macronix octaflash spi: mxic: patch for octal DTR mode support Zhengxun Li (2): mtd: spi-nor: macronix: add support for Macronix octaflash spi: mxic: patch for octal DTR mode support drivers/mtd/spi-nor/macronix.c | 185 +++++++++++++++++++++++++++++++++++++++++ drivers/spi/spi-mxic.c | 41 ++++++--- 2 files changed, 215 insertions(+), 11 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5 0/2] Add octal DTR support for Macronix flash @ 2021-05-17 6:14 ` Zhengxun Li 0 siblings, 0 replies; 22+ messages in thread From: Zhengxun Li @ 2021-05-17 6:14 UTC (permalink / raw) To: linux-mtd, linux-spi Cc: tudor.ambarus, p.yadav, miquel.raynal, broonie, jaimeliao, Zhengxun Li This series adds support for Octal DTR for Macronix flashes. The first set of patches is add Macronix octal dtr mode support and Macronix octaflash series support. The second add the Octal DTR mode support for host driver. Changes in v5: - Based on Pratyush patch[0], modify the length of the value written to the Octal DTR register (1 is changed to 2) and add check ID in SPI mode. [0]https://patchwork.ozlabs.org/project/linux-mtd/patch/20210506191829.8271-3-p.yadav@ti.com/ Changes in v4: - merge patch 2(support octaflash Id) to patch 1(support octal dtr) - add switching back to default mode(1-1-1) support if octal dtr is disabled - delete the duplicate code settings initialized by the Profile 1.0 table. (such as cmd_ext_type, rdsr_dummy, rdsr_addr_nbytes, etc.) - add a description about stacked die Changes in v3: - Add support for Macronix octaflash series. Changes in v2: - Define with a generic name to describe the maximum dummy cycles. - Compare the ID directly in the loop, no longer copy and execute memcmp(). - Add spi_mem_dtr_supports_op() to support dtr operation. Zhengxun Li (2): mtd: spi-nor: macronix: add support for Macronix octaflash spi: mxic: patch for octal DTR mode support Zhengxun Li (2): mtd: spi-nor: macronix: add support for Macronix octaflash spi: mxic: patch for octal DTR mode support drivers/mtd/spi-nor/macronix.c | 185 +++++++++++++++++++++++++++++++++++++++++ drivers/spi/spi-mxic.c | 41 ++++++--- 2 files changed, 215 insertions(+), 11 deletions(-) -- 1.9.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash 2021-05-17 6:14 ` Zhengxun Li @ 2021-05-17 6:14 ` Zhengxun Li -1 siblings, 0 replies; 22+ messages in thread From: Zhengxun Li @ 2021-05-17 6:14 UTC (permalink / raw) To: linux-mtd, linux-spi Cc: tudor.ambarus, p.yadav, miquel.raynal, broonie, jaimeliao, Zhengxun Li The octaflash is an xSPI compliant octal DTR flash. Add support for using it in octal DTR mode. Try to verify the flash ID to check whether the flash memory in octal DTR mode and SPI mode are correct. When reading ID in OCTAL DTR mode, ID will appear in a repeated manner. ex: ID[0] = 0xc2, ID[1] = 0xc2, ID[2] = 0x94, ID[3] = 0x94... Rearrange the order so that the ID can pass. The octaflash series can be divided into the following types: MX25 series : Serial NOR Flash. MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. LW/UW series : Support simultaneous Read-while-Write operation in multiple bank architecture. Read-while-write feature which means read data one bank while another bank is programing or erasing. MX25LM : 3.0V Octal I/O -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf MX25UM : 1.8V Octal I/O -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdf MX66LM : 3.0V Octal I/O with stacked die -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/MX66LM1G45G,%203V,%201Gb,%20v1.1.pdf MX66UM : 1.8V Octal I/O with stacked die -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdf MX25LW : 3.0V Octal I/O with Read-while-Write MX25UW : 1.8V Octal I/O with Read-while-Write MX66LW : 3.0V Octal I/O with Read-while-Write and stack die MX66UW : 1.8V Octal I/O with Read-while-Write and stack die About LW/UW series, please contact us freely if you have any questions. For adding Octal NOR Flash IDs, we have validated each Flash on plateform zynq-picozed. Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> --- drivers/mtd/spi-nor/macronix.c | 185 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 185 insertions(+) diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c index 42c2cf3..f4b33c0 100644 --- a/drivers/mtd/spi-nor/macronix.c +++ b/drivers/mtd/spi-nor/macronix.c @@ -8,6 +8,12 @@ #include "core.h" +#define SPINOR_OP_RD_CR2 0x71 /* Read configuration register 2 */ +#define SPINOR_OP_WR_CR2 0x72 /* Write configuration register 2 */ +#define SPINOR_REG_MXIC_CR2_MODE 0x00000000 /* For setting octal DTR mode */ +#define SPINOR_REG_MXIC_OPI_DTR_EN 0x2 /* Enable Octal DTR */ +#define SPINOR_REG_MXIC_SPI_EN 0x0 /* Enable SPI */ + static int mx25l25635_post_bfpt_fixups(struct spi_nor *nor, const struct sfdp_parameter_header *bfpt_header, @@ -32,6 +38,85 @@ .post_bfpt = mx25l25635_post_bfpt_fixups, }; +/** + * spi_nor_macronix_octal_dtr_enable() - Enable octal DTR on Macronix flashes. + * @nor: pointer to a 'struct spi_nor' + * @enable: whether to enable Octal DTR or switch back to SPI + * + * Return: 0 on success, -errno otherwise. + */ +static int spi_nor_macronix_octal_dtr_enable(struct spi_nor *nor, bool enable) +{ + struct spi_mem_op op; + u8 *buf = nor->bouncebuf, i; + int ret; + + /* Set/unset the octal and DTR enable bits. */ + ret = spi_nor_write_enable(nor); + if (ret) + return ret; + + if (enable) { + buf[0] = SPINOR_REG_MXIC_OPI_DTR_EN; + } else { + /* + * The register is 1-byte wide, but 1-byte transactions are not + * allowed in 8D-8D-8D mode. Since there is no register at the + * next location, just initialize the value to 0 and let the + * transaction go on. + */ + buf[0] = SPINOR_REG_MXIC_SPI_EN; + buf[1] = 0x0; + } + + op = (struct spi_mem_op) + SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_WR_CR2, 1), + SPI_MEM_OP_ADDR(4, SPINOR_REG_MXIC_CR2_MODE, 1), + SPI_MEM_OP_NO_DUMMY, + SPI_MEM_OP_DATA_OUT(enable ? 1 : 2, buf, 1)); + + if (!enable) + spi_nor_spimem_setup_op(nor, &op, SNOR_PROTO_8_8_8_DTR); + + ret = spi_mem_exec_op(nor->spimem, &op); + if (ret) + return ret; + + /* Read flash ID to make sure the switch was successful. */ + op = (struct spi_mem_op) + SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_RDID, 1), + SPI_MEM_OP_ADDR(enable ? 4 : 0, 0, 1), + SPI_MEM_OP_DUMMY(enable ? 4 : 0, 1), + SPI_MEM_OP_DATA_IN(SPI_NOR_MAX_ID_LEN, buf, 1)); + + if (enable) + spi_nor_spimem_setup_op(nor, &op, SNOR_PROTO_8_8_8_DTR); + + ret = spi_mem_exec_op(nor->spimem, &op); + if (ret) + return ret; + + if (enable) { + for (i = 0; i < nor->info->id_len; i++) + if (buf[i * 2] != nor->info->id[i]) + return -EINVAL; + } else { + if (memcmp(buf, nor->info->id, nor->info->id_len)) + return -EINVAL; + } + + return 0; +} + +static void octaflash_default_init(struct spi_nor *nor) +{ + nor->params->octal_dtr_enable = spi_nor_macronix_octal_dtr_enable; +} + +static struct spi_nor_fixups octaflash_fixups = { + .default_init = octaflash_default_init, +}; + static const struct flash_info macronix_parts[] = { /* Macronix */ { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) }, @@ -86,6 +171,106 @@ { "mx66u2g45g", INFO(0xc2253c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { "mx66lm2g45g", INFO(0xc2853c, 0, 64 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66lm1g45g", INFO(0xc2853b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66lw1g45g", INFO(0xc2863b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25lm51245g", INFO(0xc2853a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25lw51245g", INFO(0xc2863a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25lm25645g", INFO(0xc28539, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25lw25645g", INFO(0xc28639, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66um2g45g", INFO(0xc2803c, 0, 64 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66uw2g345g", INFO(0xc2843c, 0, 64 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66uw2g345gx0", INFO(0xc2943c, 0, 64 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66um1g45g", INFO(0xc2803b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66um1g45g40", INFO(0xc2808b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66uw1g45g", INFO(0xc2813b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25um51245g", INFO(0xc2803a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw51245g", INFO(0xc2813a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw51345g", INFO(0xc2843a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25um25645g", INFO(0xc28039, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw25645g", INFO(0xc28139, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25um25345g", INFO(0xc28339, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw25345g", INFO(0xc28439, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw12845g", INFO(0xc28138, 0, 4 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw12a45g", INFO(0xc28938, 0, 4 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw12345g", INFO(0xc28438, 0, 4 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw6445g", INFO(0xc28137, 0, 2 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw6345g", INFO(0xc28437, 0, 2 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, }; static void macronix_default_init(struct spi_nor *nor) -- 1.9.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash @ 2021-05-17 6:14 ` Zhengxun Li 0 siblings, 0 replies; 22+ messages in thread From: Zhengxun Li @ 2021-05-17 6:14 UTC (permalink / raw) To: linux-mtd, linux-spi Cc: tudor.ambarus, p.yadav, miquel.raynal, broonie, jaimeliao, Zhengxun Li The octaflash is an xSPI compliant octal DTR flash. Add support for using it in octal DTR mode. Try to verify the flash ID to check whether the flash memory in octal DTR mode and SPI mode are correct. When reading ID in OCTAL DTR mode, ID will appear in a repeated manner. ex: ID[0] = 0xc2, ID[1] = 0xc2, ID[2] = 0x94, ID[3] = 0x94... Rearrange the order so that the ID can pass. The octaflash series can be divided into the following types: MX25 series : Serial NOR Flash. MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. LW/UW series : Support simultaneous Read-while-Write operation in multiple bank architecture. Read-while-write feature which means read data one bank while another bank is programing or erasing. MX25LM : 3.0V Octal I/O -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf MX25UM : 1.8V Octal I/O -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdf MX66LM : 3.0V Octal I/O with stacked die -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/MX66LM1G45G,%203V,%201Gb,%20v1.1.pdf MX66UM : 1.8V Octal I/O with stacked die -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdf MX25LW : 3.0V Octal I/O with Read-while-Write MX25UW : 1.8V Octal I/O with Read-while-Write MX66LW : 3.0V Octal I/O with Read-while-Write and stack die MX66UW : 1.8V Octal I/O with Read-while-Write and stack die About LW/UW series, please contact us freely if you have any questions. For adding Octal NOR Flash IDs, we have validated each Flash on plateform zynq-picozed. Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> --- drivers/mtd/spi-nor/macronix.c | 185 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 185 insertions(+) diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c index 42c2cf3..f4b33c0 100644 --- a/drivers/mtd/spi-nor/macronix.c +++ b/drivers/mtd/spi-nor/macronix.c @@ -8,6 +8,12 @@ #include "core.h" +#define SPINOR_OP_RD_CR2 0x71 /* Read configuration register 2 */ +#define SPINOR_OP_WR_CR2 0x72 /* Write configuration register 2 */ +#define SPINOR_REG_MXIC_CR2_MODE 0x00000000 /* For setting octal DTR mode */ +#define SPINOR_REG_MXIC_OPI_DTR_EN 0x2 /* Enable Octal DTR */ +#define SPINOR_REG_MXIC_SPI_EN 0x0 /* Enable SPI */ + static int mx25l25635_post_bfpt_fixups(struct spi_nor *nor, const struct sfdp_parameter_header *bfpt_header, @@ -32,6 +38,85 @@ .post_bfpt = mx25l25635_post_bfpt_fixups, }; +/** + * spi_nor_macronix_octal_dtr_enable() - Enable octal DTR on Macronix flashes. + * @nor: pointer to a 'struct spi_nor' + * @enable: whether to enable Octal DTR or switch back to SPI + * + * Return: 0 on success, -errno otherwise. + */ +static int spi_nor_macronix_octal_dtr_enable(struct spi_nor *nor, bool enable) +{ + struct spi_mem_op op; + u8 *buf = nor->bouncebuf, i; + int ret; + + /* Set/unset the octal and DTR enable bits. */ + ret = spi_nor_write_enable(nor); + if (ret) + return ret; + + if (enable) { + buf[0] = SPINOR_REG_MXIC_OPI_DTR_EN; + } else { + /* + * The register is 1-byte wide, but 1-byte transactions are not + * allowed in 8D-8D-8D mode. Since there is no register at the + * next location, just initialize the value to 0 and let the + * transaction go on. + */ + buf[0] = SPINOR_REG_MXIC_SPI_EN; + buf[1] = 0x0; + } + + op = (struct spi_mem_op) + SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_WR_CR2, 1), + SPI_MEM_OP_ADDR(4, SPINOR_REG_MXIC_CR2_MODE, 1), + SPI_MEM_OP_NO_DUMMY, + SPI_MEM_OP_DATA_OUT(enable ? 1 : 2, buf, 1)); + + if (!enable) + spi_nor_spimem_setup_op(nor, &op, SNOR_PROTO_8_8_8_DTR); + + ret = spi_mem_exec_op(nor->spimem, &op); + if (ret) + return ret; + + /* Read flash ID to make sure the switch was successful. */ + op = (struct spi_mem_op) + SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_RDID, 1), + SPI_MEM_OP_ADDR(enable ? 4 : 0, 0, 1), + SPI_MEM_OP_DUMMY(enable ? 4 : 0, 1), + SPI_MEM_OP_DATA_IN(SPI_NOR_MAX_ID_LEN, buf, 1)); + + if (enable) + spi_nor_spimem_setup_op(nor, &op, SNOR_PROTO_8_8_8_DTR); + + ret = spi_mem_exec_op(nor->spimem, &op); + if (ret) + return ret; + + if (enable) { + for (i = 0; i < nor->info->id_len; i++) + if (buf[i * 2] != nor->info->id[i]) + return -EINVAL; + } else { + if (memcmp(buf, nor->info->id, nor->info->id_len)) + return -EINVAL; + } + + return 0; +} + +static void octaflash_default_init(struct spi_nor *nor) +{ + nor->params->octal_dtr_enable = spi_nor_macronix_octal_dtr_enable; +} + +static struct spi_nor_fixups octaflash_fixups = { + .default_init = octaflash_default_init, +}; + static const struct flash_info macronix_parts[] = { /* Macronix */ { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) }, @@ -86,6 +171,106 @@ { "mx66u2g45g", INFO(0xc2253c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { "mx66lm2g45g", INFO(0xc2853c, 0, 64 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66lm1g45g", INFO(0xc2853b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66lw1g45g", INFO(0xc2863b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25lm51245g", INFO(0xc2853a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25lw51245g", INFO(0xc2863a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25lm25645g", INFO(0xc28539, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25lw25645g", INFO(0xc28639, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66um2g45g", INFO(0xc2803c, 0, 64 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66uw2g345g", INFO(0xc2843c, 0, 64 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66uw2g345gx0", INFO(0xc2943c, 0, 64 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66um1g45g", INFO(0xc2803b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66um1g45g40", INFO(0xc2808b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx66uw1g45g", INFO(0xc2813b, 0, 32 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25um51245g", INFO(0xc2803a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw51245g", INFO(0xc2813a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw51345g", INFO(0xc2843a, 0, 16 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25um25645g", INFO(0xc28039, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw25645g", INFO(0xc28139, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25um25345g", INFO(0xc28339, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw25345g", INFO(0xc28439, 0, 8 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw12845g", INFO(0xc28138, 0, 4 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw12a45g", INFO(0xc28938, 0, 4 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw12345g", INFO(0xc28438, 0, 4 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw6445g", INFO(0xc28137, 0, 2 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, + { "mx25uw6345g", INFO(0xc28437, 0, 2 * 1024, 4096, + SECT_4K | SPI_NOR_OCTAL_DTR_READ | + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) + .fixups = &octaflash_fixups }, }; static void macronix_default_init(struct spi_nor *nor) -- 1.9.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash 2021-05-17 6:14 ` Zhengxun Li @ 2021-05-17 7:33 ` Pratyush Yadav -1 siblings, 0 replies; 22+ messages in thread From: Pratyush Yadav @ 2021-05-17 7:33 UTC (permalink / raw) To: Zhengxun Li Cc: linux-mtd, linux-spi, tudor.ambarus, miquel.raynal, broonie, jaimeliao On 17/05/21 02:14PM, Zhengxun Li wrote: > The octaflash is an xSPI compliant octal DTR flash. Add support > for using it in octal DTR mode. > > Try to verify the flash ID to check whether the flash memory in octal > DTR mode and SPI mode are correct. When reading ID in OCTAL DTR mode, > ID will appear in a repeated manner. ex: ID[0] = 0xc2, ID[1] = 0xc2, > ID[2] = 0x94, ID[3] = 0x94... Rearrange the order so that the ID can pass. > > The octaflash series can be divided into the following types: > > MX25 series : Serial NOR Flash. > MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) > LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. > LW/UW series : Support simultaneous Read-while-Write operation in multiple > bank architecture. Read-while-write feature which means read > data one bank while another bank is programing or erasing. > > MX25LM : 3.0V Octal I/O > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf > > MX25UM : 1.8V Octal I/O > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdf > > MX66LM : 3.0V Octal I/O with stacked die > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/MX66LM1G45G,%203V,%201Gb,%20v1.1.pdf > > MX66UM : 1.8V Octal I/O with stacked die > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdf > > MX25LW : 3.0V Octal I/O with Read-while-Write > MX25UW : 1.8V Octal I/O with Read-while-Write > MX66LW : 3.0V Octal I/O with Read-while-Write and stack die > MX66UW : 1.8V Octal I/O with Read-while-Write and stack die > > About LW/UW series, please contact us freely if you have any > questions. For adding Octal NOR Flash IDs, we have validated > each Flash on plateform zynq-picozed. > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> Reviewed-by: Pratyush Yadav <p.yadav@ti.com> -- Regards, Pratyush Yadav Texas Instruments Inc. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash @ 2021-05-17 7:33 ` Pratyush Yadav 0 siblings, 0 replies; 22+ messages in thread From: Pratyush Yadav @ 2021-05-17 7:33 UTC (permalink / raw) To: Zhengxun Li Cc: linux-mtd, linux-spi, tudor.ambarus, miquel.raynal, broonie, jaimeliao On 17/05/21 02:14PM, Zhengxun Li wrote: > The octaflash is an xSPI compliant octal DTR flash. Add support > for using it in octal DTR mode. > > Try to verify the flash ID to check whether the flash memory in octal > DTR mode and SPI mode are correct. When reading ID in OCTAL DTR mode, > ID will appear in a repeated manner. ex: ID[0] = 0xc2, ID[1] = 0xc2, > ID[2] = 0x94, ID[3] = 0x94... Rearrange the order so that the ID can pass. > > The octaflash series can be divided into the following types: > > MX25 series : Serial NOR Flash. > MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) > LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. > LW/UW series : Support simultaneous Read-while-Write operation in multiple > bank architecture. Read-while-write feature which means read > data one bank while another bank is programing or erasing. > > MX25LM : 3.0V Octal I/O > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf > > MX25UM : 1.8V Octal I/O > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdf > > MX66LM : 3.0V Octal I/O with stacked die > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/MX66LM1G45G,%203V,%201Gb,%20v1.1.pdf > > MX66UM : 1.8V Octal I/O with stacked die > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdf > > MX25LW : 3.0V Octal I/O with Read-while-Write > MX25UW : 1.8V Octal I/O with Read-while-Write > MX66LW : 3.0V Octal I/O with Read-while-Write and stack die > MX66UW : 1.8V Octal I/O with Read-while-Write and stack die > > About LW/UW series, please contact us freely if you have any > questions. For adding Octal NOR Flash IDs, we have validated > each Flash on plateform zynq-picozed. > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> Reviewed-by: Pratyush Yadav <p.yadav@ti.com> -- Regards, Pratyush Yadav Texas Instruments Inc. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash 2021-05-17 7:33 ` Pratyush Yadav @ 2021-06-29 2:06 ` zhengxunli -1 siblings, 0 replies; 22+ messages in thread From: zhengxunli @ 2021-06-29 2:06 UTC (permalink / raw) To: tudor.ambarus, vigneshr; +Cc: broonie, linux-mtd, linux-spi, miquel.raynal Hi Tudor, Vigneshr, Hope you’re having a great day! Would you help to review this series? "Pratyush Yadav" <p.yadav@ti.com> wrote on 2021/05/17 下午 03:33:06: > "Pratyush Yadav" <p.yadav@ti.com> > 2021/05/17 下午 03:33 > > To > > "Zhengxun Li" <zhengxunli@mxic.com.tw>, > > cc > > <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>, > <tudor.ambarus@microchip.com>, <miquel.raynal@bootlin.com>, > <broonie@kernel.org>, <jaimeliao@mxic.com.tw> > > Subject > > Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash > > On 17/05/21 02:14PM, Zhengxun Li wrote: > > The octaflash is an xSPI compliant octal DTR flash. Add support > > for using it in octal DTR mode. > > > > Try to verify the flash ID to check whether the flash memory in octal > > DTR mode and SPI mode are correct. When reading ID in OCTAL DTR mode, > > ID will appear in a repeated manner. ex: ID[0] = 0xc2, ID[1] = 0xc2, > > ID[2] = 0x94, ID[3] = 0x94... Rearrange the order so that the ID can pass. > > > > The octaflash series can be divided into the following types: > > > > MX25 series : Serial NOR Flash. > > MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) > > LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. > > LW/UW series : Support simultaneous Read-while-Write operation in multiple > > bank architecture. Read-while-write feature which means read > > data one bank while another bank is programing or erasing. > > > > MX25LM : 3.0V Octal I/O > > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/ > MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf > > > > MX25UM : 1.8V Octal I/O > > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/ > MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdf > > > > MX66LM : 3.0V Octal I/O with stacked die > > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/ > MX66LM1G45G,%203V,%201Gb,%20v1.1.pdf > > > > MX66UM : 1.8V Octal I/O with stacked die > > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/ > MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdf > > > > MX25LW : 3.0V Octal I/O with Read-while-Write > > MX25UW : 1.8V Octal I/O with Read-while-Write > > MX66LW : 3.0V Octal I/O with Read-while-Write and stack die > > MX66UW : 1.8V Octal I/O with Read-while-Write and stack die > > > > About LW/UW series, please contact us freely if you have any > > questions. For adding Octal NOR Flash IDs, we have validated > > each Flash on plateform zynq-picozed. > > > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> > > Reviewed-by: Pratyush Yadav <p.yadav@ti.com> Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash @ 2021-06-29 2:06 ` zhengxunli 0 siblings, 0 replies; 22+ messages in thread From: zhengxunli @ 2021-06-29 2:06 UTC (permalink / raw) To: tudor.ambarus, vigneshr; +Cc: broonie, linux-mtd, linux-spi, miquel.raynal Hi Tudor, Vigneshr, Hope you’re having a great day! Would you help to review this series? "Pratyush Yadav" <p.yadav@ti.com> wrote on 2021/05/17 下午 03:33:06: > "Pratyush Yadav" <p.yadav@ti.com> > 2021/05/17 下午 03:33 > > To > > "Zhengxun Li" <zhengxunli@mxic.com.tw>, > > cc > > <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>, > <tudor.ambarus@microchip.com>, <miquel.raynal@bootlin.com>, > <broonie@kernel.org>, <jaimeliao@mxic.com.tw> > > Subject > > Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash > > On 17/05/21 02:14PM, Zhengxun Li wrote: > > The octaflash is an xSPI compliant octal DTR flash. Add support > > for using it in octal DTR mode. > > > > Try to verify the flash ID to check whether the flash memory in octal > > DTR mode and SPI mode are correct. When reading ID in OCTAL DTR mode, > > ID will appear in a repeated manner. ex: ID[0] = 0xc2, ID[1] = 0xc2, > > ID[2] = 0x94, ID[3] = 0x94... Rearrange the order so that the ID can pass. > > > > The octaflash series can be divided into the following types: > > > > MX25 series : Serial NOR Flash. > > MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) > > LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. > > LW/UW series : Support simultaneous Read-while-Write operation in multiple > > bank architecture. Read-while-write feature which means read > > data one bank while another bank is programing or erasing. > > > > MX25LM : 3.0V Octal I/O > > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/ > MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf > > > > MX25UM : 1.8V Octal I/O > > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/ > MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdf > > > > MX66LM : 3.0V Octal I/O with stacked die > > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/ > MX66LM1G45G,%203V,%201Gb,%20v1.1.pdf > > > > MX66UM : 1.8V Octal I/O with stacked die > > -https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/ > MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdf > > > > MX25LW : 3.0V Octal I/O with Read-while-Write > > MX25UW : 1.8V Octal I/O with Read-while-Write > > MX66LW : 3.0V Octal I/O with Read-while-Write and stack die > > MX66UW : 1.8V Octal I/O with Read-while-Write and stack die > > > > About LW/UW series, please contact us freely if you have any > > questions. For adding Octal NOR Flash IDs, we have validated > > each Flash on plateform zynq-picozed. > > > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> > > Reviewed-by: Pratyush Yadav <p.yadav@ti.com> Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash 2021-05-17 6:14 ` Zhengxun Li @ 2021-06-29 6:37 ` Tudor.Ambarus -1 siblings, 0 replies; 22+ messages in thread From: Tudor.Ambarus @ 2021-06-29 6:37 UTC (permalink / raw) To: zhengxunli, linux-mtd, linux-spi Cc: p.yadav, miquel.raynal, broonie, jaimeliao On 5/17/21 9:14 AM, Zhengxun Li wrote: > + { "mx66lm1g45g", INFO(0xc2853b, 0, 32 * 1024, 4096, > + SECT_4K | SPI_NOR_OCTAL_DTR_READ | > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) > + .fixups = &octaflash_fixups }, I have a mx66lm1g45g which does not define SFDP tables, how you'll differentiate between the two? Mine will fail after reset. I'm working to address the flash ID collisions, will send patches soon. I won't queue any new flash additions until we'll solve the ID collisions problem. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash @ 2021-06-29 6:37 ` Tudor.Ambarus 0 siblings, 0 replies; 22+ messages in thread From: Tudor.Ambarus @ 2021-06-29 6:37 UTC (permalink / raw) To: zhengxunli, linux-mtd, linux-spi Cc: p.yadav, miquel.raynal, broonie, jaimeliao On 5/17/21 9:14 AM, Zhengxun Li wrote: > + { "mx66lm1g45g", INFO(0xc2853b, 0, 32 * 1024, 4096, > + SECT_4K | SPI_NOR_OCTAL_DTR_READ | > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) > + .fixups = &octaflash_fixups }, I have a mx66lm1g45g which does not define SFDP tables, how you'll differentiate between the two? Mine will fail after reset. I'm working to address the flash ID collisions, will send patches soon. I won't queue any new flash additions until we'll solve the ID collisions problem. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash 2021-06-29 6:37 ` Tudor.Ambarus @ 2021-06-29 9:33 ` zhengxunli -1 siblings, 0 replies; 22+ messages in thread From: zhengxunli @ 2021-06-29 9:33 UTC (permalink / raw) To: Tudor.Ambarus Cc: broonie, jaimeliao, linux-mtd, linux-spi, miquel.raynal, p.yadav Hi Tudor, <Tudor.Ambarus@microchip.com> wrote on 2021/06/29 下午 02:37:01: > <Tudor.Ambarus@microchip.com> > 2021/06/29 下午 02:37 > > To > > <zhengxunli@mxic.com.tw>, <linux-mtd@lists.infradead.org>, <linux- > spi@vger.kernel.org>, > > cc > > <p.yadav@ti.com>, <miquel.raynal@bootlin.com>, <broonie@kernel.org>, > <jaimeliao@mxic.com.tw> > > Subject > > Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash > > On 5/17/21 9:14 AM, Zhengxun Li wrote: > > + { "mx66lm1g45g", INFO(0xc2853b, 0, 32 * 1024, 4096, > > + SECT_4K | SPI_NOR_OCTAL_DTR_READ | > > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) > > + .fixups = &octaflash_fixups }, > > I have a mx66lm1g45g which does not define SFDP tables, how you'll > differentiate > between the two? > Mine will fail after reset. I'm working to address > the flash ID > collisions, will send patches soon. I won't queue any new flash > additions until > we'll solve the ID collisions problem. Sorry for the inconvenience. I will discuss with our flash team as soon as possible. Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash @ 2021-06-29 9:33 ` zhengxunli 0 siblings, 0 replies; 22+ messages in thread From: zhengxunli @ 2021-06-29 9:33 UTC (permalink / raw) To: Tudor.Ambarus Cc: broonie, jaimeliao, linux-mtd, linux-spi, miquel.raynal, p.yadav Hi Tudor, <Tudor.Ambarus@microchip.com> wrote on 2021/06/29 下午 02:37:01: > <Tudor.Ambarus@microchip.com> > 2021/06/29 下午 02:37 > > To > > <zhengxunli@mxic.com.tw>, <linux-mtd@lists.infradead.org>, <linux- > spi@vger.kernel.org>, > > cc > > <p.yadav@ti.com>, <miquel.raynal@bootlin.com>, <broonie@kernel.org>, > <jaimeliao@mxic.com.tw> > > Subject > > Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash > > On 5/17/21 9:14 AM, Zhengxun Li wrote: > > + { "mx66lm1g45g", INFO(0xc2853b, 0, 32 * 1024, 4096, > > + SECT_4K | SPI_NOR_OCTAL_DTR_READ | > > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) > > + .fixups = &octaflash_fixups }, > > I have a mx66lm1g45g which does not define SFDP tables, how you'll > differentiate > between the two? > Mine will fail after reset. I'm working to address > the flash ID > collisions, will send patches soon. I won't queue any new flash > additions until > we'll solve the ID collisions problem. Sorry for the inconvenience. I will discuss with our flash team as soon as possible. Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash 2021-06-29 6:37 ` Tudor.Ambarus @ 2021-06-30 9:03 ` zhengxunli -1 siblings, 0 replies; 22+ messages in thread From: zhengxunli @ 2021-06-30 9:03 UTC (permalink / raw) To: Tudor.Ambarus Cc: broonie, jaimeliao, linux-mtd, linux-spi, miquel.raynal, p.yadav Hi Tudor, > Subject > > Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash > > On 5/17/21 9:14 AM, Zhengxun Li wrote: > > + { "mx66lm1g45g", INFO(0xc2853b, 0, 32 * 1024, 4096, > > + SECT_4K | SPI_NOR_OCTAL_DTR_READ | > > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) > > + .fixups = &octaflash_fixups }, > > I have a mx66lm1g45g which does not define SFDP tables, how you'll > differentiate > between the two? Mine will fail after reset. I'm working to address > the flash ID > collisions, will send patches soon. I won't queue any new flash > additions until > we'll solve the ID collisions problem. I asked our flash team, unfortunately, they said that due to SFDP on octaflash not existing from beginning, therefore, some old parts may not support the SFDP parameter inside the Flash. For MX66LM1G45G, we have SFDP available from 2020/03. However, other flash maybe meet the same problem, I will update them later. As for ID conflicts, I will discuss with them which series of flash has encountered this problem, and I will update it later. Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash @ 2021-06-30 9:03 ` zhengxunli 0 siblings, 0 replies; 22+ messages in thread From: zhengxunli @ 2021-06-30 9:03 UTC (permalink / raw) To: Tudor.Ambarus Cc: broonie, jaimeliao, linux-mtd, linux-spi, miquel.raynal, p.yadav Hi Tudor, > Subject > > Re: [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash > > On 5/17/21 9:14 AM, Zhengxun Li wrote: > > + { "mx66lm1g45g", INFO(0xc2853b, 0, 32 * 1024, 4096, > > + SECT_4K | SPI_NOR_OCTAL_DTR_READ | > > + SPI_NOR_OCTAL_DTR_PP | SPI_NOR_4B_OPCODES) > > + .fixups = &octaflash_fixups }, > > I have a mx66lm1g45g which does not define SFDP tables, how you'll > differentiate > between the two? Mine will fail after reset. I'm working to address > the flash ID > collisions, will send patches soon. I won't queue any new flash > additions until > we'll solve the ID collisions problem. I asked our flash team, unfortunately, they said that due to SFDP on octaflash not existing from beginning, therefore, some old parts may not support the SFDP parameter inside the Flash. For MX66LM1G45G, we have SFDP available from 2020/03. However, other flash maybe meet the same problem, I will update them later. As for ID conflicts, I will discuss with them which series of flash has encountered this problem, and I will update it later. Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support 2021-05-17 6:14 ` Zhengxun Li @ 2021-05-17 6:14 ` Zhengxun Li -1 siblings, 0 replies; 22+ messages in thread From: Zhengxun Li @ 2021-05-17 6:14 UTC (permalink / raw) To: linux-mtd, linux-spi Cc: tudor.ambarus, p.yadav, miquel.raynal, broonie, jaimeliao, Zhengxun Li Driver patch for octal DTR mode support. Owing to the spi_mem_default_supports_op() is not support dtr operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr _supports_op()" add spi_mem_dtr_supports_op() to support dtr and keep checking the buswidth and command bytes. Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> --- drivers/spi/spi-mxic.c | 41 ++++++++++++++++++++++++++++++----------- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-mxic.c b/drivers/spi/spi-mxic.c index 96b4182..32e757a 100644 --- a/drivers/spi/spi-mxic.c +++ b/drivers/spi/spi-mxic.c @@ -335,8 +335,10 @@ static int mxic_spi_data_xfer(struct mxic_spi *mxic, const void *txbuf, static bool mxic_spi_mem_supports_op(struct spi_mem *mem, const struct spi_mem_op *op) { - if (op->data.buswidth > 4 || op->addr.buswidth > 4 || - op->dummy.buswidth > 4 || op->cmd.buswidth > 4) + bool all_false; + + if (op->data.buswidth > 8 || op->addr.buswidth > 8 || + op->dummy.buswidth > 8 || op->cmd.buswidth > 8) return false; if (op->data.nbytes && op->dummy.nbytes && @@ -346,7 +348,13 @@ static bool mxic_spi_mem_supports_op(struct spi_mem *mem, if (op->addr.nbytes > 7) return false; - return spi_mem_default_supports_op(mem, op); + all_false = !op->cmd.dtr && !op->addr.dtr && !op->dummy.dtr && + !op->data.dtr; + + if (all_false) + return spi_mem_default_supports_op(mem, op); + else + return spi_mem_dtr_supports_op(mem, op); } static int mxic_spi_mem_exec_op(struct spi_mem *mem, @@ -355,14 +363,15 @@ static int mxic_spi_mem_exec_op(struct spi_mem *mem, struct mxic_spi *mxic = spi_master_get_devdata(mem->spi->master); int nio = 1, i, ret; u32 ss_ctrl; - u8 addr[8]; - u8 opcode = op->cmd.opcode; + u8 addr[8], cmd[2]; ret = mxic_spi_set_freq(mxic, mem->spi->max_speed_hz); if (ret) return ret; - if (mem->spi->mode & (SPI_TX_QUAD | SPI_RX_QUAD)) + if (mem->spi->mode & (SPI_TX_OCTAL | SPI_RX_OCTAL)) + nio = 8; + else if (mem->spi->mode & (SPI_TX_QUAD | SPI_RX_QUAD)) nio = 4; else if (mem->spi->mode & (SPI_TX_DUAL | SPI_RX_DUAL)) nio = 2; @@ -374,19 +383,25 @@ static int mxic_spi_mem_exec_op(struct spi_mem *mem, mxic->regs + HC_CFG); writel(HC_EN_BIT, mxic->regs + HC_EN); - ss_ctrl = OP_CMD_BYTES(1) | OP_CMD_BUSW(fls(op->cmd.buswidth) - 1); + ss_ctrl = OP_CMD_BYTES(op->cmd.nbytes) | + OP_CMD_BUSW(fls(op->cmd.buswidth) - 1) | + (op->cmd.dtr ? OP_CMD_DDR : 0); if (op->addr.nbytes) ss_ctrl |= OP_ADDR_BYTES(op->addr.nbytes) | - OP_ADDR_BUSW(fls(op->addr.buswidth) - 1); + OP_ADDR_BUSW(fls(op->addr.buswidth) - 1) | + (op->addr.dtr ? OP_ADDR_DDR : 0); if (op->dummy.nbytes) ss_ctrl |= OP_DUMMY_CYC(op->dummy.nbytes); if (op->data.nbytes) { - ss_ctrl |= OP_DATA_BUSW(fls(op->data.buswidth) - 1); + ss_ctrl |= OP_DATA_BUSW(fls(op->data.buswidth) - 1) | + (op->data.dtr ? OP_DATA_DDR : 0); if (op->data.dir == SPI_MEM_DATA_IN) ss_ctrl |= OP_READ; + if (op->data.dtr) + ss_ctrl |= OP_DQS_EN; } writel(ss_ctrl, mxic->regs + SS_CTRL(mem->spi->chip_select)); @@ -394,7 +409,10 @@ static int mxic_spi_mem_exec_op(struct spi_mem *mem, writel(readl(mxic->regs + HC_CFG) | HC_CFG_MAN_CS_ASSERT, mxic->regs + HC_CFG); - ret = mxic_spi_data_xfer(mxic, &opcode, NULL, 1); + for (i = 0; i < op->cmd.nbytes; i++) + cmd[i] = op->cmd.opcode >> (8 * (op->cmd.nbytes - i - 1)); + + ret = mxic_spi_data_xfer(mxic, cmd, NULL, op->cmd.nbytes); if (ret) goto out; @@ -567,7 +585,8 @@ static int mxic_spi_probe(struct platform_device *pdev) master->bits_per_word_mask = SPI_BPW_MASK(8); master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_RX_DUAL | SPI_TX_DUAL | - SPI_RX_QUAD | SPI_TX_QUAD; + SPI_RX_QUAD | SPI_TX_QUAD | + SPI_RX_OCTAL | SPI_TX_OCTAL; mxic_spi_hw_init(mxic); -- 1.9.1 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support @ 2021-05-17 6:14 ` Zhengxun Li 0 siblings, 0 replies; 22+ messages in thread From: Zhengxun Li @ 2021-05-17 6:14 UTC (permalink / raw) To: linux-mtd, linux-spi Cc: tudor.ambarus, p.yadav, miquel.raynal, broonie, jaimeliao, Zhengxun Li Driver patch for octal DTR mode support. Owing to the spi_mem_default_supports_op() is not support dtr operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr _supports_op()" add spi_mem_dtr_supports_op() to support dtr and keep checking the buswidth and command bytes. Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> --- drivers/spi/spi-mxic.c | 41 ++++++++++++++++++++++++++++++----------- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-mxic.c b/drivers/spi/spi-mxic.c index 96b4182..32e757a 100644 --- a/drivers/spi/spi-mxic.c +++ b/drivers/spi/spi-mxic.c @@ -335,8 +335,10 @@ static int mxic_spi_data_xfer(struct mxic_spi *mxic, const void *txbuf, static bool mxic_spi_mem_supports_op(struct spi_mem *mem, const struct spi_mem_op *op) { - if (op->data.buswidth > 4 || op->addr.buswidth > 4 || - op->dummy.buswidth > 4 || op->cmd.buswidth > 4) + bool all_false; + + if (op->data.buswidth > 8 || op->addr.buswidth > 8 || + op->dummy.buswidth > 8 || op->cmd.buswidth > 8) return false; if (op->data.nbytes && op->dummy.nbytes && @@ -346,7 +348,13 @@ static bool mxic_spi_mem_supports_op(struct spi_mem *mem, if (op->addr.nbytes > 7) return false; - return spi_mem_default_supports_op(mem, op); + all_false = !op->cmd.dtr && !op->addr.dtr && !op->dummy.dtr && + !op->data.dtr; + + if (all_false) + return spi_mem_default_supports_op(mem, op); + else + return spi_mem_dtr_supports_op(mem, op); } static int mxic_spi_mem_exec_op(struct spi_mem *mem, @@ -355,14 +363,15 @@ static int mxic_spi_mem_exec_op(struct spi_mem *mem, struct mxic_spi *mxic = spi_master_get_devdata(mem->spi->master); int nio = 1, i, ret; u32 ss_ctrl; - u8 addr[8]; - u8 opcode = op->cmd.opcode; + u8 addr[8], cmd[2]; ret = mxic_spi_set_freq(mxic, mem->spi->max_speed_hz); if (ret) return ret; - if (mem->spi->mode & (SPI_TX_QUAD | SPI_RX_QUAD)) + if (mem->spi->mode & (SPI_TX_OCTAL | SPI_RX_OCTAL)) + nio = 8; + else if (mem->spi->mode & (SPI_TX_QUAD | SPI_RX_QUAD)) nio = 4; else if (mem->spi->mode & (SPI_TX_DUAL | SPI_RX_DUAL)) nio = 2; @@ -374,19 +383,25 @@ static int mxic_spi_mem_exec_op(struct spi_mem *mem, mxic->regs + HC_CFG); writel(HC_EN_BIT, mxic->regs + HC_EN); - ss_ctrl = OP_CMD_BYTES(1) | OP_CMD_BUSW(fls(op->cmd.buswidth) - 1); + ss_ctrl = OP_CMD_BYTES(op->cmd.nbytes) | + OP_CMD_BUSW(fls(op->cmd.buswidth) - 1) | + (op->cmd.dtr ? OP_CMD_DDR : 0); if (op->addr.nbytes) ss_ctrl |= OP_ADDR_BYTES(op->addr.nbytes) | - OP_ADDR_BUSW(fls(op->addr.buswidth) - 1); + OP_ADDR_BUSW(fls(op->addr.buswidth) - 1) | + (op->addr.dtr ? OP_ADDR_DDR : 0); if (op->dummy.nbytes) ss_ctrl |= OP_DUMMY_CYC(op->dummy.nbytes); if (op->data.nbytes) { - ss_ctrl |= OP_DATA_BUSW(fls(op->data.buswidth) - 1); + ss_ctrl |= OP_DATA_BUSW(fls(op->data.buswidth) - 1) | + (op->data.dtr ? OP_DATA_DDR : 0); if (op->data.dir == SPI_MEM_DATA_IN) ss_ctrl |= OP_READ; + if (op->data.dtr) + ss_ctrl |= OP_DQS_EN; } writel(ss_ctrl, mxic->regs + SS_CTRL(mem->spi->chip_select)); @@ -394,7 +409,10 @@ static int mxic_spi_mem_exec_op(struct spi_mem *mem, writel(readl(mxic->regs + HC_CFG) | HC_CFG_MAN_CS_ASSERT, mxic->regs + HC_CFG); - ret = mxic_spi_data_xfer(mxic, &opcode, NULL, 1); + for (i = 0; i < op->cmd.nbytes; i++) + cmd[i] = op->cmd.opcode >> (8 * (op->cmd.nbytes - i - 1)); + + ret = mxic_spi_data_xfer(mxic, cmd, NULL, op->cmd.nbytes); if (ret) goto out; @@ -567,7 +585,8 @@ static int mxic_spi_probe(struct platform_device *pdev) master->bits_per_word_mask = SPI_BPW_MASK(8); master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_RX_DUAL | SPI_TX_DUAL | - SPI_RX_QUAD | SPI_TX_QUAD; + SPI_RX_QUAD | SPI_TX_QUAD | + SPI_RX_OCTAL | SPI_TX_OCTAL; mxic_spi_hw_init(mxic); -- 1.9.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support 2021-05-17 6:14 ` Zhengxun Li @ 2021-05-17 15:49 ` Mark Brown -1 siblings, 0 replies; 22+ messages in thread From: Mark Brown @ 2021-05-17 15:49 UTC (permalink / raw) To: Zhengxun Li Cc: linux-mtd, linux-spi, tudor.ambarus, p.yadav, miquel.raynal, jaimeliao [-- Attachment #1: Type: text/plain, Size: 406 bytes --] On Mon, May 17, 2021 at 02:14:48PM +0800, Zhengxun Li wrote: > Driver patch for octal DTR mode support. > > Owing to the spi_mem_default_supports_op() is not support dtr > operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr > _supports_op()" add spi_mem_dtr_supports_op() to support dtr and > keep checking the buswidth and command bytes. Acked-by: Mark Brown <broonie@kernel.org> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support @ 2021-05-17 15:49 ` Mark Brown 0 siblings, 0 replies; 22+ messages in thread From: Mark Brown @ 2021-05-17 15:49 UTC (permalink / raw) To: Zhengxun Li Cc: linux-mtd, linux-spi, tudor.ambarus, p.yadav, miquel.raynal, jaimeliao [-- Attachment #1.1: Type: text/plain, Size: 406 bytes --] On Mon, May 17, 2021 at 02:14:48PM +0800, Zhengxun Li wrote: > Driver patch for octal DTR mode support. > > Owing to the spi_mem_default_supports_op() is not support dtr > operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr > _supports_op()" add spi_mem_dtr_supports_op() to support dtr and > keep checking the buswidth and command bytes. Acked-by: Mark Brown <broonie@kernel.org> [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 144 bytes --] ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support 2021-05-17 6:14 ` Zhengxun Li @ 2021-05-17 16:06 ` Pratyush Yadav -1 siblings, 0 replies; 22+ messages in thread From: Pratyush Yadav @ 2021-05-17 16:06 UTC (permalink / raw) To: Zhengxun Li Cc: linux-mtd, linux-spi, tudor.ambarus, miquel.raynal, broonie, jaimeliao On 17/05/21 02:14PM, Zhengxun Li wrote: > Driver patch for octal DTR mode support. > > Owing to the spi_mem_default_supports_op() is not support dtr > operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr I don't like the "Based on Pratyush patch". Please mention the commit hash so it is much easier to find later. For example, saying based on commit 539cf68cd51b (spi: spi-mem: add spi_mem_dtr_supports_op(), 2021-02-04) is much better. But while we are on this topic, I don't think it is needed all that much. People use pre-existing APIs all the time. I don't see any need to specifically point it out. So I think saying "Call spi_mem_dtr_supports_op() to ..." is better. > _supports_op()" add spi_mem_dtr_supports_op() to support dtr and > keep checking the buswidth and command bytes. > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> > --- -- Regards, Pratyush Yadav Texas Instruments Inc. ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support @ 2021-05-17 16:06 ` Pratyush Yadav 0 siblings, 0 replies; 22+ messages in thread From: Pratyush Yadav @ 2021-05-17 16:06 UTC (permalink / raw) To: Zhengxun Li Cc: linux-mtd, linux-spi, tudor.ambarus, miquel.raynal, broonie, jaimeliao On 17/05/21 02:14PM, Zhengxun Li wrote: > Driver patch for octal DTR mode support. > > Owing to the spi_mem_default_supports_op() is not support dtr > operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr I don't like the "Based on Pratyush patch". Please mention the commit hash so it is much easier to find later. For example, saying based on commit 539cf68cd51b (spi: spi-mem: add spi_mem_dtr_supports_op(), 2021-02-04) is much better. But while we are on this topic, I don't think it is needed all that much. People use pre-existing APIs all the time. I don't see any need to specifically point it out. So I think saying "Call spi_mem_dtr_supports_op() to ..." is better. > _supports_op()" add spi_mem_dtr_supports_op() to support dtr and > keep checking the buswidth and command bytes. > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> > --- -- Regards, Pratyush Yadav Texas Instruments Inc. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support 2021-05-17 16:06 ` Pratyush Yadav @ 2021-05-18 2:47 ` zhengxunli -1 siblings, 0 replies; 22+ messages in thread From: zhengxunli @ 2021-05-18 2:47 UTC (permalink / raw) To: Pratyush Yadav Cc: broonie, jaimeliao, linux-mtd, linux-spi, miquel.raynal, tudor.ambarus Hi, "Pratyush Yadav" <p.yadav@ti.com> wrote on 2021/05/18 上午 12:06:30: > "Pratyush Yadav" <p.yadav@ti.com> > 2021/05/18 上午 12:06 > > To > > "Zhengxun Li" <zhengxunli@mxic.com.tw>, > > cc > > <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>, > <tudor.ambarus@microchip.com>, <miquel.raynal@bootlin.com>, > <broonie@kernel.org>, <jaimeliao@mxic.com.tw> > > Subject > > Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support > > On 17/05/21 02:14PM, Zhengxun Li wrote: > > Driver patch for octal DTR mode support. > > > > Owing to the spi_mem_default_supports_op() is not support dtr > > operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr > > I don't like the "Based on Pratyush patch". Please mention the commit > hash so it is much easier to find later. For example, saying based on > commit 539cf68cd51b (spi: spi-mem: add spi_mem_dtr_supports_op(), > 2021-02-04) is much better. > > But while we are on this topic, I don't think it is needed all that > much. People use pre-existing APIs all the time. I don't see any need to > specifically point it out. So I think saying "Call > spi_mem_dtr_supports_op() to ..." is better. Thanks for your suggestion. > > _supports_op()" add spi_mem_dtr_supports_op() to support dtr and > > keep checking the buswidth and command bytes. > > > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> > > --- Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support @ 2021-05-18 2:47 ` zhengxunli 0 siblings, 0 replies; 22+ messages in thread From: zhengxunli @ 2021-05-18 2:47 UTC (permalink / raw) To: Pratyush Yadav Cc: broonie, jaimeliao, linux-mtd, linux-spi, miquel.raynal, tudor.ambarus Hi, "Pratyush Yadav" <p.yadav@ti.com> wrote on 2021/05/18 上午 12:06:30: > "Pratyush Yadav" <p.yadav@ti.com> > 2021/05/18 上午 12:06 > > To > > "Zhengxun Li" <zhengxunli@mxic.com.tw>, > > cc > > <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>, > <tudor.ambarus@microchip.com>, <miquel.raynal@bootlin.com>, > <broonie@kernel.org>, <jaimeliao@mxic.com.tw> > > Subject > > Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support > > On 17/05/21 02:14PM, Zhengxun Li wrote: > > Driver patch for octal DTR mode support. > > > > Owing to the spi_mem_default_supports_op() is not support dtr > > operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr > > I don't like the "Based on Pratyush patch". Please mention the commit > hash so it is much easier to find later. For example, saying based on > commit 539cf68cd51b (spi: spi-mem: add spi_mem_dtr_supports_op(), > 2021-02-04) is much better. > > But while we are on this topic, I don't think it is needed all that > much. People use pre-existing APIs all the time. I don't see any need to > specifically point it out. So I think saying "Call > spi_mem_dtr_supports_op() to ..." is better. Thanks for your suggestion. > > _supports_op()" add spi_mem_dtr_supports_op() to support dtr and > > keep checking the buswidth and command bytes. > > > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> > > --- Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2021-06-30 9:04 UTC | newest] Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-17 6:14 [PATCH v5 0/2] Add octal DTR support for Macronix flash Zhengxun Li 2021-05-17 6:14 ` Zhengxun Li 2021-05-17 6:14 ` [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash Zhengxun Li 2021-05-17 6:14 ` Zhengxun Li 2021-05-17 7:33 ` Pratyush Yadav 2021-05-17 7:33 ` Pratyush Yadav 2021-06-29 2:06 ` zhengxunli 2021-06-29 2:06 ` zhengxunli 2021-06-29 6:37 ` Tudor.Ambarus 2021-06-29 6:37 ` Tudor.Ambarus 2021-06-29 9:33 ` zhengxunli 2021-06-29 9:33 ` zhengxunli 2021-06-30 9:03 ` zhengxunli 2021-06-30 9:03 ` zhengxunli 2021-05-17 6:14 ` [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support Zhengxun Li 2021-05-17 6:14 ` Zhengxun Li 2021-05-17 15:49 ` Mark Brown 2021-05-17 15:49 ` Mark Brown 2021-05-17 16:06 ` Pratyush Yadav 2021-05-17 16:06 ` Pratyush Yadav 2021-05-18 2:47 ` zhengxunli 2021-05-18 2:47 ` zhengxunli
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.