From: zhengxunli@mxic.com.tw To: "Mark Brown" <broonie@kernel.org> Cc: jaimeliao@mxic.com.tw, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, miquel.raynal@bootlin.com, tudor.ambarus@microchip.com Subject: Re: [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support Date: Tue, 27 Apr 2021 09:48:37 +0800 [thread overview] Message-ID: <OF9A94F8F9.DF8D5789-ON482586C4.0008EE9F-482586C4.0009F19F@mxic.com.tw> (raw) In-Reply-To: <20210426165358.GI4590@sirena.org.uk> Hi Mark, Thanks for your reply. "Mark Brown" <broonie@kernel.org> wrote on 2021/04/27 上午 12:53:58: > "Mark Brown" <broonie@kernel.org> > 2021/04/27 上午 12:54 > > To > > "Zhengxun Li" <zhengxunli@mxic.com.tw>, > > cc > > linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, > tudor.ambarus@microchip.com, miquel.raynal@bootlin.com, jaimeliao@mxic.com.tw > > Subject > > Re: [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support > > On Tue, Apr 20, 2021 at 02:29:39PM +0800, Zhengxun Li wrote: > > > - return spi_mem_default_supports_op(mem, op); > > + all_false = !op->cmd.dtr && !op->addr.dtr && !op->dummy.dtr && > > + !op->data.dtr; > > + > > + if (all_false) > > This feels like we might want a spi_mem_op_is_dtr() helper? I can see > other controllers wanting a similar check. Yes, since spi_mem_default_supports_op does not support any dtr operations, we need spi_mem_op_is dtr() to help us check dtr operations. Thanks, Zhengxun Li CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
WARNING: multiple messages have this Message-ID (diff)
From: zhengxunli@mxic.com.tw To: "Mark Brown" <broonie@kernel.org> Cc: jaimeliao@mxic.com.tw, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, miquel.raynal@bootlin.com, tudor.ambarus@microchip.com Subject: Re: [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support Date: Tue, 27 Apr 2021 09:48:37 +0800 [thread overview] Message-ID: <OF9A94F8F9.DF8D5789-ON482586C4.0008EE9F-482586C4.0009F19F@mxic.com.tw> (raw) In-Reply-To: <20210426165358.GI4590@sirena.org.uk> Hi Mark, Thanks for your reply. "Mark Brown" <broonie@kernel.org> wrote on 2021/04/27 上午 12:53:58: > "Mark Brown" <broonie@kernel.org> > 2021/04/27 上午 12:54 > > To > > "Zhengxun Li" <zhengxunli@mxic.com.tw>, > > cc > > linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, > tudor.ambarus@microchip.com, miquel.raynal@bootlin.com, jaimeliao@mxic.com.tw > > Subject > > Re: [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support > > On Tue, Apr 20, 2021 at 02:29:39PM +0800, Zhengxun Li wrote: > > > - return spi_mem_default_supports_op(mem, op); > > + all_false = !op->cmd.dtr && !op->addr.dtr && !op->dummy.dtr && > > + !op->data.dtr; > > + > > + if (all_false) > > This feels like we might want a spi_mem_op_is_dtr() helper? I can see > other controllers wanting a similar check. Yes, since spi_mem_default_supports_op does not support any dtr operations, we need spi_mem_op_is dtr() to help us check dtr operations. Thanks, Zhengxun Li CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-04-27 1:49 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-20 6:29 [PATCH v3 0/3] Add octal DTR support for Macronix flash Zhengxun Li 2021-04-20 6:29 ` Zhengxun Li 2021-04-20 6:29 ` [PATCH v3 1/3] mtd: spi-nor: macronix: add support for Macronix octal dtr operation Zhengxun Li 2021-04-20 6:29 ` Zhengxun Li 2021-04-27 2:36 ` Pratyush Yadav 2021-04-27 2:36 ` Pratyush Yadav 2021-05-04 5:31 ` zhengxunli 2021-05-04 5:31 ` zhengxunli 2021-05-04 7:42 ` Pratyush Yadav 2021-05-04 7:42 ` Pratyush Yadav 2021-05-05 8:29 ` zhengxunli 2021-05-05 8:29 ` zhengxunli 2021-04-20 6:29 ` [PATCH v3 2/3] mtd: spi-nor: macronix: add support for Macronix octaflash series Zhengxun Li 2021-04-20 6:29 ` Zhengxun Li 2021-04-27 2:47 ` Pratyush Yadav 2021-04-27 2:47 ` Pratyush Yadav 2021-05-04 5:38 ` zhengxunli 2021-05-04 5:38 ` zhengxunli 2021-04-20 6:29 ` [PATCH v3 3/3] spi: mxic: patch for octal DTR mode support Zhengxun Li 2021-04-20 6:29 ` Zhengxun Li 2021-04-26 16:53 ` Mark Brown 2021-04-26 16:53 ` Mark Brown 2021-04-27 1:48 ` zhengxunli [this message] 2021-04-27 1:48 ` zhengxunli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=OF9A94F8F9.DF8D5789-ON482586C4.0008EE9F-482586C4.0009F19F@mxic.com.tw \ --to=zhengxunli@mxic.com.tw \ --cc=broonie@kernel.org \ --cc=jaimeliao@mxic.com.tw \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ --cc=tudor.ambarus@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.