* [PATCH] usb: renesas_usbhs: Add a compatible string for r8a774a1
@ 2018-08-24 10:09 ` Biju Das
0 siblings, 0 replies; 6+ messages in thread
From: Biju Das @ 2018-08-24 10:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi
Cc: Biju Das, Yoshihiro Shimoda, Fengguang Wu, Chris Brandt,
Kuninori Morimoto, Geert Uytterhoeven, linux-usb, Simon Horman,
Chris Paterson, Fabrizio Castro, linux-renesas-soc
This patch adds support for r8a774a1 (RZ/G2M).
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
drivers/usb/renesas_usbhs/common.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 4310df4..f1a1694 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -458,6 +458,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
*/
static const struct of_device_id usbhs_of_match[] = {
{
+ .compatible = "renesas,usbhs-r8a774a1",
+ .data = (void *)USBHS_TYPE_RCAR_GEN3,
+ },
+ {
.compatible = "renesas,usbhs-r8a7790",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* usb: renesas_usbhs: Add a compatible string for r8a774a1
@ 2018-08-24 10:09 ` Biju Das
0 siblings, 0 replies; 6+ messages in thread
From: Biju Das @ 2018-08-24 10:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi
Cc: Biju Das, Yoshihiro Shimoda, Fengguang Wu, Chris Brandt,
Kuninori Morimoto, Geert Uytterhoeven, linux-usb, Simon Horman,
Chris Paterson, Fabrizio Castro, linux-renesas-soc
This patch adds support for r8a774a1 (RZ/G2M).
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
drivers/usb/renesas_usbhs/common.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 4310df4..f1a1694 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -458,6 +458,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
*/
static const struct of_device_id usbhs_of_match[] = {
{
+ .compatible = "renesas,usbhs-r8a774a1",
+ .data = (void *)USBHS_TYPE_RCAR_GEN3,
+ },
+ {
.compatible = "renesas,usbhs-r8a7790",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] usb: renesas_usbhs: Add a compatible string for r8a774a1
@ 2018-08-27 4:59 ` Yoshihiro Shimoda
0 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2018-08-27 4:59 UTC (permalink / raw)
To: Biju Das, Greg Kroah-Hartman, Felipe Balbi
Cc: Biju Das, Fengguang Wu, Chris Brandt, Kuninori Morimoto,
Geert Uytterhoeven, linux-usb, Simon Horman, Chris Paterson,
Fabrizio Castro, linux-renesas-soc
Hi Biju-san,
Thank you for the patch!
> From: Biju Das, Sent: Friday, August 24, 2018 7:09 PM
>
> This patch adds support for r8a774a1 (RZ/G2M).
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> drivers/usb/renesas_usbhs/common.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
> index 4310df4..f1a1694 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -458,6 +458,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
> */
> static const struct of_device_id usbhs_of_match[] = {
> {
> + .compatible = "renesas,usbhs-r8a774a1",
> + .data = (void *)USBHS_TYPE_RCAR_GEN3,
> + },
> + {
I don't think you need this adding entry for r8a774a1 actually because
you also submitted a bindings patch [1] and it had "renesas,rcar-gen3-usbhs" for RZ/G2.
[1]
https://patchwork.kernel.org/patch/10574875/
Best regards,
Yoshihiro Shimoda
> .compatible = "renesas,usbhs-r8a7790",
> .data = (void *)USBHS_TYPE_RCAR_GEN2,
> },
> --
> 2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* usb: renesas_usbhs: Add a compatible string for r8a774a1
@ 2018-08-27 4:59 ` Yoshihiro Shimoda
0 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2018-08-27 4:59 UTC (permalink / raw)
To: Biju Das, Greg Kroah-Hartman, Felipe Balbi
Cc: Fengguang Wu, Chris Brandt, Kuninori Morimoto,
Geert Uytterhoeven, linux-usb, Simon Horman, Chris Paterson,
Fabrizio Castro, linux-renesas-soc
Hi Biju-san,
Thank you for the patch!
> From: Biju Das, Sent: Friday, August 24, 2018 7:09 PM
>
> This patch adds support for r8a774a1 (RZ/G2M).
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> drivers/usb/renesas_usbhs/common.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
> index 4310df4..f1a1694 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -458,6 +458,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
> */
> static const struct of_device_id usbhs_of_match[] = {
> {
> + .compatible = "renesas,usbhs-r8a774a1",
> + .data = (void *)USBHS_TYPE_RCAR_GEN3,
> + },
> + {
I don't think you need this adding entry for r8a774a1 actually because
you also submitted a bindings patch [1] and it had "renesas,rcar-gen3-usbhs" for RZ/G2.
[1]
https://patchwork.kernel.org/patch/10574875/
Best regards,
Yoshihiro Shimoda
> .compatible = "renesas,usbhs-r8a7790",
> .data = (void *)USBHS_TYPE_RCAR_GEN2,
> },
> --
> 2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] usb: renesas_usbhs: Add a compatible string for r8a774a1
@ 2018-08-28 7:38 ` Biju Das
0 siblings, 0 replies; 6+ messages in thread
From: Biju Das @ 2018-08-28 7:38 UTC (permalink / raw)
To: Yoshihiro Shimoda, Greg Kroah-Hartman, Felipe Balbi
Cc: Fengguang Wu, Chris Brandt, Kuninori Morimoto,
Geert Uytterhoeven, linux-usb, Simon Horman, Chris Paterson,
Fabrizio Castro, linux-renesas-soc
Hi Shimoda-san,
Thanks for the feedback
> Subject: RE: [PATCH] usb: renesas_usbhs: Add a compatible string for
> r8a774a1
>
> Hi Biju-san,
>
> Thank you for the patch!
>
> > From: Biju Das, Sent: Friday, August 24, 2018 7:09 PM
> >
> > This patch adds support for r8a774a1 (RZ/G2M).
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> > drivers/usb/renesas_usbhs/common.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/renesas_usbhs/common.c
> > b/drivers/usb/renesas_usbhs/common.c
> > index 4310df4..f1a1694 100644
> > --- a/drivers/usb/renesas_usbhs/common.c
> > +++ b/drivers/usb/renesas_usbhs/common.c
> > @@ -458,6 +458,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct
> platform_device *pdev)
> > */
> > static const struct of_device_id usbhs_of_match[] = {
> > {
> > +.compatible = "renesas,usbhs-r8a774a1",
> > +.data = (void *)USBHS_TYPE_RCAR_GEN3,
> > +},
> > +{
>
> I don't think you need this adding entry for r8a774a1 actually because you
> also submitted a bindings patch [1] and it had "renesas,rcar-gen3-usbhs" for
> RZ/G2.
I agree. It is not needed, since fallback is present in the driver. Somehow I missed this.
> [1]
> https://patchwork.kernel.org/patch/10574875/
>
> Best regards,
> Yoshihiro Shimoda
>
> > .compatible = "renesas,usbhs-r8a7790",
> > .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > },
> > --
> > 2.7.4
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 6+ messages in thread
* usb: renesas_usbhs: Add a compatible string for r8a774a1
@ 2018-08-28 7:38 ` Biju Das
0 siblings, 0 replies; 6+ messages in thread
From: Biju Das @ 2018-08-28 7:38 UTC (permalink / raw)
To: Yoshihiro Shimoda, Greg Kroah-Hartman, Felipe Balbi
Cc: Fengguang Wu, Chris Brandt, Kuninori Morimoto,
Geert Uytterhoeven, linux-usb, Simon Horman, Chris Paterson,
Fabrizio Castro, linux-renesas-soc
Hi Shimoda-san,
Thanks for the feedback
> Subject: RE: [PATCH] usb: renesas_usbhs: Add a compatible string for
> r8a774a1
>
> Hi Biju-san,
>
> Thank you for the patch!
>
> > From: Biju Das, Sent: Friday, August 24, 2018 7:09 PM
> >
> > This patch adds support for r8a774a1 (RZ/G2M).
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> > drivers/usb/renesas_usbhs/common.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/renesas_usbhs/common.c
> > b/drivers/usb/renesas_usbhs/common.c
> > index 4310df4..f1a1694 100644
> > --- a/drivers/usb/renesas_usbhs/common.c
> > +++ b/drivers/usb/renesas_usbhs/common.c
> > @@ -458,6 +458,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct
> platform_device *pdev)
> > */
> > static const struct of_device_id usbhs_of_match[] = {
> > {
> > +.compatible = "renesas,usbhs-r8a774a1",
> > +.data = (void *)USBHS_TYPE_RCAR_GEN3,
> > +},
> > +{
>
> I don't think you need this adding entry for r8a774a1 actually because you
> also submitted a bindings patch [1] and it had "renesas,rcar-gen3-usbhs" for
> RZ/G2.
I agree. It is not needed, since fallback is present in the driver. Somehow I missed this.
> [1]
> https://patchwork.kernel.org/patch/10574875/
>
> Best regards,
> Yoshihiro Shimoda
>
> > .compatible = "renesas,usbhs-r8a7790",
> > .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > },
> > --
> > 2.7.4
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-28 11:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-24 10:09 [PATCH] usb: renesas_usbhs: Add a compatible string for r8a774a1 Biju Das
2018-08-24 10:09 ` Biju Das
2018-08-27 4:59 ` [PATCH] " Yoshihiro Shimoda
2018-08-27 4:59 ` Yoshihiro Shimoda
2018-08-28 7:38 ` [PATCH] " Biju Das
2018-08-28 7:38 ` Biju Das
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.