All of lore.kernel.org
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"david.edmondson@oracle.com" <david.edmondson@oracle.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"sburla@marvell.com" <sburla@marvell.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Maor Gottlieb <maorg@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-dev] RE: [PATCH v11 3/3] admin: Add group member legacy register access commands
Date: Fri, 7 Jul 2023 03:54:31 +0000	[thread overview]
Message-ID: <PH0PR12MB5481DF6CC374634FE1A1AAF9DC2DA@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230706174904-mutt-send-email-mst@kernel.org>


> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Thursday, July 6, 2023 6:36 PM

[..]

> I notice you decided to silently ignore my suggestion to document how are
> notifications performed. Repeating myself like this is despiriting for me.
I am sorry if it appeared that way,
But no, I didn’t silently ignored.

I added the description as best I could find it, but you commented about it being messy with mixing up the terminology.
I rewrote it in v12, it looks better now. Please check.

> Pls re-add especially since you already document it for the cfg_Write access
> method anyway.
> 
Added without citation to hypervisor etc.

> 
> also in a conformance section, document the effect of notification being the
> same as notification through legacy interface.

PCI specific things were copied from the current spec reference in the notification capability section.
All the changes you suggested are done.
Captured in the change log of v12.

Thanks a lot.
Since many parts are rewritten as you suggested in the thread, 
I prefer to add your Signed-off to in v13 if we need roll it or when it is merged, please apply if you find it appropriate.
It is at least important to me to add it yours Sign-off.

WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"david.edmondson@oracle.com" <david.edmondson@oracle.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"sburla@marvell.com" <sburla@marvell.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Maor Gottlieb <maorg@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-comment] RE: [PATCH v11 3/3] admin: Add group member legacy register access commands
Date: Fri, 7 Jul 2023 03:54:31 +0000	[thread overview]
Message-ID: <PH0PR12MB5481DF6CC374634FE1A1AAF9DC2DA@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230706174904-mutt-send-email-mst@kernel.org>


> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Thursday, July 6, 2023 6:36 PM

[..]

> I notice you decided to silently ignore my suggestion to document how are
> notifications performed. Repeating myself like this is despiriting for me.
I am sorry if it appeared that way,
But no, I didn’t silently ignored.

I added the description as best I could find it, but you commented about it being messy with mixing up the terminology.
I rewrote it in v12, it looks better now. Please check.

> Pls re-add especially since you already document it for the cfg_Write access
> method anyway.
> 
Added without citation to hypervisor etc.

> 
> also in a conformance section, document the effect of notification being the
> same as notification through legacy interface.

PCI specific things were copied from the current spec reference in the notification capability section.
All the changes you suggested are done.
Captured in the change log of v12.

Thanks a lot.
Since many parts are rewritten as you suggested in the thread, 
I prefer to add your Signed-off to in v13 if we need roll it or when it is merged, please apply if you find it appropriate.
It is at least important to me to add it yours Sign-off.

  reply	other threads:[~2023-07-07  3:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 21:27 [virtio-dev] [PATCH v11 0/3] admin: Access legacy registers using admin commands Parav Pandit
2023-07-06 21:27 ` [virtio-comment] " Parav Pandit
2023-07-06 21:27 ` [virtio-dev] [PATCH v11 1/3] admin: Split opcode table rows with a line Parav Pandit
2023-07-06 21:27   ` [virtio-comment] " Parav Pandit
2023-07-06 21:27 ` [virtio-dev] [PATCH v11 2/3] admin: Fix section numbering Parav Pandit
2023-07-06 21:27   ` [virtio-comment] " Parav Pandit
2023-07-06 21:27 ` [virtio-dev] [PATCH v11 3/3] admin: Add group member legacy register access commands Parav Pandit
2023-07-06 21:27   ` [virtio-comment] " Parav Pandit
2023-07-06 22:36   ` [virtio-dev] " Michael S. Tsirkin
2023-07-06 22:36     ` [virtio-comment] " Michael S. Tsirkin
2023-07-07  3:54     ` Parav Pandit [this message]
2023-07-07  3:54       ` [virtio-comment] " Parav Pandit
2023-07-07  8:29       ` [virtio-dev] " Michael S. Tsirkin
2023-07-07  8:29         ` [virtio-comment] " Michael S. Tsirkin
2023-07-06 22:36 ` [virtio-dev] Re: [PATCH v11 0/3] admin: Access legacy registers using admin commands Michael S. Tsirkin
2023-07-06 22:36   ` [virtio-comment] " Michael S. Tsirkin
2023-07-07 11:37   ` [virtio-dev] " Cornelia Huck
2023-07-07 11:37     ` [virtio-comment] " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR12MB5481DF6CC374634FE1A1AAF9DC2DA@PH0PR12MB5481.namprd12.prod.outlook.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=david.edmondson@oracle.com \
    --cc=jasowang@redhat.com \
    --cc=maorg@nvidia.com \
    --cc=mst@redhat.com \
    --cc=sburla@marvell.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.