All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Tatyana Brokhman <tlinder@codeaurora.org>
Cc: greg@kroah.com, linux-usb@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, balbi@ti.com,
	ablay@codeaurora.org, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] usb:dummy_hcd: Force FS device connection according to module parameter
Date: Thu, 9 Jun 2011 14:51:33 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.1106091449490.2081-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1307635009-5741-1-git-send-email-tlinder@codeaurora.org>

On Thu, 9 Jun 2011, Tatyana Brokhman wrote:

> This patch adds a new module parameter to dummy_hcd: is_high_speed
> When set to false the connected device will be forced to operate in FS
> mode. The default of this parameter is true.

...

> @@ -904,12 +908,15 @@ usb_gadget_probe_driver(struct usb_gadget_driver *driver,
>  	dum->gadget.ep0 = &dum->ep [0].ep;
>  	if (mod_data.is_super_speed)
>  		dum->gadget.speed = driver->speed;
> -	else
> +	else if (mod_data.is_high_speed)
>  		dum->gadget.speed = min((u8)USB_SPEED_HIGH, (u8)driver->speed);

Use min_t().

> +	else
> +		dum->gadget.speed = USB_SPEED_FULL;
>  	if (dum->gadget.speed < driver->speed)
> -		dev_dbg(udc_dev(dum), "This device can perform faster if"
> -				      " you connect it to a "
> -				      "SupeSpeed port...\n");
> +		dev_dbg(udc_dev(dum), "This device can perform faster"
> +				" if you connect it to a %s port...\n",
> +			(driver->speed == USB_SPEED_SUPER ?
> +			 "SuperSpeed" : "HighSpeed"));
>  
>  	if (dum->gadget.speed == USB_SPEED_SUPER) {
>  		for (i = 0; i < DUMMY_ENDPOINTS; i++)
> @@ -2417,6 +2424,9 @@ static int __init init (void)
>  	if (usb_disabled ())
>  		return -ENODEV;
>  
> +	if (!mod_data.is_high_speed && mod_data.is_super_speed)
> +		return -EINVAL;

Print an error message in the log so that the user will know why the 
failure occurred.

Alan Stern

WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu>
To: Tatyana Brokhman <tlinder@codeaurora.org>
Cc: greg@kroah.com, <linux-usb@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <balbi@ti.com>,
	<ablay@codeaurora.org>, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] usb:dummy_hcd: Force FS device connection according to module parameter
Date: Thu, 9 Jun 2011 14:51:33 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.1106091449490.2081-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1307635009-5741-1-git-send-email-tlinder@codeaurora.org>

On Thu, 9 Jun 2011, Tatyana Brokhman wrote:

> This patch adds a new module parameter to dummy_hcd: is_high_speed
> When set to false the connected device will be forced to operate in FS
> mode. The default of this parameter is true.

...

> @@ -904,12 +908,15 @@ usb_gadget_probe_driver(struct usb_gadget_driver *driver,
>  	dum->gadget.ep0 = &dum->ep [0].ep;
>  	if (mod_data.is_super_speed)
>  		dum->gadget.speed = driver->speed;
> -	else
> +	else if (mod_data.is_high_speed)
>  		dum->gadget.speed = min((u8)USB_SPEED_HIGH, (u8)driver->speed);

Use min_t().

> +	else
> +		dum->gadget.speed = USB_SPEED_FULL;
>  	if (dum->gadget.speed < driver->speed)
> -		dev_dbg(udc_dev(dum), "This device can perform faster if"
> -				      " you connect it to a "
> -				      "SupeSpeed port...\n");
> +		dev_dbg(udc_dev(dum), "This device can perform faster"
> +				" if you connect it to a %s port...\n",
> +			(driver->speed == USB_SPEED_SUPER ?
> +			 "SuperSpeed" : "HighSpeed"));
>  
>  	if (dum->gadget.speed == USB_SPEED_SUPER) {
>  		for (i = 0; i < DUMMY_ENDPOINTS; i++)
> @@ -2417,6 +2424,9 @@ static int __init init (void)
>  	if (usb_disabled ())
>  		return -ENODEV;
>  
> +	if (!mod_data.is_high_speed && mod_data.is_super_speed)
> +		return -EINVAL;

Print an error message in the log so that the user will know why the 
failure occurred.

Alan Stern


  reply	other threads:[~2011-06-09 18:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09 15:56 [PATCH v2] usb:dummy_hcd: Force FS device connection according to module parameter Tatyana Brokhman
2011-06-09 15:56 ` Tatyana Brokhman
2011-06-09 18:51 ` Alan Stern [this message]
2011-06-09 18:51   ` Alan Stern
2011-06-09 20:56   ` Tanya Brokhman
2011-06-09 20:56     ` Tanya Brokhman
2011-06-09 21:23     ` Alan Stern
2011-06-09 21:23       ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.1106091449490.2081-100000@iolanthe.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=ablay@codeaurora.org \
    --cc=balbi@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tlinder@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.