From: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
To: Tanya Brokhman <tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
'open list'
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH v2] usb:dummy_hcd: Force FS device connection according to module parameter
Date: Thu, 9 Jun 2011 17:23:10 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1106091721240.1914-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <027301cc26e7$b5c99690$215cc3b0$@org>
On Thu, 9 Jun 2011, Tanya Brokhman wrote:
> > > + if (!mod_data.is_high_speed && mod_data.is_super_speed)
> > > + return -EINVAL;
> >
> > Print an error message in the log so that the user will know why the
> > failure occurred.
> >
>
> But when the module fails to load the message sais that it's invalid
> parameter (or something like that). That's why I thought it will be enough.
Oh yes, that's true.
> You mean to add something that explains WHY these values are wrong?
That's what I had in mind. But "invalid parameter" is probably good
enough, since these are the _only_ parameters. :-) So this part is
okay as it stands.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu>
To: Tanya Brokhman <tlinder@codeaurora.org>
Cc: greg@kroah.com, <linux-usb@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <balbi@ti.com>,
<ablay@codeaurora.org>,
"'open list'" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] usb:dummy_hcd: Force FS device connection according to module parameter
Date: Thu, 9 Jun 2011 17:23:10 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1106091721240.1914-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <027301cc26e7$b5c99690$215cc3b0$@org>
On Thu, 9 Jun 2011, Tanya Brokhman wrote:
> > > + if (!mod_data.is_high_speed && mod_data.is_super_speed)
> > > + return -EINVAL;
> >
> > Print an error message in the log so that the user will know why the
> > failure occurred.
> >
>
> But when the module fails to load the message sais that it's invalid
> parameter (or something like that). That's why I thought it will be enough.
Oh yes, that's true.
> You mean to add something that explains WHY these values are wrong?
That's what I had in mind. But "invalid parameter" is probably good
enough, since these are the _only_ parameters. :-) So this part is
okay as it stands.
Alan Stern
next prev parent reply other threads:[~2011-06-09 21:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 15:56 [PATCH v2] usb:dummy_hcd: Force FS device connection according to module parameter Tatyana Brokhman
2011-06-09 15:56 ` Tatyana Brokhman
2011-06-09 18:51 ` Alan Stern
2011-06-09 18:51 ` Alan Stern
2011-06-09 20:56 ` Tanya Brokhman
2011-06-09 20:56 ` Tanya Brokhman
2011-06-09 21:23 ` Alan Stern [this message]
2011-06-09 21:23 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1106091721240.1914-100000@iolanthe.rowland.org \
--to=stern-nwvwt67g6+6dfdvte/nmlpvzexx5g7lz@public.gmane.org \
--cc=ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.