* [PATCH] usb: host: remove unnecessary null check
@ 2017-05-02 16:09 Gustavo A. R. Silva
2017-05-02 18:25 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-05-02 16:09 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel
Remove unnecessary null check. udev->tt cannot ever be NULL when this
section of code runs.
Addresses-Coverity-ID: 100828
Cc: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/usb/host/ehci-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index 980a6b3..6bc6304 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -1105,7 +1105,7 @@ iso_stream_init(
addr |= epnum << 8;
addr |= dev->devnum;
stream->ps.usecs = HS_USECS_ISO(maxp);
- think_time = dev->tt ? dev->tt->think_time : 0;
+ think_time = dev->tt->think_time;
stream->ps.tt_usecs = NS_TO_US(think_time + usb_calc_bus_time(
dev->speed, is_input, 1, maxp));
hs_transfers = max(1u, (maxp + 187) / 188);
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: host: remove unnecessary null check
2017-05-02 16:09 [PATCH] usb: host: remove unnecessary null check Gustavo A. R. Silva
@ 2017-05-02 18:25 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2017-05-02 18:25 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
On Tue, 2 May 2017, Gustavo A. R. Silva wrote:
> Remove unnecessary null check. udev->tt cannot ever be NULL when this
> section of code runs.
>
> Addresses-Coverity-ID: 100828
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/usb/host/ehci-sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
> index 980a6b3..6bc6304 100644
> --- a/drivers/usb/host/ehci-sched.c
> +++ b/drivers/usb/host/ehci-sched.c
> @@ -1105,7 +1105,7 @@ iso_stream_init(
> addr |= epnum << 8;
> addr |= dev->devnum;
> stream->ps.usecs = HS_USECS_ISO(maxp);
> - think_time = dev->tt ? dev->tt->think_time : 0;
> + think_time = dev->tt->think_time;
> stream->ps.tt_usecs = NS_TO_US(think_time + usb_calc_bus_time(
> dev->speed, is_input, 1, maxp));
> hs_transfers = max(1u, (maxp + 187) / 188);
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-02 18:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 16:09 [PATCH] usb: host: remove unnecessary null check Gustavo A. R. Silva
2017-05-02 18:25 ` Alan Stern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.