* [PATCH] usb: host: ehci-sched: remove redundant pointer dev
@ 2018-07-13 9:29 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-07-13 9:29 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer dev is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'dev' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/host/ehci-sched.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index 1d87295682b8..da7b00a6110b 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -1835,7 +1835,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
unsigned uframe;
int urb_index = -1;
struct ehci_iso_stream *stream = itd->stream;
- struct usb_device *dev;
bool retval = false;
/* for each uframe with a packet */
@@ -1886,7 +1885,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
*/
/* give urb back to the driver; completion often (re)submits */
- dev = urb->dev;
ehci_urb_done(ehci, urb, 0);
retval = true;
urb = NULL;
@@ -2230,7 +2228,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
u32 t;
int urb_index;
struct ehci_iso_stream *stream = sitd->stream;
- struct usb_device *dev;
bool retval = false;
urb_index = sitd->index;
@@ -2268,7 +2265,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
*/
/* give urb back to the driver; completion often (re)submits */
- dev = urb->dev;
ehci_urb_done(ehci, urb, 0);
retval = true;
urb = NULL;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* usb: host: ehci-sched: remove redundant pointer dev
@ 2018-07-13 9:29 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-07-13 9:29 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer dev is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'dev' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/host/ehci-sched.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index 1d87295682b8..da7b00a6110b 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -1835,7 +1835,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
unsigned uframe;
int urb_index = -1;
struct ehci_iso_stream *stream = itd->stream;
- struct usb_device *dev;
bool retval = false;
/* for each uframe with a packet */
@@ -1886,7 +1885,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
*/
/* give urb back to the driver; completion often (re)submits */
- dev = urb->dev;
ehci_urb_done(ehci, urb, 0);
retval = true;
urb = NULL;
@@ -2230,7 +2228,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
u32 t;
int urb_index;
struct ehci_iso_stream *stream = sitd->stream;
- struct usb_device *dev;
bool retval = false;
urb_index = sitd->index;
@@ -2268,7 +2265,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
*/
/* give urb back to the driver; completion often (re)submits */
- dev = urb->dev;
ehci_urb_done(ehci, urb, 0);
retval = true;
urb = NULL;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] usb: host: ehci-sched: remove redundant pointer dev
@ 2018-07-13 9:29 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-07-13 9:29 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer dev is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'dev' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/host/ehci-sched.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index 1d87295682b8..da7b00a6110b 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -1835,7 +1835,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
unsigned uframe;
int urb_index = -1;
struct ehci_iso_stream *stream = itd->stream;
- struct usb_device *dev;
bool retval = false;
/* for each uframe with a packet */
@@ -1886,7 +1885,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
*/
/* give urb back to the driver; completion often (re)submits */
- dev = urb->dev;
ehci_urb_done(ehci, urb, 0);
retval = true;
urb = NULL;
@@ -2230,7 +2228,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
u32 t;
int urb_index;
struct ehci_iso_stream *stream = sitd->stream;
- struct usb_device *dev;
bool retval = false;
urb_index = sitd->index;
@@ -2268,7 +2265,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
*/
/* give urb back to the driver; completion often (re)submits */
- dev = urb->dev;
ehci_urb_done(ehci, urb, 0);
retval = true;
urb = NULL;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: host: ehci-sched: remove redundant pointer dev
2018-07-13 9:29 ` [PATCH] " Colin King
(?)
@ 2018-07-13 20:17 ` Alan Stern
-1 siblings, 0 replies; 6+ messages in thread
From: Alan Stern @ 2018-07-13 20:17 UTC (permalink / raw)
To: Colin King; +Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors, linux-kernel
On Fri, 13 Jul 2018, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer dev is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'dev' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/host/ehci-sched.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
> index 1d87295682b8..da7b00a6110b 100644
> --- a/drivers/usb/host/ehci-sched.c
> +++ b/drivers/usb/host/ehci-sched.c
> @@ -1835,7 +1835,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
> unsigned uframe;
> int urb_index = -1;
> struct ehci_iso_stream *stream = itd->stream;
> - struct usb_device *dev;
> bool retval = false;
>
> /* for each uframe with a packet */
> @@ -1886,7 +1885,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
> */
>
> /* give urb back to the driver; completion often (re)submits */
> - dev = urb->dev;
> ehci_urb_done(ehci, urb, 0);
> retval = true;
> urb = NULL;
> @@ -2230,7 +2228,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
> u32 t;
> int urb_index;
> struct ehci_iso_stream *stream = sitd->stream;
> - struct usb_device *dev;
> bool retval = false;
>
> urb_index = sitd->index;
> @@ -2268,7 +2265,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
> */
>
> /* give urb back to the driver; completion often (re)submits */
> - dev = urb->dev;
> ehci_urb_done(ehci, urb, 0);
> retval = true;
> urb = NULL;
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 6+ messages in thread
* usb: host: ehci-sched: remove redundant pointer dev
@ 2018-07-13 20:17 ` Alan Stern
0 siblings, 0 replies; 6+ messages in thread
From: Alan Stern @ 2018-07-13 20:17 UTC (permalink / raw)
To: Colin King; +Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors, linux-kernel
On Fri, 13 Jul 2018, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer dev is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'dev' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/host/ehci-sched.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
> index 1d87295682b8..da7b00a6110b 100644
> --- a/drivers/usb/host/ehci-sched.c
> +++ b/drivers/usb/host/ehci-sched.c
> @@ -1835,7 +1835,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
> unsigned uframe;
> int urb_index = -1;
> struct ehci_iso_stream *stream = itd->stream;
> - struct usb_device *dev;
> bool retval = false;
>
> /* for each uframe with a packet */
> @@ -1886,7 +1885,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
> */
>
> /* give urb back to the driver; completion often (re)submits */
> - dev = urb->dev;
> ehci_urb_done(ehci, urb, 0);
> retval = true;
> urb = NULL;
> @@ -2230,7 +2228,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
> u32 t;
> int urb_index;
> struct ehci_iso_stream *stream = sitd->stream;
> - struct usb_device *dev;
> bool retval = false;
>
> urb_index = sitd->index;
> @@ -2268,7 +2265,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
> */
>
> /* give urb back to the driver; completion often (re)submits */
> - dev = urb->dev;
> ehci_urb_done(ehci, urb, 0);
> retval = true;
> urb = NULL;
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: host: ehci-sched: remove redundant pointer dev
@ 2018-07-13 20:17 ` Alan Stern
0 siblings, 0 replies; 6+ messages in thread
From: Alan Stern @ 2018-07-13 20:17 UTC (permalink / raw)
To: Colin King; +Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors, linux-kernel
On Fri, 13 Jul 2018, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer dev is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'dev' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/host/ehci-sched.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
> index 1d87295682b8..da7b00a6110b 100644
> --- a/drivers/usb/host/ehci-sched.c
> +++ b/drivers/usb/host/ehci-sched.c
> @@ -1835,7 +1835,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
> unsigned uframe;
> int urb_index = -1;
> struct ehci_iso_stream *stream = itd->stream;
> - struct usb_device *dev;
> bool retval = false;
>
> /* for each uframe with a packet */
> @@ -1886,7 +1885,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd)
> */
>
> /* give urb back to the driver; completion often (re)submits */
> - dev = urb->dev;
> ehci_urb_done(ehci, urb, 0);
> retval = true;
> urb = NULL;
> @@ -2230,7 +2228,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
> u32 t;
> int urb_index;
> struct ehci_iso_stream *stream = sitd->stream;
> - struct usb_device *dev;
> bool retval = false;
>
> urb_index = sitd->index;
> @@ -2268,7 +2265,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd)
> */
>
> /* give urb back to the driver; completion often (re)submits */
> - dev = urb->dev;
> ehci_urb_done(ehci, urb, 0);
> retval = true;
> urb = NULL;
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-13 20:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 9:29 [PATCH] usb: host: ehci-sched: remove redundant pointer dev Colin King
2018-07-13 9:29 ` Colin King
2018-07-13 9:29 ` [PATCH] " Colin King
2018-07-13 20:17 ` Alan Stern
2018-07-13 20:17 ` Alan Stern
2018-07-13 20:17 ` [PATCH] " Alan Stern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.