runme

runme

[Michal Margula]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=X-UNKNOWN, Size: 705 bytes --]

Hello!

	Yesterday I was fighting with patch-o-matic. It was complaining 
about "bad substitution" at some line. After few minutes of googling, i 
found out that runme is bash-based shell. So it requires bash to run. OK, 
fine. But in header it has #!/bin/sh and it shouldn't. Some distribution 
(PLD for example) use other shells like pdksh for /bin/sh. 

Solution is simple - changing #!/bin/sh into #!/bin/bash and everything 
should be fine. I don't know if I should to report it at 
bugs.netfilter.org or maybe someone can commit a change to CVS?

Thanks.

-- 
Micha³ Margula, alchemyx@uznam.net.pl, http://alchemyx.uznam.net.pl/ +)
"W ¿yciu piêkne s± tylko chwile" [Ryszard Riedel]

Re: runme

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

On Tue, Jan 06, 2004 at 03:17:22PM +0100, Michal Margula wrote:
> Hello!
> 
> 	Yesterday I was fighting with patch-o-matic. It was complaining 
> about "bad substitution" at some line. After few minutes of googling, i 
> found out that runme is bash-based shell. So it requires bash to run. OK, 
> fine. But in header it has #!/bin/sh and it shouldn't. Some distribution 
> (PLD for example) use other shells like pdksh for /bin/sh. 
> 
> Solution is simple - changing #!/bin/sh into #!/bin/bash and everything 
> should be fine. I don't know if I should to report it at 
> bugs.netfilter.org or maybe someone can commit a change to CVS?

thanks, I'll fix it in CVS.  but normally bugzilla would be the right
way to do this.  thanks.

> Thanks.
 

-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: runme

[Maciej Soltysiak]

> > Solution is simple - changing #!/bin/sh into #!/bin/bash and everything 
> > should be fine. I don't know if I should to report it at 
> > bugs.netfilter.org or maybe someone can commit a change to CVS?
> thanks, I'll fix it in CVS.  but normally bugzilla would be the right
Harald, I remember that changing to /bin/sh was part of a wave of
removing bash'isms from the scripts. Not every linux box has bash,
and some people were complaining about it I think.

I do not know if it is relevant, but it might be.

Regards,
Maciej