[PATCH] Added QE to the list of default scanned OF devices

[PATCH] Added QE to the list of default scanned OF devices

[Andy Fleming]

Signed-off-by: Andrew Fleming <afleming@freescale.com>
---
 arch/powerpc/kernel/of_platform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
index b734517..43c5a00 100644
--- a/arch/powerpc/kernel/of_platform.c
+++ b/arch/powerpc/kernel/of_platform.c
@@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
 	{ .type = "plb4", },
 	{ .type = "opb", },
 	{ .type = "ebc", },
+	{ .type = "qe", },
 	{},
 };
 
-- 
1.4.4

Re: [PATCH] Added QE to the list of default scanned OF devices

[Kumar Gala]

On Thu, 8 Feb 2007, Andy Fleming wrote:

>
> Signed-off-by: Andrew Fleming <afleming@freescale.com>
> ---
> arch/powerpc/kernel/of_platform.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>

applied.

- k

Re: [PATCH] Added QE to the list of default scanned OF devices

[Benjamin Herrenschmidt]

On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
> Signed-off-by: Andrew Fleming <afleming@freescale.com>
> ---
>  arch/powerpc/kernel/of_platform.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

As I said several times on irc, I dislike the "default list" and I'm
tempted to remove it. I'd much prefer if your platform passed in the
list of what it wants exposed.

Ben.

> diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
> index b734517..43c5a00 100644
> --- a/arch/powerpc/kernel/of_platform.c
> +++ b/arch/powerpc/kernel/of_platform.c
> @@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
>  	{ .type = "plb4", },
>  	{ .type = "opb", },
>  	{ .type = "ebc", },
> +	{ .type = "qe", },
>  	{},
>  };
>  

Re: [PATCH] Added QE to the list of default scanned OF devices

[Kumar Gala]

On Feb 8, 2007, at 4:27 PM, Benjamin Herrenschmidt wrote:

> On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
>> Signed-off-by: Andrew Fleming <afleming@freescale.com>
>> ---
>>  arch/powerpc/kernel/of_platform.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> As I said several times on irc, I dislike the "default list" and I'm
> tempted to remove it. I'd much prefer if your platform passed in the
> list of what it wants exposed.

How about we add 'qe' for now and look at removing the list going  
forward.

- k

>> diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/ 
>> kernel/of_platform.c
>> index b734517..43c5a00 100644
>> --- a/arch/powerpc/kernel/of_platform.c
>> +++ b/arch/powerpc/kernel/of_platform.c
>> @@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
>>  	{ .type = "plb4", },
>>  	{ .type = "opb", },
>>  	{ .type = "ebc", },
>> +	{ .type = "qe", },
>>  	{},
>>  };
>>

Re: [PATCH] Added QE to the list of default scanned OF devices

[Kumar Gala]

On Feb 8, 2007, at 4:56 PM, Kumar Gala wrote:

>
> On Feb 8, 2007, at 4:27 PM, Benjamin Herrenschmidt wrote:
>
>> On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
>>> Signed-off-by: Andrew Fleming <afleming@freescale.com>
>>> ---
>>>  arch/powerpc/kernel/of_platform.c |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> As I said several times on irc, I dislike the "default list" and I'm
>> tempted to remove it. I'd much prefer if your platform passed in the
>> list of what it wants exposed.
>
> How about we add 'qe' for now and look at removing the list going
> forward.

Actually, nevermind.  I've dropped the patch and will make the guys  
do what you are suggesting.  Can you look at the other users (cell,  
pmac?) and change them so we can remove the "default list"

- k

Re: [PATCH] Added QE to the list of default scanned OF devices

[Benjamin Herrenschmidt]

On Thu, 2007-02-08 at 17:25 -0600, Kumar Gala wrote:
> On Feb 8, 2007, at 4:56 PM, Kumar Gala wrote:
> 
> >
> > On Feb 8, 2007, at 4:27 PM, Benjamin Herrenschmidt wrote:
> >
> >> On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
> >>> Signed-off-by: Andrew Fleming <afleming@freescale.com>
> >>> ---
> >>>  arch/powerpc/kernel/of_platform.c |    1 +
> >>>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> As I said several times on irc, I dislike the "default list" and I'm
> >> tempted to remove it. I'd much prefer if your platform passed in the
> >> list of what it wants exposed.
> >
> > How about we add 'qe' for now and look at removing the list going
> > forward.
> 
> Actually, nevermind.  I've dropped the patch and will make the guys  
> do what you are suggesting.  Can you look at the other users (cell,  
> pmac?) and change them so we can remove the "default list"

Only Cell is using that afaik. I'll do a patch asap.

Ben.