* [PATCH/RFC] fb: put framebuffer drivers back under the "frame buffer devices" menu
@ 2009-11-08 22:46 Guennadi Liakhovetski
2009-11-11 0:51 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Guennadi Liakhovetski @ 2009-11-08 22:46 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: Andrew Morton, linux-kbuild, Roman Zippel
The config FB_PRE_INIT_FB entry in drivers/video/Kconfig pushes all entries
below it out of the menuconfig selection. Fix this.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
This is _most_ _probably_ not a right fix, but rather an observation, that
the patch below fixes the problem, whereby all entires below
FB_PRE_INIT_FB get displaced from the "frame buffer devices" menu. A bug
in kconfig? The additional dependency on FB in this patch is certainly
redundant.
drivers/video/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 9bbb285..188e1ba 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2121,7 +2121,7 @@ config FB_EP93XX
config FB_PRE_INIT_FB
bool "Don't reinitialize, use bootloader's GDC/Display configuration"
- depends on FB_MB862XX_LIME
+ depends on FB && FB_MB862XX_LIME
---help---
Select this option if display contents should be inherited as set by
the bootloader.
--
1.6.2.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH/RFC] fb: put framebuffer drivers back under the "frame buffer devices" menu
2009-11-08 22:46 [PATCH/RFC] fb: put framebuffer drivers back under the "frame buffer devices" menu Guennadi Liakhovetski
@ 2009-11-11 0:51 ` Andrew Morton
2009-11-11 7:35 ` Guennadi Liakhovetski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2009-11-11 0:51 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: linux-fbdev-devel, linux-kbuild, Roman Zippel
On Sun, 8 Nov 2009 23:46:24 +0100 (CET)
Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> The config FB_PRE_INIT_FB entry in drivers/video/Kconfig pushes all entries
> below it out of the menuconfig selection. Fix this.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> This is _most_ _probably_ not a right fix, but rather an observation, that
> the patch below fixes the problem, whereby all entires below
> FB_PRE_INIT_FB get displaced from the "frame buffer devices" menu. A bug
> in kconfig? The additional dependency on FB in this patch is certainly
> redundant.
>
> drivers/video/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 9bbb285..188e1ba 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -2121,7 +2121,7 @@ config FB_EP93XX
>
> config FB_PRE_INIT_FB
> bool "Don't reinitialize, use bootloader's GDC/Display configuration"
> - depends on FB_MB862XX_LIME
> + depends on FB && FB_MB862XX_LIME
> ---help---
> Select this option if display contents should be inherited as set by
> the bootloader.
hmm, well, lots of surrounding records also have `depends on FB', and
it fixes the bug, so I see no problem with using the patch as-is.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/RFC] fb: put framebuffer drivers back under the "frame buffer devices" menu
2009-11-11 0:51 ` Andrew Morton
@ 2009-11-11 7:35 ` Guennadi Liakhovetski
0 siblings, 0 replies; 3+ messages in thread
From: Guennadi Liakhovetski @ 2009-11-11 7:35 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-fbdev-devel, linux-kbuild, Roman Zippel
On Tue, 10 Nov 2009, Andrew Morton wrote:
> On Sun, 8 Nov 2009 23:46:24 +0100 (CET)
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
>
> > The config FB_PRE_INIT_FB entry in drivers/video/Kconfig pushes all entries
> > below it out of the menuconfig selection. Fix this.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > ---
> >
> > This is _most_ _probably_ not a right fix, but rather an observation, that
> > the patch below fixes the problem, whereby all entires below
> > FB_PRE_INIT_FB get displaced from the "frame buffer devices" menu. A bug
> > in kconfig? The additional dependency on FB in this patch is certainly
> > redundant.
> >
> > drivers/video/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> > index 9bbb285..188e1ba 100644
> > --- a/drivers/video/Kconfig
> > +++ b/drivers/video/Kconfig
> > @@ -2121,7 +2121,7 @@ config FB_EP93XX
> >
> > config FB_PRE_INIT_FB
> > bool "Don't reinitialize, use bootloader's GDC/Display configuration"
> > - depends on FB_MB862XX_LIME
> > + depends on FB && FB_MB862XX_LIME
> > ---help---
> > Select this option if display contents should be inherited as set by
> > the bootloader.
>
> hmm, well, lots of surrounding records also have `depends on FB', and
> it fixes the bug, so I see no problem with using the patch as-is.
Well, not that much of a problem with applying this patch, but this seems
like a bug in kernel kconfig system, and by applying this patch we paper
over it without having found, understood and fixed it.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-11 7:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-08 22:46 [PATCH/RFC] fb: put framebuffer drivers back under the "frame buffer devices" menu Guennadi Liakhovetski
2009-11-11 0:51 ` Andrew Morton
2009-11-11 7:35 ` Guennadi Liakhovetski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.