All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: YueHaibing <yuehaibing@huawei.com>
Cc: harveyhuntnexus@gmail.com, miquel.raynal@bootlin.com,
	richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static
Date: Fri, 10 Apr 2020 17:47:50 +0200	[thread overview]
Message-ID: <Q7XK8Q.LJL60QVBDX02@crapouillou.net> (raw)
In-Reply-To: <20200410115121.11852-1-yuehaibing@huawei.com>

Hi,

Le ven. 10 avril 2020 à 19:51, YueHaibing <yuehaibing@huawei.com> a 
écrit :
> Fix sparse warning:
> 
> drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:105:32:
>  warning: symbol 'qi_lb60_ooblayout_ops' was not declared. Should it 
> be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks!
-Paul

> ---
>  drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c 
> b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> index 935c4902ada7..e7bd845fdbf5 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> @@ -102,7 +102,7 @@ static int qi_lb60_ooblayout_free(struct mtd_info 
> *mtd, int section,
>  	return 0;
>  }
> 
> -const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
> +static const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
>  	.ecc = qi_lb60_ooblayout_ecc,
>  	.free = qi_lb60_ooblayout_free,
>  };
> --
> 2.17.1
> 
> 



WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net>
To: YueHaibing <yuehaibing@huawei.com>
Cc: vigneshr@ti.com, richard@nod.at, linux-kernel@vger.kernel.org,
	harveyhuntnexus@gmail.com, linux-mtd@lists.infradead.org,
	miquel.raynal@bootlin.com
Subject: Re: [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static
Date: Fri, 10 Apr 2020 17:47:50 +0200	[thread overview]
Message-ID: <Q7XK8Q.LJL60QVBDX02@crapouillou.net> (raw)
In-Reply-To: <20200410115121.11852-1-yuehaibing@huawei.com>

Hi,

Le ven. 10 avril 2020 à 19:51, YueHaibing <yuehaibing@huawei.com> a 
écrit :
> Fix sparse warning:
> 
> drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:105:32:
>  warning: symbol 'qi_lb60_ooblayout_ops' was not declared. Should it 
> be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks!
-Paul

> ---
>  drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c 
> b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> index 935c4902ada7..e7bd845fdbf5 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> @@ -102,7 +102,7 @@ static int qi_lb60_ooblayout_free(struct mtd_info 
> *mtd, int section,
>  	return 0;
>  }
> 
> -const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
> +static const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
>  	.ecc = qi_lb60_ooblayout_ecc,
>  	.free = qi_lb60_ooblayout_free,
>  };
> --
> 2.17.1
> 
> 



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-04-10 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 11:51 [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static YueHaibing
2020-04-10 11:51 ` YueHaibing
2020-04-10 15:47 ` Paul Cercueil [this message]
2020-04-10 15:47   ` Paul Cercueil
2020-05-10 20:06 ` Miquel Raynal
2020-05-10 20:06   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Q7XK8Q.LJL60QVBDX02@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=harveyhuntnexus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.