All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static
@ 2020-04-10 11:51 ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2020-04-10 11:51 UTC (permalink / raw)
  To: harveyhuntnexus, paul, miquel.raynal, richard, vigneshr
  Cc: linux-mtd, linux-kernel, YueHaibing

Fix sparse warning:

drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:105:32:
 warning: symbol 'qi_lb60_ooblayout_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
index 935c4902ada7..e7bd845fdbf5 100644
--- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
+++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
@@ -102,7 +102,7 @@ static int qi_lb60_ooblayout_free(struct mtd_info *mtd, int section,
 	return 0;
 }
 
-const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
+static const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
 	.ecc = qi_lb60_ooblayout_ecc,
 	.free = qi_lb60_ooblayout_free,
 };
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static
@ 2020-04-10 11:51 ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2020-04-10 11:51 UTC (permalink / raw)
  To: harveyhuntnexus, paul, miquel.raynal, richard, vigneshr
  Cc: YueHaibing, linux-mtd, linux-kernel

Fix sparse warning:

drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:105:32:
 warning: symbol 'qi_lb60_ooblayout_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
index 935c4902ada7..e7bd845fdbf5 100644
--- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
+++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
@@ -102,7 +102,7 @@ static int qi_lb60_ooblayout_free(struct mtd_info *mtd, int section,
 	return 0;
 }
 
-const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
+static const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
 	.ecc = qi_lb60_ooblayout_ecc,
 	.free = qi_lb60_ooblayout_free,
 };
-- 
2.17.1



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static
  2020-04-10 11:51 ` YueHaibing
@ 2020-04-10 15:47   ` Paul Cercueil
  -1 siblings, 0 replies; 6+ messages in thread
From: Paul Cercueil @ 2020-04-10 15:47 UTC (permalink / raw)
  To: YueHaibing
  Cc: harveyhuntnexus, miquel.raynal, richard, vigneshr, linux-mtd,
	linux-kernel

Hi,

Le ven. 10 avril 2020 à 19:51, YueHaibing <yuehaibing@huawei.com> a 
écrit :
> Fix sparse warning:
> 
> drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:105:32:
>  warning: symbol 'qi_lb60_ooblayout_ops' was not declared. Should it 
> be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks!
-Paul

> ---
>  drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c 
> b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> index 935c4902ada7..e7bd845fdbf5 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> @@ -102,7 +102,7 @@ static int qi_lb60_ooblayout_free(struct mtd_info 
> *mtd, int section,
>  	return 0;
>  }
> 
> -const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
> +static const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
>  	.ecc = qi_lb60_ooblayout_ecc,
>  	.free = qi_lb60_ooblayout_free,
>  };
> --
> 2.17.1
> 
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static
@ 2020-04-10 15:47   ` Paul Cercueil
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Cercueil @ 2020-04-10 15:47 UTC (permalink / raw)
  To: YueHaibing
  Cc: vigneshr, richard, linux-kernel, harveyhuntnexus, linux-mtd,
	miquel.raynal

Hi,

Le ven. 10 avril 2020 à 19:51, YueHaibing <yuehaibing@huawei.com> a 
écrit :
> Fix sparse warning:
> 
> drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:105:32:
>  warning: symbol 'qi_lb60_ooblayout_ops' was not declared. Should it 
> be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks!
-Paul

> ---
>  drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c 
> b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> index 935c4902ada7..e7bd845fdbf5 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> @@ -102,7 +102,7 @@ static int qi_lb60_ooblayout_free(struct mtd_info 
> *mtd, int section,
>  	return 0;
>  }
> 
> -const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
> +static const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
>  	.ecc = qi_lb60_ooblayout_ecc,
>  	.free = qi_lb60_ooblayout_free,
>  };
> --
> 2.17.1
> 
> 



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static
  2020-04-10 11:51 ` YueHaibing
@ 2020-05-10 20:06   ` Miquel Raynal
  -1 siblings, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2020-05-10 20:06 UTC (permalink / raw)
  To: YueHaibing, harveyhuntnexus, paul, miquel.raynal, richard, vigneshr
  Cc: linux-mtd, linux-kernel

On Fri, 2020-04-10 at 11:51:21 UTC, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:105:32:
>  warning: symbol 'qi_lb60_ooblayout_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Paul Cercueil <paul@crapouillou.net>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static
@ 2020-05-10 20:06   ` Miquel Raynal
  0 siblings, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2020-05-10 20:06 UTC (permalink / raw)
  To: YueHaibing, harveyhuntnexus, paul, miquel.raynal, richard, vigneshr
  Cc: linux-mtd, linux-kernel

On Fri, 2020-04-10 at 11:51:21 UTC, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:105:32:
>  warning: symbol 'qi_lb60_ooblayout_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Paul Cercueil <paul@crapouillou.net>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-10 20:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 11:51 [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops static YueHaibing
2020-04-10 11:51 ` YueHaibing
2020-04-10 15:47 ` Paul Cercueil
2020-04-10 15:47   ` Paul Cercueil
2020-05-10 20:06 ` Miquel Raynal
2020-05-10 20:06   ` Miquel Raynal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.