* [PATCH] Input: adp5589-keys - Use the right header
@ 2021-08-16 23:27 Linus Walleij
2021-08-17 5:56 ` Hennerich, Michael
2021-08-30 21:23 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2021-08-16 23:27 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input
Cc: Linus Walleij, Michael Hennerich, Alexandru Ardelean
This keyboard driver is implementing a GPIO driver, so it need
to include <linux/gpio/driver.h> and not the legacy <linux/gpio.h>
header.
Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: Alexandru Ardelean <Alexandru.ardelean@analog.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/input/keyboard/adp5589-keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/adp5589-keys.c b/drivers/input/keyboard/adp5589-keys.c
index 654e0476406b..bdd264459a97 100644
--- a/drivers/input/keyboard/adp5589-keys.c
+++ b/drivers/input/keyboard/adp5589-keys.c
@@ -18,7 +18,7 @@
#include <linux/platform_device.h>
#include <linux/input.h>
#include <linux/i2c.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
#include <linux/slab.h>
#include <linux/input/adp5589.h>
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] Input: adp5589-keys - Use the right header
2021-08-16 23:27 [PATCH] Input: adp5589-keys - Use the right header Linus Walleij
@ 2021-08-17 5:56 ` Hennerich, Michael
2021-08-30 21:23 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Hennerich, Michael @ 2021-08-17 5:56 UTC (permalink / raw)
To: Linus Walleij, Dmitry Torokhov, linux-input; +Cc: Alexandru Ardelean
> -----Original Message-----
> From: Linus Walleij <linus.walleij@linaro.org>
> Sent: Dienstag, 17. August 2021 01:27
> To: Dmitry Torokhov <dmitry.torokhov@gmail.com>; linux-
> input@vger.kernel.org
> Cc: Linus Walleij <linus.walleij@linaro.org>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Alexandru Ardelean
> <Alexandru.ardelean@analog.com>
> Subject: [PATCH] Input: adp5589-keys - Use the right header
>
> This keyboard driver is implementing a GPIO driver, so it need to include
> <linux/gpio/driver.h> and not the legacy <linux/gpio.h> header.
>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Alexandru Ardelean <Alexandru.ardelean@analog.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/input/keyboard/adp5589-keys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/adp5589-keys.c
> b/drivers/input/keyboard/adp5589-keys.c
> index 654e0476406b..bdd264459a97 100644
> --- a/drivers/input/keyboard/adp5589-keys.c
> +++ b/drivers/input/keyboard/adp5589-keys.c
> @@ -18,7 +18,7 @@
> #include <linux/platform_device.h>
> #include <linux/input.h>
> #include <linux/i2c.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
> #include <linux/slab.h>
>
> #include <linux/input/adp5589.h>
> --
> 2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: adp5589-keys - Use the right header
2021-08-16 23:27 [PATCH] Input: adp5589-keys - Use the right header Linus Walleij
2021-08-17 5:56 ` Hennerich, Michael
@ 2021-08-30 21:23 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2021-08-30 21:23 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-input, Michael Hennerich, Alexandru Ardelean
On Tue, Aug 17, 2021 at 01:27:07AM +0200, Linus Walleij wrote:
> This keyboard driver is implementing a GPIO driver, so it need
> to include <linux/gpio/driver.h> and not the legacy <linux/gpio.h>
> header.
>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Alexandru Ardelean <Alexandru.ardelean@analog.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-30 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 23:27 [PATCH] Input: adp5589-keys - Use the right header Linus Walleij
2021-08-17 5:56 ` Hennerich, Michael
2021-08-30 21:23 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.