[PATCH] Input: adp5589-keys - Use the right header

[PATCH] Input: adp5589-keys - Use the right header

[Linus Walleij]

This keyboard driver is implementing a GPIO driver, so it need
to include <linux/gpio/driver.h> and not the legacy <linux/gpio.h>
header.

Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: Alexandru Ardelean <Alexandru.ardelean@analog.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/input/keyboard/adp5589-keys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/adp5589-keys.c b/drivers/input/keyboard/adp5589-keys.c
index 654e0476406b..bdd264459a97 100644
--- a/drivers/input/keyboard/adp5589-keys.c
+++ b/drivers/input/keyboard/adp5589-keys.c
@@ -18,7 +18,7 @@
 #include <linux/platform_device.h>
 #include <linux/input.h>
 #include <linux/i2c.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
 #include <linux/slab.h>
 
 #include <linux/input/adp5589.h>
-- 
2.31.1

RE: [PATCH] Input: adp5589-keys - Use the right header

[Hennerich, Michael]

> -----Original Message-----
> From: Linus Walleij <linus.walleij@linaro.org>
> Sent: Dienstag, 17. August 2021 01:27
> To: Dmitry Torokhov <dmitry.torokhov@gmail.com>; linux-
> input@vger.kernel.org
> Cc: Linus Walleij <linus.walleij@linaro.org>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Alexandru Ardelean
> <Alexandru.ardelean@analog.com>
> Subject: [PATCH] Input: adp5589-keys - Use the right header
>  
> This keyboard driver is implementing a GPIO driver, so it need to include
> <linux/gpio/driver.h> and not the legacy <linux/gpio.h> header.
> 
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Alexandru Ardelean <Alexandru.ardelean@analog.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/input/keyboard/adp5589-keys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/adp5589-keys.c
> b/drivers/input/keyboard/adp5589-keys.c
> index 654e0476406b..bdd264459a97 100644
> --- a/drivers/input/keyboard/adp5589-keys.c
> +++ b/drivers/input/keyboard/adp5589-keys.c
> @@ -18,7 +18,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/input.h>
>  #include <linux/i2c.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>  #include <linux/slab.h>
> 
>  #include <linux/input/adp5589.h>
> --
> 2.31.1

Re: [PATCH] Input: adp5589-keys - Use the right header

[Dmitry Torokhov]

On Tue, Aug 17, 2021 at 01:27:07AM +0200, Linus Walleij wrote:
> This keyboard driver is implementing a GPIO driver, so it need
> to include <linux/gpio/driver.h> and not the legacy <linux/gpio.h>
> header.
> 
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Alexandru Ardelean <Alexandru.ardelean@analog.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Applied, thank you.

-- 
Dmitry