All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: please drop the nvme code from net-next
@ 2021-06-08 19:51 ` Shai Malin
  0 siblings, 0 replies; 12+ messages in thread
From: Shai Malin @ 2021-06-08 19:51 UTC (permalink / raw)
  To: Keith Busch, David Miller
  Cc: hch, geert, axboe, sagi, Omkar Kulkarni, hare, Dean Balandin,
	himanshu.madhani, pmladek, linux-nvme, netdev, linux-kernel,
	malin1024


On Tue, Jun 08, 2021 at 10:41:00PM -0700, Keith Busch wrote:
> On Tue, Jun 08, 2021 at 12:08:39PM -0700, David Miller wrote:
> > From: Christoph Hellwig <hch@lst.de>
> > Date: Tue, 8 Jun 2021 15:43:03 +0200
> >
> > > please drop the nvme-offload code from net-next.  Code for drivers/nvme/
> > > needs ACKs from us nvme maintainers and for something this significant
> > > also needs to go through the NVMe tree.  And this code is not ready yet.
> >
> > Please send me a revert, and I will apply it, thank you.
> >
> > It's tricky because at least one driver uses the new interfaces.
> 
> Shouldn't whoever merged un-ACK'ed patches from a different subsystem
> get to own the tricky revert?

Dave, we will provide a revert patch.

^ permalink raw reply	[flat|nested] 12+ messages in thread
* RE: please drop the nvme code from net-next
@ 2021-06-08 15:56 ` Shai Malin
  0 siblings, 0 replies; 12+ messages in thread
From: Shai Malin @ 2021-06-08 15:56 UTC (permalink / raw)
  To: Christoph Hellwig, Geert Uytterhoeven
  Cc: David S . Miller, Keith Busch, Jens Axboe, Sagi Grimberg,
	Omkar Kulkarni, Hannes Reinecke, Dean Balandin, Himanshu Madhani,
	Petr Mladek, linux-nvme, netdev, Linux Kernel Mailing List


On Tue, Jun 8, 2021 at 4:38 PM Christoph Hellwig <hch@lst.de> wrote:
> Hi Dave,
> 
> please drop the nvme-offload code from net-next.  Code for drivers/nvme/
> needs ACKs from us nvme maintainers and for something this significant
> also needs to go through the NVMe tree.  And this code is not ready yet.

Hi all,

Sorry for any confusion we may have caused. Our plan was for the qed series 
to be considered for net-next, and for the nvme-tcp-offload series to be 
considered for nvme mailing list.
We attempted to communicate this in the cover letter and the addresses 
in to: vs. those in cc:, but perhaps this was not clear enough.

The plan was detailed in the cover latter under the "upstream plan" section 
https://lore.kernel.org/netdev/20210531225222.16992-1-smalin@marvell.com/
The series is structured in a modular way so that part 1 (nvme-tcp-offload) 
and part 2 (qed) are independent and part 3 (qedn) depends on both parts 1+2.

We have sent the first 2 parts which are independent:

- QED NVMeTCP Offload - https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=eda1bc65b0dc1b03006e427430ba23746ec44714
  This part includes the qed infrastructure which was discussed over the RFC.
  Our intent for this part was for it to be accepted to net-next, which it was.
  Dave, from our perspective this piece can stay in net-next.

- NVMeTCP Offload ULP - https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=5ff5622ea1f16d535f1be4e478e712ef48fe183b
  This is the nvme-tcp-offload ULP which we intended the NVMe tree,
  and it shouldn't be merged to net-next.
  Dave, please revert this from net-next until nvme maintainers are completely 
  satisfied with it.

Christoph, we would be more than happy to incorporate any feedback you may 
provide for any part of the series.

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
@ 2021-06-08 10:56 Geert Uytterhoeven
  2021-06-08 12:19 ` Christoph Hellwig
  0 siblings, 1 reply; 12+ messages in thread
From: Geert Uytterhoeven @ 2021-06-08 10:56 UTC (permalink / raw)
  To: David S . Miller, Keith Busch, Jens Axboe, Christoph Hellwig,
	Sagi Grimberg, Omkar Kulkarni, Hannes Reinecke, Dean Balandin,
	Himanshu Madhani, Shai Malin
  Cc: Petr Mladek, linux-nvme, netdev, linux-kernel, Geert Uytterhoeven

The help text for the symbol controlling support for the NVM Express
over Fabrics TCP offload common layer suggests to not enable this
support when unsure.

Hence drop the "default m", which actually means "default y" if
CONFIG_MODULES is not enabled.

Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/nvme/host/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index 9c6f4d776daf14cf..f76cc4690bfc37bc 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -88,7 +88,6 @@ config NVME_TCP
 
 config NVME_TCP_OFFLOAD
 	tristate "NVM Express over Fabrics TCP offload common layer"
-	default m
 	depends on BLOCK
 	depends on INET
 	select NVME_CORE
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-10-13  6:19 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 19:51 please drop the nvme code from net-next Shai Malin
2021-06-08 19:51 ` Shai Malin
2021-06-09 12:13 ` Shai Malin
2021-06-09 12:13   ` Shai Malin
  -- strict thread matches above, loose matches on Subject: below --
2021-06-08 15:56 Shai Malin
2021-06-08 15:56 ` Shai Malin
2021-06-08 10:56 [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m Geert Uytterhoeven
2021-06-08 12:19 ` Christoph Hellwig
2021-06-08 13:37   ` Geert Uytterhoeven
2021-06-08 13:43     ` please drop the nvme code from net-next Christoph Hellwig
2021-06-08 13:43       ` Christoph Hellwig
2021-06-08 19:08       ` David Miller
2021-06-08 19:08         ` David Miller
2021-06-08 19:40         ` Keith Busch
2021-06-08 19:40           ` Keith Busch

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.