From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
"uli@fpond.eu" <uli@fpond.eu>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Greg KH <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: RE: [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value
Date: Wed, 08 Aug 2018 00:16:05 +0000 [thread overview]
Message-ID: <TY1PR01MB1562BACED660584300228AA08A260@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWgJrPRh8TRTrEjWsaRAhEQX0T7M5eBGP_z3Ft=T6FfDg@mail.gmail.com>
SGkgR2VlcnQsDQoNCk9uIFR1ZXNkYXksIEF1Z3VzdCAwNywgMjAxOCwgR2VlcnQgVXl0dGVyaG9l
dmVuIHdyb3RlOg0KPiA+IEkgc2VlIHRoYXQgeW91IGFkZGVkIHRoaXM6DQo+ID4NCj4gPiBPRl9F
QVJMWUNPTl9ERUNMQVJFKHNjaWYsICJyZW5lc2FzLHNjaWYtcjdzOTIxMCIsDQo+IHJ6YTJfZWFy
bHlfY29uc29sZV9zZXR1cCk7DQo+ID4NCj4gPiAgYW5kICJyZW5lc2FzLHNjaWYtcjdzOTIxMCIg
bWF0Y2hlcyB3aGF0IEkgaGF2ZSBpbiBteSAuZHRzaS4NCj4gPg0KPiA+IEJ1dCwgd2hlbiBJIHJ1
biB0aGUgY29kZSwgSSBlbmQgdXAgaW4gZnVuY3Rpb24gc2NpZl9lYXJseV9jb25zb2xlX3NldHVw
LA0KPiA+IG5vdCByemEyX2Vhcmx5X2NvbnNvbGVfc2V0dXANCj4gDQo+IEhtbSwgcGVyaGFwcyBp
dCBkb2Vzbid0IHBpY2sgdGhlIGZpcnN0L21vc3Qgc3BlY2lhbGl6ZWQgbWF0Y2guDQoNCkl0IHNl
ZW1zIGl0IHBpY2tzIHRoZSBmaXJzdCBtYXRjaC4NCg0KQnV0LCB0aGUgdGFibGUgaXMgYnVpbHQg
aW4gdGhlIG9wcG9zaXRlIG9yZGVyIGluIHdoaWNoIHRoZXkgYXJlIGRlY2xhcmVkDQppbiB0aGUg
ZmlsZS4gU28gInJlbmVzYXMsc2NpZiIgd2FzIGNvbWluZyBiZWZvcmUgDQoicmVuZXNhcyxzY2lm
LXI3czkyMTAiLg0KDQpTbywgYnkganVzdCBzd2FwcGluZyB0aGUgb3JkZXIgb2YgInJlbmVzYXMs
c2NpZiIgYW5kIA0KInJlbmVzYXMsc2NpZi1yN3M5MjEwIiBtYWRlIGl0IHdvcmshDQoNCg0KLS0t
IGEvZHJpdmVycy90dHkvc2VyaWFsL3NoLXNjaS5jDQorKysgYi9kcml2ZXJzL3R0eS9zZXJpYWwv
c2gtc2NpLmMNCkBAIC0zNDIzLDggKzM0MjMsOCBAQCBzdGF0aWMgaW50IF9faW5pdCBoc2NpZl9l
YXJseV9jb25zb2xlX3NldHVwKHN0cnVjdCBlYXJseWNvbl9kZXZpY2UgKmRldmljZSwNCiB9DQog
DQogT0ZfRUFSTFlDT05fREVDTEFSRShzY2ksICJyZW5lc2FzLHNjaSIsIHNjaV9lYXJseV9jb25z
b2xlX3NldHVwKTsNCi1PRl9FQVJMWUNPTl9ERUNMQVJFKHNjaWYsICJyZW5lc2FzLHNjaWYtcjdz
OTIxMCIsIHJ6YTJfZWFybHlfY29uc29sZV9zZXR1cCk7DQogT0ZfRUFSTFlDT05fREVDTEFSRShz
Y2lmLCAicmVuZXNhcyxzY2lmIiwgc2NpZl9lYXJseV9jb25zb2xlX3NldHVwKTsNCitPRl9FQVJM
WUNPTl9ERUNMQVJFKHNjaWYsICJyZW5lc2FzLHNjaWYtcjdzOTIxMCIsIHJ6YTJfZWFybHlfY29u
c29sZV9zZXR1cCk7DQogT0ZfRUFSTFlDT05fREVDTEFSRShzY2lmYSwgInJlbmVzYXMsc2NpZmEi
LCBzY2lmYV9lYXJseV9jb25zb2xlX3NldHVwKTsNCiBPRl9FQVJMWUNPTl9ERUNMQVJFKHNjaWZi
LCAicmVuZXNhcyxzY2lmYiIsIHNjaWZiX2Vhcmx5X2NvbnNvbGVfc2V0dXApOw0KIE9GX0VBUkxZ
Q09OX0RFQ0xBUkUoaHNjaWYsICJyZW5lc2FzLGhzY2lmIiwgaHNjaWZfZWFybHlfY29uc29sZV9z
ZXR1cCk7DQoNCg0KICAtLSBsb2cgLS0NCkJvb3RpbmcgTGludXguLi4NClsgICAgMC4wMDAwMDBd
IEJvb3RpbmcgTGludXggb24gcGh5c2ljYWwgQ1BVIDB4MA0KWyAgICAwLjAwMDAwMF0gTGludXgg
dmVyc2lvbiA0LjE4LjAtcmM3LTAwMDE3LWc3MGNkYjRmMjQzYzYtZGlydHkgKGNocmlzQHVidW50
dSkgKGdjYyB2ZXJzaW9uIDUuNC4xIDIwMTYxMjEzIChMaW5hcm8gR0NDIDUuNC0yMDE3LjAxKSkg
IzIzIFR1ZSBBdWcgNyAxOTowNDoyNSBFU1QgMjAxOA0KWyAgICAwLjAwMDAwMF0gQ1BVOiBBUk12
NyBQcm9jZXNzb3IgWzQxNGZjMDkxXSByZXZpc2lvbiAxIChBUk12NyksIGNyPTUwYzUzYzdkDQpb
ICAgIDAuMDAwMDAwXSBDUFU6IFBJUFQgLyBWSVBUIG5vbmFsaWFzaW5nIGRhdGEgY2FjaGUsIFZJ
UFQgYWxpYXNpbmcgaW5zdHJ1Y3Rpb24gY2FjaGUNClsgICAgMC4wMDAwMDBdIE9GOiBmZHQ6IE1h
Y2hpbmUgbW9kZWw6IFJaQTJNRVZCDQpbICAgIDAuMDAwMDAwXSBkZWJ1ZzogaWdub3JpbmcgbG9n
bGV2ZWwgc2V0dGluZy4NClsgICAgMC4wMDAwMDBdIGVhcmx5Y29uOiBzY2lmMCBhdCBNTUlPIDB4
ZTgwMDkwMDAgKG9wdGlvbnMgJzExNTIwMG44JykNClsgICAgMC4wMDAwMDBdIGJvb3Rjb25zb2xl
IFtzY2lmMjU2XSBlbmFibGVkDQoNCg0KDQpDaHJpcw0KDQo
WARNING: multiple messages have this Message-ID (diff)
From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
"uli@fpond.eu" <uli@fpond.eu>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Greg KH <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: RE: [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value
Date: Wed, 8 Aug 2018 00:16:05 +0000 [thread overview]
Message-ID: <TY1PR01MB1562BACED660584300228AA08A260@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWgJrPRh8TRTrEjWsaRAhEQX0T7M5eBGP_z3Ft=T6FfDg@mail.gmail.com>
Hi Geert,
On Tuesday, August 07, 2018, Geert Uytterhoeven wrote:
> > I see that you added this:
> >
> > OF_EARLYCON_DECLARE(scif, "renesas,scif-r7s9210",
> rza2_early_console_setup);
> >
> > and "renesas,scif-r7s9210" matches what I have in my .dtsi.
> >
> > But, when I run the code, I end up in function scif_early_console_setup,
> > not rza2_early_console_setup
>
> Hmm, perhaps it doesn't pick the first/most specialized match.
It seems it picks the first match.
But, the table is built in the opposite order in which they are declared
in the file. So "renesas,scif" was coming before
"renesas,scif-r7s9210".
So, by just swapping the order of "renesas,scif" and
"renesas,scif-r7s9210" made it work!
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -3423,8 +3423,8 @@ static int __init hscif_early_console_setup(struct earlycon_device *device,
}
OF_EARLYCON_DECLARE(sci, "renesas,sci", sci_early_console_setup);
-OF_EARLYCON_DECLARE(scif, "renesas,scif-r7s9210", rza2_early_console_setup);
OF_EARLYCON_DECLARE(scif, "renesas,scif", scif_early_console_setup);
+OF_EARLYCON_DECLARE(scif, "renesas,scif-r7s9210", rza2_early_console_setup);
OF_EARLYCON_DECLARE(scifa, "renesas,scifa", scifa_early_console_setup);
OF_EARLYCON_DECLARE(scifb, "renesas,scifb", scifb_early_console_setup);
OF_EARLYCON_DECLARE(hscif, "renesas,hscif", hscif_early_console_setup);
-- log --
Booting Linux...
[ 0.000000] Booting Linux on physical CPU 0x0
[ 0.000000] Linux version 4.18.0-rc7-00017-g70cdb4f243c6-dirty (chris@ubuntu) (gcc version 5.4.1 20161213 (Linaro GCC 5.4-2017.01)) #23 Tue Aug 7 19:04:25 EST 2018
[ 0.000000] CPU: ARMv7 Processor [414fc091] revision 1 (ARMv7), cr=50c53c7d
[ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache
[ 0.000000] OF: fdt: Machine model: RZA2MEVB
[ 0.000000] debug: ignoring loglevel setting.
[ 0.000000] earlycon: scif0 at MMIO 0xe8009000 (options '115200n8')
[ 0.000000] bootconsole [scif256] enabled
Chris
next prev parent reply other threads:[~2018-08-08 0:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 14:07 [PATCH/RFC 0/4] sh-sci : Do not derive regshift from regsize Geert Uytterhoeven
2018-08-06 14:07 ` Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 1/4] sh-sci: Use a separate sci_port for earlycon Geert Uytterhoeven
2018-08-06 14:07 ` Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 2/4] sh-sci: Take into account regshift to fix earlycon breakage Geert Uytterhoeven
2018-08-06 14:07 ` Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 3/4] Revert "serial: sh-sci: Compute the regshift value for SCI ports" Geert Uytterhoeven
2018-08-06 14:07 ` Geert Uytterhoeven
2018-08-06 14:16 ` Laurent Pinchart
2018-08-06 14:16 ` Laurent Pinchart
2018-08-06 14:34 ` Geert Uytterhoeven
2018-08-06 14:34 ` Geert Uytterhoeven
2018-08-06 14:41 ` Laurent Pinchart
2018-08-06 14:41 ` Laurent Pinchart
2018-08-06 14:52 ` Geert Uytterhoeven
2018-08-06 14:52 ` Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value Geert Uytterhoeven
2018-08-06 14:07 ` Geert Uytterhoeven
2018-08-06 14:18 ` Chris Brandt
2018-08-06 14:18 ` Chris Brandt
2018-08-06 14:38 ` Geert Uytterhoeven
2018-08-06 14:38 ` Geert Uytterhoeven
2018-08-06 16:10 ` Chris Brandt
2018-08-06 16:10 ` Chris Brandt
2018-08-07 19:24 ` Chris Brandt
2018-08-07 19:24 ` Chris Brandt
2018-08-07 19:37 ` Geert Uytterhoeven
2018-08-07 19:37 ` Geert Uytterhoeven
2018-08-07 21:10 ` Chris Brandt
2018-08-07 21:10 ` Chris Brandt
2018-08-08 0:16 ` Chris Brandt [this message]
2018-08-08 0:16 ` Chris Brandt
2018-08-08 10:11 ` Geert Uytterhoeven
2018-08-08 10:11 ` Geert Uytterhoeven
2018-08-08 10:39 ` Chris Brandt
2018-08-08 10:39 ` Chris Brandt
2018-08-08 11:05 ` Geert Uytterhoeven
2018-08-08 11:05 ` Geert Uytterhoeven
2018-08-06 14:37 ` [PATCH/RFC 0/4] sh-sci : Do not derive regshift from regsize Laurent Pinchart
2018-08-06 14:37 ` Laurent Pinchart
2018-08-06 14:41 ` Laurent Pinchart
2018-08-06 14:41 ` Laurent Pinchart
2018-08-06 14:41 ` Geert Uytterhoeven
2018-08-06 14:41 ` Geert Uytterhoeven
2018-08-08 11:02 ` Geert Uytterhoeven
2018-08-08 11:02 ` Geert Uytterhoeven
2018-08-08 11:32 ` Chris Brandt
2018-08-08 11:32 ` Chris Brandt
2018-08-08 20:46 ` Chris Brandt
2018-08-08 20:46 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY1PR01MB1562BACED660584300228AA08A260@TY1PR01MB1562.jpnprd01.prod.outlook.com \
--to=chris.brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=uli@fpond.eu \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.