All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	"uli@fpond.eu" <uli@fpond.eu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Greg KH <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: RE: [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value
Date: Tue, 07 Aug 2018 19:24:30 +0000	[thread overview]
Message-ID: <TY1PR01MB1562F2D2FD1BF47A80B044028A270@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWfsdbmGUQPk4O=9jyPZ_tUEytO5z2XE6-TnagJ3taPVA@mail.gmail.com>

SGkgR2VlcnQsDQoNCk9uIE1vbmRheSwgQXVndXN0IDA2LCAyMDE4IDEsIEdlZXJ0IFV5dHRlcmhv
ZXZlbiB3cm90ZToNCj4gPiBJIGhhZCBhIHNpbXBsZSBwYXRjaCB0byBhZGQgc3VwcG9ydCBmb3Ig
Q09ORklHX0RFQlVHX0xMIGZvciBSWi9BMg0KPiA+IGJlY2F1c2UgZWFybHljb24gbmV2ZXIgd29y
a2VkIGJlY2F1c2Ugb2YgUlovQTIncyBkaWZmZXJlbnQgcmVnaXN0ZXINCj4gbG9jYXRpb25zLg0K
PiANCj4gWWVhaCwgc2NpX3Byb2JlX3JlZ21hcCgpIGFzc3VtZWQgdGhlIHdyb25nIHJlZ3R5cGUg
Zm9yIHlvdXIgVFlQRV9TQ0lGDQo+IHBvcnQuIFlvdSBuZWVkZWQgYW4gT0ZfRUFSTFlDT05fREVD
TEFSRSgpIGxpbmUgdGhhdCBhbHNvIGZpbGxlZCBpbg0KPiB0aGUgY29ycmVjdCByZWd0eXBlLg0K
DQoNCkkgZ2F2ZSB5b3VyIHBhdGNoIGEgdHJ5Lg0KV2hlbiBlYXJseWNvbiBpcyBlbmFibGVkLCBv
biBSWi9BMiwgaXQgZ2V0cyBzdHVjayBpbiBoZXJlOg0KDQpzdGF0aWMgdm9pZCBzY2lfcG9sbF9w
dXRfY2hhcihzdHJ1Y3QgdWFydF9wb3J0ICpwb3J0LCB1bnNpZ25lZCBjaGFyIGMpDQp7DQoJdW5z
aWduZWQgc2hvcnQgc3RhdHVzOw0KDQoJZG8gew0KCQlzdGF0dXMgPSBzZXJpYWxfcG9ydF9pbihw
b3J0LCBTQ3hTUik7DQoJfSB3aGlsZSAoIShzdGF0dXMgJiBTQ3hTUl9URHhFKHBvcnQpKSk7DQoN
CglzZXJpYWxfcG9ydF9vdXQocG9ydCwgU0N4VERSLCBjKTsNCglzY2lfY2xlYXJfU0N4U1IocG9y
dCwgU0N4U1JfVER4RV9DTEVBUihwb3J0KSAmIH5TQ3hTUl9URU5EKHBvcnQpKTsNCn0NCg0KDQpJ
IHNlZSB0aGF0IHlvdSBhZGRlZCB0aGlzOg0KDQpPRl9FQVJMWUNPTl9ERUNMQVJFKHNjaWYsICJy
ZW5lc2FzLHNjaWYtcjdzOTIxMCIsIHJ6YTJfZWFybHlfY29uc29sZV9zZXR1cCk7DQoNCiBhbmQg
InJlbmVzYXMsc2NpZi1yN3M5MjEwIiBtYXRjaGVzIHdoYXQgSSBoYXZlIGluIG15IC5kdHNpLg0K
DQpCdXQsIHdoZW4gSSBydW4gdGhlIGNvZGUsIEkgZW5kIHVwIGluIGZ1bmN0aW9uIHNjaWZfZWFy
bHlfY29uc29sZV9zZXR1cCwNCm5vdCByemEyX2Vhcmx5X2NvbnNvbGVfc2V0dXANCg0KSSdtIGFz
c3VtaW5nIEknbSBqdXN0IHN1cHBvc2VkIHRvIHVzZSB0aGlzIG9uIG15IGJvb3RhcmdzOg0KICAg
ZWFybHljb249c2NpZiwweEU4MDA5MDAwDQoNCg0KQ2hyaXMNCg0K

WARNING: multiple messages have this Message-ID (diff)
From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	"uli@fpond.eu" <uli@fpond.eu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Greg KH <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: RE: [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value
Date: Tue, 7 Aug 2018 19:24:30 +0000	[thread overview]
Message-ID: <TY1PR01MB1562F2D2FD1BF47A80B044028A270@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWfsdbmGUQPk4O=9jyPZ_tUEytO5z2XE6-TnagJ3taPVA@mail.gmail.com>

Hi Geert,

On Monday, August 06, 2018 1, Geert Uytterhoeven wrote:
> > I had a simple patch to add support for CONFIG_DEBUG_LL for RZ/A2
> > because earlycon never worked because of RZ/A2's different register
> locations.
> 
> Yeah, sci_probe_regmap() assumed the wrong regtype for your TYPE_SCIF
> port. You needed an OF_EARLYCON_DECLARE() line that also filled in
> the correct regtype.


I gave your patch a try.
When earlycon is enabled, on RZ/A2, it gets stuck in here:

static void sci_poll_put_char(struct uart_port *port, unsigned char c)
{
	unsigned short status;

	do {
		status = serial_port_in(port, SCxSR);
	} while (!(status & SCxSR_TDxE(port)));

	serial_port_out(port, SCxTDR, c);
	sci_clear_SCxSR(port, SCxSR_TDxE_CLEAR(port) & ~SCxSR_TEND(port));
}


I see that you added this:

OF_EARLYCON_DECLARE(scif, "renesas,scif-r7s9210", rza2_early_console_setup);

 and "renesas,scif-r7s9210" matches what I have in my .dtsi.

But, when I run the code, I end up in function scif_early_console_setup,
not rza2_early_console_setup

I'm assuming I'm just supposed to use this on my bootargs:
   earlycon=scif,0xE8009000


Chris


  parent reply	other threads:[~2018-08-07 19:24 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06 14:07 [PATCH/RFC 0/4] sh-sci : Do not derive regshift from regsize Geert Uytterhoeven
2018-08-06 14:07 ` Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 1/4] sh-sci: Use a separate sci_port for earlycon Geert Uytterhoeven
2018-08-06 14:07   ` Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 2/4] sh-sci: Take into account regshift to fix earlycon breakage Geert Uytterhoeven
2018-08-06 14:07   ` Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 3/4] Revert "serial: sh-sci: Compute the regshift value for SCI ports" Geert Uytterhoeven
2018-08-06 14:07   ` Geert Uytterhoeven
2018-08-06 14:16   ` Laurent Pinchart
2018-08-06 14:16     ` Laurent Pinchart
2018-08-06 14:34     ` Geert Uytterhoeven
2018-08-06 14:34       ` Geert Uytterhoeven
2018-08-06 14:41       ` Laurent Pinchart
2018-08-06 14:41         ` Laurent Pinchart
2018-08-06 14:52         ` Geert Uytterhoeven
2018-08-06 14:52           ` Geert Uytterhoeven
2018-08-06 14:07 ` [PATCH/RFC 4/4] sh-sci: Derive regshift value from DT compatible value Geert Uytterhoeven
2018-08-06 14:07   ` Geert Uytterhoeven
2018-08-06 14:18   ` Chris Brandt
2018-08-06 14:18     ` Chris Brandt
2018-08-06 14:38     ` Geert Uytterhoeven
2018-08-06 14:38       ` Geert Uytterhoeven
2018-08-06 16:10       ` Chris Brandt
2018-08-06 16:10         ` Chris Brandt
2018-08-07 19:24       ` Chris Brandt [this message]
2018-08-07 19:24         ` Chris Brandt
2018-08-07 19:37         ` Geert Uytterhoeven
2018-08-07 19:37           ` Geert Uytterhoeven
2018-08-07 21:10           ` Chris Brandt
2018-08-07 21:10             ` Chris Brandt
2018-08-08  0:16           ` Chris Brandt
2018-08-08  0:16             ` Chris Brandt
2018-08-08 10:11             ` Geert Uytterhoeven
2018-08-08 10:11               ` Geert Uytterhoeven
2018-08-08 10:39               ` Chris Brandt
2018-08-08 10:39                 ` Chris Brandt
2018-08-08 11:05                 ` Geert Uytterhoeven
2018-08-08 11:05                   ` Geert Uytterhoeven
2018-08-06 14:37 ` [PATCH/RFC 0/4] sh-sci : Do not derive regshift from regsize Laurent Pinchart
2018-08-06 14:37   ` Laurent Pinchart
2018-08-06 14:41   ` Laurent Pinchart
2018-08-06 14:41     ` Laurent Pinchart
2018-08-06 14:41   ` Geert Uytterhoeven
2018-08-06 14:41     ` Geert Uytterhoeven
2018-08-08 11:02 ` Geert Uytterhoeven
2018-08-08 11:02   ` Geert Uytterhoeven
2018-08-08 11:32   ` Chris Brandt
2018-08-08 11:32     ` Chris Brandt
2018-08-08 20:46   ` Chris Brandt
2018-08-08 20:46     ` Chris Brandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY1PR01MB1562F2D2FD1BF47A80B044028A270@TY1PR01MB1562.jpnprd01.prod.outlook.com \
    --to=chris.brandt@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=uli@fpond.eu \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.