All of lore.kernel.org
 help / color / mirror / Atom feed
From: <nobuhiro1.iwamatsu@toshiba.co.jp>
To: <cip-dev@lists.cip-project.org>, <uli@fpond.eu>
Subject: RE: [cip-dev] Coordinating stable reviews
Date: Tue, 28 Sep 2021 12:29:54 +0000	[thread overview]
Message-ID: <TYAPR01MB625208335CBDF511529323C492A89@TYAPR01MB6252.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210927100950.GA11971@amd>

Hi,

> -----Original Message-----
> From: cip-dev@lists.cip-project.org [mailto:cip-dev@lists.cip-project.org] On Behalf Of Pavel Machek
> Sent: Monday, September 27, 2021 7:10 PM
> To: uli@fpond.eu; cip-dev@lists.cip-project.org
> Subject: [cip-dev] Coordinating stable reviews
> 
> Hi!
> 
> It is good to review "stable" patches soon, because such reviews are
> more useful for the stable community, and because when bug is spotted,
> it is easier to get patch dropped in the 5.10.X-rc phase than waiting
> for 5.10.X release and then having patch reverted in 5.10.X+1.
> 
> Unfortunately, we don't have good system for coordinating reviews in
> -rc phase.
> 

It's different from the current system, but how about using patchwork?
Somehow forward the patch posted to stable@kernel.org as -rc to 
cip-dev and review it at patchwork.kernel.org. It doesn't meet all
requests because it can't be operated from the command line.

Also, as Ulrich wrote, I think it's a good idea to use gitlab.
I suggest a way to comment on the commit instead of using the gitlab wiki.
for example, we can comment on the following URL (commit). We need to investigate, 
but I think it can be manipulated from the command line using Gitlab's
API or libraries.

  https://gitlab.com/cip-project/cip-kernel/linux-cip/-/commit/d25b48d4d3ef1ce75ce5628a8a3ba60a2427090f

> There's a script (commit.py) that produces one-line-per-patch output
> suitable for review. One possibility would be to have shared place
> somewhere reviewers could tag "I'm working on these patches".
> 
> I don't believe lts-commit-list.git repository is suitable for that;
> format suitable for review is different from what we have in
> lts-commit-list, and there is going to be multiple updates per day in
> busy periods.
> 
> We don't really need commit messages for this. Actually, we don't
> really need to keep history, either. It would be good if system could
> be controlled from command line for easy scripting.
> 
> Any ideas what kind of service could be used for this?
> 
Best regards,
  Nobuhiro

WARNING: multiple messages have this Message-ID (diff)
From: "Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>
To: <cip-dev@lists.cip-project.org>, <uli@fpond.eu>
Subject: Re: [cip-dev] Coordinating stable reviews
Date: Tue, 28 Sep 2021 12:29:54 +0000	[thread overview]
Message-ID: <TYAPR01MB625208335CBDF511529323C492A89@TYAPR01MB6252.jpnprd01.prod.outlook.com> (raw)
Message-ID: <20210928122954.QV3NQ2fPySsxtm-rZYdul2gVSJEGImsutafVV5i44bI@z> (raw)
In-Reply-To: <20210927100950.GA11971@amd>

[-- Attachment #1: Type: text/plain, Size: 2108 bytes --]

Hi,

> -----Original Message-----
> From: cip-dev@lists.cip-project.org [mailto:cip-dev@lists.cip-project.org] On Behalf Of Pavel Machek
> Sent: Monday, September 27, 2021 7:10 PM
> To: uli@fpond.eu; cip-dev@lists.cip-project.org
> Subject: [cip-dev] Coordinating stable reviews
> 
> Hi!
> 
> It is good to review "stable" patches soon, because such reviews are
> more useful for the stable community, and because when bug is spotted,
> it is easier to get patch dropped in the 5.10.X-rc phase than waiting
> for 5.10.X release and then having patch reverted in 5.10.X+1.
> 
> Unfortunately, we don't have good system for coordinating reviews in
> -rc phase.
> 

It's different from the current system, but how about using patchwork?
Somehow forward the patch posted to stable@kernel.org as -rc to 
cip-dev and review it at patchwork.kernel.org. It doesn't meet all
requests because it can't be operated from the command line.

Also, as Ulrich wrote, I think it's a good idea to use gitlab.
I suggest a way to comment on the commit instead of using the gitlab wiki.
for example, we can comment on the following URL (commit). We need to investigate, 
but I think it can be manipulated from the command line using Gitlab's
API or libraries.

  https://gitlab.com/cip-project/cip-kernel/linux-cip/-/commit/d25b48d4d3ef1ce75ce5628a8a3ba60a2427090f

> There's a script (commit.py) that produces one-line-per-patch output
> suitable for review. One possibility would be to have shared place
> somewhere reviewers could tag "I'm working on these patches".
> 
> I don't believe lts-commit-list.git repository is suitable for that;
> format suitable for review is different from what we have in
> lts-commit-list, and there is going to be multiple updates per day in
> busy periods.
> 
> We don't really need commit messages for this. Actually, we don't
> really need to keep history, either. It would be good if system could
> be controlled from command line for easy scripting.
> 
> Any ideas what kind of service could be used for this?
> 
Best regards,
  Nobuhiro

[-- Attachment #2: Type: text/plain, Size: 429 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6755): https://lists.cip-project.org/g/cip-dev/message/6755
Mute This Topic: https://lists.cip-project.org/mt/85896746/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/10495289/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-


  parent reply	other threads:[~2021-09-28 12:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 10:09 Coordinating stable reviews Pavel Machek
2021-09-27 10:09 ` [cip-dev] " Pavel Machek
2021-09-27 10:43 ` Ulrich Hecht
2021-09-27 10:43   ` Ulrich Hecht
2021-09-28 12:29 ` nobuhiro1.iwamatsu [this message]
2021-09-28 12:29   ` Nobuhiro Iwamatsu
     [not found] <16A8A6032C9B7813.26412@lists.cip-project.org>
2021-09-27 10:17 ` Pavel Machek
2021-09-27 10:17   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB625208335CBDF511529323C492A89@TYAPR01MB6252.jpnprd01.prod.outlook.com \
    --to=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=cip-dev@lists.cip-project.org \
    --cc=uli@fpond.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.