* [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series
@ 2021-01-01 11:39 Adam Ford
2021-01-01 11:39 ` [PATCH 2/2] arm64: dts: renesas: rzg2: Add RPC-IF Support Adam Ford
2021-01-01 18:58 ` [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series Biju Das
0 siblings, 2 replies; 8+ messages in thread
From: Adam Ford @ 2021-01-01 11:39 UTC (permalink / raw)
To: linux-renesas-soc
Cc: aford, Adam Ford, Krzysztof Kozlowski, Rob Herring,
Geert Uytterhoeven, Magnus Damm, Sergei Shtylyov, linux-kernel,
devicetree
The RZ/G2 Series has the RPC-IF interface.
Update bindings to support: r8a774a1, r8a774b1, r8a774c0, and r8a774e1
Signed-off-by: Adam Ford <aford173@gmail.com>
---
.../bindings/memory-controllers/renesas,rpc-if.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
index 6d6ba608fd22..050c66af8c2c 100644
--- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
@@ -26,6 +26,10 @@ properties:
compatible:
items:
- enum:
+ - renesas,r8a774a1-rpc-if # RZ/G2M
+ - renesas,r8a774b1-rpc-if # RZ/G2N
+ - renesas,r8a774c0-rpc-if # RZ/G2E
+ - renesas,r8a774e1-rpc-if # RZ/G2H
- renesas,r8a77970-rpc-if # R-Car V3M
- renesas,r8a77980-rpc-if # R-Car V3H
- renesas,r8a77995-rpc-if # R-Car D3
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: rzg2: Add RPC-IF Support
2021-01-01 11:39 [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series Adam Ford
@ 2021-01-01 11:39 ` Adam Ford
2021-01-08 14:38 ` Geert Uytterhoeven
2021-01-01 18:58 ` [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series Biju Das
1 sibling, 1 reply; 8+ messages in thread
From: Adam Ford @ 2021-01-01 11:39 UTC (permalink / raw)
To: linux-renesas-soc
Cc: aford, Adam Ford, Krzysztof Kozlowski, Rob Herring,
Geert Uytterhoeven, Magnus Damm, Sergei Shtylyov, linux-kernel,
devicetree
The RZ/G2 series contain the SPI Multi I/O Bus Controller (RPC-IF).
Add the nodes, but make them disabled by default.
Signed-off-by: Adam Ford <aford173@gmail.com>
---
arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 17 +++++++++++++++++
arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 17 +++++++++++++++++
arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 17 +++++++++++++++++
arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 17 +++++++++++++++++
4 files changed, 68 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index d37ec42a1caa..5246f4d91e84 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -2302,6 +2302,23 @@ sdhi3: mmc@ee160000 {
status = "disabled";
};
+ rpc: spi@ee200000 {
+ compatible = "renesas,r8a774a1-rpc-if",
+ "renesas,rcar-gen3-rpc-if";
+ reg = <0 0xee200000 0 0x200>,
+ <0 0x08000000 0 0x4000000>,
+ <0 0xee208000 0 0x100>;
+ reg-names = "regs", "dirmap", "wbuf";
+ interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 917>;
+ clock-names = "rpc";
+ power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
+ resets = <&cpg 917>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
gic: interrupt-controller@f1010000 {
compatible = "arm,gic-400";
#interrupt-cells = <3>;
diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
index 83523916d360..5862aa2ad2bf 100644
--- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
@@ -2160,6 +2160,23 @@ sdhi3: mmc@ee160000 {
status = "disabled";
};
+ rpc: spi@ee200000 {
+ compatible = "renesas,r8a774b1-rpc-if",
+ "renesas,rcar-gen3-rpc-if";
+ reg = <0 0xee200000 0 0x200>,
+ <0 0x08000000 0 0x4000000>,
+ <0 0xee208000 0 0x100>;
+ reg-names = "regs", "dirmap", "wbuf";
+ interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 917>;
+ clock-names = "rpc";
+ power-domains = <&sysc R8A774B1_PD_ALWAYS_ON>;
+ resets = <&cpg 917>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
sata: sata@ee300000 {
compatible = "renesas,sata-r8a774b1",
"renesas,rcar-gen3-sata";
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index e0e54342cd4c..20fa3caa050e 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -1654,6 +1654,23 @@ sdhi3: mmc@ee160000 {
status = "disabled";
};
+ rpc: spi@ee200000 {
+ compatible = "renesas,r8a774c0-rpc-if",
+ "renesas,rcar-gen3-rpc-if";
+ reg = <0 0xee200000 0 0x200>,
+ <0 0x08000000 0 0x4000000>,
+ <0 0xee208000 0 0x100>;
+ reg-names = "regs", "dirmap", "wbuf";
+ interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 917>;
+ clock-names = "rpc";
+ power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+ resets = <&cpg 917>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
gic: interrupt-controller@f1010000 {
compatible = "arm,gic-400";
#interrupt-cells = <3>;
diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
index 1333b02d623a..9be94945af8c 100644
--- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
@@ -2393,6 +2393,23 @@ sdhi3: mmc@ee160000 {
status = "disabled";
};
+ rpc: spi@ee200000 {
+ compatible = "renesas,r8a774e1-rpc-if",
+ "renesas,rcar-gen3-rpc-if";
+ reg = <0 0xee200000 0 0x200>,
+ <0 0x08000000 0 0x4000000>,
+ <0 0xee208000 0 0x100>;
+ reg-names = "regs", "dirmap", "wbuf";
+ interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 917>;
+ clock-names = "rpc";
+ power-domains = <&sysc R8A774E1_PD_ALWAYS_ON>;
+ resets = <&cpg 917>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
sata: sata@ee300000 {
compatible = "renesas,sata-r8a774e1",
"renesas,rcar-gen3-sata";
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series
2021-01-01 11:39 [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series Adam Ford
2021-01-01 11:39 ` [PATCH 2/2] arm64: dts: renesas: rzg2: Add RPC-IF Support Adam Ford
@ 2021-01-01 18:58 ` Biju Das
2021-01-01 21:34 ` Adam Ford
1 sibling, 1 reply; 8+ messages in thread
From: Biju Das @ 2021-01-01 18:58 UTC (permalink / raw)
To: Adam Ford, linux-renesas-soc
Cc: aford, Krzysztof Kozlowski, Rob Herring, Geert Uytterhoeven,
Magnus Damm, Sergei Shtylyov, linux-kernel, devicetree
Hi Adam,
Thanks for the patch.
> -----Original Message-----
> From: Adam Ford <aford173@gmail.com>
> Sent: 01 January 2021 11:39
> To: linux-renesas-soc@vger.kernel.org
> Cc: aford@beaconembedded.com; Adam Ford <aford173@gmail.com>; Krzysztof
> Kozlowski <krzk@kernel.org>; Rob Herring <robh+dt@kernel.org>; Geert
> Uytterhoeven <geert+renesas@glider.be>; Magnus Damm
> <magnus.damm@gmail.com>; Sergei Shtylyov <sergei.shtylyov@gmail.com>;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for
> RZ/G2 Series
>
> The RZ/G2 Series has the RPC-IF interface.
> Update bindings to support: r8a774a1, r8a774b1, r8a774c0, and r8a774e1
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> .../bindings/memory-controllers/renesas,rpc-if.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-
> controllers/renesas,rpc-if.yaml
> b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> index 6d6ba608fd22..050c66af8c2c 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-
> if.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-
> if.yaml
> @@ -26,6 +26,10 @@ properties:
> compatible:
> items:
> - enum:
> + - renesas,r8a774a1-rpc-if # RZ/G2M
> + - renesas,r8a774b1-rpc-if # RZ/G2N
> + - renesas,r8a774c0-rpc-if # RZ/G2E
> + - renesas,r8a774e1-rpc-if # RZ/G2H
> - renesas,r8a77970-rpc-if # R-Car V3M
> - renesas,r8a77980-rpc-if # R-Car V3H
> - renesas,r8a77995-rpc-if # R-Car D3
May be we need to update the below description as well to cover RZ/G2 device??
- const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 device
Cheers,
Biju
> --
> 2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series
2021-01-01 18:58 ` [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series Biju Das
@ 2021-01-01 21:34 ` Adam Ford
2021-01-02 8:08 ` Biju Das
2021-01-02 8:13 ` Biju Das
0 siblings, 2 replies; 8+ messages in thread
From: Adam Ford @ 2021-01-01 21:34 UTC (permalink / raw)
To: Biju Das
Cc: linux-renesas-soc, aford, Krzysztof Kozlowski, Rob Herring,
Geert Uytterhoeven, Magnus Damm, Sergei Shtylyov, linux-kernel,
devicetree
On Fri, Jan 1, 2021 at 12:58 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> Hi Adam,
>
> Thanks for the patch.
>
> > -----Original Message-----
> > From: Adam Ford <aford173@gmail.com>
> > Sent: 01 January 2021 11:39
> > To: linux-renesas-soc@vger.kernel.org
> > Cc: aford@beaconembedded.com; Adam Ford <aford173@gmail.com>; Krzysztof
> > Kozlowski <krzk@kernel.org>; Rob Herring <robh+dt@kernel.org>; Geert
> > Uytterhoeven <geert+renesas@glider.be>; Magnus Damm
> > <magnus.damm@gmail.com>; Sergei Shtylyov <sergei.shtylyov@gmail.com>;
> > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> > Subject: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for
> > RZ/G2 Series
> >
> > The RZ/G2 Series has the RPC-IF interface.
> > Update bindings to support: r8a774a1, r8a774b1, r8a774c0, and r8a774e1
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > .../bindings/memory-controllers/renesas,rpc-if.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/memory-
> > controllers/renesas,rpc-if.yaml
> > b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > index 6d6ba608fd22..050c66af8c2c 100644
> > --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-
> > if.yaml
> > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-
> > if.yaml
> > @@ -26,6 +26,10 @@ properties:
> > compatible:
> > items:
> > - enum:
> > + - renesas,r8a774a1-rpc-if # RZ/G2M
> > + - renesas,r8a774b1-rpc-if # RZ/G2N
> > + - renesas,r8a774c0-rpc-if # RZ/G2E
> > + - renesas,r8a774e1-rpc-if # RZ/G2H
> > - renesas,r8a77970-rpc-if # R-Car V3M
> > - renesas,r8a77980-rpc-if # R-Car V3H
> > - renesas,r8a77995-rpc-if # R-Car D3
>
> May be we need to update the below description as well to cover RZ/G2 device??
>
> - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 device
How do you want it to read?
adam
>
> Cheers,
> Biju
>
>
> > --
> > 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series
2021-01-01 21:34 ` Adam Ford
@ 2021-01-02 8:08 ` Biju Das
2021-01-02 8:13 ` Biju Das
1 sibling, 0 replies; 8+ messages in thread
From: Biju Das @ 2021-01-02 8:08 UTC (permalink / raw)
To: Adam Ford
Cc: linux-renesas-soc, aford, Krzysztof Kozlowski, Rob Herring,
Geert Uytterhoeven, Magnus Damm, Sergei Shtylyov, linux-kernel,
devicetree
> Subject: Re: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support
> for RZ/G2 Series
>
> On Fri, Jan 1, 2021 at 12:58 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> >
> > Hi Adam,
> >
> > Thanks for the patch.
> >
> > > -----Original Message-----
> > > From: Adam Ford <aford173@gmail.com>
> > > Sent: 01 January 2021 11:39
> > > To: linux-renesas-soc@vger.kernel.org
> > > Cc: aford@beaconembedded.com; Adam Ford <aford173@gmail.com>;
> > > Krzysztof Kozlowski <krzk@kernel.org>; Rob Herring
> > > <robh+dt@kernel.org>; Geert Uytterhoeven <geert+renesas@glider.be>;
> > > Magnus Damm <magnus.damm@gmail.com>; Sergei Shtylyov
> > > <sergei.shtylyov@gmail.com>; linux-kernel@vger.kernel.org;
> > > devicetree@vger.kernel.org
> > > Subject: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add
> > > support for
> > > RZ/G2 Series
> > >
> > > The RZ/G2 Series has the RPC-IF interface.
> > > Update bindings to support: r8a774a1, r8a774b1, r8a774c0, and
> > > r8a774e1
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > ---
> > > .../bindings/memory-controllers/renesas,rpc-if.yaml | 4
> ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/memory-
> > > controllers/renesas,rpc-if.yaml
> > > b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-i
> > > f.yaml index 6d6ba608fd22..050c66af8c2c 100644
> > > ---
> > > a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-
> > > if.yaml
> > > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,r
> > > +++ pc-
> > > if.yaml
> > > @@ -26,6 +26,10 @@ properties:
> > > compatible:
> > > items:
> > > - enum:
> > > + - renesas,r8a774a1-rpc-if # RZ/G2M
> > > + - renesas,r8a774b1-rpc-if # RZ/G2N
> > > + - renesas,r8a774c0-rpc-if # RZ/G2E
> > > + - renesas,r8a774e1-rpc-if # RZ/G2H
> > > - renesas,r8a77970-rpc-if # R-Car V3M
> > > - renesas,r8a77980-rpc-if # R-Car V3H
> > > - renesas,r8a77995-rpc-if # R-Car D3
> >
> > May be we need to update the below description as well to cover RZ/G2
> device??
> >
> > - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 device
Since it is generic compatible string for both R-Car gen3 and RZ/G2 device, I would update the description as
- const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 or RZ/G2 device
Also may be we need to update the description of config RENESAS_RPCIF in drivers/memory/Kconfig to taken care of RZ/G2 devices in a separate patch.
Cheers,
Biju
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series
2021-01-01 21:34 ` Adam Ford
2021-01-02 8:08 ` Biju Das
@ 2021-01-02 8:13 ` Biju Das
2021-01-02 11:31 ` Adam Ford
1 sibling, 1 reply; 8+ messages in thread
From: Biju Das @ 2021-01-02 8:13 UTC (permalink / raw)
To: Adam Ford
Cc: linux-renesas-soc, aford, Krzysztof Kozlowski, Rob Herring,
Geert Uytterhoeven, Magnus Damm, Sergei Shtylyov, linux-kernel,
devicetree
> -----Original Message-----
> From: Adam Ford <aford173@gmail.com>
> Sent: 01 January 2021 21:34
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: linux-renesas-soc@vger.kernel.org; aford@beaconembedded.com; Krzysztof
> Kozlowski <krzk@kernel.org>; Rob Herring <robh+dt@kernel.org>; Geert
> Uytterhoeven <geert+renesas@glider.be>; Magnus Damm
> <magnus.damm@gmail.com>; Sergei Shtylyov <sergei.shtylyov@gmail.com>;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support
> for RZ/G2 Series
>
> On Fri, Jan 1, 2021 at 12:58 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> >
> > Hi Adam,
> >
> > Thanks for the patch.
> >
> > > -----Original Message-----
> > > From: Adam Ford <aford173@gmail.com>
> > > Sent: 01 January 2021 11:39
> > > To: linux-renesas-soc@vger.kernel.org
> > > Cc: aford@beaconembedded.com; Adam Ford <aford173@gmail.com>;
> > > Krzysztof Kozlowski <krzk@kernel.org>; Rob Herring
> > > <robh+dt@kernel.org>; Geert Uytterhoeven <geert+renesas@glider.be>;
> > > Magnus Damm <magnus.damm@gmail.com>; Sergei Shtylyov
> > > <sergei.shtylyov@gmail.com>; linux-kernel@vger.kernel.org;
> > > devicetree@vger.kernel.org
> > > Subject: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add
> > > support for
> > > RZ/G2 Series
> > >
> > > The RZ/G2 Series has the RPC-IF interface.
> > > Update bindings to support: r8a774a1, r8a774b1, r8a774c0, and
> > > r8a774e1
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > ---
> > > .../bindings/memory-controllers/renesas,rpc-if.yaml | 4
> ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/memory-
> > > controllers/renesas,rpc-if.yaml
> > > b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-i
> > > f.yaml index 6d6ba608fd22..050c66af8c2c 100644
> > > ---
> > > a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-
> > > if.yaml
> > > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,r
> > > +++ pc-
> > > if.yaml
> > > @@ -26,6 +26,10 @@ properties:
> > > compatible:
> > > items:
> > > - enum:
> > > + - renesas,r8a774a1-rpc-if # RZ/G2M
> > > + - renesas,r8a774b1-rpc-if # RZ/G2N
> > > + - renesas,r8a774c0-rpc-if # RZ/G2E
> > > + - renesas,r8a774e1-rpc-if # RZ/G2H
> > > - renesas,r8a77970-rpc-if # R-Car V3M
> > > - renesas,r8a77980-rpc-if # R-Car V3H
> > > - renesas,r8a77995-rpc-if # R-Car D3
> >
> > May be we need to update the below description as well to cover RZ/G2
> device??
> >
> > - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 device
>
> How do you want it to read?
Since it is generic compatible string for both R-Car gen3 and RZ/G2 device, I would update the description as
- const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 or RZ/G2 device
Also may be we need to update the description of config RENESAS_RPCIF in drivers/memory/Kconfig to taken care of RZ/G2 devices in a separate patch.
Cheers,
Biju
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series
2021-01-02 8:13 ` Biju Das
@ 2021-01-02 11:31 ` Adam Ford
0 siblings, 0 replies; 8+ messages in thread
From: Adam Ford @ 2021-01-02 11:31 UTC (permalink / raw)
To: Biju Das
Cc: linux-renesas-soc, aford, Krzysztof Kozlowski, Rob Herring,
Geert Uytterhoeven, Magnus Damm, Sergei Shtylyov, linux-kernel,
devicetree
On Sat, Jan 2, 2021 at 2:13 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Adam Ford <aford173@gmail.com>
> > Sent: 01 January 2021 21:34
> > To: Biju Das <biju.das.jz@bp.renesas.com>
> > Cc: linux-renesas-soc@vger.kernel.org; aford@beaconembedded.com; Krzysztof
> > Kozlowski <krzk@kernel.org>; Rob Herring <robh+dt@kernel.org>; Geert
> > Uytterhoeven <geert+renesas@glider.be>; Magnus Damm
> > <magnus.damm@gmail.com>; Sergei Shtylyov <sergei.shtylyov@gmail.com>;
> > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> > Subject: Re: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support
> > for RZ/G2 Series
> >
> > On Fri, Jan 1, 2021 at 12:58 PM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > >
> > > Hi Adam,
> > >
> > > Thanks for the patch.
> > >
> > > > -----Original Message-----
> > > > From: Adam Ford <aford173@gmail.com>
> > > > Sent: 01 January 2021 11:39
> > > > To: linux-renesas-soc@vger.kernel.org
> > > > Cc: aford@beaconembedded.com; Adam Ford <aford173@gmail.com>;
> > > > Krzysztof Kozlowski <krzk@kernel.org>; Rob Herring
> > > > <robh+dt@kernel.org>; Geert Uytterhoeven <geert+renesas@glider.be>;
> > > > Magnus Damm <magnus.damm@gmail.com>; Sergei Shtylyov
> > > > <sergei.shtylyov@gmail.com>; linux-kernel@vger.kernel.org;
> > > > devicetree@vger.kernel.org
> > > > Subject: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add
> > > > support for
> > > > RZ/G2 Series
> > > >
> > > > The RZ/G2 Series has the RPC-IF interface.
> > > > Update bindings to support: r8a774a1, r8a774b1, r8a774c0, and
> > > > r8a774e1
> > > >
> > > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > > ---
> > > > .../bindings/memory-controllers/renesas,rpc-if.yaml | 4
> > ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/memory-
> > > > controllers/renesas,rpc-if.yaml
> > > > b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-i
> > > > f.yaml index 6d6ba608fd22..050c66af8c2c 100644
> > > > ---
> > > > a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-
> > > > if.yaml
> > > > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,r
> > > > +++ pc-
> > > > if.yaml
> > > > @@ -26,6 +26,10 @@ properties:
> > > > compatible:
> > > > items:
> > > > - enum:
> > > > + - renesas,r8a774a1-rpc-if # RZ/G2M
> > > > + - renesas,r8a774b1-rpc-if # RZ/G2N
> > > > + - renesas,r8a774c0-rpc-if # RZ/G2E
> > > > + - renesas,r8a774e1-rpc-if # RZ/G2H
> > > > - renesas,r8a77970-rpc-if # R-Car V3M
> > > > - renesas,r8a77980-rpc-if # R-Car V3H
> > > > - renesas,r8a77995-rpc-if # R-Car D3
> > >
> > > May be we need to update the below description as well to cover RZ/G2
> > device??
> > >
> > > - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 device
> >
> > How do you want it to read?
>
> Since it is generic compatible string for both R-Car gen3 and RZ/G2 device, I would update the description as
>
> - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 or RZ/G2 device
>
> Also may be we need to update the description of config RENESAS_RPCIF in drivers/memory/Kconfig to taken care of RZ/G2 devices in a separate patch.
>
Thanks for the suggestion. I'll work on V2 where I update the
descriptions for both.
adam
> Cheers,
> Biju
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: rzg2: Add RPC-IF Support
2021-01-01 11:39 ` [PATCH 2/2] arm64: dts: renesas: rzg2: Add RPC-IF Support Adam Ford
@ 2021-01-08 14:38 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2021-01-08 14:38 UTC (permalink / raw)
To: Adam Ford
Cc: Linux-Renesas, Adam Ford-BE, Krzysztof Kozlowski, Rob Herring,
Magnus Damm, Sergei Shtylyov, Linux Kernel Mailing List,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Fri, Jan 1, 2021 at 12:39 PM Adam Ford <aford173@gmail.com> wrote:
> The RZ/G2 series contain the SPI Multi I/O Bus Controller (RPC-IF).
> Add the nodes, but make them disabled by default.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.12.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-01-08 14:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-01 11:39 [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series Adam Ford
2021-01-01 11:39 ` [PATCH 2/2] arm64: dts: renesas: rzg2: Add RPC-IF Support Adam Ford
2021-01-08 14:38 ` Geert Uytterhoeven
2021-01-01 18:58 ` [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series Biju Das
2021-01-01 21:34 ` Adam Ford
2021-01-02 8:08 ` Biju Das
2021-01-02 8:13 ` Biju Das
2021-01-02 11:31 ` Adam Ford
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.