From: Horia Geanta <horia.geanta@nxp.com> To: Christoph Hellwig <hch@lst.de>, Marek Szyprowski <m.szyprowski@samsung.com>, Robin Murphy <robin.murphy@arm.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, dl-linux-imx <linux-imx@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Device obligation to write into a DMA_FROM_DEVICE streaming DMA mapping Date: Tue, 21 May 2019 17:14:12 +0000 [thread overview] Message-ID: <VI1PR0402MB348537CB86926B3E6D1DBE0A98070@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw) Hi, Is it mandatory for a device to write data in an area DMA mapped DMA_FROM_DEVICE? Can't the device just "ignore" that mapping - i.e. not write anything - and driver should expect original data to be found in that location (since it was not touched / written to by the device)? [Let's leave cache coherency aside, and consider "original data" to be in RAM.] I am asking this since I am seeing what seems to be an inconsistent behavior / semantics between cases when swiotlb bouncing is used and when it's not. Specifically, the context is: 1. driver prepares a scatterlist with several entries and performs a dma_map_sg() with direction FROM_DEVICE 2. device decides there's no need to write into the buffer pointed by first scatterlist entry and skips it (writing into subsequent buffers) 3. driver is notified the device finished processing and dma unmaps the scatterlist When swiotlb bounce is used, the buffer pointed to by first scatterlist entry is corrupted. That's because swiotlb implementation expects the device to write something into that buffer, however the device logic is "whatever was previously in that buffer should be used" (2. above). For FROM_DEVICE direction: -swiotlb_tbl_map_single() does not copy data from original location to swiotlb if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && (dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL)) swiotlb_bounce(orig_addr, tlb_addr, size, DMA_TO_DEVICE); -swiotlb_tbl_unmap_single() copies data from swiotlb to original location if (orig_addr != INVALID_PHYS_ADDR && !(attrs & DMA_ATTR_SKIP_CPU_SYNC) && ((dir == DMA_FROM_DEVICE) || (dir == DMA_BIDIRECTIONAL))) swiotlb_bounce(orig_addr, tlb_addr, size, DMA_FROM_DEVICE); and when device did not write anything (as in current situation), it overwrites original data with zeros In case swiotlb bounce is not used and device does not write into the FROM_DEVICE streaming DMA maping, the original data is available. Could you please clarify whether: -I am missing something obvious OR -the DMA API documentation should be updated - to mandate for device writes into FROM_DEVICE mappings) OR -the swiotlb implementation should be updated - to copy data from original location irrespective of DMA mapping direction? Thanks, Horia
WARNING: multiple messages have this Message-ID (diff)
From: Horia Geanta <horia.geanta@nxp.com> To: Christoph Hellwig <hch@lst.de>, Marek Szyprowski <m.szyprowski@samsung.com>, Robin Murphy <robin.murphy@arm.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, dl-linux-imx <linux-imx@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Device obligation to write into a DMA_FROM_DEVICE streaming DMA mapping Date: Tue, 21 May 2019 17:14:12 +0000 [thread overview] Message-ID: <VI1PR0402MB348537CB86926B3E6D1DBE0A98070@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw) Hi, Is it mandatory for a device to write data in an area DMA mapped DMA_FROM_DEVICE? Can't the device just "ignore" that mapping - i.e. not write anything - and driver should expect original data to be found in that location (since it was not touched / written to by the device)? [Let's leave cache coherency aside, and consider "original data" to be in RAM.] I am asking this since I am seeing what seems to be an inconsistent behavior / semantics between cases when swiotlb bouncing is used and when it's not. Specifically, the context is: 1. driver prepares a scatterlist with several entries and performs a dma_map_sg() with direction FROM_DEVICE 2. device decides there's no need to write into the buffer pointed by first scatterlist entry and skips it (writing into subsequent buffers) 3. driver is notified the device finished processing and dma unmaps the scatterlist When swiotlb bounce is used, the buffer pointed to by first scatterlist entry is corrupted. That's because swiotlb implementation expects the device to write something into that buffer, however the device logic is "whatever was previously in that buffer should be used" (2. above). For FROM_DEVICE direction: -swiotlb_tbl_map_single() does not copy data from original location to swiotlb if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && (dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL)) swiotlb_bounce(orig_addr, tlb_addr, size, DMA_TO_DEVICE); -swiotlb_tbl_unmap_single() copies data from swiotlb to original location if (orig_addr != INVALID_PHYS_ADDR && !(attrs & DMA_ATTR_SKIP_CPU_SYNC) && ((dir == DMA_FROM_DEVICE) || (dir == DMA_BIDIRECTIONAL))) swiotlb_bounce(orig_addr, tlb_addr, size, DMA_FROM_DEVICE); and when device did not write anything (as in current situation), it overwrites original data with zeros In case swiotlb bounce is not used and device does not write into the FROM_DEVICE streaming DMA maping, the original data is available. Could you please clarify whether: -I am missing something obvious OR -the DMA API documentation should be updated - to mandate for device writes into FROM_DEVICE mappings) OR -the swiotlb implementation should be updated - to copy data from original location irrespective of DMA mapping direction? Thanks, Horia _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2019-05-21 17:14 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-21 17:14 Horia Geanta [this message] 2019-05-21 17:14 ` Device obligation to write into a DMA_FROM_DEVICE streaming DMA mapping Horia Geanta 2019-05-21 17:27 ` Robin Murphy 2019-05-21 17:27 ` Robin Murphy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VI1PR0402MB348537CB86926B3E6D1DBE0A98070@VI1PR0402MB3485.eurprd04.prod.outlook.com \ --to=horia.geanta@nxp.com \ --cc=hch@lst.de \ --cc=iommu@lists.linux-foundation.org \ --cc=konrad.wilk@oracle.com \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=robin.murphy@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.