From: Peter Chen <peter.chen@nxp.com>
To: Fabio Estevam <festevam@gmail.com>,
"frieder.schrempf@kontron.de" <frieder.schrempf@kontron.de>
Cc: USB list <linux-usb@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Schrempf Frieder <frieder.schrempf@exceet.de>
Subject: RE: [PATCH v2 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
Date: Tue, 23 Oct 2018 05:59:22 +0000 [thread overview]
Message-ID: <VI1PR04MB532702FECD4C9E80312E7B7C8BF50@VI1PR04MB5327.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAOMZO5BsT40T+BH35Wx6fZwJDad+QAqTy9jyJK0bvBJFa0QO8w@mail.gmail.com>
> On Mon, Oct 22, 2018 at 11:55 AM Schrempf Frieder
> <frieder.schrempf@kontron.de> wrote:
>
> > I think you forgot to improve this description. Maybe something like this:
> >
> > pinctrl-names: Names for optional pin modes for "default", "host" or
> > "device". In case of HSIC-mode "idle" and "active" pin
> > modes are mandatory. In this case the "idle" state needs
> > to pull down the data and strobe pin and the "active"
> > state needs to pull up the strobe pin.
>
> Correct, and the dts example is also missing.
Thanks, both. Will do your comments.
Peter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@nxp.com>
To: Fabio Estevam <festevam@gmail.com>,
"frieder.schrempf@kontron.de" <frieder.schrempf@kontron.de>
Cc: USB list <linux-usb@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Schrempf Frieder <frieder.schrempf@exceet.de>
Subject: [v2,4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
Date: Tue, 23 Oct 2018 05:59:22 +0000 [thread overview]
Message-ID: <VI1PR04MB532702FECD4C9E80312E7B7C8BF50@VI1PR04MB5327.eurprd04.prod.outlook.com> (raw)
> On Mon, Oct 22, 2018 at 11:55 AM Schrempf Frieder
> <frieder.schrempf@kontron.de> wrote:
>
> > I think you forgot to improve this description. Maybe something like this:
> >
> > pinctrl-names: Names for optional pin modes for "default", "host" or
> > "device". In case of HSIC-mode "idle" and "active" pin
> > modes are mandatory. In this case the "idle" state needs
> > to pull down the data and strobe pin and the "active"
> > state needs to pull up the strobe pin.
>
> Correct, and the dts example is also missing.
Thanks, both. Will do your comments.
Peter
next prev parent reply other threads:[~2018-10-23 14:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 5:42 [PATCH v2 0/4] usb: chipidea: imx: add HSIC support Peter Chen
2018-10-22 5:42 ` [PATCH v2 1/4] usb: chipidea: add flag for imx hsic implementation Peter Chen
2018-10-22 5:42 ` [v2,1/4] " Peter Chen
2018-11-05 8:52 ` [PATCH v2 1/4] " Schrempf Frieder
2018-11-05 8:52 ` [v2,1/4] " Frieder Schrempf
2018-11-05 9:31 ` [PATCH v2 1/4] " Peter Chen
2018-11-05 9:31 ` [v2,1/4] " Peter Chen
2018-10-22 5:43 ` [PATCH v2 2/4] usb: chipidea: imx: add HSIC support Peter Chen
2018-10-22 5:43 ` [v2,2/4] " Peter Chen
2018-11-05 8:52 ` [PATCH v2 2/4] " Schrempf Frieder
2018-11-05 8:52 ` [v2,2/4] " Frieder Schrempf
2018-11-05 9:40 ` [PATCH v2 2/4] " Peter Chen
2018-11-05 9:40 ` [v2,2/4] " Peter Chen
2018-10-22 5:43 ` [PATCH v2 3/4] usb: chipidea: host: override ehci->hub_control Peter Chen
2018-10-22 5:43 ` [v2,3/4] " Peter Chen
2018-10-22 5:43 ` [PATCH v2 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups Peter Chen
2018-10-22 5:43 ` [v2,4/4] " Peter Chen
2018-10-22 14:54 ` [PATCH v2 4/4] " Schrempf Frieder
2018-10-22 14:54 ` [v2,4/4] " Frieder Schrempf
2018-10-22 14:59 ` [PATCH v2 4/4] " Fabio Estevam
2018-10-22 14:59 ` [v2,4/4] " Fabio Estevam
2018-10-23 5:59 ` Peter Chen [this message]
2018-10-23 5:59 ` Peter Chen
2018-10-23 6:30 ` [PATCH v2 0/4] usb: chipidea: imx: add HSIC support Schrempf Frieder
2018-10-23 6:33 ` Peter Chen
2018-11-05 8:52 ` Schrempf Frieder
2018-11-19 8:36 ` Schrempf Frieder
2018-11-20 2:11 ` PETER CHEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB532702FECD4C9E80312E7B7C8BF50@VI1PR04MB5327.eurprd04.prod.outlook.com \
--to=peter.chen@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@exceet.de \
--cc=frieder.schrempf@kontron.de \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.