From: Peter Chen <peter.chen@nxp.com> To: Schrempf Frieder <frieder.schrempf@kontron.De>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org> Cc: dl-linux-imx <linux-imx@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "frieder.schrempf@exceet.de" <frieder.schrempf@exceet.de>, "festevam@gmail.com" <festevam@gmail.com> Subject: RE: [PATCH v2 1/4] usb: chipidea: add flag for imx hsic implementation Date: Mon, 5 Nov 2018 09:31:04 +0000 [thread overview] Message-ID: <VI1PR04MB532767CCE7618D9950FBC0418BCA0@VI1PR04MB5327.eurprd04.prod.outlook.com> (raw) In-Reply-To: <38c1da4a-6fa7-783a-b600-3be7f8ea42a4@kontron.de> > > diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c > > index d858a82c4f44..d74a13d7c21c 100644 > > --- a/drivers/usb/chipidea/host.c > > +++ b/drivers/usb/chipidea/host.c > > @@ -28,6 +28,20 @@ struct ehci_ci_priv { > > struct regulator *reg_vbus; > > }; > > > > +/* This function is used to override WKCN, WKDN, and WKOC */ static > > +void ci_ehci_override_wakeup_flag(struct ehci_hcd *ehci, > > I think it would be better to rename this function to something like > ci_ehci_clear_reg_bits() as it is completely generic and just clears some bits in reg. > > And also remove the argument "set", as currently the only usage of this function is > with set=false. > Agree. Peter > > + u32 __iomem *reg, u32 flags, bool set) { > > + u32 val = ehci_readl(ehci, reg); > > + > > + if (set) > > + val |= flags; > > + else > > + val &= ~flags; > > + > > + ehci_writel(ehci, val, reg); > > +} > > + > > static int ehci_ci_portpower(struct usb_hcd *hcd, int portnum, bool enable) > > { > > struct ehci_hcd *ehci = hcd_to_ehci(hcd); @@ -170,6 +184,11 @@ > > static int host_start(struct ci_hdrc *ci) > > otg->host = &hcd->self; > > hcd->self.otg_port = 1; > > } > > + > > + if (ci->platdata->notify_event && > > + (ci->platdata->flags & CI_HDRC_IMX_IS_HSIC)) > > + ci->platdata->notify_event > > + (ci, CI_HDRC_IMX_HSIC_ACTIVE_EVENT); > > } > > > > return ret; > > @@ -218,6 +237,8 @@ void ci_hdrc_host_destroy(struct ci_hdrc *ci) > > static int ci_ehci_bus_suspend(struct usb_hcd *hcd) > > { > > struct ehci_hcd *ehci = hcd_to_ehci(hcd); > > + struct device *dev = hcd->self.controller; > > + struct ci_hdrc *ci = dev_get_drvdata(dev); > > int port; > > u32 tmp; > > > > @@ -249,6 +270,9 @@ static int ci_ehci_bus_suspend(struct usb_hcd *hcd) > > * It needs a short delay between set RS bit and PHCD. > > */ > > usleep_range(150, 200); > > + if (ci->platdata->flags & CI_HDRC_IMX_IS_HSIC) > > + ci_ehci_override_wakeup_flag(ehci, reg, > > + PORT_WKDISC_E | PORT_WKCONN_E, > false); > > break; > > } > > } > > diff --git a/include/linux/usb/chipidea.h > > b/include/linux/usb/chipidea.h index 63758c399e4e..911e05af671e 100644 > > --- a/include/linux/usb/chipidea.h > > +++ b/include/linux/usb/chipidea.h > > @@ -60,9 +60,12 @@ struct ci_hdrc_platform_data { > > #define CI_HDRC_OVERRIDE_RX_BURST BIT(11) > > #define CI_HDRC_OVERRIDE_PHY_CONTROL BIT(12) /* Glue layer > manages phy */ > > #define CI_HDRC_REQUIRES_ALIGNED_DMA BIT(13) > > +#define CI_HDRC_IMX_IS_HSIC BIT(14) > > enum usb_dr_mode dr_mode; > > #define CI_HDRC_CONTROLLER_RESET_EVENT 0 > > #define CI_HDRC_CONTROLLER_STOPPED_EVENT 1 > > +#define CI_HDRC_IMX_HSIC_ACTIVE_EVENT 2 > > +#define CI_HDRC_IMX_HSIC_SUSPEND_EVENT 3 > > int (*notify_event) (struct ci_hdrc *ci, unsigned event); > > struct regulator *reg_vbus; > > struct usb_otg_caps ci_otg_caps;
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@nxp.com> To: Schrempf Frieder <frieder.schrempf@kontron.De>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org> Cc: dl-linux-imx <linux-imx@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "frieder.schrempf@exceet.de" <frieder.schrempf@exceet.de>, "festevam@gmail.com" <festevam@gmail.com> Subject: [v2,1/4] usb: chipidea: add flag for imx hsic implementation Date: Mon, 5 Nov 2018 09:31:04 +0000 [thread overview] Message-ID: <VI1PR04MB532767CCE7618D9950FBC0418BCA0@VI1PR04MB5327.eurprd04.prod.outlook.com> (raw) > > diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c > > index d858a82c4f44..d74a13d7c21c 100644 > > --- a/drivers/usb/chipidea/host.c > > +++ b/drivers/usb/chipidea/host.c > > @@ -28,6 +28,20 @@ struct ehci_ci_priv { > > struct regulator *reg_vbus; > > }; > > > > +/* This function is used to override WKCN, WKDN, and WKOC */ static > > +void ci_ehci_override_wakeup_flag(struct ehci_hcd *ehci, > > I think it would be better to rename this function to something like > ci_ehci_clear_reg_bits() as it is completely generic and just clears some bits in reg. > > And also remove the argument "set", as currently the only usage of this function is > with set=false. > Agree. Peter > > + u32 __iomem *reg, u32 flags, bool set) { > > + u32 val = ehci_readl(ehci, reg); > > + > > + if (set) > > + val |= flags; > > + else > > + val &= ~flags; > > + > > + ehci_writel(ehci, val, reg); > > +} > > + > > static int ehci_ci_portpower(struct usb_hcd *hcd, int portnum, bool enable) > > { > > struct ehci_hcd *ehci = hcd_to_ehci(hcd); @@ -170,6 +184,11 @@ > > static int host_start(struct ci_hdrc *ci) > > otg->host = &hcd->self; > > hcd->self.otg_port = 1; > > } > > + > > + if (ci->platdata->notify_event && > > + (ci->platdata->flags & CI_HDRC_IMX_IS_HSIC)) > > + ci->platdata->notify_event > > + (ci, CI_HDRC_IMX_HSIC_ACTIVE_EVENT); > > } > > > > return ret; > > @@ -218,6 +237,8 @@ void ci_hdrc_host_destroy(struct ci_hdrc *ci) > > static int ci_ehci_bus_suspend(struct usb_hcd *hcd) > > { > > struct ehci_hcd *ehci = hcd_to_ehci(hcd); > > + struct device *dev = hcd->self.controller; > > + struct ci_hdrc *ci = dev_get_drvdata(dev); > > int port; > > u32 tmp; > > > > @@ -249,6 +270,9 @@ static int ci_ehci_bus_suspend(struct usb_hcd *hcd) > > * It needs a short delay between set RS bit and PHCD. > > */ > > usleep_range(150, 200); > > + if (ci->platdata->flags & CI_HDRC_IMX_IS_HSIC) > > + ci_ehci_override_wakeup_flag(ehci, reg, > > + PORT_WKDISC_E | PORT_WKCONN_E, > false); > > break; > > } > > } > > diff --git a/include/linux/usb/chipidea.h > > b/include/linux/usb/chipidea.h index 63758c399e4e..911e05af671e 100644 > > --- a/include/linux/usb/chipidea.h > > +++ b/include/linux/usb/chipidea.h > > @@ -60,9 +60,12 @@ struct ci_hdrc_platform_data { > > #define CI_HDRC_OVERRIDE_RX_BURST BIT(11) > > #define CI_HDRC_OVERRIDE_PHY_CONTROL BIT(12) /* Glue layer > manages phy */ > > #define CI_HDRC_REQUIRES_ALIGNED_DMA BIT(13) > > +#define CI_HDRC_IMX_IS_HSIC BIT(14) > > enum usb_dr_mode dr_mode; > > #define CI_HDRC_CONTROLLER_RESET_EVENT 0 > > #define CI_HDRC_CONTROLLER_STOPPED_EVENT 1 > > +#define CI_HDRC_IMX_HSIC_ACTIVE_EVENT 2 > > +#define CI_HDRC_IMX_HSIC_SUSPEND_EVENT 3 > > int (*notify_event) (struct ci_hdrc *ci, unsigned event); > > struct regulator *reg_vbus; > > struct usb_otg_caps ci_otg_caps;
next prev parent reply other threads:[~2018-11-05 18:49 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-22 5:42 [PATCH v2 0/4] usb: chipidea: imx: add HSIC support Peter Chen 2018-10-22 5:42 ` [PATCH v2 1/4] usb: chipidea: add flag for imx hsic implementation Peter Chen 2018-10-22 5:42 ` [v2,1/4] " Peter Chen 2018-11-05 8:52 ` [PATCH v2 1/4] " Schrempf Frieder 2018-11-05 8:52 ` [v2,1/4] " Frieder Schrempf 2018-11-05 9:31 ` Peter Chen [this message] 2018-11-05 9:31 ` Peter Chen 2018-10-22 5:43 ` [PATCH v2 2/4] usb: chipidea: imx: add HSIC support Peter Chen 2018-10-22 5:43 ` [v2,2/4] " Peter Chen 2018-11-05 8:52 ` [PATCH v2 2/4] " Schrempf Frieder 2018-11-05 8:52 ` [v2,2/4] " Frieder Schrempf 2018-11-05 9:40 ` [PATCH v2 2/4] " Peter Chen 2018-11-05 9:40 ` [v2,2/4] " Peter Chen 2018-10-22 5:43 ` [PATCH v2 3/4] usb: chipidea: host: override ehci->hub_control Peter Chen 2018-10-22 5:43 ` [v2,3/4] " Peter Chen 2018-10-22 5:43 ` [PATCH v2 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups Peter Chen 2018-10-22 5:43 ` [v2,4/4] " Peter Chen 2018-10-22 14:54 ` [PATCH v2 4/4] " Schrempf Frieder 2018-10-22 14:54 ` [v2,4/4] " Frieder Schrempf 2018-10-22 14:59 ` [PATCH v2 4/4] " Fabio Estevam 2018-10-22 14:59 ` [v2,4/4] " Fabio Estevam 2018-10-23 5:59 ` [PATCH v2 4/4] " Peter Chen 2018-10-23 5:59 ` [v2,4/4] " Peter Chen 2018-10-23 6:30 ` [PATCH v2 0/4] usb: chipidea: imx: add HSIC support Schrempf Frieder 2018-10-23 6:33 ` Peter Chen 2018-11-05 8:52 ` Schrempf Frieder 2018-11-19 8:36 ` Schrempf Frieder 2018-11-20 2:11 ` PETER CHEN
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VI1PR04MB532767CCE7618D9950FBC0418BCA0@VI1PR04MB5327.eurprd04.prod.outlook.com \ --to=peter.chen@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=frieder.schrempf@exceet.de \ --cc=frieder.schrempf@kontron.De \ --cc=linux-imx@nxp.com \ --cc=linux-usb@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.