* [PATCH] PCI: imx6: Limit DBI register length for imx6qp PCIe @ 2021-02-20 2:49 ` Richard Zhu 0 siblings, 0 replies; 10+ messages in thread From: Richard Zhu @ 2021-02-20 2:49 UTC (permalink / raw) To: l.stach, kw, bhelgaas, stefan, lorenzo.pieralisi Cc: linux-pci, linux-imx, linux-arm-kernel, linux-kernel, kernel Changes from v1 to v2: - Add reviewed by Lucas and Krzysztof. - Refine the subject and commit refer to Krzysztof comments. drivers/pci/controller/dwc/pci-imx6.c | 1 + 1 file changed, 1 insertion(+) [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] PCI: imx6: Limit DBI register length for imx6qp PCIe @ 2021-02-20 2:49 ` Richard Zhu 0 siblings, 0 replies; 10+ messages in thread From: Richard Zhu @ 2021-02-20 2:49 UTC (permalink / raw) To: l.stach, kw, bhelgaas, stefan, lorenzo.pieralisi Cc: kernel, linux-pci, linux-imx, linux-arm-kernel, linux-kernel Changes from v1 to v2: - Add reviewed by Lucas and Krzysztof. - Refine the subject and commit refer to Krzysztof comments. drivers/pci/controller/dwc/pci-imx6.c | 1 + 1 file changed, 1 insertion(+) [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe 2021-02-20 2:49 ` Richard Zhu @ 2021-02-20 2:49 ` Richard Zhu -1 siblings, 0 replies; 10+ messages in thread From: Richard Zhu @ 2021-02-20 2:49 UTC (permalink / raw) To: l.stach, kw, bhelgaas, stefan, lorenzo.pieralisi Cc: linux-pci, linux-imx, linux-arm-kernel, linux-kernel, kernel, Richard Zhu Define the length of the DBI registers and limit config space to its length. This makes sure that the kernel does not access registers beyond that point that otherwise would lead to an abort on the i.MX 6QuadPlus. See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that resolves a similar issue on the i.MX 6Quad PCIe. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Krzysztof Wilczyński <kw@linux.com> --- drivers/pci/controller/dwc/pci-imx6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 0cf1333c0440..853ea8e82952 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = { .variant = IMX6QP, .flags = IMX6_PCIE_FLAG_IMX6_PHY | IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, + .dbi_length = 0x200, }, [IMX7D] = { .variant = IMX7D, -- 2.17.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe @ 2021-02-20 2:49 ` Richard Zhu 0 siblings, 0 replies; 10+ messages in thread From: Richard Zhu @ 2021-02-20 2:49 UTC (permalink / raw) To: l.stach, kw, bhelgaas, stefan, lorenzo.pieralisi Cc: Richard Zhu, linux-pci, linux-kernel, linux-imx, kernel, linux-arm-kernel Define the length of the DBI registers and limit config space to its length. This makes sure that the kernel does not access registers beyond that point that otherwise would lead to an abort on the i.MX 6QuadPlus. See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that resolves a similar issue on the i.MX 6Quad PCIe. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Krzysztof Wilczyński <kw@linux.com> --- drivers/pci/controller/dwc/pci-imx6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 0cf1333c0440..853ea8e82952 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = { .variant = IMX6QP, .flags = IMX6_PCIE_FLAG_IMX6_PHY | IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, + .dbi_length = 0x200, }, [IMX7D] = { .variant = IMX7D, -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe 2021-02-20 2:49 ` Richard Zhu @ 2021-06-21 14:24 ` Lorenzo Pieralisi -1 siblings, 0 replies; 10+ messages in thread From: Lorenzo Pieralisi @ 2021-06-21 14:24 UTC (permalink / raw) To: Richard Zhu Cc: l.stach, kw, bhelgaas, stefan, linux-pci, linux-imx, linux-arm-kernel, linux-kernel, kernel On Sat, Feb 20, 2021 at 10:49:48AM +0800, Richard Zhu wrote: > Define the length of the DBI registers and limit config space to its > length. This makes sure that the kernel does not access registers beyond > that point that otherwise would lead to an abort on the i.MX 6QuadPlus. > > See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that > resolves a similar issue on the i.MX 6Quad PCIe. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Reviewed-by: Krzysztof Wilczyński <kw@linux.com> > --- > drivers/pci/controller/dwc/pci-imx6.c | 1 + > 1 file changed, 1 insertion(+) I'd like to merge this patch since I believe it is still required, please let me know if that's not the case. Lorenzo > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 0cf1333c0440..853ea8e82952 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = { > .variant = IMX6QP, > .flags = IMX6_PCIE_FLAG_IMX6_PHY | > IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > + .dbi_length = 0x200, > }, > [IMX7D] = { > .variant = IMX7D, > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe @ 2021-06-21 14:24 ` Lorenzo Pieralisi 0 siblings, 0 replies; 10+ messages in thread From: Lorenzo Pieralisi @ 2021-06-21 14:24 UTC (permalink / raw) To: Richard Zhu Cc: l.stach, kw, bhelgaas, stefan, linux-pci, linux-imx, linux-arm-kernel, linux-kernel, kernel On Sat, Feb 20, 2021 at 10:49:48AM +0800, Richard Zhu wrote: > Define the length of the DBI registers and limit config space to its > length. This makes sure that the kernel does not access registers beyond > that point that otherwise would lead to an abort on the i.MX 6QuadPlus. > > See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that > resolves a similar issue on the i.MX 6Quad PCIe. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Reviewed-by: Krzysztof Wilczyński <kw@linux.com> > --- > drivers/pci/controller/dwc/pci-imx6.c | 1 + > 1 file changed, 1 insertion(+) I'd like to merge this patch since I believe it is still required, please let me know if that's not the case. Lorenzo > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 0cf1333c0440..853ea8e82952 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = { > .variant = IMX6QP, > .flags = IMX6_PCIE_FLAG_IMX6_PHY | > IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > + .dbi_length = 0x200, > }, > [IMX7D] = { > .variant = IMX7D, > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe 2021-06-21 14:24 ` Lorenzo Pieralisi @ 2021-06-22 0:41 ` Richard Zhu -1 siblings, 0 replies; 10+ messages in thread From: Richard Zhu @ 2021-06-22 0:41 UTC (permalink / raw) To: Lorenzo Pieralisi Cc: l.stach, kw, bhelgaas, stefan, linux-pci, dl-linux-imx, linux-arm-kernel, linux-kernel, kernel > -----Original Message----- > From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Sent: Monday, June 21, 2021 10:24 PM > To: Richard Zhu <hongxing.zhu@nxp.com> > Cc: l.stach@pengutronix.de; kw@linux.com; bhelgaas@google.com; > stefan@agner.ch; linux-pci@vger.kernel.org; dl-linux-imx > <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; kernel@pengutronix.de > Subject: Re: [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe > > On Sat, Feb 20, 2021 at 10:49:48AM +0800, Richard Zhu wrote: > > Define the length of the DBI registers and limit config space to its > > length. This makes sure that the kernel does not access registers > > beyond that point that otherwise would lead to an abort on the i.MX > 6QuadPlus. > > > > See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that > > resolves a similar issue on the i.MX 6Quad PCIe. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > > Reviewed-by: Krzysztof Wilczyński <kw@linux.com> > > --- > > drivers/pci/controller/dwc/pci-imx6.c | 1 + > > 1 file changed, 1 insertion(+) > > I'd like to merge this patch since I believe it is still required, please let me > know if that's not the case. Hi Lorenzo: Thanks for merging this patch. Best Regards Richard Zhu > > Lorenzo > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c > > b/drivers/pci/controller/dwc/pci-imx6.c > > index 0cf1333c0440..853ea8e82952 100644 > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = > { > > .variant = IMX6QP, > > .flags = IMX6_PCIE_FLAG_IMX6_PHY | > > IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > > + .dbi_length = 0x200, > > }, > > [IMX7D] = { > > .variant = IMX7D, > > -- > > 2.17.1 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe @ 2021-06-22 0:41 ` Richard Zhu 0 siblings, 0 replies; 10+ messages in thread From: Richard Zhu @ 2021-06-22 0:41 UTC (permalink / raw) To: Lorenzo Pieralisi Cc: l.stach, kw, bhelgaas, stefan, linux-pci, dl-linux-imx, linux-arm-kernel, linux-kernel, kernel > -----Original Message----- > From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Sent: Monday, June 21, 2021 10:24 PM > To: Richard Zhu <hongxing.zhu@nxp.com> > Cc: l.stach@pengutronix.de; kw@linux.com; bhelgaas@google.com; > stefan@agner.ch; linux-pci@vger.kernel.org; dl-linux-imx > <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; kernel@pengutronix.de > Subject: Re: [PATCH v2] PCI: imx6: Limit DBI register length for imx6qp PCIe > > On Sat, Feb 20, 2021 at 10:49:48AM +0800, Richard Zhu wrote: > > Define the length of the DBI registers and limit config space to its > > length. This makes sure that the kernel does not access registers > > beyond that point that otherwise would lead to an abort on the i.MX > 6QuadPlus. > > > > See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that > > resolves a similar issue on the i.MX 6Quad PCIe. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > > Reviewed-by: Krzysztof Wilczyński <kw@linux.com> > > --- > > drivers/pci/controller/dwc/pci-imx6.c | 1 + > > 1 file changed, 1 insertion(+) > > I'd like to merge this patch since I believe it is still required, please let me > know if that's not the case. Hi Lorenzo: Thanks for merging this patch. Best Regards Richard Zhu > > Lorenzo > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c > > b/drivers/pci/controller/dwc/pci-imx6.c > > index 0cf1333c0440..853ea8e82952 100644 > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = > { > > .variant = IMX6QP, > > .flags = IMX6_PCIE_FLAG_IMX6_PHY | > > IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > > + .dbi_length = 0x200, > > }, > > [IMX7D] = { > > .variant = IMX7D, > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp PCIe 2021-02-20 2:49 ` Richard Zhu @ 2021-06-22 9:28 ` Lorenzo Pieralisi -1 siblings, 0 replies; 10+ messages in thread From: Lorenzo Pieralisi @ 2021-06-22 9:28 UTC (permalink / raw) To: Richard Zhu, stefan, l.stach, bhelgaas, kw Cc: Lorenzo Pieralisi, linux-imx, linux-arm-kernel, linux-pci, kernel, linux-kernel On Sat, 20 Feb 2021 10:49:47 +0800, Richard Zhu wrote: > Changes from v1 to v2: > - Add reviewed by Lucas and Krzysztof. > - Refine the subject and commit refer to Krzysztof comments. > > drivers/pci/controller/dwc/pci-imx6.c | 1 + > 1 file changed, 1 insertion(+) > > [...] Applied to pci/imx6, thanks! [1/1] PCI: imx6: Limit DBI register length for imx6qp PCIe https://git.kernel.org/lpieralisi/pci/c/36ff5224f1 Thanks, Lorenzo ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp PCIe @ 2021-06-22 9:28 ` Lorenzo Pieralisi 0 siblings, 0 replies; 10+ messages in thread From: Lorenzo Pieralisi @ 2021-06-22 9:28 UTC (permalink / raw) To: Richard Zhu, stefan, l.stach, bhelgaas, kw Cc: Lorenzo Pieralisi, linux-imx, linux-arm-kernel, linux-pci, kernel, linux-kernel On Sat, 20 Feb 2021 10:49:47 +0800, Richard Zhu wrote: > Changes from v1 to v2: > - Add reviewed by Lucas and Krzysztof. > - Refine the subject and commit refer to Krzysztof comments. > > drivers/pci/controller/dwc/pci-imx6.c | 1 + > 1 file changed, 1 insertion(+) > > [...] Applied to pci/imx6, thanks! [1/1] PCI: imx6: Limit DBI register length for imx6qp PCIe https://git.kernel.org/lpieralisi/pci/c/36ff5224f1 Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-06-22 9:30 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-20 2:49 [PATCH] PCI: imx6: Limit DBI register length for imx6qp PCIe Richard Zhu 2021-02-20 2:49 ` Richard Zhu 2021-02-20 2:49 ` [PATCH v2] " Richard Zhu 2021-02-20 2:49 ` Richard Zhu 2021-06-21 14:24 ` Lorenzo Pieralisi 2021-06-21 14:24 ` Lorenzo Pieralisi 2021-06-22 0:41 ` Richard Zhu 2021-06-22 0:41 ` Richard Zhu 2021-06-22 9:28 ` [PATCH] " Lorenzo Pieralisi 2021-06-22 9:28 ` Lorenzo Pieralisi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.