From: Daniel Vetter <daniel@ffwll.ch> To: "ZhiJie.Zhang" <zhangzhijie@loongson.cn> Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: Improve the output_poll_changed description Date: Tue, 12 Jan 2021 15:20:36 +0100 [thread overview] Message-ID: <X/2wNLjupzAS7O5c@phenom.ffwll.local> (raw) In-Reply-To: <20210112104644.341345-1-zhangzhijie@loongson.cn> On Tue, Jan 12, 2021 at 06:46:44PM +0800, ZhiJie.Zhang wrote: > From: zhangzhijie <zhangzhijie@loongson.cn> > > codeview the implementation of few Drivers. I'm not really understanding what you're trying to say here. > this callback was used by drm_kms_helper_hotplug_event() > > Signed-off-by: zhangzhijie <zhangzhijie@loongson.cn> > --- > include/drm/drm_mode_config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index ab424ddd7665..e01c4d0f07d1 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -104,7 +104,7 @@ struct drm_mode_config_funcs { > * changes. > * > * Drivers implementing fbdev emulation with the helpers can call > - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev > + * drm_kms_helper_hotplug_event() from this hook to inform the fbdev > * helper of output changes. I think since we touch this, maybe better to revamp it complete. The best way to handle all this is by registering a struct drm_client, since that provides the &drm_client_funcs.hotplug callback. Also for fbdev support drivers shouldn't even use that, but instead use the drm_fbdev_generic_setup() function, which takes care of everything. I think we can also remove the FIXME below, since with the drm_client infrastructure and the generic fbdev emulation we've resolved this all very neatly now. Can you please respin with my suggestions taking into account somehow? Thanks, Daniel > * > * FIXME: > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: "ZhiJie.Zhang" <zhangzhijie@loongson.cn> Cc: tzimmermann@suse.de, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: Improve the output_poll_changed description Date: Tue, 12 Jan 2021 15:20:36 +0100 [thread overview] Message-ID: <X/2wNLjupzAS7O5c@phenom.ffwll.local> (raw) In-Reply-To: <20210112104644.341345-1-zhangzhijie@loongson.cn> On Tue, Jan 12, 2021 at 06:46:44PM +0800, ZhiJie.Zhang wrote: > From: zhangzhijie <zhangzhijie@loongson.cn> > > codeview the implementation of few Drivers. I'm not really understanding what you're trying to say here. > this callback was used by drm_kms_helper_hotplug_event() > > Signed-off-by: zhangzhijie <zhangzhijie@loongson.cn> > --- > include/drm/drm_mode_config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index ab424ddd7665..e01c4d0f07d1 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -104,7 +104,7 @@ struct drm_mode_config_funcs { > * changes. > * > * Drivers implementing fbdev emulation with the helpers can call > - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev > + * drm_kms_helper_hotplug_event() from this hook to inform the fbdev > * helper of output changes. I think since we touch this, maybe better to revamp it complete. The best way to handle all this is by registering a struct drm_client, since that provides the &drm_client_funcs.hotplug callback. Also for fbdev support drivers shouldn't even use that, but instead use the drm_fbdev_generic_setup() function, which takes care of everything. I think we can also remove the FIXME below, since with the drm_client infrastructure and the generic fbdev emulation we've resolved this all very neatly now. Can you please respin with my suggestions taking into account somehow? Thanks, Daniel > * > * FIXME: > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-12 14:21 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-12 10:46 [PATCH] drm: Improve the output_poll_changed description ZhiJie.Zhang 2021-01-12 10:46 ` ZhiJie.Zhang 2021-01-12 14:20 ` Daniel Vetter [this message] 2021-01-12 14:20 ` Daniel Vetter 2021-01-13 2:57 ` zhangzhijie 2021-01-13 2:57 ` zhangzhijie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X/2wNLjupzAS7O5c@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ --cc=zhangzhijie@loongson.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.