* [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
@ 2020-11-02 11:44 ` Lee Jones
2020-11-04 0:46 ` Jakub Kicinski
2020-11-02 11:44 ` [PATCH 02/30] net: fddi: skfp: ecm: Remove seemingly unused variable 'ID_sccs' Lee Jones
` (28 subsequent siblings)
29 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
When AIX_EVENT is not defined, the 'if' body will be empty, which
makes GCC complain. Place bracketing around the invocation to protect
it.
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/ecm.c: In function ‘ecm_fsm’:
drivers/net/fddi/skfp/ecm.c:153:29: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/ecm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fddi/skfp/ecm.c b/drivers/net/fddi/skfp/ecm.c
index 15c503f43727b..97f3efd5eb13c 100644
--- a/drivers/net/fddi/skfp/ecm.c
+++ b/drivers/net/fddi/skfp/ecm.c
@@ -147,10 +147,11 @@ static void ecm_fsm(struct s_smc *smc, int cmd)
/* For AIX event notification: */
/* Is a disconnect command remotely issued ? */
if (cmd == EC_DISCONNECT &&
- smc->mib.fddiSMTRemoteDisconnectFlag == TRUE)
+ smc->mib.fddiSMTRemoteDisconnectFlag == TRUE) {
AIX_EVENT (smc, (u_long) CIO_HARD_FAIL, (u_long)
FDDI_REMOTE_DISCONNECT, smt_get_event_word(smc),
smt_get_error_word(smc) );
+ }
/*jd 05-Aug-1999 Bug #10419 "Port Disconnect fails at Dup MAc Cond."*/
if (cmd == EC_CONNECT) {
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 02/30] net: fddi: skfp: ecm: Remove seemingly unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
2020-11-02 11:44 ` [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 03/30] net: fddi: skfp: pcmplc: Remove defined but not used " Lee Jones
` (27 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
This variable is present in many source files and has not been used
anywhere (at least internally) since it was introduced.
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/ecm.c: In function ‘ecm_fsm’:
drivers/net/fddi/skfp/ecm.c:44:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/ecm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/ecm.c b/drivers/net/fddi/skfp/ecm.c
index 97f3efd5eb13c..2f5f5f26bb434 100644
--- a/drivers/net/fddi/skfp/ecm.c
+++ b/drivers/net/fddi/skfp/ecm.c
@@ -40,10 +40,6 @@
#define KERNEL
#include "h/smtstate.h"
-#ifndef lint
-static const char ID_sccs[] = "@(#)ecm.c 2.7 99/08/05 (C) SK " ;
-#endif
-
/*
* FSM Macros
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 03/30] net: fddi: skfp: pcmplc: Remove defined but not used variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
2020-11-02 11:44 ` [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined Lee Jones
2020-11-02 11:44 ` [PATCH 02/30] net: fddi: skfp: ecm: Remove seemingly unused variable 'ID_sccs' Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
` (26 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, Gustavo A. R. Silva, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/pcmplc.c:49:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/pcmplc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/pcmplc.c b/drivers/net/fddi/skfp/pcmplc.c
index 554cde8d6073e..90e8df6d9a88a 100644
--- a/drivers/net/fddi/skfp/pcmplc.c
+++ b/drivers/net/fddi/skfp/pcmplc.c
@@ -45,10 +45,6 @@
#define KERNEL
#include "h/smtstate.h"
-#ifndef lint
-static const char ID_sccs[] = "@(#)pcmplc.c 2.55 99/08/05 (C) SK " ;
-#endif
-
#ifdef FDDI_MIB
extern int snmp_fddi_trap(
#ifdef ANSIC
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (2 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 03/30] net: fddi: skfp: pcmplc: Remove defined but not used " Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-12 10:04 ` Lee Jones
2020-11-02 11:44 ` [PATCH 05/30] net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
` (25 subsequent siblings)
29 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Inaky Perez-Gonzalez, linux-wimax, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/control.c:1195: warning: Function parameter or member 'arg' not described in 'i2400m_set_init_config'
drivers/net/wimax/i2400m/control.c:1195: warning: Excess function parameter 'arg_size' description in 'i2400m_set_init_config'
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/control.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/control.c b/drivers/staging/wimax/i2400m/control.c
index fe885aa56cf37..1e270b2101e86 100644
--- a/drivers/staging/wimax/i2400m/control.c
+++ b/drivers/staging/wimax/i2400m/control.c
@@ -1183,11 +1183,11 @@ static int i2400m_cmd_get_state(struct i2400m *i2400m)
* Set basic configuration settings
*
* @i2400m: device descriptor
- * @args: array of pointers to the TLV headers to send for
+ * @arg: array of pointers to the TLV headers to send for
* configuration (each followed by its payload).
* TLV headers and payloads must be properly initialized, with the
* right endianess (LE).
- * @arg_size: number of pointers in the @args array
+ * @args: number of pointers in the @arg array
*/
static int i2400m_set_init_config(struct i2400m *i2400m,
const struct i2400m_tlv_hdr **arg,
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 05/30] net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (3 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 06/30] net: wimax: i2400m: fw: Fix some function header misdemeanours Lee Jones
` (24 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Inaky Perez-Gonzalez, linux-wimax, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/driver.c:681: warning: Function parameter or member 'i2400m' not described in 'i2400m_dev_reset_handle'
drivers/net/wimax/i2400m/driver.c:681: warning: Function parameter or member 'reason' not described in 'i2400m_dev_reset_handle'
drivers/net/wimax/i2400m/driver.c:775: warning: Function parameter or member 'i2400m' not described in 'i2400m_init'
drivers/net/wimax/i2400m/driver.c:842: warning: Function parameter or member 'bm_flags' not described in 'i2400m_setup'
drivers/net/wimax/i2400m/driver.c:942: warning: Function parameter or member 'i2400m' not described in 'i2400m_release'
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/driver.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/driver.c b/drivers/staging/wimax/i2400m/driver.c
index dc8939ff78c0e..f5186458bb3d4 100644
--- a/drivers/staging/wimax/i2400m/driver.c
+++ b/drivers/staging/wimax/i2400m/driver.c
@@ -665,7 +665,7 @@ void __i2400m_dev_reset_handle(struct work_struct *ws)
}
-/**
+/*
* i2400m_dev_reset_handle - Handle a device's reset in a thread context
*
* Schedule a device reset handling out on a thread context, so it
@@ -685,7 +685,7 @@ int i2400m_dev_reset_handle(struct i2400m *i2400m, const char *reason)
EXPORT_SYMBOL_GPL(i2400m_dev_reset_handle);
- /*
+/*
* The actual work of error recovery.
*
* The current implementation of error recovery is to trigger a bus reset.
@@ -766,7 +766,7 @@ void i2400m_bm_buf_free(struct i2400m *i2400m)
}
-/**
+/*
* i2400m_init - Initialize a 'struct i2400m' from all zeroes
*
* This is a bus-generic API call.
@@ -831,6 +831,7 @@ EXPORT_SYMBOL_GPL(i2400m_reset);
* i2400m_setup - bus-generic setup function for the i2400m device
*
* @i2400m: device descriptor (bus-specific parts have been initialized)
+ * @bm_flags: boot mode flags
*
* Returns: 0 if ok, < 0 errno code on error.
*
@@ -933,7 +934,7 @@ int i2400m_setup(struct i2400m *i2400m, enum i2400m_bri bm_flags)
EXPORT_SYMBOL_GPL(i2400m_setup);
-/**
+/*
* i2400m_release - release the bus-generic driver resources
*
* Sends a disconnect message and undoes any setup done by i2400m_setup()
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 06/30] net: wimax: i2400m: fw: Fix some function header misdemeanours
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (4 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 05/30] net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 07/30] net: fddi: skfp: pmf: Remove defined but unused variable 'ID_sccs' Lee Jones
` (23 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Inaky Perez-Gonzalez, linux-wimax, Jakub Kicinski,
Yanir Lubetkin, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/fw.c:584: warning: Function parameter or member 'i2400m' not described in 'i2400m_bm_cmd'
drivers/net/wimax/i2400m/fw.c:584: warning: Excess function parameter 'returns' description in 'i2400m_bm_cmd'
drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member 'chunk' not described in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member '__chunk_len' not described in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf' description in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf_len' description in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:1548: warning: Function parameter or member 'flags' not described in 'i2400m_dev_bootstrap'
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/fw.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
index 6c9a41bff2e0a..9970857063374 100644
--- a/drivers/staging/wimax/i2400m/fw.c
+++ b/drivers/staging/wimax/i2400m/fw.c
@@ -534,6 +534,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
/**
* i2400m_bm_cmd - Execute a boot mode command
*
+ * @i2400m: device descriptor
* @cmd: buffer containing the command data (pointing at the header).
* This data can be ANYWHERE (for USB, we will copy it to an
* specific buffer). Make sure everything is in proper little
@@ -566,7 +567,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
*
* @flags: see I2400M_BM_CMD_* above.
*
- * @returns: bytes received by the notification; if < 0, an errno code
+ * Returns: bytes received by the notification; if < 0, an errno code
* denoting an error or:
*
* -ERESTARTSYS The device has rebooted
@@ -634,8 +635,8 @@ ssize_t i2400m_bm_cmd(struct i2400m *i2400m,
* i2400m_download_chunk - write a single chunk of data to the device's memory
*
* @i2400m: device descriptor
- * @buf: the buffer to write
- * @buf_len: length of the buffer to write
+ * @chunk: the buffer to write
+ * @chunk_len: length of the buffer to write
* @addr: address in the device memory space
* @direct: bootrom write mode
* @do_csum: should a checksum validation be performed
@@ -1533,6 +1534,13 @@ void i2400m_fw_put(struct i2400m_fw *i2400m_fw)
* i2400m_dev_bootstrap - Bring the device to a known state and upload firmware
*
* @i2400m: device descriptor
+ * @flags:
+ * I2400M_BRI_SOFT: a reboot barker has been seen
+ * already, so don't wait for it.
+ *
+ * I2400M_BRI_NO_REBOOT: Don't send a reboot command, but wait
+ * for a reboot barker notification. This is a one shot; if
+ * the state machine needs to send a reboot command it will.
*
* Returns: >= 0 if ok, < 0 errno code on error.
*
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 07/30] net: fddi: skfp: pmf: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (5 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 06/30] net: wimax: i2400m: fw: Fix some function header misdemeanours Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 08/30] net: fddi: skfp: queue: " Lee Jones
` (22 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/pmf.c:28:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/pmf.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/pmf.c b/drivers/net/fddi/skfp/pmf.c
index 14f10b4cab0fc..563fb7f0b327e 100644
--- a/drivers/net/fddi/skfp/pmf.c
+++ b/drivers/net/fddi/skfp/pmf.c
@@ -24,10 +24,6 @@
#ifndef SLIM_SMT
-#ifndef lint
-static const char ID_sccs[] = "@(#)pmf.c 1.37 97/08/04 (C) SK " ;
-#endif
-
static int smt_authorize(struct s_smc *smc, struct smt_header *sm);
static int smt_check_set_count(struct s_smc *smc, struct smt_header *sm);
static const struct s_p_tab* smt_get_ptab(u_short para);
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 08/30] net: fddi: skfp: queue: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (6 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 07/30] net: fddi: skfp: pmf: Remove defined but unused variable 'ID_sccs' Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 09/30] net: fddi: skfp: rmt: " Lee Jones
` (21 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/queue.c:22:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/queue.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/queue.c b/drivers/net/fddi/skfp/queue.c
index ba022f723bd77..abe155ad777fa 100644
--- a/drivers/net/fddi/skfp/queue.c
+++ b/drivers/net/fddi/skfp/queue.c
@@ -18,10 +18,6 @@
#include "h/fddi.h"
#include "h/smc.h"
-#ifndef lint
-static const char ID_sccs[] = "@(#)queue.c 2.9 97/08/04 (C) SK " ;
-#endif
-
#define PRINTF(a,b,c)
/*
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 09/30] net: fddi: skfp: rmt: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (7 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 08/30] net: fddi: skfp: queue: " Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 10/30] net: fddi: skfp: smtdef: " Lee Jones
` (20 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/rmt.c:49:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/rmt.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/rmt.c b/drivers/net/fddi/skfp/rmt.c
index c0e62c25332cd..37a89675dbeb3 100644
--- a/drivers/net/fddi/skfp/rmt.c
+++ b/drivers/net/fddi/skfp/rmt.c
@@ -45,10 +45,6 @@
#define KERNEL
#include "h/smtstate.h"
-#ifndef lint
-static const char ID_sccs[] = "@(#)rmt.c 2.13 99/07/02 (C) SK " ;
-#endif
-
/*
* FSM Macros
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 10/30] net: fddi: skfp: smtdef: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (8 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 09/30] net: fddi: skfp: rmt: " Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 11/30] net: fddi: skfp: smtinit: " Lee Jones
` (19 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/smtdef.c:26:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/smtdef.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/smtdef.c b/drivers/net/fddi/skfp/smtdef.c
index 0bebde3c6cb9a..99cc9a549bd7e 100644
--- a/drivers/net/fddi/skfp/smtdef.c
+++ b/drivers/net/fddi/skfp/smtdef.c
@@ -22,10 +22,6 @@
#define OEM_USER_DATA "SK-NET FDDI V2.0 Userdata"
#endif
-#ifndef lint
-static const char ID_sccs[] = "@(#)smtdef.c 2.53 99/08/11 (C) SK " ;
-#endif
-
/*
* defaults
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 11/30] net: fddi: skfp: smtinit: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (9 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 10/30] net: fddi: skfp: smtdef: " Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 12/30] net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
` (18 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/smtinit.c:23:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/smtinit.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/smtinit.c b/drivers/net/fddi/skfp/smtinit.c
index 01f6c75cbea81..c9898c83fe304 100644
--- a/drivers/net/fddi/skfp/smtinit.c
+++ b/drivers/net/fddi/skfp/smtinit.c
@@ -19,10 +19,6 @@
#include "h/fddi.h"
#include "h/smc.h"
-#ifndef lint
-static const char ID_sccs[] = "@(#)smtinit.c 1.15 97/05/06 (C) SK " ;
-#endif
-
void init_fddi_driver(struct s_smc *smc, u_char *mac_addr);
/* define global debug variable */
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 12/30] net: wimax: i2400m: netdev: Demote non-conformant function header
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (10 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 11/30] net: fddi: skfp: smtinit: " Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 13/30] net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
` (17 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Inaky Perez-Gonzalez, linux-wimax, Jakub Kicinski,
Yanir Lubetkin, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/netdev.c:583: warning: Function parameter or member 'net_dev' not described in 'i2400m_netdev_setup'
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/netdev.c b/drivers/staging/wimax/i2400m/netdev.c
index a7fcbceb6e6be..8339d600e77b5 100644
--- a/drivers/staging/wimax/i2400m/netdev.c
+++ b/drivers/staging/wimax/i2400m/netdev.c
@@ -574,7 +574,7 @@ static const struct ethtool_ops i2400m_ethtool_ops = {
.get_link = ethtool_op_get_link,
};
-/**
+/*
* i2400m_netdev_setup - Setup setup @net_dev's i2400m private data
*
* Called by alloc_netdev()
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 13/30] net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (11 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 12/30] net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 14/30] net: fddi: skfp: smttimer: Remove defined but unused variable 'ID_sccs' Lee Jones
` (16 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Inaky Perez-Gonzalez, linux-wimax, Jakub Kicinski,
Yanir Lubetkin, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/tx.c:715: warning: Function parameter or member 'i2400m' not described in 'i2400m_tx'
drivers/net/wimax/i2400m/tx.c:964: warning: Function parameter or member 'i2400m' not described in 'i2400m_tx_setup'
drivers/net/wimax/i2400m/tx.c:1005: warning: Function parameter or member 'i2400m' not described in 'i2400m_tx_release'
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/tx.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/tx.c b/drivers/staging/wimax/i2400m/tx.c
index 1255302e251e4..e9436212fe54d 100644
--- a/drivers/staging/wimax/i2400m/tx.c
+++ b/drivers/staging/wimax/i2400m/tx.c
@@ -681,6 +681,8 @@ void i2400m_tx_close(struct i2400m *i2400m)
/**
* i2400m_tx - send the data in a buffer to the device
*
+ * @i2400m: device descriptor
+ *
* @buf: pointer to the buffer to transmit
*
* @buf_len: buffer size
@@ -955,6 +957,8 @@ EXPORT_SYMBOL_GPL(i2400m_tx_msg_sent);
/**
* i2400m_tx_setup - Initialize the TX queue and infrastructure
*
+ * @i2400m: device descriptor
+ *
* Make sure we reset the TX sequence to zero, as when this function
* is called, the firmware has been just restarted. Same rational
* for tx_in, tx_out, tx_msg_size and tx_msg. We reset them since
@@ -998,7 +1002,7 @@ int i2400m_tx_setup(struct i2400m *i2400m)
}
-/**
+/*
* i2400m_tx_release - Tear down the TX queue and infrastructure
*/
void i2400m_tx_release(struct i2400m *i2400m)
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 14/30] net: fddi: skfp: smttimer: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (12 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 13/30] net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 15/30] net: fddi: skfp: hwt: " Lee Jones
` (15 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/smttimer.c:22:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/smttimer.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/smttimer.c b/drivers/net/fddi/skfp/smttimer.c
index 9d549bb14f07f..5f3e5d7bf415b 100644
--- a/drivers/net/fddi/skfp/smttimer.c
+++ b/drivers/net/fddi/skfp/smttimer.c
@@ -18,10 +18,6 @@
#include "h/fddi.h"
#include "h/smc.h"
-#ifndef lint
-static const char ID_sccs[] = "@(#)smttimer.c 2.4 97/08/04 (C) SK " ;
-#endif
-
static void timer_done(struct s_smc *smc, int restart);
void smt_timer_init(struct s_smc *smc)
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 15/30] net: fddi: skfp: hwt: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (13 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 14/30] net: fddi: skfp: smttimer: Remove defined but unused variable 'ID_sccs' Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 16/30] net: fddi: skfp: srf: " Lee Jones
` (14 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/hwt.c:31:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/hwt.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/hwt.c b/drivers/net/fddi/skfp/hwt.c
index 32804ed049cdd..5577b8e14b736 100644
--- a/drivers/net/fddi/skfp/hwt.c
+++ b/drivers/net/fddi/skfp/hwt.c
@@ -27,10 +27,6 @@
#include "h/fddi.h"
#include "h/smc.h"
-#ifndef lint
-static const char ID_sccs[] = "@(#)hwt.c 1.13 97/04/23 (C) SK " ;
-#endif
-
/*
* Prototypes of local functions.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 16/30] net: fddi: skfp: srf: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (14 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 15/30] net: fddi: skfp: hwt: " Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:44 ` [PATCH 17/30] net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
` (13 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/srf.c:30:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/srf.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/fddi/skfp/srf.c b/drivers/net/fddi/skfp/srf.c
index f98d060b0f5b0..4cad68c3f49b3 100644
--- a/drivers/net/fddi/skfp/srf.c
+++ b/drivers/net/fddi/skfp/srf.c
@@ -26,11 +26,6 @@
#ifndef SLIM_SMT
#ifndef BOOT
-#ifndef lint
-static const char ID_sccs[] = "@(#)srf.c 1.18 97/08/04 (C) SK " ;
-#endif
-
-
/*
* function declarations
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 17/30] net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (15 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 16/30] net: fddi: skfp: srf: " Lee Jones
@ 2020-11-02 11:44 ` Lee Jones
2020-11-02 11:45 ` [PATCH 18/30] net: fddi: skfp: drvfbi: Remove defined but unused variable 'ID_sccs' Lee Jones
` (12 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:44 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Inaky Perez-Gonzalez, linux-wimax, Jakub Kicinski,
Yanir Lubetkin, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/fw.c:647: warning: Function parameter or member '__chunk_len' not described in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:647: warning: Excess function parameter 'chunk_len' description in 'i2400m_download_chunk'
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
index 9970857063374..edb5eba0898b0 100644
--- a/drivers/staging/wimax/i2400m/fw.c
+++ b/drivers/staging/wimax/i2400m/fw.c
@@ -636,7 +636,7 @@ ssize_t i2400m_bm_cmd(struct i2400m *i2400m,
*
* @i2400m: device descriptor
* @chunk: the buffer to write
- * @chunk_len: length of the buffer to write
+ * @__chunk_len: length of the buffer to write
* @addr: address in the device memory space
* @direct: bootrom write mode
* @do_csum: should a checksum validation be performed
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 18/30] net: fddi: skfp: drvfbi: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (16 preceding siblings ...)
2020-11-02 11:44 ` [PATCH 17/30] net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 11:45 ` [PATCH 19/30] net: fddi: skfp: ess: " Lee Jones
` (11 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, Heiner Kallweit, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/drvfbi.c:26:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/drvfbi.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/fddi/skfp/drvfbi.c b/drivers/net/fddi/skfp/drvfbi.c
index cc9ac572423e9..e9b9614639cdd 100644
--- a/drivers/net/fddi/skfp/drvfbi.c
+++ b/drivers/net/fddi/skfp/drvfbi.c
@@ -22,10 +22,6 @@
#include <linux/bitrev.h>
#include <linux/pci.h>
-#ifndef lint
-static const char ID_sccs[] = "@(#)drvfbi.c 1.63 99/02/11 (C) SK " ;
-#endif
-
/*
* PCM active state
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 19/30] net: fddi: skfp: ess: Remove defined but unused variable 'ID_sccs'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (17 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 18/30] net: fddi: skfp: drvfbi: Remove defined but unused variable 'ID_sccs' Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 11:45 ` [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues Lee Jones
` (10 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, Tetsuo Handa, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/fddi/skfp/ess.c:43:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/fddi/skfp/ess.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/fddi/skfp/ess.c b/drivers/net/fddi/skfp/ess.c
index afd5ca39f43b6..35110c0c00a04 100644
--- a/drivers/net/fddi/skfp/ess.c
+++ b/drivers/net/fddi/skfp/ess.c
@@ -40,7 +40,6 @@
#ifdef ESS
#ifndef lint
-static const char ID_sccs[] = "@(#)ess.c 1.10 96/02/23 (C) SK" ;
#define LINT_USE(x)
#else
#define LINT_USE(x) (x)=(x)
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (18 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 19/30] net: fddi: skfp: ess: " Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-03 16:18 ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 21/30] net: ethernet: dec: tulip: tulip_core: 'last_irq' is only used when i386 or x86 Lee Jones
` (9 subsequent siblings)
29 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Harry Morris, Alexander Aring, Stefan Schmidt,
Jakub Kicinski, linux-wpan, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/ieee802154/ca8210.c:326: warning: Function parameter or member 'readq' not described in 'ca8210_test'
drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'spi_transfer_complete' not described in 'ca8210_priv'
drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'sync_exchange_complete' not described in 'ca8210_priv'
drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'promiscuous' not described in 'ca8210_priv'
drivers/net/ieee802154/ca8210.c:430: warning: Function parameter or member 'short_address' not described in 'macaddr'
drivers/net/ieee802154/ca8210.c:723: warning: Function parameter or member 'cas_ctl' not described in 'ca8210_rx_done'
drivers/net/ieee802154/ca8210.c:723: warning: Excess function parameter 'arg' description in 'ca8210_rx_done'
drivers/net/ieee802154/ca8210.c:1289: warning: Excess function parameter 'device_ref' description in 'tdme_checkpibattribute'
drivers/net/ieee802154/ca8210.c:3054: warning: Function parameter or member 'spi_device' not described in 'ca8210_remove'
drivers/net/ieee802154/ca8210.c:3054: warning: Excess function parameter 'priv' description in 'ca8210_remove'
drivers/net/ieee802154/ca8210.c:3104: warning: Function parameter or member 'spi_device' not described in 'ca8210_probe'
drivers/net/ieee802154/ca8210.c:3104: warning: Excess function parameter 'priv' description in 'ca8210_probe'
Cc: Harry Morris <h.morris@cascoda.com>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wpan@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/ieee802154/ca8210.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 4eb64709d44cb..9b3ab7acad37e 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -316,6 +316,7 @@ struct cas_control {
* struct ca8210_test - ca8210 test interface structure
* @ca8210_dfs_spi_int: pointer to the entry in the debug fs for this device
* @up_fifo: fifo for upstream messages
+ * @readq: read wait queue
*
* This structure stores all the data pertaining to the debug interface
*/
@@ -346,12 +347,12 @@ struct ca8210_test {
* @ca8210_is_awake: nonzero if ca8210 is initialised, ready for comms
* @sync_down: counts number of downstream synchronous commands
* @sync_up: counts number of upstream synchronous commands
- * @spi_transfer_complete completion object for a single spi_transfer
- * @sync_exchange_complete completion object for a complete synchronous API
- * exchange
- * @promiscuous whether the ca8210 is in promiscuous mode or not
+ * @spi_transfer_complete: completion object for a single spi_transfer
+ * @sync_exchange_complete: completion object for a complete synchronous API
+ * exchange
+ * @promiscuous: whether the ca8210 is in promiscuous mode or not
* @retries: records how many times the current pending spi
- * transfer has been retried
+ * transfer has been retried
*/
struct ca8210_priv {
struct spi_device *spi;
@@ -420,8 +421,8 @@ struct fulladdr {
/**
* union macaddr: generic MAC address container
- * @short_addr: 16-bit short address
- * @ieee_address: 64-bit extended address as LE byte array
+ * @short_address: 16-bit short address
+ * @ieee_address: 64-bit extended address as LE byte array
*
*/
union macaddr {
@@ -714,7 +715,7 @@ static void ca8210_mlme_reset_worker(struct work_struct *work)
/**
* ca8210_rx_done() - Calls various message dispatches responding to a received
* command
- * @arg: Pointer to the cas_control object for the relevant spi transfer
+ * @cas_ctrl: Pointer to the cas_control object for the relevant spi transfer
*
* Presents a received SAP command from the ca8210 to the Cascoda EVBME, test
* interface and network driver.
@@ -1277,7 +1278,6 @@ static u8 tdme_channelinit(u8 channel, void *device_ref)
* @pib_attribute: Attribute Number
* @pib_attribute_length: Attribute length
* @pib_attribute_value: Pointer to Attribute Value
- * @device_ref: Nondescript pointer to target device
*
* Return: 802.15.4 status code of checks
*/
@@ -3046,7 +3046,7 @@ static void ca8210_test_interface_clear(struct ca8210_priv *priv)
/**
* ca8210_remove() - Shut down a ca8210 upon being disconnected
- * @priv: Pointer to private data structure
+ * @spi_device: Pointer to spi device data structure
*
* Return: 0 or linux error code
*/
@@ -3096,7 +3096,7 @@ static int ca8210_remove(struct spi_device *spi_device)
/**
* ca8210_probe() - Set up a connected ca8210 upon being detected by the system
- * @priv: Pointer to private data structure
+ * @spi_device: Pointer to spi device data structure
*
* Return: 0 or linux error code
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 21/30] net: ethernet: dec: tulip: tulip_core: 'last_irq' is only used when i386 or x86
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (19 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 11:45 ` [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members Lee Jones
` (8 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, netdev, linux-parisc
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/dec/tulip/tulip_core.c: In function ‘tulip_init_one’:
drivers/net/ethernet/dec/tulip/tulip_core.c:1296:13: warning: variable ‘last_irq’ set but not used [-Wunused-but-set-variable]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Cc: linux-parisc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index e7b0d7de40fd6..94f615869827c 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1293,7 +1293,7 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
static unsigned char last_phys_addr[ETH_ALEN] = {
0x00, 'L', 'i', 'n', 'u', 'x'
};
- static int last_irq;
+ static int __maybe_unused last_irq;
int i, irq;
unsigned short sum;
unsigned char *ee_data;
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (20 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 21/30] net: ethernet: dec: tulip: tulip_core: 'last_irq' is only used when i386 or x86 Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 12:06 ` Hayes Wang
2020-11-02 11:45 ` [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc Lee Jones
` (7 subsequent siblings)
29 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Jakub Kicinski, Hayes Wang, nic maintainers,
linux-usb, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/usb/r8152.c:934: warning: Function parameter or member 'blk_hdr' not described in 'fw_mac'
drivers/net/usb/r8152.c:934: warning: Function parameter or member 'reserved' not described in 'fw_mac'
drivers/net/usb/r8152.c:947: warning: Function parameter or member 'blk_hdr' not described in 'fw_phy_patch_key'
drivers/net/usb/r8152.c:947: warning: Function parameter or member 'reserved' not described in 'fw_phy_patch_key'
drivers/net/usb/r8152.c:986: warning: Function parameter or member 'blk_hdr' not described in 'fw_phy_nc'
drivers/net/usb/r8152.c:986: warning: Function parameter or member 'mode_pre' not described in 'fw_phy_nc'
drivers/net/usb/r8152.c:986: warning: Function parameter or member 'mode_post' not described in 'fw_phy_nc'
drivers/net/usb/r8152.c:986: warning: Function parameter or member 'reserved' not described in 'fw_phy_nc'
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Hayes Wang <hayeswang@realtek.com>
Cc: nic maintainers <nic_swsd@realtek.com>
Cc: linux-usb@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/usb/r8152.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index b1770489aca51..cebe2dc15c3f0 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -898,6 +898,7 @@ struct fw_header {
* struct fw_mac - a firmware block used by RTL_FW_PLA and RTL_FW_USB.
* The layout of the firmware block is:
* <struct fw_mac> + <info> + <firmware data>.
+ * @blk_hdr: firmware descriptor (type, length)
* @fw_offset: offset of the firmware binary data. The start address of
* the data would be the address of struct fw_mac + @fw_offset.
* @fw_reg: the register to load the firmware. Depends on chip.
@@ -911,6 +912,7 @@ struct fw_header {
* @bp_num: the break point number which needs to be set for this firmware.
* Depends on the firmware.
* @bp: break points. Depends on firmware.
+ * @reserved: reserved space (unused)
* @fw_ver_reg: the register to store the fw version.
* @fw_ver_data: the firmware version of the current type.
* @info: additional information for debugging, and is followed by the
@@ -936,8 +938,10 @@ struct fw_mac {
/**
* struct fw_phy_patch_key - a firmware block used by RTL_FW_PHY_START.
* This is used to set patch key when loading the firmware of PHY.
+ * @blk_hdr: firmware descriptor (type, length)
* @key_reg: the register to write the patch key.
* @key_data: patch key.
+ * @reserved: reserved space (unused)
*/
struct fw_phy_patch_key {
struct fw_block blk_hdr;
@@ -950,6 +954,7 @@ struct fw_phy_patch_key {
* struct fw_phy_nc - a firmware block used by RTL_FW_PHY_NC.
* The layout of the firmware block is:
* <struct fw_phy_nc> + <info> + <firmware data>.
+ * @blk_hdr: firmware descriptor (type, length)
* @fw_offset: offset of the firmware binary data. The start address of
* the data would be the address of struct fw_phy_nc + @fw_offset.
* @fw_reg: the register to load the firmware. Depends on chip.
@@ -960,6 +965,7 @@ struct fw_phy_patch_key {
* @mode_reg: the regitster of switching the mode.
* @mod_pre: the mode needing to be set before loading the firmware.
* @mod_post: the mode to be set when finishing to load the firmware.
+ * @reserved: reserved space (unused)
* @bp_start: the start register of break points. Depends on chip.
* @bp_num: the break point number which needs to be set for this firmware.
* Depends on the firmware.
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (21 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-03 16:19 ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 24/30] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones
` (6 subsequent siblings)
29 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Harry Morris, Alexander Aring, Stefan Schmidt,
Jakub Kicinski, linux-wpan, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/ieee802154/ca8210.c:724: warning: Function parameter or member 'cas_ctl' not described in 'ca8210_rx_done'
drivers/net/ieee802154/ca8210.c:724: warning: Excess function parameter 'cas_ctrl' description in 'ca8210_rx_done'
Cc: Harry Morris <h.morris@cascoda.com>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wpan@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/ieee802154/ca8210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 9b3ab7acad37e..3a2824f24caa8 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -715,7 +715,7 @@ static void ca8210_mlme_reset_worker(struct work_struct *work)
/**
* ca8210_rx_done() - Calls various message dispatches responding to a received
* command
- * @cas_ctrl: Pointer to the cas_control object for the relevant spi transfer
+ * @cas_ctl: Pointer to the cas_control object for the relevant spi transfer
*
* Presents a received SAP command from the ca8210 to the Cascoda EVBME, test
* interface and network driver.
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 24/30] net: usb: lan78xx: Remove lots of set but unused 'ret' variables
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (22 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 11:45 ` [PATCH 25/30] net: macsec: Add missing documentation for 'gro_cells' Lee Jones
` (5 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Woojung Huh, Microchip Linux Driver Support,
Jakub Kicinski, netdev, linux-usb
Fixes the following W=1 kernel build warning(s):
drivers/net/usb/lan78xx.c: In function ‘lan78xx_read_raw_otp’:
drivers/net/usb/lan78xx.c:825:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_write_raw_otp’:
drivers/net/usb/lan78xx.c:879:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_deferred_multicast_write’:
drivers/net/usb/lan78xx.c:1041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_update_flowcontrol’:
drivers/net/usb/lan78xx.c:1127:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_init_mac_address’:
drivers/net/usb/lan78xx.c:1666:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_link_status_change’:
drivers/net/usb/lan78xx.c:1841:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_irq_bus_sync_unlock’:
drivers/net/usb/lan78xx.c:1920:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan8835_fixup’:
drivers/net/usb/lan78xx.c:1994:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_rx_max_frame_length’:
drivers/net/usb/lan78xx.c:2192:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_change_mtu’:
drivers/net/usb/lan78xx.c:2270:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_mac_addr’:
drivers/net/usb/lan78xx.c:2299:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_features’:
drivers/net/usb/lan78xx.c:2333:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_suspend’:
drivers/net/usb/lan78xx.c:3807:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
Cc: Woojung Huh <woojung.huh@microchip.com>
Cc: Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/usb/lan78xx.c | 168 ++++++++++++++++++--------------------
1 file changed, 78 insertions(+), 90 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 65b315bc60abd..bf243edeb0641 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -822,20 +822,19 @@ static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset,
u32 length, u8 *data)
{
int i;
- int ret;
u32 buf;
unsigned long timeout;
- ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf);
+ lan78xx_read_reg(dev, OTP_PWR_DN, &buf);
if (buf & OTP_PWR_DN_PWRDN_N_) {
/* clear it and wait to be cleared */
- ret = lan78xx_write_reg(dev, OTP_PWR_DN, 0);
+ lan78xx_write_reg(dev, OTP_PWR_DN, 0);
timeout = jiffies + HZ;
do {
usleep_range(1, 10);
- ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf);
+ lan78xx_read_reg(dev, OTP_PWR_DN, &buf);
if (time_after(jiffies, timeout)) {
netdev_warn(dev->net,
"timeout on OTP_PWR_DN");
@@ -845,18 +844,18 @@ static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset,
}
for (i = 0; i < length; i++) {
- ret = lan78xx_write_reg(dev, OTP_ADDR1,
+ lan78xx_write_reg(dev, OTP_ADDR1,
((offset + i) >> 8) & OTP_ADDR1_15_11);
- ret = lan78xx_write_reg(dev, OTP_ADDR2,
+ lan78xx_write_reg(dev, OTP_ADDR2,
((offset + i) & OTP_ADDR2_10_3));
- ret = lan78xx_write_reg(dev, OTP_FUNC_CMD, OTP_FUNC_CMD_READ_);
- ret = lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_);
+ lan78xx_write_reg(dev, OTP_FUNC_CMD, OTP_FUNC_CMD_READ_);
+ lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_);
timeout = jiffies + HZ;
do {
udelay(1);
- ret = lan78xx_read_reg(dev, OTP_STATUS, &buf);
+ lan78xx_read_reg(dev, OTP_STATUS, &buf);
if (time_after(jiffies, timeout)) {
netdev_warn(dev->net,
"timeout on OTP_STATUS");
@@ -864,7 +863,7 @@ static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset,
}
} while (buf & OTP_STATUS_BUSY_);
- ret = lan78xx_read_reg(dev, OTP_RD_DATA, &buf);
+ lan78xx_read_reg(dev, OTP_RD_DATA, &buf);
data[i] = (u8)(buf & 0xFF);
}
@@ -876,20 +875,19 @@ static int lan78xx_write_raw_otp(struct lan78xx_net *dev, u32 offset,
u32 length, u8 *data)
{
int i;
- int ret;
u32 buf;
unsigned long timeout;
- ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf);
+ lan78xx_read_reg(dev, OTP_PWR_DN, &buf);
if (buf & OTP_PWR_DN_PWRDN_N_) {
/* clear it and wait to be cleared */
- ret = lan78xx_write_reg(dev, OTP_PWR_DN, 0);
+ lan78xx_write_reg(dev, OTP_PWR_DN, 0);
timeout = jiffies + HZ;
do {
udelay(1);
- ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf);
+ lan78xx_read_reg(dev, OTP_PWR_DN, &buf);
if (time_after(jiffies, timeout)) {
netdev_warn(dev->net,
"timeout on OTP_PWR_DN completion");
@@ -899,21 +897,21 @@ static int lan78xx_write_raw_otp(struct lan78xx_net *dev, u32 offset,
}
/* set to BYTE program mode */
- ret = lan78xx_write_reg(dev, OTP_PRGM_MODE, OTP_PRGM_MODE_BYTE_);
+ lan78xx_write_reg(dev, OTP_PRGM_MODE, OTP_PRGM_MODE_BYTE_);
for (i = 0; i < length; i++) {
- ret = lan78xx_write_reg(dev, OTP_ADDR1,
+ lan78xx_write_reg(dev, OTP_ADDR1,
((offset + i) >> 8) & OTP_ADDR1_15_11);
- ret = lan78xx_write_reg(dev, OTP_ADDR2,
+ lan78xx_write_reg(dev, OTP_ADDR2,
((offset + i) & OTP_ADDR2_10_3));
- ret = lan78xx_write_reg(dev, OTP_PRGM_DATA, data[i]);
- ret = lan78xx_write_reg(dev, OTP_TST_CMD, OTP_TST_CMD_PRGVRFY_);
- ret = lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_);
+ lan78xx_write_reg(dev, OTP_PRGM_DATA, data[i]);
+ lan78xx_write_reg(dev, OTP_TST_CMD, OTP_TST_CMD_PRGVRFY_);
+ lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_);
timeout = jiffies + HZ;
do {
udelay(1);
- ret = lan78xx_read_reg(dev, OTP_STATUS, &buf);
+ lan78xx_read_reg(dev, OTP_STATUS, &buf);
if (time_after(jiffies, timeout)) {
netdev_warn(dev->net,
"Timeout on OTP_STATUS completion");
@@ -1038,7 +1036,6 @@ static void lan78xx_deferred_multicast_write(struct work_struct *param)
container_of(param, struct lan78xx_priv, set_multicast);
struct lan78xx_net *dev = pdata->dev;
int i;
- int ret;
netif_dbg(dev, drv, dev->net, "deferred multicast write 0x%08x\n",
pdata->rfe_ctl);
@@ -1047,14 +1044,14 @@ static void lan78xx_deferred_multicast_write(struct work_struct *param)
DP_SEL_VHF_HASH_LEN, pdata->mchash_table);
for (i = 1; i < NUM_OF_MAF; i++) {
- ret = lan78xx_write_reg(dev, MAF_HI(i), 0);
- ret = lan78xx_write_reg(dev, MAF_LO(i),
+ lan78xx_write_reg(dev, MAF_HI(i), 0);
+ lan78xx_write_reg(dev, MAF_LO(i),
pdata->pfilter_table[i][1]);
- ret = lan78xx_write_reg(dev, MAF_HI(i),
+ lan78xx_write_reg(dev, MAF_HI(i),
pdata->pfilter_table[i][0]);
}
- ret = lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
+ lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
}
static void lan78xx_set_multicast(struct net_device *netdev)
@@ -1124,7 +1121,6 @@ static int lan78xx_update_flowcontrol(struct lan78xx_net *dev, u8 duplex,
u16 lcladv, u16 rmtadv)
{
u32 flow = 0, fct_flow = 0;
- int ret;
u8 cap;
if (dev->fc_autoneg)
@@ -1147,10 +1143,10 @@ static int lan78xx_update_flowcontrol(struct lan78xx_net *dev, u8 duplex,
(cap & FLOW_CTRL_RX ? "enabled" : "disabled"),
(cap & FLOW_CTRL_TX ? "enabled" : "disabled"));
- ret = lan78xx_write_reg(dev, FCT_FLOW, fct_flow);
+ lan78xx_write_reg(dev, FCT_FLOW, fct_flow);
/* threshold value should be set before enabling flow */
- ret = lan78xx_write_reg(dev, FLOW, flow);
+ lan78xx_write_reg(dev, FLOW, flow);
return 0;
}
@@ -1663,11 +1659,10 @@ static const struct ethtool_ops lan78xx_ethtool_ops = {
static void lan78xx_init_mac_address(struct lan78xx_net *dev)
{
u32 addr_lo, addr_hi;
- int ret;
u8 addr[6];
- ret = lan78xx_read_reg(dev, RX_ADDRL, &addr_lo);
- ret = lan78xx_read_reg(dev, RX_ADDRH, &addr_hi);
+ lan78xx_read_reg(dev, RX_ADDRL, &addr_lo);
+ lan78xx_read_reg(dev, RX_ADDRH, &addr_hi);
addr[0] = addr_lo & 0xFF;
addr[1] = (addr_lo >> 8) & 0xFF;
@@ -1700,12 +1695,12 @@ static void lan78xx_init_mac_address(struct lan78xx_net *dev)
(addr[2] << 16) | (addr[3] << 24);
addr_hi = addr[4] | (addr[5] << 8);
- ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo);
- ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi);
+ lan78xx_write_reg(dev, RX_ADDRL, addr_lo);
+ lan78xx_write_reg(dev, RX_ADDRH, addr_hi);
}
- ret = lan78xx_write_reg(dev, MAF_LO(0), addr_lo);
- ret = lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_);
+ lan78xx_write_reg(dev, MAF_LO(0), addr_lo);
+ lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_);
ether_addr_copy(dev->net->dev_addr, addr);
}
@@ -1838,7 +1833,7 @@ static void lan78xx_remove_mdio(struct lan78xx_net *dev)
static void lan78xx_link_status_change(struct net_device *net)
{
struct phy_device *phydev = net->phydev;
- int ret, temp;
+ int temp;
/* At forced 100 F/H mode, chip may fail to set mode correctly
* when cable is switched between long(~50+m) and short one.
@@ -1849,7 +1844,7 @@ static void lan78xx_link_status_change(struct net_device *net)
/* disable phy interrupt */
temp = phy_read(phydev, LAN88XX_INT_MASK);
temp &= ~LAN88XX_INT_MASK_MDINTPIN_EN_;
- ret = phy_write(phydev, LAN88XX_INT_MASK, temp);
+ phy_write(phydev, LAN88XX_INT_MASK, temp);
temp = phy_read(phydev, MII_BMCR);
temp &= ~(BMCR_SPEED100 | BMCR_SPEED1000);
@@ -1863,7 +1858,7 @@ static void lan78xx_link_status_change(struct net_device *net)
/* enable phy interrupt back */
temp = phy_read(phydev, LAN88XX_INT_MASK);
temp |= LAN88XX_INT_MASK_MDINTPIN_EN_;
- ret = phy_write(phydev, LAN88XX_INT_MASK, temp);
+ phy_write(phydev, LAN88XX_INT_MASK, temp);
}
}
@@ -1917,14 +1912,13 @@ static void lan78xx_irq_bus_sync_unlock(struct irq_data *irqd)
struct lan78xx_net *dev =
container_of(data, struct lan78xx_net, domain_data);
u32 buf;
- int ret;
/* call register access here because irq_bus_lock & irq_bus_sync_unlock
* are only two callbacks executed in non-atomic contex.
*/
- ret = lan78xx_read_reg(dev, INT_EP_CTL, &buf);
+ lan78xx_read_reg(dev, INT_EP_CTL, &buf);
if (buf != data->irqenable)
- ret = lan78xx_write_reg(dev, INT_EP_CTL, data->irqenable);
+ lan78xx_write_reg(dev, INT_EP_CTL, data->irqenable);
mutex_unlock(&data->irq_lock);
}
@@ -1991,7 +1985,6 @@ static void lan78xx_remove_irq_domain(struct lan78xx_net *dev)
static int lan8835_fixup(struct phy_device *phydev)
{
int buf;
- int ret;
struct lan78xx_net *dev = netdev_priv(phydev->attached_dev);
/* LED2/PME_N/IRQ_N/RGMII_ID pin to IRQ_N mode */
@@ -2001,11 +1994,11 @@ static int lan8835_fixup(struct phy_device *phydev)
phy_write_mmd(phydev, MDIO_MMD_PCS, 0x8010, buf);
/* RGMII MAC TXC Delay Enable */
- ret = lan78xx_write_reg(dev, MAC_RGMII_ID,
+ lan78xx_write_reg(dev, MAC_RGMII_ID,
MAC_RGMII_ID_TXC_DELAY_EN_);
/* RGMII TX DLL Tune Adjust */
- ret = lan78xx_write_reg(dev, RGMII_TX_BYP_DLL, 0x3D00);
+ lan78xx_write_reg(dev, RGMII_TX_BYP_DLL, 0x3D00);
dev->interface = PHY_INTERFACE_MODE_RGMII_TXID;
@@ -2189,28 +2182,27 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
static int lan78xx_set_rx_max_frame_length(struct lan78xx_net *dev, int size)
{
- int ret = 0;
u32 buf;
bool rxenabled;
- ret = lan78xx_read_reg(dev, MAC_RX, &buf);
+ lan78xx_read_reg(dev, MAC_RX, &buf);
rxenabled = ((buf & MAC_RX_RXEN_) != 0);
if (rxenabled) {
buf &= ~MAC_RX_RXEN_;
- ret = lan78xx_write_reg(dev, MAC_RX, buf);
+ lan78xx_write_reg(dev, MAC_RX, buf);
}
/* add 4 to size for FCS */
buf &= ~MAC_RX_MAX_SIZE_MASK_;
buf |= (((size + 4) << MAC_RX_MAX_SIZE_SHIFT_) & MAC_RX_MAX_SIZE_MASK_);
- ret = lan78xx_write_reg(dev, MAC_RX, buf);
+ lan78xx_write_reg(dev, MAC_RX, buf);
if (rxenabled) {
buf |= MAC_RX_RXEN_;
- ret = lan78xx_write_reg(dev, MAC_RX, buf);
+ lan78xx_write_reg(dev, MAC_RX, buf);
}
return 0;
@@ -2267,13 +2259,12 @@ static int lan78xx_change_mtu(struct net_device *netdev, int new_mtu)
int ll_mtu = new_mtu + netdev->hard_header_len;
int old_hard_mtu = dev->hard_mtu;
int old_rx_urb_size = dev->rx_urb_size;
- int ret;
/* no second zero-length packet read wanted after mtu-sized packets */
if ((ll_mtu % dev->maxpacket) == 0)
return -EDOM;
- ret = lan78xx_set_rx_max_frame_length(dev, new_mtu + VLAN_ETH_HLEN);
+ lan78xx_set_rx_max_frame_length(dev, new_mtu + VLAN_ETH_HLEN);
netdev->mtu = new_mtu;
@@ -2296,7 +2287,6 @@ static int lan78xx_set_mac_addr(struct net_device *netdev, void *p)
struct lan78xx_net *dev = netdev_priv(netdev);
struct sockaddr *addr = p;
u32 addr_lo, addr_hi;
- int ret;
if (netif_running(netdev))
return -EBUSY;
@@ -2313,12 +2303,12 @@ static int lan78xx_set_mac_addr(struct net_device *netdev, void *p)
addr_hi = netdev->dev_addr[4] |
netdev->dev_addr[5] << 8;
- ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo);
- ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi);
+ lan78xx_write_reg(dev, RX_ADDRL, addr_lo);
+ lan78xx_write_reg(dev, RX_ADDRH, addr_hi);
/* Added to support MAC address changes */
- ret = lan78xx_write_reg(dev, MAF_LO(0), addr_lo);
- ret = lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_);
+ lan78xx_write_reg(dev, MAF_LO(0), addr_lo);
+ lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_);
return 0;
}
@@ -2330,7 +2320,6 @@ static int lan78xx_set_features(struct net_device *netdev,
struct lan78xx_net *dev = netdev_priv(netdev);
struct lan78xx_priv *pdata = (struct lan78xx_priv *)(dev->data[0]);
unsigned long flags;
- int ret;
spin_lock_irqsave(&pdata->rfe_ctl_lock, flags);
@@ -2354,7 +2343,7 @@ static int lan78xx_set_features(struct net_device *netdev,
spin_unlock_irqrestore(&pdata->rfe_ctl_lock, flags);
- ret = lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
+ lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
return 0;
}
@@ -3804,7 +3793,6 @@ static u16 lan78xx_wakeframe_crc16(const u8 *buf, int len)
static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol)
{
u32 buf;
- int ret;
int mask_index;
u16 crc;
u32 temp_wucsr;
@@ -3813,26 +3801,26 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol)
const u8 ipv6_multicast[3] = { 0x33, 0x33 };
const u8 arp_type[2] = { 0x08, 0x06 };
- ret = lan78xx_read_reg(dev, MAC_TX, &buf);
+ lan78xx_read_reg(dev, MAC_TX, &buf);
buf &= ~MAC_TX_TXEN_;
- ret = lan78xx_write_reg(dev, MAC_TX, buf);
- ret = lan78xx_read_reg(dev, MAC_RX, &buf);
+ lan78xx_write_reg(dev, MAC_TX, buf);
+ lan78xx_read_reg(dev, MAC_RX, &buf);
buf &= ~MAC_RX_RXEN_;
- ret = lan78xx_write_reg(dev, MAC_RX, buf);
+ lan78xx_write_reg(dev, MAC_RX, buf);
- ret = lan78xx_write_reg(dev, WUCSR, 0);
- ret = lan78xx_write_reg(dev, WUCSR2, 0);
- ret = lan78xx_write_reg(dev, WK_SRC, 0xFFF1FF1FUL);
+ lan78xx_write_reg(dev, WUCSR, 0);
+ lan78xx_write_reg(dev, WUCSR2, 0);
+ lan78xx_write_reg(dev, WK_SRC, 0xFFF1FF1FUL);
temp_wucsr = 0;
temp_pmt_ctl = 0;
- ret = lan78xx_read_reg(dev, PMT_CTL, &temp_pmt_ctl);
+ lan78xx_read_reg(dev, PMT_CTL, &temp_pmt_ctl);
temp_pmt_ctl &= ~PMT_CTL_RES_CLR_WKP_EN_;
temp_pmt_ctl |= PMT_CTL_RES_CLR_WKP_STS_;
for (mask_index = 0; mask_index < NUM_OF_WUF_CFG; mask_index++)
- ret = lan78xx_write_reg(dev, WUF_CFG(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_CFG(mask_index), 0);
mask_index = 0;
if (wol & WAKE_PHY) {
@@ -3861,30 +3849,30 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol)
/* set WUF_CFG & WUF_MASK for IPv4 Multicast */
crc = lan78xx_wakeframe_crc16(ipv4_multicast, 3);
- ret = lan78xx_write_reg(dev, WUF_CFG(mask_index),
+ lan78xx_write_reg(dev, WUF_CFG(mask_index),
WUF_CFGX_EN_ |
WUF_CFGX_TYPE_MCAST_ |
(0 << WUF_CFGX_OFFSET_SHIFT_) |
(crc & WUF_CFGX_CRC16_MASK_));
- ret = lan78xx_write_reg(dev, WUF_MASK0(mask_index), 7);
- ret = lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0);
- ret = lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0);
- ret = lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_MASK0(mask_index), 7);
+ lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0);
mask_index++;
/* for IPv6 Multicast */
crc = lan78xx_wakeframe_crc16(ipv6_multicast, 2);
- ret = lan78xx_write_reg(dev, WUF_CFG(mask_index),
+ lan78xx_write_reg(dev, WUF_CFG(mask_index),
WUF_CFGX_EN_ |
WUF_CFGX_TYPE_MCAST_ |
(0 << WUF_CFGX_OFFSET_SHIFT_) |
(crc & WUF_CFGX_CRC16_MASK_));
- ret = lan78xx_write_reg(dev, WUF_MASK0(mask_index), 3);
- ret = lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0);
- ret = lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0);
- ret = lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_MASK0(mask_index), 3);
+ lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0);
mask_index++;
temp_pmt_ctl |= PMT_CTL_WOL_EN_;
@@ -3905,16 +3893,16 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol)
* for packettype (offset 12,13) = ARP (0x0806)
*/
crc = lan78xx_wakeframe_crc16(arp_type, 2);
- ret = lan78xx_write_reg(dev, WUF_CFG(mask_index),
+ lan78xx_write_reg(dev, WUF_CFG(mask_index),
WUF_CFGX_EN_ |
WUF_CFGX_TYPE_ALL_ |
(0 << WUF_CFGX_OFFSET_SHIFT_) |
(crc & WUF_CFGX_CRC16_MASK_));
- ret = lan78xx_write_reg(dev, WUF_MASK0(mask_index), 0x3000);
- ret = lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0);
- ret = lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0);
- ret = lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_MASK0(mask_index), 0x3000);
+ lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0);
+ lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0);
mask_index++;
temp_pmt_ctl |= PMT_CTL_WOL_EN_;
@@ -3922,7 +3910,7 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol)
temp_pmt_ctl |= PMT_CTL_SUS_MODE_0_;
}
- ret = lan78xx_write_reg(dev, WUCSR, temp_wucsr);
+ lan78xx_write_reg(dev, WUCSR, temp_wucsr);
/* when multiple WOL bits are set */
if (hweight_long((unsigned long)wol) > 1) {
@@ -3930,16 +3918,16 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol)
temp_pmt_ctl &= ~PMT_CTL_SUS_MODE_MASK_;
temp_pmt_ctl |= PMT_CTL_SUS_MODE_0_;
}
- ret = lan78xx_write_reg(dev, PMT_CTL, temp_pmt_ctl);
+ lan78xx_write_reg(dev, PMT_CTL, temp_pmt_ctl);
/* clear WUPS */
- ret = lan78xx_read_reg(dev, PMT_CTL, &buf);
+ lan78xx_read_reg(dev, PMT_CTL, &buf);
buf |= PMT_CTL_WUPS_MASK_;
- ret = lan78xx_write_reg(dev, PMT_CTL, buf);
+ lan78xx_write_reg(dev, PMT_CTL, buf);
- ret = lan78xx_read_reg(dev, MAC_RX, &buf);
+ lan78xx_read_reg(dev, MAC_RX, &buf);
buf |= MAC_RX_RXEN_;
- ret = lan78xx_write_reg(dev, MAC_RX, buf);
+ lan78xx_write_reg(dev, MAC_RX, buf);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 25/30] net: macsec: Add missing documentation for 'gro_cells'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (23 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 24/30] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 11:45 ` [PATCH 26/30] net: macvlan: Demote nonconformant function header Lee Jones
` (4 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, Sabrina Dubroca, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/macsec.c:113: warning: Function parameter or member 'gro_cells' not described in 'macsec_dev'
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/macsec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
index 11ca5fa902a16..92425e1fd70c0 100644
--- a/drivers/net/macsec.c
+++ b/drivers/net/macsec.c
@@ -101,6 +101,7 @@ struct pcpu_secy_stats {
* @real_dev: pointer to underlying netdevice
* @stats: MACsec device stats
* @secys: linked list of SecY's on the underlying device
+ * @gro_cells: pointer to the Generic Receive Offload cell
* @offload: status of offloading on the MACsec device
*/
struct macsec_dev {
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 26/30] net: macvlan: Demote nonconformant function header
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (24 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 25/30] net: macsec: Add missing documentation for 'gro_cells' Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 11:45 ` [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs Lee Jones
` (3 subsequent siblings)
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Jakub Kicinski, Patrick McHardy, Broadband Ltd,
Ben Greear, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/macvlan.c:1350: warning: Function parameter or member 'vlan' not described in 'macvlan_changelink_sources'
drivers/net/macvlan.c:1350: warning: Function parameter or member 'mode' not described in 'macvlan_changelink_sources'
drivers/net/macvlan.c:1350: warning: Function parameter or member 'data' not described in 'macvlan_changelink_sources'
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Patrick McHardy <kaber@trash.net>
Cc: Broadband Ltd <ajz@cambridgebroadband.com>
Cc: Ben Greear <greearb@candelatech.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/macvlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index c8d803d3616c9..dd960209da943 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -1339,7 +1339,7 @@ static int macvlan_validate(struct nlattr *tb[], struct nlattr *data[],
return 0;
}
-/**
+/*
* reconfigure list of remote source mac address
* (only for macvlan devices in source mode)
* Note regarding alignment: all netlink data is aligned to 4 Byte, which
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (25 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 26/30] net: macvlan: Demote nonconformant function header Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 12:06 ` Hayes Wang
2020-11-02 11:45 ` [PATCH 28/30] net: netconsole: Add description for 'netconsole_target's extended attribute Lee Jones
` (2 subsequent siblings)
29 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Jakub Kicinski, Hayes Wang, nic maintainers,
linux-usb, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/usb/r8152.c:992: warning: Function parameter or member 'mode_pre' not described in 'fw_phy_nc'
drivers/net/usb/r8152.c:992: warning: Function parameter or member 'mode_post' not described in 'fw_phy_nc'
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Hayes Wang <hayeswang@realtek.com>
Cc: nic maintainers <nic_swsd@realtek.com>
Cc: linux-usb@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/usb/r8152.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index cebe2dc15c3f0..b9b3d19a2e988 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -963,8 +963,8 @@ struct fw_phy_patch_key {
* @patch_en_addr: the register of enabling patch mode. Depends on chip.
* @patch_en_value: patch mode enabled mask. Depends on the firmware.
* @mode_reg: the regitster of switching the mode.
- * @mod_pre: the mode needing to be set before loading the firmware.
- * @mod_post: the mode to be set when finishing to load the firmware.
+ * @mode_pre: the mode needing to be set before loading the firmware.
+ * @mode_post: the mode to be set when finishing to load the firmware.
* @reserved: reserved space (unused)
* @bp_start: the start register of break points. Depends on chip.
* @bp_num: the break point number which needs to be set for this firmware.
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 28/30] net: netconsole: Add description for 'netconsole_target's extended attribute
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (26 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 11:45 ` [PATCH 29/30] net: net_failover: Correct parameter name 'standby_dev' Lee Jones
2020-11-02 11:45 ` [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused Lee Jones
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Jakub Kicinski, Ingo Molnar, Matt Mackall, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/netconsole.c:104: warning: Function parameter or member 'extended' not described in 'netconsole_target'
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Matt Mackall <mpm@selenic.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/netconsole.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index 92001f7af380c..ccecba908ded6 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -83,6 +83,7 @@ static struct console netconsole_ext;
* whether the corresponding netpoll is active or inactive.
* Also, other parameters of a target may be modified at
* runtime only when it is disabled (enabled == 0).
+ * @extended: Denotes whether console is extended or not.
* @np: The netpoll structure for this target.
* Contains the other userspace visible parameters:
* dev_name (read-write)
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 29/30] net: net_failover: Correct parameter name 'standby_dev'
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (27 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 28/30] net: netconsole: Add description for 'netconsole_target's extended attribute Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-02 11:45 ` [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused Lee Jones
29 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem; +Cc: Lee Jones, Sridhar Samudrala, Jakub Kicinski, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/net_failover.c:711: warning: Function parameter or member 'standby_dev' not described in 'net_failover_create'
drivers/net/net_failover.c:711: warning: Excess function parameter 'dev' description in 'net_failover_create'
Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/net_failover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
index fb182bec8f062..2a4892402ed8c 100644
--- a/drivers/net/net_failover.c
+++ b/drivers/net/net_failover.c
@@ -697,7 +697,7 @@ static struct failover_ops net_failover_ops = {
/**
* net_failover_create - Create and register a failover instance
*
- * @dev: standby netdev
+ * @standby_dev: standby netdev
*
* Creates a failover netdev and registers a failover instance for a standby
* netdev. Used by paravirtual drivers that use 3-netdev model.
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
` (28 preceding siblings ...)
2020-11-02 11:45 ` [PATCH 29/30] net: net_failover: Correct parameter name 'standby_dev' Lee Jones
@ 2020-11-02 11:45 ` Lee Jones
2020-11-12 10:06 ` Lee Jones
29 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-02 11:45 UTC (permalink / raw)
To: davem
Cc: Lee Jones, Nicolas Pitre, Jakub Kicinski, Erik Stahlman,
Peter Cammaert, Daris A Nevil, Russell King, netdev
'pkt_len' is used to interact with a hardware register. It might not
be safe to remove it entirely. Mark it as __maybe_unused instead.
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/smsc/smc91x.c: In function ‘smc_tx’:
drivers/net/ethernet/smsc/smc91x.c:706:51: warning: variable ‘pkt_len’ set but not used [-Wunused-but-set-variable]
Cc: Nicolas Pitre <nico@fluxnic.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Erik Stahlman <erik@vt.edu>
Cc: Peter Cammaert <pc@denkart.be>
Cc: Daris A Nevil <dnevil@snmc.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/ethernet/smsc/smc91x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index b5d053292e717..a3f37b1f86491 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -703,7 +703,7 @@ static void smc_tx(struct net_device *dev)
{
struct smc_local *lp = netdev_priv(dev);
void __iomem *ioaddr = lp->base;
- unsigned int saved_packet, packet_no, tx_status, pkt_len;
+ unsigned int saved_packet, packet_no, tx_status, __maybe_unused pkt_len;
DBG(3, dev, "%s\n", __func__);
--
2.25.1
^ permalink raw reply related [flat|nested] 41+ messages in thread
* RE: [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members
2020-11-02 11:45 ` [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members Lee Jones
@ 2020-11-02 12:06 ` Hayes Wang
0 siblings, 0 replies; 41+ messages in thread
From: Hayes Wang @ 2020-11-02 12:06 UTC (permalink / raw)
To: Lee Jones, davem; +Cc: Jakub Kicinski, nic_swsd, linux-usb, netdev
Lee Jones <lee.jones@linaro.org>
> Sent: Monday, November 2, 2020 7:45 PM
[...]
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/usb/r8152.c:934: warning: Function parameter or member
> 'blk_hdr' not described in 'fw_mac'
> drivers/net/usb/r8152.c:934: warning: Function parameter or member
> 'reserved' not described in 'fw_mac'
> drivers/net/usb/r8152.c:947: warning: Function parameter or member
> 'blk_hdr' not described in 'fw_phy_patch_key'
> drivers/net/usb/r8152.c:947: warning: Function parameter or member
> 'reserved' not described in 'fw_phy_patch_key'
> drivers/net/usb/r8152.c:986: warning: Function parameter or member
> 'blk_hdr' not described in 'fw_phy_nc'
> drivers/net/usb/r8152.c:986: warning: Function parameter or member
> 'mode_pre' not described in 'fw_phy_nc'
> drivers/net/usb/r8152.c:986: warning: Function parameter or member
> 'mode_post' not described in 'fw_phy_nc'
> drivers/net/usb/r8152.c:986: warning: Function parameter or member
> 'reserved' not described in 'fw_phy_nc'
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Hayes Wang <hayeswang@realtek.com>
> Cc: nic maintainers <nic_swsd@realtek.com>
> Cc: linux-usb@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Hayes Wang <hayeswang@realtek.com>
^ permalink raw reply [flat|nested] 41+ messages in thread
* RE: [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs
2020-11-02 11:45 ` [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs Lee Jones
@ 2020-11-02 12:06 ` Hayes Wang
0 siblings, 0 replies; 41+ messages in thread
From: Hayes Wang @ 2020-11-02 12:06 UTC (permalink / raw)
To: Lee Jones, davem; +Cc: Jakub Kicinski, nic_swsd, linux-usb, netdev
Lee Jones <lee.jones@linaro.org>
> Sent: Monday, November 2, 2020 7:45 PM
[...]
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/usb/r8152.c:992: warning: Function parameter or member
> 'mode_pre' not described in 'fw_phy_nc'
> drivers/net/usb/r8152.c:992: warning: Function parameter or member
> 'mode_post' not described in 'fw_phy_nc'
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Hayes Wang <hayeswang@realtek.com>
> Cc: nic maintainers <nic_swsd@realtek.com>
> Cc: linux-usb@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Hayes Wang <hayeswang@realtek.com>
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues
2020-11-02 11:45 ` [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues Lee Jones
@ 2020-11-03 16:18 ` Stefan Schmidt
0 siblings, 0 replies; 41+ messages in thread
From: Stefan Schmidt @ 2020-11-03 16:18 UTC (permalink / raw)
To: Lee Jones, davem
Cc: Harry Morris, Alexander Aring, Jakub Kicinski, linux-wpan, netdev
Hello.
On 02.11.20 12:45, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ieee802154/ca8210.c:326: warning: Function parameter or member 'readq' not described in 'ca8210_test'
> drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'spi_transfer_complete' not described in 'ca8210_priv'
> drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'sync_exchange_complete' not described in 'ca8210_priv'
> drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'promiscuous' not described in 'ca8210_priv'
> drivers/net/ieee802154/ca8210.c:430: warning: Function parameter or member 'short_address' not described in 'macaddr'
> drivers/net/ieee802154/ca8210.c:723: warning: Function parameter or member 'cas_ctl' not described in 'ca8210_rx_done'
> drivers/net/ieee802154/ca8210.c:723: warning: Excess function parameter 'arg' description in 'ca8210_rx_done'
> drivers/net/ieee802154/ca8210.c:1289: warning: Excess function parameter 'device_ref' description in 'tdme_checkpibattribute'
> drivers/net/ieee802154/ca8210.c:3054: warning: Function parameter or member 'spi_device' not described in 'ca8210_remove'
> drivers/net/ieee802154/ca8210.c:3054: warning: Excess function parameter 'priv' description in 'ca8210_remove'
> drivers/net/ieee802154/ca8210.c:3104: warning: Function parameter or member 'spi_device' not described in 'ca8210_probe'
> drivers/net/ieee802154/ca8210.c:3104: warning: Excess function parameter 'priv' description in 'ca8210_probe'
>
> Cc: Harry Morris <h.morris@cascoda.com>
> Cc: Alexander Aring <alex.aring@gmail.com>
> Cc: Stefan Schmidt <stefan@datenfreihafen.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: linux-wpan@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
I assume Dave or Jakub will apply the whole series directly. In that case:
Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc
2020-11-02 11:45 ` [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc Lee Jones
@ 2020-11-03 16:19 ` Stefan Schmidt
0 siblings, 0 replies; 41+ messages in thread
From: Stefan Schmidt @ 2020-11-03 16:19 UTC (permalink / raw)
To: Lee Jones, davem
Cc: Harry Morris, Alexander Aring, Jakub Kicinski, linux-wpan, netdev
Hello.
On 02.11.20 12:45, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ieee802154/ca8210.c:724: warning: Function parameter or member 'cas_ctl' not described in 'ca8210_rx_done'
> drivers/net/ieee802154/ca8210.c:724: warning: Excess function parameter 'cas_ctrl' description in 'ca8210_rx_done'
>
> Cc: Harry Morris <h.morris@cascoda.com>
> Cc: Alexander Aring <alex.aring@gmail.com>
> Cc: Stefan Schmidt <stefan@datenfreihafen.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: linux-wpan@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined
2020-11-02 11:44 ` [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined Lee Jones
@ 2020-11-04 0:46 ` Jakub Kicinski
2020-11-04 7:28 ` Lee Jones
0 siblings, 1 reply; 41+ messages in thread
From: Jakub Kicinski @ 2020-11-04 0:46 UTC (permalink / raw)
To: Lee Jones; +Cc: davem, netdev
On Mon, 2 Nov 2020 11:44:43 +0000 Lee Jones wrote:
> When AIX_EVENT is not defined, the 'if' body will be empty, which
> makes GCC complain. Place bracketing around the invocation to protect
> it.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/fddi/skfp/ecm.c: In function ‘ecm_fsm’:
> drivers/net/fddi/skfp/ecm.c:153:29: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Okay, I applied most of these, but please don't post series larger than
15 patches in the future. Also each patch series should have a cover
letter.
I did not apply:
- wimax - it should go to staging
- tulip - does not apply
- lan79xx - has checkpatch warnings
- smsc - I'm expecting a patch from Andew there
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined
2020-11-04 0:46 ` Jakub Kicinski
@ 2020-11-04 7:28 ` Lee Jones
2020-11-04 7:30 ` Lee Jones
0 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-04 7:28 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev
On Tue, 03 Nov 2020, Jakub Kicinski wrote:
> On Mon, 2 Nov 2020 11:44:43 +0000 Lee Jones wrote:
> > When AIX_EVENT is not defined, the 'if' body will be empty, which
> > makes GCC complain. Place bracketing around the invocation to protect
> > it.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/net/fddi/skfp/ecm.c: In function ‘ecm_fsm’:
> > drivers/net/fddi/skfp/ecm.c:153:29: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> >
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Okay, I applied most of these,
Thank you.
> but please don't post series larger than 15 patches in the future.
No problem.
> Also each patch series should have a cover letter.
https://lore.kernel.org/lkml/20200817081630.GR4354@dell/
> I did not apply:
>
> - wimax - it should go to staging
> - tulip - does not apply
> - lan79xx - has checkpatch warnings
> - smsc - I'm expecting a patch from Andew there
I'll look into these.
Thanks again Jakub.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined
2020-11-04 7:28 ` Lee Jones
@ 2020-11-04 7:30 ` Lee Jones
0 siblings, 0 replies; 41+ messages in thread
From: Lee Jones @ 2020-11-04 7:30 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev
On Wed, 04 Nov 2020, Lee Jones wrote:
> On Tue, 03 Nov 2020, Jakub Kicinski wrote:
>
> > On Mon, 2 Nov 2020 11:44:43 +0000 Lee Jones wrote:
> > > When AIX_EVENT is not defined, the 'if' body will be empty, which
> > > makes GCC complain. Place bracketing around the invocation to protect
> > > it.
> > >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/net/fddi/skfp/ecm.c: In function ‘ecm_fsm’:
> > > drivers/net/fddi/skfp/ecm.c:153:29: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> > >
> > > Cc: "David S. Miller" <davem@davemloft.net>
> > > Cc: Jakub Kicinski <kuba@kernel.org>
> > > Cc: netdev@vger.kernel.org
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >
> > Okay, I applied most of these,
>
> Thank you.
>
> > but please don't post series larger than 15 patches in the future.
>
> No problem.
>
> > Also each patch series should have a cover letter.
>
> https://lore.kernel.org/lkml/20200817081630.GR4354@dell/
Whoops. Wrong one.
Ah, I see what happened.
It looks like it was only sent to Dave for some reason.
Apologies. Will fix in the future.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs
2020-11-02 11:44 ` [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
@ 2020-11-12 10:04 ` Lee Jones
2020-11-12 10:50 ` Greg KH
0 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-12 10:04 UTC (permalink / raw)
To: davem, gregkh; +Cc: Inaky Perez-Gonzalez, linux-wimax, Jakub Kicinski, netdev
On Mon, 02 Nov 2020, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wimax/i2400m/control.c:1195: warning: Function parameter or member 'arg' not described in 'i2400m_set_init_config'
> drivers/net/wimax/i2400m/control.c:1195: warning: Excess function parameter 'arg_size' description in 'i2400m_set_init_config'
>
> Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
> Cc: linux-wimax@intel.com
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/staging/wimax/i2400m/control.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Any news on these i2400 patches?
Looks like the driver has been moved to Staging since submission.
Greg, shall I re-submit?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused
2020-11-02 11:45 ` [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused Lee Jones
@ 2020-11-12 10:06 ` Lee Jones
2020-11-12 16:18 ` Andrew Lunn
0 siblings, 1 reply; 41+ messages in thread
From: Lee Jones @ 2020-11-12 10:06 UTC (permalink / raw)
To: davem
Cc: Nicolas Pitre, Jakub Kicinski, Erik Stahlman, Peter Cammaert,
Daris A Nevil, Russell King, netdev
On Mon, 02 Nov 2020, Lee Jones wrote:
> 'pkt_len' is used to interact with a hardware register. It might not
> be safe to remove it entirely. Mark it as __maybe_unused instead.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/smsc/smc91x.c: In function ‘smc_tx’:
> drivers/net/ethernet/smsc/smc91x.c:706:51: warning: variable ‘pkt_len’ set but not used [-Wunused-but-set-variable]
>
> Cc: Nicolas Pitre <nico@fluxnic.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Erik Stahlman <erik@vt.edu>
> Cc: Peter Cammaert <pc@denkart.be>
> Cc: Daris A Nevil <dnevil@snmc.com>
> Cc: Russell King <rmk@arm.linux.org.uk>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/net/ethernet/smsc/smc91x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index b5d053292e717..a3f37b1f86491 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -703,7 +703,7 @@ static void smc_tx(struct net_device *dev)
> {
> struct smc_local *lp = netdev_priv(dev);
> void __iomem *ioaddr = lp->base;
> - unsigned int saved_packet, packet_no, tx_status, pkt_len;
> + unsigned int saved_packet, packet_no, tx_status, __maybe_unused pkt_len;
>
> DBG(3, dev, "%s\n", __func__);
This one is still lingering. Looks like it's still relevant.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs
2020-11-12 10:04 ` Lee Jones
@ 2020-11-12 10:50 ` Greg KH
0 siblings, 0 replies; 41+ messages in thread
From: Greg KH @ 2020-11-12 10:50 UTC (permalink / raw)
To: Lee Jones
Cc: davem, Inaky Perez-Gonzalez, linux-wimax, Jakub Kicinski, netdev
On Thu, Nov 12, 2020 at 10:04:45AM +0000, Lee Jones wrote:
> On Mon, 02 Nov 2020, Lee Jones wrote:
>
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/net/wimax/i2400m/control.c:1195: warning: Function parameter or member 'arg' not described in 'i2400m_set_init_config'
> > drivers/net/wimax/i2400m/control.c:1195: warning: Excess function parameter 'arg_size' description in 'i2400m_set_init_config'
> >
> > Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
> > Cc: linux-wimax@intel.com
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/staging/wimax/i2400m/control.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Any news on these i2400 patches?
>
> Looks like the driver has been moved to Staging since submission.
>
> Greg, shall I re-submit?
Please do as I don't have any pending from you at all. And put
"staging:" as a prefix please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused
2020-11-12 10:06 ` Lee Jones
@ 2020-11-12 16:18 ` Andrew Lunn
0 siblings, 0 replies; 41+ messages in thread
From: Andrew Lunn @ 2020-11-12 16:18 UTC (permalink / raw)
To: Lee Jones
Cc: davem, Nicolas Pitre, Jakub Kicinski, Erik Stahlman,
Peter Cammaert, Daris A Nevil, Russell King, netdev
> This one is still lingering. Looks like it's still relevant.
Hi Lee
It is part of this patchset:
https://www.mail-archive.com/netdev@vger.kernel.org/msg368589.html
Andrew
^ permalink raw reply [flat|nested] 41+ messages in thread
end of thread, other threads:[~2020-11-12 16:19 UTC | newest]
Thread overview: 41+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
2020-11-02 11:44 ` [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined Lee Jones
2020-11-04 0:46 ` Jakub Kicinski
2020-11-04 7:28 ` Lee Jones
2020-11-04 7:30 ` Lee Jones
2020-11-02 11:44 ` [PATCH 02/30] net: fddi: skfp: ecm: Remove seemingly unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 03/30] net: fddi: skfp: pcmplc: Remove defined but not used " Lee Jones
2020-11-02 11:44 ` [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
2020-11-12 10:04 ` Lee Jones
2020-11-12 10:50 ` Greg KH
2020-11-02 11:44 ` [PATCH 05/30] net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
2020-11-02 11:44 ` [PATCH 06/30] net: wimax: i2400m: fw: Fix some function header misdemeanours Lee Jones
2020-11-02 11:44 ` [PATCH 07/30] net: fddi: skfp: pmf: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 08/30] net: fddi: skfp: queue: " Lee Jones
2020-11-02 11:44 ` [PATCH 09/30] net: fddi: skfp: rmt: " Lee Jones
2020-11-02 11:44 ` [PATCH 10/30] net: fddi: skfp: smtdef: " Lee Jones
2020-11-02 11:44 ` [PATCH 11/30] net: fddi: skfp: smtinit: " Lee Jones
2020-11-02 11:44 ` [PATCH 12/30] net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
2020-11-02 11:44 ` [PATCH 13/30] net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
2020-11-02 11:44 ` [PATCH 14/30] net: fddi: skfp: smttimer: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 15/30] net: fddi: skfp: hwt: " Lee Jones
2020-11-02 11:44 ` [PATCH 16/30] net: fddi: skfp: srf: " Lee Jones
2020-11-02 11:44 ` [PATCH 17/30] net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
2020-11-02 11:45 ` [PATCH 18/30] net: fddi: skfp: drvfbi: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:45 ` [PATCH 19/30] net: fddi: skfp: ess: " Lee Jones
2020-11-02 11:45 ` [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues Lee Jones
2020-11-03 16:18 ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 21/30] net: ethernet: dec: tulip: tulip_core: 'last_irq' is only used when i386 or x86 Lee Jones
2020-11-02 11:45 ` [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members Lee Jones
2020-11-02 12:06 ` Hayes Wang
2020-11-02 11:45 ` [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc Lee Jones
2020-11-03 16:19 ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 24/30] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones
2020-11-02 11:45 ` [PATCH 25/30] net: macsec: Add missing documentation for 'gro_cells' Lee Jones
2020-11-02 11:45 ` [PATCH 26/30] net: macvlan: Demote nonconformant function header Lee Jones
2020-11-02 11:45 ` [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs Lee Jones
2020-11-02 12:06 ` Hayes Wang
2020-11-02 11:45 ` [PATCH 28/30] net: netconsole: Add description for 'netconsole_target's extended attribute Lee Jones
2020-11-02 11:45 ` [PATCH 29/30] net: net_failover: Correct parameter name 'standby_dev' Lee Jones
2020-11-02 11:45 ` [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused Lee Jones
2020-11-12 10:06 ` Lee Jones
2020-11-12 16:18 ` Andrew Lunn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.