From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
sergey.senozhatsky.work@gmail.com, tony@atomide.com,
linux-arm-kernel@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Harish Sriram <harish@linux.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range"
Date: Wed, 18 Nov 2020 11:06:49 +0900 [thread overview]
Message-ID: <X7SBufr4GftKY9pB@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20201117202916.GA3856507@google.com>
On (20/11/17 12:29), Minchan Kim wrote:
> Yub, I remeber the discussion.
> https://lore.kernel.org/linux-mm/20200416203736.GB50092@google.com/
>
> I wanted to remove it but 30% gain made me think again before
> deciding to drop it.
> Since it continue to make problems and Linux is approaching to
> deprecate the 32bit machines, I think it would be better to drop it
> rather than inventing weird workaround.
>
> Ccing Tony since omap2plus have used it by default for just in case.
>
> From fc1b17a120991fd86b9e1153ab22d0b0bdadd8d0 Mon Sep 17 00:00:00 2001
> From: Minchan Kim <minchan@kernel.org>
> Date: Tue, 17 Nov 2020 11:58:51 -0800
> Subject: [PATCH] mm/zsmalloc.c: drop ZSMALLOC_PGTABLE_MAPPING
>
> Even though this option showed some amount improvement(e.g., 30%)
> in some arm32 platforms, it has been headache to maintain since it
> have abused APIs[1](e.g., unmap_kernel_range in atomic context).
>
> Since we are approaching to deprecate 32bit machines and already made
> the config option available for only builtin build since v5.8, lastly
> it has been not default option in zsmalloc, it's time to drop the
> option for better maintainance.
>
> [1] http://lore.kernel.org/linux-mm/20201105170249.387069-1-minchan@kernel.org
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: <stable@vger.kernel.org>
> Fixes: e47110e90584 ("mm/vunmap: add cond_resched() in vunmap_pmd_range")
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Looks good to me.
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: sergey.senozhatsky.work@gmail.com, tony@atomide.com,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-mm <linux-mm@kvack.org>,
Harish Sriram <harish@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range"
Date: Wed, 18 Nov 2020 11:06:49 +0900 [thread overview]
Message-ID: <X7SBufr4GftKY9pB@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20201117202916.GA3856507@google.com>
On (20/11/17 12:29), Minchan Kim wrote:
> Yub, I remeber the discussion.
> https://lore.kernel.org/linux-mm/20200416203736.GB50092@google.com/
>
> I wanted to remove it but 30% gain made me think again before
> deciding to drop it.
> Since it continue to make problems and Linux is approaching to
> deprecate the 32bit machines, I think it would be better to drop it
> rather than inventing weird workaround.
>
> Ccing Tony since omap2plus have used it by default for just in case.
>
> From fc1b17a120991fd86b9e1153ab22d0b0bdadd8d0 Mon Sep 17 00:00:00 2001
> From: Minchan Kim <minchan@kernel.org>
> Date: Tue, 17 Nov 2020 11:58:51 -0800
> Subject: [PATCH] mm/zsmalloc.c: drop ZSMALLOC_PGTABLE_MAPPING
>
> Even though this option showed some amount improvement(e.g., 30%)
> in some arm32 platforms, it has been headache to maintain since it
> have abused APIs[1](e.g., unmap_kernel_range in atomic context).
>
> Since we are approaching to deprecate 32bit machines and already made
> the config option available for only builtin build since v5.8, lastly
> it has been not default option in zsmalloc, it's time to drop the
> option for better maintainance.
>
> [1] http://lore.kernel.org/linux-mm/20201105170249.387069-1-minchan@kernel.org
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: <stable@vger.kernel.org>
> Fixes: e47110e90584 ("mm/vunmap: add cond_resched() in vunmap_pmd_range")
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Looks good to me.
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-18 2:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 17:02 [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range" Minchan Kim
2020-11-05 17:16 ` Matthew Wilcox
2020-11-05 17:33 ` Minchan Kim
2020-11-07 1:59 ` Andrew Morton
2020-11-07 8:39 ` Minchan Kim
2020-11-09 11:33 ` Uladzislau Rezki
2020-11-12 20:01 ` Minchan Kim
2020-11-12 22:49 ` Andrew Morton
2020-11-13 16:25 ` Minchan Kim
2020-11-16 17:53 ` Minchan Kim
2020-11-16 23:20 ` Andrew Morton
2020-11-17 13:57 ` Uladzislau Rezki
2020-11-17 13:56 ` Christoph Hellwig
2020-11-17 20:29 ` Minchan Kim
2020-11-17 20:29 ` Minchan Kim
2020-11-18 2:06 ` Sergey Senozhatsky [this message]
2020-11-18 2:06 ` Sergey Senozhatsky
2020-11-19 9:29 ` Tony Lindgren
2020-11-19 9:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7SBufr4GftKY9pB@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=harish@linux.ibm.com \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.