From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
ntfs3@lists.linux.dev, netdev@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54
Date: Tue, 25 Oct 2022 09:21:07 +0100 [thread overview]
Message-ID: <Y1eccygLSjEoPdHV@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221024145527.0eff7844@kernel.org>
On Mon, Oct 24, 2022 at 02:55:27PM -0700, Jakub Kicinski wrote:
> On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote:
> > drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583)
>
> Hi Russell, I think the warning is semi-legit. Your commit f392a1846489
> ("net: phylink: provide phylink_validate_mask_caps() helper") added an
> if (state) before defer'ing state but it's already deref'ed higher up
> so can't be null.
Not me, Sean. My original implementation of phylink_validate_mask_caps()
doesn't know anything about rate matching, so my version didn't have
this issue.
Sean's version of my patch (which is what was submitted) added the
dereference that causes this, so, it's up to Sean to figure out a fix -
but he reading his follow up to the build bot's message, he seems to
be passing it over to me to fix!
I've got other issues to be worked on right now, and have no time to
spare to fix other people's mistakes. Sorry.
You can't always rely on the apparent author mentioned in the commit to
be the actual person responsible for the changes in a patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
ntfs3@lists.linux.dev, netdev@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54
Date: Tue, 25 Oct 2022 09:21:07 +0100 [thread overview]
Message-ID: <Y1eccygLSjEoPdHV@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221024145527.0eff7844@kernel.org>
On Mon, Oct 24, 2022 at 02:55:27PM -0700, Jakub Kicinski wrote:
> On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote:
> > drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583)
>
> Hi Russell, I think the warning is semi-legit. Your commit f392a1846489
> ("net: phylink: provide phylink_validate_mask_caps() helper") added an
> if (state) before defer'ing state but it's already deref'ed higher up
> so can't be null.
Not me, Sean. My original implementation of phylink_validate_mask_caps()
doesn't know anything about rate matching, so my version didn't have
this issue.
Sean's version of my patch (which is what was submitted) added the
dereference that causes this, so, it's up to Sean to figure out a fix -
but he reading his follow up to the build bot's message, he seems to
be passing it over to me to fix!
I've got other issues to be worked on right now, and have no time to
spare to fix other people's mistakes. Sorry.
You can't always rely on the apparent author mentioned in the commit to
be the actual person responsible for the changes in a patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
linux-parisc@vger.kernel.org, netdev@vger.kernel.org,
amd-gfx@lists.freedesktop.org,
Linux Memory Management List <linux-mm@kvack.org>,
linux-mediatek@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
ntfs3@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54
Date: Tue, 25 Oct 2022 09:21:07 +0100 [thread overview]
Message-ID: <Y1eccygLSjEoPdHV@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221024145527.0eff7844@kernel.org>
On Mon, Oct 24, 2022 at 02:55:27PM -0700, Jakub Kicinski wrote:
> On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote:
> > drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583)
>
> Hi Russell, I think the warning is semi-legit. Your commit f392a1846489
> ("net: phylink: provide phylink_validate_mask_caps() helper") added an
> if (state) before defer'ing state but it's already deref'ed higher up
> so can't be null.
Not me, Sean. My original implementation of phylink_validate_mask_caps()
doesn't know anything about rate matching, so my version didn't have
this issue.
Sean's version of my patch (which is what was submitted) added the
dereference that causes this, so, it's up to Sean to figure out a fix -
but he reading his follow up to the build bot's message, he seems to
be passing it over to me to fix!
I've got other issues to be worked on right now, and have no time to
spare to fix other people's mistakes. Sorry.
You can't always rely on the apparent author mentioned in the commit to
be the actual person responsible for the changes in a patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-10-25 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:58 [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54 kernel test robot
2022-10-24 16:58 ` kernel test robot
2022-10-24 16:58 ` kernel test robot
2022-10-24 21:55 ` Jakub Kicinski
2022-10-24 21:55 ` Jakub Kicinski
2022-10-24 21:55 ` Jakub Kicinski
2022-10-25 8:21 ` Russell King (Oracle) [this message]
2022-10-25 8:21 ` Russell King (Oracle)
2022-10-25 8:21 ` Russell King (Oracle)
2022-10-25 18:52 ` Jakub Kicinski
2022-10-25 18:52 ` Jakub Kicinski
2022-10-25 18:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1eccygLSjEoPdHV@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.