Re: [PATCH v1 0/3] Add watchdog driver for StarFive RISC-V SoCs

From: Conor Dooley <conor@kernel.org>
To: "xingu.wu" <xingyu.wu@starfivetech.com>
Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-watchdog@vger.kernel.org,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Samin Guo <samin.guo@starfivetech.com>,
	linux-kernel@vger.kernel.org,
	Hal Feng <hal.feng@starfivetech.com>
Subject: Re: [PATCH v1 0/3] Add watchdog driver for StarFive RISC-V SoCs
Date: Fri, 2 Dec 2022 11:52:48 +0000	[thread overview]
Message-ID: <Y4nnEMxaV4MrAOYw@spud> (raw)
In-Reply-To: <20221202093943.149674-1-xingyu.wu@starfivetech.com>

[-- Attachment #1: Type: text/plain, Size: 4459 bytes --]

Hello!

+CC Hal Feng

On Fri, Dec 02, 2022 at 05:39:40PM +0800, xingu.wu wrote:
> This patch serises are to add watchdog driver for the StarFive RISC-V SoCs
> such as JH7110. The first patch adds docunmentation to describe device
> tree bindings. The subsequent patch adds watchdog driver and support
> JH7110 SoC. The last patch adds device node about watchdog to JH7110
> dts.
> 
> The watchdog driver has been tested on the VisionFive 2 boards which
> equip with JH7110 SoC and works normally.
> 
> This patchset should be applied after the patchset [1], [2], [3]:
> [1] https://lore.kernel.org/all/20221118010627.70576-1-hal.feng@starfivetech.com/
> [2] https://lore.kernel.org/all/20221118011108.70715-1-hal.feng@starfivetech.com/
> [3] https://lore.kernel.org/all/20221118011714.70877-1-hal.feng@starfivetech.com/

You say "patchset" but that's not really the case. Realistically, only
one patch here has a real dependency on the above AFAICT.
How about for v2, whenever you send that, in your dt-bindings you drop
the uses of dt-bindings/*/starfive-jh7110.h & instead put the numbers?
Same goes, IMO, for ~all the jh7110 dt-bindings, see here:
https://lore.kernel.org/all/624cba7f-1be9-7100-91d7-f9232c855d9f@linaro.org/

Then the only person that has to care about prerequisite patches is then
me for the dt patch and you will not have the driver itself delayed
until the clock bindings are merged?

Perhaps Guenter likes having the defines, but my opinion would be get as
much as possible that does not have real dependencies on the clock &
reset bindings capable of being merged in isolation.

Thanks,
Conor.

> 
> Xingyu Wu (3):
>   dt-bindings: watchdog: Add watchdog for StarFive
>   drivers: watchdog: Add StarFive Watchdog driver
>   riscv: dts: starfive: jh7110: Add watchdog node
> 
>  .../bindings/watchdog/starfive,wdt.yaml       |  77 ++
>  MAINTAINERS                                   |   7 +
>  arch/riscv/boot/dts/starfive/jh7110.dtsi      |  14 +
>  drivers/watchdog/Kconfig                      |  11 +
>  drivers/watchdog/Makefile                     |   3 +
>  drivers/watchdog/starfive-wdt.c               | 854 ++++++++++++++++++
>  6 files changed, 966 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml
>  create mode 100644 drivers/watchdog/starfive-wdt.c
> 
> 
> base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa
> prerequisite-patch-id: 6b1b43a55b9773bec61ab6c1bbaa54dccbac0837
> prerequisite-patch-id: 09c98554df52d17ba5fd604125f8cdd62cbe80d1
> prerequisite-patch-id: 29fe0b0c19b6f0cd31114ee9fe17fe9732047f33
> prerequisite-patch-id: c59d9908de90e09ba2b9a81aadbf9fb9f00c8f04
> prerequisite-patch-id: 94ac03d518993921bcfc9cc9f58d7da0c3528b51
> prerequisite-patch-id: 694f7400375f5b85581fc1821e427334507826f2
> prerequisite-patch-id: 699d49c4439dadb4b7cf900857f027d050cd6093
> prerequisite-patch-id: 40d773f5a19912f731ee5fd4739ed2e3c2157b07
> prerequisite-patch-id: 2bc3fd6df5dda116efe882045863d6c88aa81b3a
> prerequisite-patch-id: 735e62255c75801bdc4c0b4107850bce821ff7f5
> prerequisite-patch-id: b2a923b922e661fa6085185f33c1f1e733db9110
> prerequisite-patch-id: b2bbc28354075432f059344eba5a127a653475cf
> prerequisite-patch-id: 70eab7b7eee728afcd90e40f6743d1356f6d81ab
> prerequisite-patch-id: 6276b2a23818c65ff2ad3d65b562615690cffee9
> prerequisite-patch-id: d834ece14ffb525b8c3e661e78736692f33fca9b
> prerequisite-patch-id: 4c17a3ce4dae9b788795d915bf775630f5c43c53
> prerequisite-patch-id: dabb913fd478e97593e45c23fee4be9fd807f851
> prerequisite-patch-id: 22fa141f7f0f80a5d619e9f3f4cf161ad06f108e
> prerequisite-patch-id: f306819c257ea73aff8e06b17b5731053cdddfc8
> prerequisite-patch-id: 536114f0732646095ef5302a165672b3290d4c75
> prerequisite-patch-id: 258ea5f9b8bf41b6981345dcc81795f25865d38f
> prerequisite-patch-id: 8b6f2c9660c0ac0ee4e73e4c21aca8e6b75e81b9
> prerequisite-patch-id: e09e995700a814a763aa304ad3881a7222acf556
> prerequisite-patch-id: 05803238293fcc90c8e83018a1103c41133a816c
> prerequisite-patch-id: d074c7ffa2917a9f754d5801e3f67bc980f9de4c
> prerequisite-patch-id: ef23fdf3466b3c713b3826e8545c8dd2bc6cc9d7
> prerequisite-patch-id: d5da3475c6a3588e11a1678feb565bdd459b548e
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]