From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: "xingu.wu" <xingyu.wu@starfivetech.com>, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Philipp Zabel <p.zabel@pengutronix.de>, Samin Guo <samin.guo@starfivetech.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/3] dt-bindings: watchdog: Add watchdog for StarFive Date: Fri, 2 Dec 2022 11:46:59 +0100 [thread overview] Message-ID: <cb8deb55-902a-0058-4764-a5f391f8de6d@linaro.org> (raw) In-Reply-To: <20221202093943.149674-2-xingyu.wu@starfivetech.com> On 02/12/2022 10:39, xingu.wu wrote: > From: Xingyu Wu <xingyu.wu@starfivetech.com> > > Add bindings to describe the watchdog for the StarFive SoCs. > > Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> > --- > .../bindings/watchdog/starfive,wdt.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml > new file mode 100644 > index 000000000000..ece3e80153a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml Filename should be based on compatible. You do not allow here any other models... If you intent and you are 100% sure you will grow with new models, make it maybe a family-based name. > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/starfive,wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive Watchdog > + > +allOf: > + - $ref: "watchdog.yaml#" Drop quotes. > + > +maintainers: > + - Samin Guo <samin.guo@starfivetech.com> > + - Xingyu Wu <xingyu.wu@starfivetech.com> > + > +properties: > + compatible: > + const: starfive,jh7110-wdt > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Core clock > + - description: APB clock > + > + clock-names: > + items: > + - const: core_clk Drop _clk > + - const: apb_clk Drop _clk > + > + resets: > + items: > + - description: APB reset > + - description: Core reset > + > + reset-names: > + items: > + - const: rst_apb Drop rst_ > + - const: rst_core Ditto > + > + timeout-sec: true > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + - timeout-sec > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/starfive-jh7110.h> > + #include <dt-bindings/reset/starfive-jh7110.h> > + > + watchdog@13070000 { > + compatible = "starfive,jh7110-wdt"; Use 4 spaces for example indentation. > + reg = <0x13070000 0x10000>; > + interrupts = <68>; > + clocks = <&syscrg_clk JH7110_SYSCLK_WDT_CORE>, > + <&syscrg_clk JH7110_SYSCLK_WDT_APB>; > + clock-names = "core_clk", "apb_clk"; > + resets = <&syscrg_rst JH7110_SYSRST_WDT_APB>, > + <&syscrg_rst JH7110_SYSRST_WDT_CORE>; > + reset-names = "rst_apb", "rst_core"; > + timeout-sec = <15>; > + }; > + Drop trailing line. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: "xingu.wu" <xingyu.wu@starfivetech.com>, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Philipp Zabel <p.zabel@pengutronix.de>, Samin Guo <samin.guo@starfivetech.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/3] dt-bindings: watchdog: Add watchdog for StarFive Date: Fri, 2 Dec 2022 11:46:59 +0100 [thread overview] Message-ID: <cb8deb55-902a-0058-4764-a5f391f8de6d@linaro.org> (raw) In-Reply-To: <20221202093943.149674-2-xingyu.wu@starfivetech.com> On 02/12/2022 10:39, xingu.wu wrote: > From: Xingyu Wu <xingyu.wu@starfivetech.com> > > Add bindings to describe the watchdog for the StarFive SoCs. > > Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> > --- > .../bindings/watchdog/starfive,wdt.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml > new file mode 100644 > index 000000000000..ece3e80153a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml Filename should be based on compatible. You do not allow here any other models... If you intent and you are 100% sure you will grow with new models, make it maybe a family-based name. > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/starfive,wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive Watchdog > + > +allOf: > + - $ref: "watchdog.yaml#" Drop quotes. > + > +maintainers: > + - Samin Guo <samin.guo@starfivetech.com> > + - Xingyu Wu <xingyu.wu@starfivetech.com> > + > +properties: > + compatible: > + const: starfive,jh7110-wdt > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Core clock > + - description: APB clock > + > + clock-names: > + items: > + - const: core_clk Drop _clk > + - const: apb_clk Drop _clk > + > + resets: > + items: > + - description: APB reset > + - description: Core reset > + > + reset-names: > + items: > + - const: rst_apb Drop rst_ > + - const: rst_core Ditto > + > + timeout-sec: true > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + - timeout-sec > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/starfive-jh7110.h> > + #include <dt-bindings/reset/starfive-jh7110.h> > + > + watchdog@13070000 { > + compatible = "starfive,jh7110-wdt"; Use 4 spaces for example indentation. > + reg = <0x13070000 0x10000>; > + interrupts = <68>; > + clocks = <&syscrg_clk JH7110_SYSCLK_WDT_CORE>, > + <&syscrg_clk JH7110_SYSCLK_WDT_APB>; > + clock-names = "core_clk", "apb_clk"; > + resets = <&syscrg_rst JH7110_SYSRST_WDT_APB>, > + <&syscrg_rst JH7110_SYSRST_WDT_CORE>; > + reset-names = "rst_apb", "rst_core"; > + timeout-sec = <15>; > + }; > + Drop trailing line. Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-02 10:47 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-02 9:39 [PATCH v1 0/3] Add watchdog driver for StarFive RISC-V SoCs xingu.wu 2022-12-02 9:39 ` [PATCH v1 1/3] dt-bindings: watchdog: Add watchdog for StarFive xingu.wu 2022-12-02 10:46 ` Krzysztof Kozlowski [this message] 2022-12-02 10:46 ` Krzysztof Kozlowski 2022-12-05 3:49 ` Xingyu Wu 2022-12-05 3:49 ` Xingyu Wu 2022-12-05 7:30 ` Krzysztof Kozlowski 2022-12-05 7:30 ` Krzysztof Kozlowski 2022-12-05 8:22 ` Xingyu Wu 2022-12-05 8:22 ` Xingyu Wu 2022-12-02 9:39 ` [PATCH v1 2/3] drivers: watchdog: Add StarFive Watchdog driver xingu.wu 2022-12-02 15:08 ` Guenter Roeck 2022-12-02 15:08 ` Guenter Roeck 2022-12-05 8:08 ` Xingyu Wu 2022-12-05 8:08 ` Xingyu Wu 2022-12-02 9:39 ` [PATCH v1 3/3] riscv: dts: starfive: jh7110: Add watchdog node xingu.wu 2022-12-02 10:48 ` Krzysztof Kozlowski 2022-12-02 10:48 ` Krzysztof Kozlowski 2022-12-05 8:27 ` Xingyu Wu 2022-12-05 8:27 ` Xingyu Wu 2022-12-02 11:52 ` [PATCH v1 0/3] Add watchdog driver for StarFive RISC-V SoCs Conor Dooley 2022-12-02 11:52 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cb8deb55-902a-0058-4764-a5f391f8de6d@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=aou@eecs.berkeley.edu \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=p.zabel@pengutronix.de \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ --cc=samin.guo@starfivetech.com \ --cc=wim@linux-watchdog.org \ --cc=xingyu.wu@starfivetech.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.