From: Lorenzo Bianconi <lorenzo@kernel.org> To: Nicolas Cavallari <nicolas.cavallari@green-communications.fr> Cc: Johannes Berg <johannes@sipsolutions.net>, Rameshkumar Sundaram <quic_ramess@quicinc.com>, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] nl80211: add support to enable/disable bss color collision detection Date: Tue, 24 Jan 2023 15:09:52 +0100 [thread overview] Message-ID: <Y8/msHegwheXGWze@lore-desk> (raw) In-Reply-To: <eac1cf31-518f-6542-24c6-69e6c059f3c9@green-communications.fr> [-- Attachment #1: Type: text/plain, Size: 1355 bytes --] > Hi Lorenzo, > > On 20/01/2023 16:55, Lorenzo Bianconi wrote: > > I agree, I think we can ratelimit netlink messages sent by the kernel to > > userspace (e.g. to hostapd), I would say every 500ms is ok. > > I guess we can move cfg80211_obss_color_collision_notify() in a dedicated > > delayed_work so we can grab wdev mutex (cfg80211_obss_color_collision_notify is > > currently running in interrupt context). > > To give an idea, what do you think about patch below? (please note it is just > > compiled tested so far). > > The patch does not work, the fix appears easy: > > +void ieee80211_color_collision_detection_work(struct work_struct *work) > > +{ > > + struct delayed_work *delayed_work = to_delayed_work(work); > > + struct ieee80211_link_data *link = > > + container_of(delayed_work, struct ieee80211_link_data, > > + dfs_cac_timer_work); > > This should probably be color_collision_detect_work. Yep, sorry. It is just a copy paste issue :) I will share a new version. Regards, Lorenzo > > > + struct ieee80211_sub_if_data *sdata = link->sdata; > > + > > + sdata_lock(sdata); > > It crashed here, link is NULL. > > > + cfg80211_obss_color_collision_notify(sdata->dev, link->color_bitmap, > > + GFP_KERNEL); > > + sdata_unlock(sdata); > > +} > Will test the fixed version later. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo@kernel.org> To: Nicolas Cavallari <nicolas.cavallari@green-communications.fr> Cc: Johannes Berg <johannes@sipsolutions.net>, Rameshkumar Sundaram <quic_ramess@quicinc.com>, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] nl80211: add support to enable/disable bss color collision detection Date: Tue, 24 Jan 2023 15:09:52 +0100 [thread overview] Message-ID: <Y8/msHegwheXGWze@lore-desk> (raw) In-Reply-To: <eac1cf31-518f-6542-24c6-69e6c059f3c9@green-communications.fr> [-- Attachment #1.1: Type: text/plain, Size: 1355 bytes --] > Hi Lorenzo, > > On 20/01/2023 16:55, Lorenzo Bianconi wrote: > > I agree, I think we can ratelimit netlink messages sent by the kernel to > > userspace (e.g. to hostapd), I would say every 500ms is ok. > > I guess we can move cfg80211_obss_color_collision_notify() in a dedicated > > delayed_work so we can grab wdev mutex (cfg80211_obss_color_collision_notify is > > currently running in interrupt context). > > To give an idea, what do you think about patch below? (please note it is just > > compiled tested so far). > > The patch does not work, the fix appears easy: > > +void ieee80211_color_collision_detection_work(struct work_struct *work) > > +{ > > + struct delayed_work *delayed_work = to_delayed_work(work); > > + struct ieee80211_link_data *link = > > + container_of(delayed_work, struct ieee80211_link_data, > > + dfs_cac_timer_work); > > This should probably be color_collision_detect_work. Yep, sorry. It is just a copy paste issue :) I will share a new version. Regards, Lorenzo > > > + struct ieee80211_sub_if_data *sdata = link->sdata; > > + > > + sdata_lock(sdata); > > It crashed here, link is NULL. > > > + cfg80211_obss_color_collision_notify(sdata->dev, link->color_bitmap, > > + GFP_KERNEL); > > + sdata_unlock(sdata); > > +} > Will test the fixed version later. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 102 bytes --] -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2023-01-24 14:10 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-26 8:33 [PATCH 0/2] wifi: Add support to enable/disable bss color collision detection Rameshkumar Sundaram 2022-12-26 8:33 ` Rameshkumar Sundaram 2022-12-26 8:33 ` [PATCH 1/2] nl80211: add " Rameshkumar Sundaram 2022-12-26 8:33 ` Rameshkumar Sundaram 2023-01-19 14:02 ` Johannes Berg 2023-01-19 14:02 ` Johannes Berg 2023-01-19 14:52 ` Nicolas Cavallari 2023-01-19 14:52 ` Nicolas Cavallari 2023-01-19 14:54 ` Johannes Berg 2023-01-19 14:54 ` Johannes Berg 2023-01-19 18:36 ` Lorenzo Bianconi 2023-01-19 18:36 ` Lorenzo Bianconi 2023-01-20 15:55 ` Lorenzo Bianconi 2023-01-20 15:55 ` Lorenzo Bianconi 2023-01-20 16:10 ` Nicolas Cavallari 2023-01-20 16:10 ` Nicolas Cavallari 2023-01-24 11:13 ` Nicolas Cavallari 2023-01-24 11:13 ` Nicolas Cavallari 2023-01-24 14:09 ` Lorenzo Bianconi [this message] 2023-01-24 14:09 ` Lorenzo Bianconi 2023-01-23 4:57 ` Rameshkumar Sundaram (QUIC) 2023-01-23 4:57 ` Rameshkumar Sundaram (QUIC) 2022-12-26 8:33 ` [PATCH 2/2] ath11k: add support to enable/disable BSS " Rameshkumar Sundaram 2022-12-26 8:33 ` Rameshkumar Sundaram
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y8/msHegwheXGWze@lore-desk \ --to=lorenzo@kernel.org \ --cc=ath11k@lists.infradead.org \ --cc=johannes@sipsolutions.net \ --cc=linux-wireless@vger.kernel.org \ --cc=nicolas.cavallari@green-communications.fr \ --cc=quic_ramess@quicinc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.