From: Lorenzo Bianconi <lorenzo@kernel.org> To: Johannes Berg <johannes@sipsolutions.net> Cc: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>, Rameshkumar Sundaram <quic_ramess@quicinc.com>, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] nl80211: add support to enable/disable bss color collision detection Date: Thu, 19 Jan 2023 19:36:15 +0100 [thread overview] Message-ID: <Y8mNn18XeUcEjLWe@lore-desk> (raw) In-Reply-To: <2a2332211b2ca9daa968a3644006f5c9e0c88a00.camel@sipsolutions.net> [-- Attachment #1.1: Type: text/plain, Size: 685 bytes --] > On Thu, 2023-01-19 at 15:52 +0100, Nicolas Cavallari wrote: > > > > This may not be related, but the software color collision detection > > sends a netlink message for every colliding frame and it can hose up the > > system if the other network is very active. > > > > Also, cfg80211_bss_color_notify() complains that the wdev lock isn't held. > > Yay. > > Lorenzo can you take a look at that? It seems fine to me, I am just wondering if we need to forward the info to the hw (if it supports hw color collision detection) if we just flip collision_detection_enabled field in ieee80211_change_beacon(). What do you think? Regards, Lorenzo > > johannes [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 102 bytes --] -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo@kernel.org> To: Johannes Berg <johannes@sipsolutions.net> Cc: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>, Rameshkumar Sundaram <quic_ramess@quicinc.com>, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] nl80211: add support to enable/disable bss color collision detection Date: Thu, 19 Jan 2023 19:36:15 +0100 [thread overview] Message-ID: <Y8mNn18XeUcEjLWe@lore-desk> (raw) In-Reply-To: <2a2332211b2ca9daa968a3644006f5c9e0c88a00.camel@sipsolutions.net> [-- Attachment #1: Type: text/plain, Size: 685 bytes --] > On Thu, 2023-01-19 at 15:52 +0100, Nicolas Cavallari wrote: > > > > This may not be related, but the software color collision detection > > sends a netlink message for every colliding frame and it can hose up the > > system if the other network is very active. > > > > Also, cfg80211_bss_color_notify() complains that the wdev lock isn't held. > > Yay. > > Lorenzo can you take a look at that? It seems fine to me, I am just wondering if we need to forward the info to the hw (if it supports hw color collision detection) if we just flip collision_detection_enabled field in ieee80211_change_beacon(). What do you think? Regards, Lorenzo > > johannes [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-19 18:36 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-26 8:33 [PATCH 0/2] wifi: Add support to enable/disable bss color collision detection Rameshkumar Sundaram 2022-12-26 8:33 ` Rameshkumar Sundaram 2022-12-26 8:33 ` [PATCH 1/2] nl80211: add " Rameshkumar Sundaram 2022-12-26 8:33 ` Rameshkumar Sundaram 2023-01-19 14:02 ` Johannes Berg 2023-01-19 14:02 ` Johannes Berg 2023-01-19 14:52 ` Nicolas Cavallari 2023-01-19 14:52 ` Nicolas Cavallari 2023-01-19 14:54 ` Johannes Berg 2023-01-19 14:54 ` Johannes Berg 2023-01-19 18:36 ` Lorenzo Bianconi [this message] 2023-01-19 18:36 ` Lorenzo Bianconi 2023-01-20 15:55 ` Lorenzo Bianconi 2023-01-20 15:55 ` Lorenzo Bianconi 2023-01-20 16:10 ` Nicolas Cavallari 2023-01-20 16:10 ` Nicolas Cavallari 2023-01-24 11:13 ` Nicolas Cavallari 2023-01-24 11:13 ` Nicolas Cavallari 2023-01-24 14:09 ` Lorenzo Bianconi 2023-01-24 14:09 ` Lorenzo Bianconi 2023-01-23 4:57 ` Rameshkumar Sundaram (QUIC) 2023-01-23 4:57 ` Rameshkumar Sundaram (QUIC) 2022-12-26 8:33 ` [PATCH 2/2] ath11k: add support to enable/disable BSS " Rameshkumar Sundaram 2022-12-26 8:33 ` Rameshkumar Sundaram
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y8mNn18XeUcEjLWe@lore-desk \ --to=lorenzo@kernel.org \ --cc=ath11k@lists.infradead.org \ --cc=johannes@sipsolutions.net \ --cc=linux-wireless@vger.kernel.org \ --cc=nicolas.cavallari@green-communications.fr \ --cc=quic_ramess@quicinc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.