From: Abel Vesa <abel.vesa@linaro.org> To: Stephen Boyd <sboyd@kernel.org> Cc: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 18701859600@163.com, bsp-development.geo@leica-geosystems.com, Marco Felsch <m.felsch@pengutronix.de> Subject: Re: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE Date: Mon, 16 Jan 2023 16:28:33 +0200 [thread overview] Message-ID: <Y8VfEfnWwt8+QB1W@linaro.org> (raw) In-Reply-To: <20230111101030.686885-2-Qing-wu.Li@leica-geosystems.com.cn> On 23-01-11 11:10:30, LI Qingwu wrote: > Defined IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV in imx8mp-clock.h > but never assigned. It will cause the system to hang if using them. > Alias IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV to IMX8MP_CLK_M7_CORE > for backward compatibility. > > Fixes: 8c83a8ff4dd9 (clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code) > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> Stephen, can you please pick this up yourself? Thanks! > --- > drivers/clk/imx/clk-imx8mp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c > index 652ae58c2735..601eea7ab99d 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -522,6 +522,8 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) > hws[IMX8MP_CLK_A53_SRC] = hws[IMX8MP_CLK_A53_DIV]; > hws[IMX8MP_CLK_A53_CG] = hws[IMX8MP_CLK_A53_DIV]; > hws[IMX8MP_CLK_M7_CORE] = imx8m_clk_hw_composite_core("m7_core", imx8mp_m7_sels, ccm_base + 0x8080); > + hws[IMX8MP_CLK_M7_DIV] = hws[IMX8MP_CLK_M7_CORE]; > + hws[IMX8MP_CLK_M7_SRC] = hws[IMX8MP_CLK_M7_CORE]; > hws[IMX8MP_CLK_ML_CORE] = imx8m_clk_hw_composite_core("ml_core", imx8mp_ml_sels, ccm_base + 0x8100); > hws[IMX8MP_CLK_GPU3D_CORE] = imx8m_clk_hw_composite_core("gpu3d_core", imx8mp_gpu3d_core_sels, ccm_base + 0x8180); > hws[IMX8MP_CLK_GPU3D_SHADER_CORE] = imx8m_clk_hw_composite("gpu3d_shader_core", imx8mp_gpu3d_shader_sels, ccm_base + 0x8200); > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@linaro.org> To: Stephen Boyd <sboyd@kernel.org> Cc: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 18701859600@163.com, bsp-development.geo@leica-geosystems.com, Marco Felsch <m.felsch@pengutronix.de> Subject: Re: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE Date: Mon, 16 Jan 2023 16:28:33 +0200 [thread overview] Message-ID: <Y8VfEfnWwt8+QB1W@linaro.org> (raw) In-Reply-To: <20230111101030.686885-2-Qing-wu.Li@leica-geosystems.com.cn> On 23-01-11 11:10:30, LI Qingwu wrote: > Defined IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV in imx8mp-clock.h > but never assigned. It will cause the system to hang if using them. > Alias IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV to IMX8MP_CLK_M7_CORE > for backward compatibility. > > Fixes: 8c83a8ff4dd9 (clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code) > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> Stephen, can you please pick this up yourself? Thanks! > --- > drivers/clk/imx/clk-imx8mp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c > index 652ae58c2735..601eea7ab99d 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -522,6 +522,8 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) > hws[IMX8MP_CLK_A53_SRC] = hws[IMX8MP_CLK_A53_DIV]; > hws[IMX8MP_CLK_A53_CG] = hws[IMX8MP_CLK_A53_DIV]; > hws[IMX8MP_CLK_M7_CORE] = imx8m_clk_hw_composite_core("m7_core", imx8mp_m7_sels, ccm_base + 0x8080); > + hws[IMX8MP_CLK_M7_DIV] = hws[IMX8MP_CLK_M7_CORE]; > + hws[IMX8MP_CLK_M7_SRC] = hws[IMX8MP_CLK_M7_CORE]; > hws[IMX8MP_CLK_ML_CORE] = imx8m_clk_hw_composite_core("ml_core", imx8mp_ml_sels, ccm_base + 0x8100); > hws[IMX8MP_CLK_GPU3D_CORE] = imx8m_clk_hw_composite_core("gpu3d_core", imx8mp_gpu3d_core_sels, ccm_base + 0x8180); > hws[IMX8MP_CLK_GPU3D_SHADER_CORE] = imx8m_clk_hw_composite("gpu3d_shader_core", imx8mp_gpu3d_shader_sels, ccm_base + 0x8200); > -- > 2.25.1 >
next prev parent reply other threads:[~2023-01-16 14:30 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-11 10:10 [PATCH V5 0/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE LI Qingwu 2023-01-11 10:10 ` LI Qingwu 2023-01-11 10:10 ` [PATCH V5 1/1] " LI Qingwu 2023-01-11 10:10 ` LI Qingwu 2023-01-16 14:28 ` Abel Vesa [this message] 2023-01-16 14:28 ` Abel Vesa 2023-01-18 19:00 ` Stephen Boyd 2023-01-18 19:00 ` Stephen Boyd 2023-01-28 18:38 ` Abel Vesa 2023-01-28 18:38 ` Abel Vesa 2023-01-30 7:44 ` LI Qingwu 2023-01-30 7:44 ` LI Qingwu [not found] ` <911ff831eaa686c87682d8e95e90326c.sboyd@kernel.org> [not found] ` <AS8PR06MB7432D9E3D31FAF8087338548D7DD9@AS8PR06MB7432.eurprd06.prod.outlook.com> 2023-02-13 5:44 ` LI Qingwu 2023-02-13 5:44 ` LI Qingwu 2023-02-13 7:41 ` Abel Vesa 2023-02-13 7:41 ` Abel Vesa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y8VfEfnWwt8+QB1W@linaro.org \ --to=abel.vesa@linaro.org \ --cc=18701859600@163.com \ --cc=Qing-wu.Li@leica-geosystems.com.cn \ --cc=abelvesa@kernel.org \ --cc=bsp-development.geo@leica-geosystems.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=m.felsch@pengutronix.de \ --cc=mturquette@baylibre.com \ --cc=s.hauer@pengutronix.de \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.