From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: "Michael S. Tsirkin" <mst@redhat.com>, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, elena.reshetova@intel.com, kirill.shutemov@linux.intel.com, Andi Kleen <ak@linux.intel.com>, Amit Shah <amit@kernel.org>, Arnd Bergmann <arnd@arndb.de> Subject: Re: [PATCH v1 2/6] virtio console: Harden port adding Date: Fri, 27 Jan 2023 15:37:34 +0100 [thread overview] Message-ID: <Y9PhrjovJvxMuF9+@kroah.com> (raw) In-Reply-To: <87bkmkoyd1.fsf@ubik.fi.intel.com> On Fri, Jan 27, 2023 at 04:17:46PM +0200, Alexander Shishkin wrote: > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > > > On Fri, Jan 27, 2023 at 02:47:55PM +0200, Alexander Shishkin wrote: > >> "Michael S. Tsirkin" <mst@redhat.com> writes: > >> > >> > On Fri, Jan 27, 2023 at 01:55:43PM +0200, Alexander Shishkin wrote: > >> >> We can have shared pages between the host and guest without bounce > >> >> buffers in between, so they can be both looking directly at the same > >> >> page. > >> >> > >> >> Regards, > >> > > >> > How does this configuration work? What else is in this page? > >> > >> So, for example in TDX, you have certain pages as "shared", as in > >> between guest and hypervisor. You can have virtio ring(s) in such > >> pages. It's likely that there'd be a swiotlb buffer there instead, but > >> sharing pages between host virtio and guest virtio drivers is possible. > > > > If it is shared, then what does this mean? Do we then need to copy > > everything out of that buffer first before doing anything with it > > because the data could change later on? Or do we not trust anything in > > it at all and we throw it away? Or something else (trust for a short > > while and then we don't?) > > The first one, we need a consistent view of the metadata (the ckpt in > this case), so we take a snapshot of it. Then, we validate it (because > we don't trust it) to be correct. If it is not, we discard it, otherwise > we act on it. Since this is a ring, we just move on to the next record > if there is one. So you do an additional extra copy of everything, making the bounce buffer useless? :) > Meanwhile, in the shared page, it can change from correct to incorrect, > but it won't affect us because we have this consistent view at the > moment the snapshot was taken. Wonderful, copy everything out then, the whole page, don't do it piecemeal field by field. And then justify it to everyone whose throughput you just tanked... good luck! greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>, "Michael S. Tsirkin" <mst@redhat.com>, Amit Shah <amit@kernel.org>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, elena.reshetova@intel.com, kirill.shutemov@linux.intel.com Subject: Re: [PATCH v1 2/6] virtio console: Harden port adding Date: Fri, 27 Jan 2023 15:37:34 +0100 [thread overview] Message-ID: <Y9PhrjovJvxMuF9+@kroah.com> (raw) In-Reply-To: <87bkmkoyd1.fsf@ubik.fi.intel.com> On Fri, Jan 27, 2023 at 04:17:46PM +0200, Alexander Shishkin wrote: > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > > > On Fri, Jan 27, 2023 at 02:47:55PM +0200, Alexander Shishkin wrote: > >> "Michael S. Tsirkin" <mst@redhat.com> writes: > >> > >> > On Fri, Jan 27, 2023 at 01:55:43PM +0200, Alexander Shishkin wrote: > >> >> We can have shared pages between the host and guest without bounce > >> >> buffers in between, so they can be both looking directly at the same > >> >> page. > >> >> > >> >> Regards, > >> > > >> > How does this configuration work? What else is in this page? > >> > >> So, for example in TDX, you have certain pages as "shared", as in > >> between guest and hypervisor. You can have virtio ring(s) in such > >> pages. It's likely that there'd be a swiotlb buffer there instead, but > >> sharing pages between host virtio and guest virtio drivers is possible. > > > > If it is shared, then what does this mean? Do we then need to copy > > everything out of that buffer first before doing anything with it > > because the data could change later on? Or do we not trust anything in > > it at all and we throw it away? Or something else (trust for a short > > while and then we don't?) > > The first one, we need a consistent view of the metadata (the ckpt in > this case), so we take a snapshot of it. Then, we validate it (because > we don't trust it) to be correct. If it is not, we discard it, otherwise > we act on it. Since this is a ring, we just move on to the next record > if there is one. So you do an additional extra copy of everything, making the bounce buffer useless? :) > Meanwhile, in the shared page, it can change from correct to incorrect, > but it won't affect us because we have this consistent view at the > moment the snapshot was taken. Wonderful, copy everything out then, the whole page, don't do it piecemeal field by field. And then justify it to everyone whose throughput you just tanked... good luck! greg k-h _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-01-27 14:37 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-19 13:57 [PATCH v1 0/6] Harden a few virtio bits Alexander Shishkin 2023-01-19 13:57 ` [PATCH v1 1/6] virtio console: Harden multiport against invalid host input Alexander Shishkin 2023-01-19 15:17 ` Greg Kroah-Hartman 2023-01-19 15:17 ` Greg Kroah-Hartman 2023-01-19 18:52 ` Alexander Shishkin 2023-01-19 19:18 ` Greg Kroah-Hartman 2023-01-19 19:18 ` Greg Kroah-Hartman 2023-01-19 19:34 ` Alexander Shishkin 2023-01-20 13:01 ` Michael S. Tsirkin 2023-01-20 13:01 ` Michael S. Tsirkin 2023-01-20 15:51 ` Alexander Shishkin 2023-01-19 13:57 ` [PATCH v1 2/6] virtio console: Harden port adding Alexander Shishkin 2023-01-19 15:20 ` Greg Kroah-Hartman 2023-01-19 15:20 ` Greg Kroah-Hartman 2023-01-19 17:48 ` Alexander Shishkin 2023-01-19 18:57 ` Greg Kroah-Hartman 2023-01-19 18:57 ` Greg Kroah-Hartman 2023-01-19 20:13 ` Alexander Shishkin 2023-01-20 7:15 ` Greg Kroah-Hartman 2023-01-20 7:15 ` Greg Kroah-Hartman 2023-01-27 11:02 ` Michael S. Tsirkin 2023-01-27 11:02 ` Michael S. Tsirkin 2023-01-27 11:55 ` Alexander Shishkin 2023-01-27 12:12 ` Michael S. Tsirkin 2023-01-27 12:12 ` Michael S. Tsirkin 2023-01-27 12:47 ` Alexander Shishkin 2023-01-27 13:31 ` Greg Kroah-Hartman 2023-01-27 13:31 ` Greg Kroah-Hartman 2023-01-27 14:17 ` Alexander Shishkin 2023-01-27 14:37 ` Greg Kroah-Hartman [this message] 2023-01-27 14:37 ` Greg Kroah-Hartman 2023-01-27 14:46 ` Michael S. Tsirkin 2023-01-27 14:46 ` Michael S. Tsirkin 2023-02-02 12:02 ` Reshetova, Elena 2023-01-27 13:52 ` Michael S. Tsirkin 2023-01-27 13:52 ` Michael S. Tsirkin 2023-01-20 12:59 ` Michael S. Tsirkin 2023-01-20 12:59 ` Michael S. Tsirkin 2023-01-19 13:57 ` [PATCH v1 3/6] virtio 9p: Fix an overflow Alexander Shishkin 2023-01-20 12:54 ` Michael S. Tsirkin 2023-01-20 12:54 ` Michael S. Tsirkin 2023-01-20 16:29 ` Alexander Shishkin 2023-01-19 13:57 ` [PATCH v1 4/6] virtio console: Harden control message handling Alexander Shishkin 2023-01-19 15:22 ` Greg Kroah-Hartman 2023-01-19 15:22 ` Greg Kroah-Hartman 2023-01-20 12:45 ` Michael S. Tsirkin 2023-01-20 12:45 ` Michael S. Tsirkin 2023-01-20 16:41 ` Alexander Shishkin 2023-01-27 10:58 ` Michael S. Tsirkin 2023-01-27 10:58 ` Michael S. Tsirkin 2023-01-27 12:04 ` Alexander Shishkin 2023-01-19 13:57 ` [PATCH v1 5/6] virtio_net: Guard against buffer length overflow in xdp_linearize_page() Alexander Shishkin 2023-01-20 13:09 ` Michael S. Tsirkin 2023-01-20 13:09 ` Michael S. Tsirkin 2023-01-19 13:57 ` [PATCH v1 6/6] virtio_ring: Prevent bounds check bypass on descriptor index Alexander Shishkin 2023-01-20 12:56 ` Michael S. Tsirkin 2023-01-20 12:56 ` Michael S. Tsirkin 2023-01-20 11:55 ` [PATCH v1 0/6] Harden a few virtio bits Michael S. Tsirkin 2023-01-20 11:55 ` Michael S. Tsirkin 2023-01-20 12:32 ` Alexander Shishkin 2023-01-20 12:40 ` Michael S. Tsirkin 2023-01-20 12:40 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y9PhrjovJvxMuF9+@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=amit@kernel.org \ --cc=arnd@arndb.de \ --cc=elena.reshetova@intel.com \ --cc=jasowang@redhat.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.