* [PATCH net-next] sh: checksum: add missing linux/uaccess.h include
@ 2023-01-28 7:31 Jakub Kicinski
2023-01-28 16:16 ` Simon Horman
2023-01-31 5:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: Jakub Kicinski @ 2023-01-28 7:31 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, pabeni, Jakub Kicinski, ysato, dalias, linux-sh
SuperH does not include uaccess.h, even tho it calls access_ok().
Fixes: 68f4eae781dd ("net: checksum: drop the linux/uaccess.h include")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: ysato@users.sourceforge.jp
CC: dalias@libc.org
CC: linux-sh@vger.kernel.org
---
arch/sh/include/asm/checksum_32.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/include/asm/checksum_32.h b/arch/sh/include/asm/checksum_32.h
index a6501b856f3e..2b5fa75b4651 100644
--- a/arch/sh/include/asm/checksum_32.h
+++ b/arch/sh/include/asm/checksum_32.h
@@ -7,6 +7,7 @@
*/
#include <linux/in6.h>
+#include <linux/uaccess.h>
/*
* computes the checksum of a memory block at buff, length len,
--
2.39.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sh: checksum: add missing linux/uaccess.h include
2023-01-28 7:31 [PATCH net-next] sh: checksum: add missing linux/uaccess.h include Jakub Kicinski
@ 2023-01-28 16:16 ` Simon Horman
2023-01-28 16:29 ` Simon Horman
2023-01-31 5:10 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 5+ messages in thread
From: Simon Horman @ 2023-01-28 16:16 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, ysato, dalias, linux-sh
On Fri, Jan 27, 2023 at 11:31:08PM -0800, Jakub Kicinski wrote:
> SuperH does not include uaccess.h, even tho it calls access_ok().
I see that is true.
But it's less clear to me why that is a problem.
> Fixes: 68f4eae781dd ("net: checksum: drop the linux/uaccess.h include")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: ysato@users.sourceforge.jp
> CC: dalias@libc.org
> CC: linux-sh@vger.kernel.org
> ---
> arch/sh/include/asm/checksum_32.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/include/asm/checksum_32.h b/arch/sh/include/asm/checksum_32.h
> index a6501b856f3e..2b5fa75b4651 100644
> --- a/arch/sh/include/asm/checksum_32.h
> +++ b/arch/sh/include/asm/checksum_32.h
> @@ -7,6 +7,7 @@
> */
>
> #include <linux/in6.h>
> +#include <linux/uaccess.h>
>
> /*
> * computes the checksum of a memory block at buff, length len,
> --
> 2.39.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sh: checksum: add missing linux/uaccess.h include
2023-01-28 16:16 ` Simon Horman
@ 2023-01-28 16:29 ` Simon Horman
2023-01-28 19:56 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2023-01-28 16:29 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, ysato, dalias, linux-sh
On Sat, Jan 28, 2023 at 05:16:48PM +0100, Simon Horman wrote:
> On Fri, Jan 27, 2023 at 11:31:08PM -0800, Jakub Kicinski wrote:
> > SuperH does not include uaccess.h, even tho it calls access_ok().
>
> I see that is true.
> But it's less clear to me why that is a problem.
Ok, now I see the kernel test robot splat.
Let me try and reproduce it for my own edification.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sh: checksum: add missing linux/uaccess.h include
2023-01-28 16:29 ` Simon Horman
@ 2023-01-28 19:56 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2023-01-28 19:56 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, ysato, dalias, linux-sh
On Sat, Jan 28, 2023 at 05:29:37PM +0100, Simon Horman wrote:
> On Sat, Jan 28, 2023 at 05:16:48PM +0100, Simon Horman wrote:
> > On Fri, Jan 27, 2023 at 11:31:08PM -0800, Jakub Kicinski wrote:
> > > SuperH does not include uaccess.h, even tho it calls access_ok().
> >
> > I see that is true.
> > But it's less clear to me why that is a problem.
>
> Ok, now I see the kernel test robot splat.
> Let me try and reproduce it for my own edification.
Done. Unsurprisingly, your patch resolves the problem.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Tested-by: Simon Horman <simon.horman@corigine.com>
For the record, the splat is here:
- https://lore.kernel.org/netdev/202301281438.ZNGVwW6S-lkp@intel.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] sh: checksum: add missing linux/uaccess.h include
2023-01-28 7:31 [PATCH net-next] sh: checksum: add missing linux/uaccess.h include Jakub Kicinski
2023-01-28 16:16 ` Simon Horman
@ 2023-01-31 5:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-31 5:10 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, ysato, dalias, linux-sh
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 27 Jan 2023 23:31:08 -0800 you wrote:
> SuperH does not include uaccess.h, even tho it calls access_ok().
>
> Fixes: 68f4eae781dd ("net: checksum: drop the linux/uaccess.h include")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: ysato@users.sourceforge.jp
> CC: dalias@libc.org
> CC: linux-sh@vger.kernel.org
>
> [...]
Here is the summary with links:
- [net-next] sh: checksum: add missing linux/uaccess.h include
https://git.kernel.org/netdev/net-next/c/2083656bb30d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-31 5:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 7:31 [PATCH net-next] sh: checksum: add missing linux/uaccess.h include Jakub Kicinski
2023-01-28 16:16 ` Simon Horman
2023-01-28 16:29 ` Simon Horman
2023-01-28 19:56 ` Simon Horman
2023-01-31 5:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.