[PATCH v3 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[PATCH v3 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[Mukesh Ojha]

Document the qcom,sm8450-tcsr compatible.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
Change in v3:
  - Align with new format mentioned at
    Documentation/devicetree/bindings/arm/qcom-soc.yaml    

Change in v2:
  - Considering here it as v2 as this patch came out from comment
    made on its v1 https://lore.kernel.org/lkml/c5dc8042-717b-22eb-79f6-d18ab10d6685@linaro.org/


 Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
index adcae6c..4290062 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
@@ -26,6 +26,7 @@ properties:
           - qcom,sdm630-tcsr
           - qcom,sdm845-tcsr
           - qcom,sm8150-tcsr
+          - qcom,sm8450-tcsr
           - qcom,tcsr-apq8064
           - qcom,tcsr-apq8084
           - qcom,tcsr-ipq6018
-- 
2.7.4

[PATCH v3 2/2] arm64: dts: qcom: sm8450: Add TCSR halt register space

[Mukesh Ojha]

Add TCSR register space and refer it from scm node, so that
it can be used by SCM driver.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
Change in v3:
  - Align with new format of compatible for Qcom SoC.

Changes in v2:
  - Added SoC compatible based on comment made by krzysztof in v1.

 arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 5704750..d9f7a9b 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -270,6 +270,7 @@
 	firmware {
 		scm: scm {
 			compatible = "qcom,scm-sm8450", "qcom,scm";
+			qcom,dload-mode = <&tcsr 0x13000>;
 			interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
 			#reset-cells = <1>;
 		};
@@ -1986,6 +1987,11 @@
 			#hwlock-cells = <1>;
 		};
 
+		tcsr: syscon@1fc0000 {
+			compatible = "qcom,sm8450-tcsr", "syscon";
+			reg = <0x0 0x1fc0000 0x0 0x30000>;
+		};
+
 		usb_1_hsphy: phy@88e3000 {
 			compatible = "qcom,sm8450-usb-hs-phy",
 				     "qcom,usb-snps-hs-7nm-phy";
-- 
2.7.4

Re: [PATCH v3 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[Krzysztof Kozlowski]

On 12/01/2023 09:54, Mukesh Ojha wrote:
> Document the qcom,sm8450-tcsr compatible.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> Change in v3:


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: (subset) [PATCH v3 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[Bjorn Andersson]

On Thu, 12 Jan 2023 14:24:56 +0530, Mukesh Ojha wrote:
> Document the qcom,sm8450-tcsr compatible.
> 
> 

Applied, thanks!

[2/2] arm64: dts: qcom: sm8450: Add TCSR halt register space
      commit: 1f731bbf71e374d93d477831518402ebcfddb75b

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v3 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[Mukesh Ojha]

+Jones

Jones,

Can this patch be taken into your tree ?

-Mukesh

On 1/12/2023 2:24 PM, Mukesh Ojha wrote:
> Document the qcom,sm8450-tcsr compatible.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> Change in v3:
>    - Align with new format mentioned at
>      Documentation/devicetree/bindings/arm/qcom-soc.yaml
> 
> Change in v2:
>    - Considering here it as v2 as this patch came out from comment
>      made on its v1 https://lore.kernel.org/lkml/c5dc8042-717b-22eb-79f6-d18ab10d6685@linaro.org/
> 
> 
>   Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> index adcae6c..4290062 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> @@ -26,6 +26,7 @@ properties:
>             - qcom,sdm630-tcsr
>             - qcom,sdm845-tcsr
>             - qcom,sm8150-tcsr
> +          - qcom,sm8450-tcsr
>             - qcom,tcsr-apq8064
>             - qcom,tcsr-apq8084
>             - qcom,tcsr-ipq6018

Re: [PATCH v3 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[Lee Jones]

On Sun, 29 Jan 2023, Mukesh Ojha wrote:

> +Jones
> 
> Jones,
> 
> Can this patch be taken into your tree ?

If it is sent to me properly, then yes.

> On 1/12/2023 2:24 PM, Mukesh Ojha wrote:
> > Document the qcom,sm8450-tcsr compatible.
> > 
> > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> > ---
> > Change in v3:
> >    - Align with new format mentioned at
> >      Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > 
> > Change in v2:
> >    - Considering here it as v2 as this patch came out from comment
> >      made on its v1 https://lore.kernel.org/lkml/c5dc8042-717b-22eb-79f6-d18ab10d6685@linaro.org/
> > 
> > 
> >   Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> > index adcae6c..4290062 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> > @@ -26,6 +26,7 @@ properties:
> >             - qcom,sdm630-tcsr
> >             - qcom,sdm845-tcsr
> >             - qcom,sm8150-tcsr
> > +          - qcom,sm8450-tcsr
> >             - qcom,tcsr-apq8064
> >             - qcom,tcsr-apq8084
> >             - qcom,tcsr-ipq6018

-- 
Lee Jones [李琼斯]

Re: [PATCH v3 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[Mukesh Ojha]

On 1/30/2023 1:50 PM, Lee Jones wrote:
> On Sun, 29 Jan 2023, Mukesh Ojha wrote:
> 
>> +Jones
>>
>> Jones,
>>
>> Can this patch be taken into your tree ?
> 
> If it is sent to me properly, then yes.

Apology on my behalf to missed cc'ing you..

-Thanks

> 
>> On 1/12/2023 2:24 PM, Mukesh Ojha wrote:
>>> Document the qcom,sm8450-tcsr compatible.
>>>
>>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>>> ---
>>> Change in v3:
>>>     - Align with new format mentioned at
>>>       Documentation/devicetree/bindings/arm/qcom-soc.yaml
>>>
>>> Change in v2:
>>>     - Considering here it as v2 as this patch came out from comment
>>>       made on its v1 https://lore.kernel.org/lkml/c5dc8042-717b-22eb-79f6-d18ab10d6685@linaro.org/
>>>
>>>
>>>    Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
>>> index adcae6c..4290062 100644
>>> --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
>>> @@ -26,6 +26,7 @@ properties:
>>>              - qcom,sdm630-tcsr
>>>              - qcom,sdm845-tcsr
>>>              - qcom,sm8150-tcsr
>>> +          - qcom,sm8450-tcsr
>>>              - qcom,tcsr-apq8064
>>>              - qcom,tcsr-apq8084
>>>              - qcom,tcsr-ipq6018
>