From: Petr Mladek <pmladek@suse.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Christian König" <christian.koenig@amd.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Eryk Brol" <eryk.brol@amd.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"David S. Miller" <davem@davemloft.net>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Francis Laniel" <laniel_francis@privacyrequired.com>,
amd-gfx@lists.freedesktop.org,
dri-devel <dri-devel@lists.freedesktop.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
netdev <netdev@vger.kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>, "David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Jakub Kicinski" <kuba@kernel.org>
Subject: Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood
Date: Wed, 17 Feb 2021 13:45:58 +0100 [thread overview]
Message-ID: <YC0QBvv9HXr64ySf@alley> (raw)
In-Reply-To: <CAHp75VfVXnqdVRAPQ36vZeD-ZMCjWmjA_-6T=jnOEVMne4bv0g@mail.gmail.com>
On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote:
> +Cc: Sakari and printk people
>
> On Mon, Feb 15, 2021 at 4:28 PM Christian König
> <christian.koenig@amd.com> wrote:
> > Am 15.02.21 um 15:21 schrieb Andy Shevchenko:
> > > We have already few similar implementation and a lot of code that can benefit
> > > of the yesno() helper. Consolidate yesno() helpers under string.h hood.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Looks like a good idea to me, feel free to add an Acked-by: Christian
> > König <christian.koenig@amd.com> to the series.
>
> Thanks.
>
> > But looking at the use cases for this, wouldn't it make more sense to
> > teach kprintf some new format modifier for this?
>
> As a next step? IIRC Sakari has at some point the series converted
> yesno and Co. to something which I don't remember the details of.
>
> Guys, what do you think?
Honestly, I think that yesno() is much easier to understand than %py.
And %py[DOY] looks really scary. It has been suggested at
https://lore.kernel.org/lkml/YCqaNnr7ynRydczE@smile.fi.intel.com/#t
Yes, enabledisable() is hard to parse but it is still self-explaining
and can be found easily by cscope. On the contrary, %pyD will likely
print some python code and it is not clear if it would be compatible
with v3. I am just kidding but you get the picture.
Best Regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Francis Laniel" <laniel_francis@privacyrequired.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
amd-gfx@lists.freedesktop.org, "Jakub Kicinski" <kuba@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Leo Li" <sunpeng.li@amd.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Eryk Brol" <eryk.brol@amd.com>, netdev <netdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood
Date: Wed, 17 Feb 2021 13:45:58 +0100 [thread overview]
Message-ID: <YC0QBvv9HXr64ySf@alley> (raw)
In-Reply-To: <CAHp75VfVXnqdVRAPQ36vZeD-ZMCjWmjA_-6T=jnOEVMne4bv0g@mail.gmail.com>
On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote:
> +Cc: Sakari and printk people
>
> On Mon, Feb 15, 2021 at 4:28 PM Christian König
> <christian.koenig@amd.com> wrote:
> > Am 15.02.21 um 15:21 schrieb Andy Shevchenko:
> > > We have already few similar implementation and a lot of code that can benefit
> > > of the yesno() helper. Consolidate yesno() helpers under string.h hood.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Looks like a good idea to me, feel free to add an Acked-by: Christian
> > König <christian.koenig@amd.com> to the series.
>
> Thanks.
>
> > But looking at the use cases for this, wouldn't it make more sense to
> > teach kprintf some new format modifier for this?
>
> As a next step? IIRC Sakari has at some point the series converted
> yesno and Co. to something which I don't remember the details of.
>
> Guys, what do you think?
Honestly, I think that yesno() is much easier to understand than %py.
And %py[DOY] looks really scary. It has been suggested at
https://lore.kernel.org/lkml/YCqaNnr7ynRydczE@smile.fi.intel.com/#t
Yes, enabledisable() is hard to parse but it is still self-explaining
and can be found easily by cscope. On the contrary, %pyD will likely
print some python code and it is not clear if it would be compatible
with v3. I am just kidding but you get the picture.
Best Regards,
Petr
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Francis Laniel" <laniel_francis@privacyrequired.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
amd-gfx@lists.freedesktop.org, "Jakub Kicinski" <kuba@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Leo Li" <sunpeng.li@amd.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Eryk Brol" <eryk.brol@amd.com>, netdev <netdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood
Date: Wed, 17 Feb 2021 13:45:58 +0100 [thread overview]
Message-ID: <YC0QBvv9HXr64ySf@alley> (raw)
In-Reply-To: <CAHp75VfVXnqdVRAPQ36vZeD-ZMCjWmjA_-6T=jnOEVMne4bv0g@mail.gmail.com>
On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote:
> +Cc: Sakari and printk people
>
> On Mon, Feb 15, 2021 at 4:28 PM Christian König
> <christian.koenig@amd.com> wrote:
> > Am 15.02.21 um 15:21 schrieb Andy Shevchenko:
> > > We have already few similar implementation and a lot of code that can benefit
> > > of the yesno() helper. Consolidate yesno() helpers under string.h hood.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Looks like a good idea to me, feel free to add an Acked-by: Christian
> > König <christian.koenig@amd.com> to the series.
>
> Thanks.
>
> > But looking at the use cases for this, wouldn't it make more sense to
> > teach kprintf some new format modifier for this?
>
> As a next step? IIRC Sakari has at some point the series converted
> yesno and Co. to something which I don't remember the details of.
>
> Guys, what do you think?
Honestly, I think that yesno() is much easier to understand than %py.
And %py[DOY] looks really scary. It has been suggested at
https://lore.kernel.org/lkml/YCqaNnr7ynRydczE@smile.fi.intel.com/#t
Yes, enabledisable() is hard to parse but it is still self-explaining
and can be found easily by cscope. On the contrary, %pyD will likely
print some python code and it is not clear if it would be compatible
with v3. I am just kidding but you get the picture.
Best Regards,
Petr
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Francis Laniel" <laniel_francis@privacyrequired.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
amd-gfx@lists.freedesktop.org, "Jakub Kicinski" <kuba@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Leo Li" <sunpeng.li@amd.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Eryk Brol" <eryk.brol@amd.com>, netdev <netdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Raju Rangoju" <rajur@chelsio.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood
Date: Wed, 17 Feb 2021 13:45:58 +0100 [thread overview]
Message-ID: <YC0QBvv9HXr64ySf@alley> (raw)
In-Reply-To: <CAHp75VfVXnqdVRAPQ36vZeD-ZMCjWmjA_-6T=jnOEVMne4bv0g@mail.gmail.com>
On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote:
> +Cc: Sakari and printk people
>
> On Mon, Feb 15, 2021 at 4:28 PM Christian König
> <christian.koenig@amd.com> wrote:
> > Am 15.02.21 um 15:21 schrieb Andy Shevchenko:
> > > We have already few similar implementation and a lot of code that can benefit
> > > of the yesno() helper. Consolidate yesno() helpers under string.h hood.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Looks like a good idea to me, feel free to add an Acked-by: Christian
> > König <christian.koenig@amd.com> to the series.
>
> Thanks.
>
> > But looking at the use cases for this, wouldn't it make more sense to
> > teach kprintf some new format modifier for this?
>
> As a next step? IIRC Sakari has at some point the series converted
> yesno and Co. to something which I don't remember the details of.
>
> Guys, what do you think?
Honestly, I think that yesno() is much easier to understand than %py.
And %py[DOY] looks really scary. It has been suggested at
https://lore.kernel.org/lkml/YCqaNnr7ynRydczE@smile.fi.intel.com/#t
Yes, enabledisable() is hard to parse but it is still self-explaining
and can be found easily by cscope. On the contrary, %pyD will likely
print some python code and it is not clear if it would be compatible
with v3. I am just kidding but you get the picture.
Best Regards,
Petr
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-02-17 12:46 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 14:21 [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood Andy Shevchenko
2021-02-15 14:21 ` Andy Shevchenko
2021-02-15 14:21 ` [Intel-gfx] " Andy Shevchenko
2021-02-15 14:21 ` Andy Shevchenko
2021-02-15 14:21 ` [PATCH v1 2/3] string: Move onoff() helper " Andy Shevchenko
2021-02-15 14:21 ` Andy Shevchenko
2021-02-15 14:21 ` [Intel-gfx] " Andy Shevchenko
2021-02-15 14:21 ` Andy Shevchenko
2021-02-15 14:21 ` [PATCH v1 3/3] string: Move enableddisabled() " Andy Shevchenko
2021-02-15 14:21 ` Andy Shevchenko
2021-02-15 14:21 ` [Intel-gfx] " Andy Shevchenko
2021-02-15 14:21 ` Andy Shevchenko
2021-02-15 14:26 ` [PATCH v1 1/3] string: Consolidate yesno() helpers " Christian König
2021-02-15 14:26 ` Christian König
2021-02-15 14:26 ` [Intel-gfx] " Christian König
2021-02-15 14:26 ` Christian König
2021-02-15 14:39 ` Andy Shevchenko
2021-02-15 14:39 ` Andy Shevchenko
2021-02-15 14:39 ` [Intel-gfx] " Andy Shevchenko
2021-02-15 14:39 ` Andy Shevchenko
2021-02-17 12:45 ` Petr Mladek [this message]
2021-02-17 12:45 ` Petr Mladek
2021-02-17 12:45 ` [Intel-gfx] " Petr Mladek
2021-02-17 12:45 ` Petr Mladek
2021-02-17 17:13 ` Jani Nikula
2021-02-17 17:13 ` Jani Nikula
2021-02-17 17:13 ` [Intel-gfx] " Jani Nikula
2021-02-17 17:13 ` Jani Nikula
2021-02-15 14:37 ` Jani Nikula
2021-02-15 14:37 ` Jani Nikula
2021-02-15 14:37 ` [Intel-gfx] " Jani Nikula
2021-02-15 14:37 ` Jani Nikula
2021-02-15 15:58 ` Andy Shevchenko
2021-02-15 15:58 ` Andy Shevchenko
2021-02-15 15:58 ` [Intel-gfx] " Andy Shevchenko
2021-02-15 15:58 ` Andy Shevchenko
2021-02-15 16:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v1,1/3] " Patchwork
2021-02-15 16:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-15 18:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-05 21:34 ` [PATCH v1 1/3] " Lucas De Marchi
2021-10-05 21:34 ` [Intel-gfx] " Lucas De Marchi
2021-11-15 11:07 ` Andy Shevchenko
2021-11-15 11:07 ` Andy Shevchenko
2021-11-15 11:07 ` Andy Shevchenko
2021-11-15 11:07 ` [Intel-gfx] " Andy Shevchenko
2021-11-15 11:43 ` Jani Nikula
2021-11-15 11:43 ` Jani Nikula
2021-11-15 11:43 ` [Intel-gfx] " Jani Nikula
2021-11-15 11:43 ` Jani Nikula
2021-11-15 14:22 ` Andy Shevchenko
2021-11-15 14:22 ` Andy Shevchenko
2021-11-15 14:22 ` Andy Shevchenko
2021-11-15 14:22 ` [Intel-gfx] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC0QBvv9HXr64ySf@alley \
--to=pmladek@suse.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=eryk.brol@amd.com \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kuba@kernel.org \
--cc=laniel_francis@privacyrequired.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mikita.lipski@amd.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rajur@chelsio.com \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.