* [bug report] mt76: mt7915: add support for continuous tx in testmode
@ 2021-02-10 11:06 Dan Carpenter
2021-02-11 9:01 ` Lorenzo Bianconi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-02-10 11:06 UTC (permalink / raw)
To: shayne.chen; +Cc: linux-wireless
Hello Shayne Chen,
The patch 3f0caa3cbf94: "mt76: mt7915: add support for continuous tx
in testmode" from Jan 5, 2021, leads to the following static checker
warning:
drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597 mt7915_tm_set_tx_cont()
error: uninitialized symbol 'mode'.
drivers/net/wireless/mediatek/mt76/mt7915/testmode.c
583 break;
584 case MT76_TM_TX_MODE_HE_EXT_SU:
585 mode = MT_PHY_TYPE_HE_EXT_SU;
586 break;
587 case MT76_TM_TX_MODE_HE_TB:
588 mode = MT_PHY_TYPE_HE_TB;
589 break;
590 case MT76_TM_TX_MODE_HE_MU:
591 mode = MT_PHY_TYPE_HE_MU;
592 break;
593 default:
"mode" is uninitialized on the default path.
594 break;
595 }
596
597 rateval = mode << 6 | rate_idx;
^^^^^^^^^
598 tx_cont->rateval = cpu_to_le16(rateval);
599
600 out:
601 if (!en) {
602 int ret;
603
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] mt76: mt7915: add support for continuous tx in testmode
2021-02-10 11:06 [bug report] mt76: mt7915: add support for continuous tx in testmode Dan Carpenter
@ 2021-02-11 9:01 ` Lorenzo Bianconi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Bianconi @ 2021-02-11 9:01 UTC (permalink / raw)
To: Dan Carpenter; +Cc: shayne.chen, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
> Hello Shayne Chen,
Hi Dan,
right. I will post a fix soon.
Regards,
Lorenzo
>
> The patch 3f0caa3cbf94: "mt76: mt7915: add support for continuous tx
> in testmode" from Jan 5, 2021, leads to the following static checker
> warning:
>
> drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597 mt7915_tm_set_tx_cont()
> error: uninitialized symbol 'mode'.
>
> drivers/net/wireless/mediatek/mt76/mt7915/testmode.c
> 583 break;
> 584 case MT76_TM_TX_MODE_HE_EXT_SU:
> 585 mode = MT_PHY_TYPE_HE_EXT_SU;
> 586 break;
> 587 case MT76_TM_TX_MODE_HE_TB:
> 588 mode = MT_PHY_TYPE_HE_TB;
> 589 break;
> 590 case MT76_TM_TX_MODE_HE_MU:
> 591 mode = MT_PHY_TYPE_HE_MU;
> 592 break;
> 593 default:
>
> "mode" is uninitialized on the default path.
>
> 594 break;
> 595 }
> 596
> 597 rateval = mode << 6 | rate_idx;
> ^^^^^^^^^
>
> 598 tx_cont->rateval = cpu_to_le16(rateval);
> 599
> 600 out:
> 601 if (!en) {
> 602 int ret;
> 603
>
> regards,
> dan carpenter
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-11 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 11:06 [bug report] mt76: mt7915: add support for continuous tx in testmode Dan Carpenter
2021-02-11 9:01 ` Lorenzo Bianconi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.