* [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
@ 2021-03-30 9:31 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-03-30 9:31 UTC (permalink / raw)
To: Hyun Kwon
Cc: Laurent Pinchart, David Airlie, Daniel Vetter, Michal Simek,
dri-devel, kernel-janitors
The dp->train_set[] for this driver is only two characters, not four so
this memsets too much. Fortunately, this ends up corrupting a struct
hole and not anything important.
Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 99158ee67d02..59d1fb017da0 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)
return ret;
zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1);
- memset(dp->train_set, 0, 4);
+ memset(dp->train_set, 0, sizeof(dp->train_set));
ret = zynqmp_dp_link_train_cr(dp);
if (ret)
return ret;
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
@ 2021-03-30 9:31 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-03-30 9:31 UTC (permalink / raw)
To: Hyun Kwon
Cc: David Airlie, kernel-janitors, Michal Simek, dri-devel, Laurent Pinchart
The dp->train_set[] for this driver is only two characters, not four so
this memsets too much. Fortunately, this ends up corrupting a struct
hole and not anything important.
Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 99158ee67d02..59d1fb017da0 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)
return ret;
zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1);
- memset(dp->train_set, 0, 4);
+ memset(dp->train_set, 0, sizeof(dp->train_set));
ret = zynqmp_dp_link_train_cr(dp);
if (ret)
return ret;
--
2.30.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
2021-03-30 9:31 ` Dan Carpenter
@ 2021-04-07 10:17 ` Michal Simek
-1 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2021-04-07 10:17 UTC (permalink / raw)
To: Dan Carpenter, Hyun Kwon
Cc: Laurent Pinchart, David Airlie, Daniel Vetter, Michal Simek,
dri-devel, kernel-janitors
On 3/30/21 11:31 AM, Dan Carpenter wrote:
> The dp->train_set[] for this driver is only two characters, not four so
> this memsets too much. Fortunately, this ends up corrupting a struct
> hole and not anything important.
>
> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 99158ee67d02..59d1fb017da0 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)
> return ret;
>
> zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1);
> - memset(dp->train_set, 0, 4);
> + memset(dp->train_set, 0, sizeof(dp->train_set));
> ret = zynqmp_dp_link_train_cr(dp);
> if (ret)
> return ret;
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
@ 2021-04-07 10:17 ` Michal Simek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2021-04-07 10:17 UTC (permalink / raw)
To: Dan Carpenter, Hyun Kwon
Cc: David Airlie, kernel-janitors, Michal Simek, dri-devel, Laurent Pinchart
On 3/30/21 11:31 AM, Dan Carpenter wrote:
> The dp->train_set[] for this driver is only two characters, not four so
> this memsets too much. Fortunately, this ends up corrupting a struct
> hole and not anything important.
>
> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 99158ee67d02..59d1fb017da0 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)
> return ret;
>
> zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1);
> - memset(dp->train_set, 0, 4);
> + memset(dp->train_set, 0, sizeof(dp->train_set));
> ret = zynqmp_dp_link_train_cr(dp);
> if (ret)
> return ret;
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
2021-04-07 10:17 ` Michal Simek
@ 2021-04-08 10:53 ` Daniel Vetter
-1 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2021-04-08 10:53 UTC (permalink / raw)
To: Michal Simek
Cc: Dan Carpenter, Hyun Kwon, Laurent Pinchart, David Airlie,
Daniel Vetter, dri-devel, kernel-janitors
On Wed, Apr 07, 2021 at 12:17:49PM +0200, Michal Simek wrote:
>
>
> On 3/30/21 11:31 AM, Dan Carpenter wrote:
> > The dp->train_set[] for this driver is only two characters, not four so
> > this memsets too much. Fortunately, this ends up corrupting a struct
> > hole and not anything important.
> >
> > Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > index 99158ee67d02..59d1fb017da0 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > @@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)
> > return ret;
> >
> > zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1);
> > - memset(dp->train_set, 0, 4);
> > + memset(dp->train_set, 0, sizeof(dp->train_set));
> > ret = zynqmp_dp_link_train_cr(dp);
> > if (ret)
> > return ret;
> >
>
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Stuffed into drm-misc-next, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
@ 2021-04-08 10:53 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2021-04-08 10:53 UTC (permalink / raw)
To: Michal Simek
Cc: Hyun Kwon, David Airlie, kernel-janitors, dri-devel,
Laurent Pinchart, Dan Carpenter
On Wed, Apr 07, 2021 at 12:17:49PM +0200, Michal Simek wrote:
>
>
> On 3/30/21 11:31 AM, Dan Carpenter wrote:
> > The dp->train_set[] for this driver is only two characters, not four so
> > this memsets too much. Fortunately, this ends up corrupting a struct
> > hole and not anything important.
> >
> > Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > index 99158ee67d02..59d1fb017da0 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > @@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)
> > return ret;
> >
> > zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1);
> > - memset(dp->train_set, 0, 4);
> > + memset(dp->train_set, 0, sizeof(dp->train_set));
> > ret = zynqmp_dp_link_train_cr(dp);
> > if (ret)
> > return ret;
> >
>
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Stuffed into drm-misc-next, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-08 10:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 9:31 [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train() Dan Carpenter
2021-03-30 9:31 ` Dan Carpenter
2021-04-07 10:17 ` Michal Simek
2021-04-07 10:17 ` Michal Simek
2021-04-08 10:53 ` Daniel Vetter
2021-04-08 10:53 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.